[jira] [Assigned] (FLINK-37283) Improved ability to split ‘db.\.*.\.*.’

2025-02-07 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-37283: -- Assignee: ouyangwulin > Improved ability to split ‘db.\.*.\.*.’ > ---

[jira] [Created] (FLINK-37284) ForwardForConsecutiveHashPartitioner cannot be chained in Adaptive batch.

2025-02-07 Thread Junrui Lee (Jira)
Junrui Lee created FLINK-37284: -- Summary: ForwardForConsecutiveHashPartitioner cannot be chained in Adaptive batch. Key: FLINK-37284 URL: https://issues.apache.org/jira/browse/FLINK-37284 Project: Flink

Re: [PR] [FLINK-37184][connector/filesystem] Add ZStandard to supported standard decompressors [flink]

2025-02-07 Thread via GitHub
JoeryH commented on PR #26029: URL: https://github.com/apache/flink/pull/26029#issuecomment-2644286321 Would still like to have this merged; let me know if I need to do something -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] FLINK-25029: Hadoop Caller Context Setting in Flink [flink]

2025-02-07 Thread via GitHub
HuangZhenQiu commented on PR #17958: URL: https://github.com/apache/flink/pull/17958#issuecomment-2644316012 @1996fanrui @gyfora We need this feature internally. How should we proceed from here? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Commented] (FLINK-25029) Hadoop Caller Context Setting In Flink

2025-02-07 Thread Zhenqiu Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925084#comment-17925084 ] Zhenqiu Huang commented on FLINK-25029: --- [~liufangqi] Shall we finish the task? If

Re: [PR] [FLINK-36604][datastream] StreamingJobGraphGenerator::setOperatorConfig checks input serializer length [flink]

2025-02-07 Thread via GitHub
liuml07 commented on PR #25576: URL: https://github.com/apache/flink/pull/25576#issuecomment-2644528007 @sujay-jain Could you help review this patch? Appreciate your help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] [docs] Translate "Table ID" Page for Flink CDC Chinese Documentation [flink-cdc]

2025-02-07 Thread via GitHub
gtk96 commented on PR #3888: URL: https://github.com/apache/flink-cdc/pull/3888#issuecomment-2644528574 > > @Kevin-Caesar Thank you for the excellent work. I have a reference for a Chinese typesetting guide here. Would you mind optimizing this pull request according to this style?https://g

Re: [PR] [FLINK-34251][core] ClosureCleaner to include reference classes for non-serialization exception [flink]

2025-02-07 Thread via GitHub
liuml07 commented on PR #24205: URL: https://github.com/apache/flink/pull/24205#issuecomment-2644528655 @sujay-jain Could you help review this patch? I think you have context about potential use cases that can benefit from it. Thanks! -- This is an automated message from the Apache Git Se

Re: [PR] [FLINK-37276] Add missing state v2 access interfaces in `RuntimeContext` [flink]

2025-02-07 Thread via GitHub
Zakelly commented on code in PR #26120: URL: https://github.com/apache/flink/pull/26120#discussion_r1947411751 ## flink-core/src/main/java/org/apache/flink/api/common/functions/RuntimeContext.java: ## @@ -410,6 +411,95 @@ AggregatingState getAggregatingState( @PublicEvolv

Re: [PR] [FLINK-37276] Add missing state v2 access interfaces in `RuntimeContext` [flink]

2025-02-07 Thread via GitHub
Zakelly commented on code in PR #26120: URL: https://github.com/apache/flink/pull/26120#discussion_r1947412905 ## flink-core/src/main/java/org/apache/flink/api/common/state/v2/AggregatingStateDescriptor.java: ## @@ -72,6 +72,23 @@ public AggregatingStateDescriptor( this

Re: [PR] [FLINK-37276] Add missing state v2 access interfaces in `RuntimeContext` [flink]

2025-02-07 Thread via GitHub
Zakelly commented on code in PR #26120: URL: https://github.com/apache/flink/pull/26120#discussion_r1947413310 ## flink-core/src/main/java/org/apache/flink/api/common/state/v2/ReducingStateDescriptor.java: ## @@ -67,6 +67,23 @@ public ReducingStateDescriptor( this.reduc

Re: [PR] [FLINK-37276] Add missing state v2 access interfaces in `RuntimeContext` [flink]

2025-02-07 Thread via GitHub
Zakelly commented on code in PR #26120: URL: https://github.com/apache/flink/pull/26120#discussion_r1947412905 ## flink-core/src/main/java/org/apache/flink/api/common/state/v2/AggregatingStateDescriptor.java: ## @@ -72,6 +72,23 @@ public AggregatingStateDescriptor( this

Re: [PR] [BP-2.0][hotfix] Remove inappropriate annotation in `flink-statebackend-forst` [flink]

2025-02-07 Thread via GitHub
flinkbot commented on PR #26124: URL: https://github.com/apache/flink/pull/26124#issuecomment-2644466051 ## CI report: * 4f4daaaec2312930f9a2bcc390ec4d813ceaf143 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-37276] Add missing state v2 access interfaces in `RuntimeContext` [flink]

2025-02-07 Thread via GitHub
flinkbot commented on PR #26125: URL: https://github.com/apache/flink/pull/26125#issuecomment-2644466092 ## CI report: * 6cd3eca63fe851b13850f3bc5ea96599fc29ca45 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-37274] Add examples for DataStream V2 [flink]

2025-02-07 Thread via GitHub
reswqa commented on code in PR #26118: URL: https://github.com/apache/flink/pull/26118#discussion_r1947422299 ## flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/dsv2/watermark/SyncOffsetByWatermark.java: ## @@ -0,0 +1,193 @@ +/* + * Lice

Re: [PR] [FLINK-36336][doc] Remove deprecated DataSet API related contents in documentations [flink]

2025-02-07 Thread via GitHub
codenohup commented on PR #26119: URL: https://github.com/apache/flink/pull/26119#issuecomment-2644465130 Hi, @davidradl Thank you for your review! I have updated the PR based on your comments. PTAL. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] [hotfix][state/rocksdb] Use try-with-resources to close RocksStateKeysIterator and fix some typos. [flink]

2025-02-07 Thread via GitHub
flinkbot commented on PR #26126: URL: https://github.com/apache/flink/pull/26126#issuecomment-2644476318 ## CI report: * 5f351decf79377e3f30b45776729bb87ff629663 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-37278] Optimize regular schema evolution topology's performance [flink-cdc]

2025-02-07 Thread via GitHub
yuxiqian opened a new pull request, #3912: URL: https://github.com/apache/flink-cdc/pull/3912 This closes FLINK-37278. Currently, regular SE topology uses the following POC to drain existing `DataChangeEvent`s in the pipeline: 1. SchemaOperator ("client") emits `FlushEvent` to

[jira] [Updated] (FLINK-37278) Regular schema evolution process is too slow when starting from specific offset

2025-02-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37278: --- Labels: pull-request-available (was: ) > Regular schema evolution process is too slow when

[jira] [Created] (FLINK-37282) Add backchannel for producer recycling

2025-02-07 Thread Arvid Heise (Jira)
Arvid Heise created FLINK-37282: --- Summary: Add backchannel for producer recycling Key: FLINK-37282 URL: https://issues.apache.org/jira/browse/FLINK-37282 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-37278) Regular schema evolution process is too slow when starting from specific offset

2025-02-07 Thread yux (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925120#comment-17925120 ] yux commented on FLINK-37278: - I'd like to take this ticket. > Regular schema evolution pro

[jira] [Created] (FLINK-37281) Refactor KafkaSinkITCase

2025-02-07 Thread Arvid Heise (Jira)
Arvid Heise created FLINK-37281: --- Summary: Refactor KafkaSinkITCase Key: FLINK-37281 URL: https://issues.apache.org/jira/browse/FLINK-37281 Project: Flink Issue Type: Improvement Comp

Re: [PR] [FLINK-32097][Connectors/Kinesis] Implement support for Kinesis deaggregation [flink-connector-aws]

2025-02-07 Thread via GitHub
nicusX commented on PR #188: URL: https://github.com/apache/flink-connector-aws/pull/188#issuecomment-2643519339 I tested it locally, with a stream produced by KPL with aggregation enabled, and it worked fine. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-21912] Introduce ResolvedSchema in Python Table API [flink]

2025-02-07 Thread via GitHub
flinkbot commented on PR #26121: URL: https://github.com/apache/flink/pull/26121#issuecomment-2643527061 ## CI report: * 82e6994a369f26e8a7de213be5e5d3fa59ec63a9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-32097][Connectors/Kinesis] Implement support for Kinesis deaggregation [flink-connector-aws]

2025-02-07 Thread via GitHub
nicusX commented on PR #188: URL: https://github.com/apache/flink-connector-aws/pull/188#issuecomment-2643565743 Uhm, `spotless:apply` it did some changes for me, and after that `mvn package` succeeded -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] [FLINK-32097][Connectors/Kinesis] Implement support for Kinesis deaggregation [flink-connector-aws]

2025-02-07 Thread via GitHub
Lzgpom commented on PR #188: URL: https://github.com/apache/flink-connector-aws/pull/188#issuecomment-2643549489 > @Lzgpom Building this locally and I've got a spotless-check format violation. `mvn spotless:apply` fixes it I tried to run `mvn spotless:apply` but it didn't have any ch

Re: [PR] [FLINK-32097][Connectors/Kinesis] Implement support for Kinesis deaggregation [flink-connector-aws]

2025-02-07 Thread via GitHub
nicusX commented on PR #188: URL: https://github.com/apache/flink-connector-aws/pull/188#issuecomment-2643588383 If I run a simple `mvn clean package` on your branch I get spotess-check violations in `RecordBatchTest.java` + 10 other files. And `mvn spotless:apply` changes 12 files. A

Re: [PR] Main thread callback async wait op [flink]

2025-02-07 Thread via GitHub
flinkbot commented on PR #26122: URL: https://github.com/apache/flink/pull/26122#issuecomment-2643622545 ## CI report: * 01f65aef0ff2d7667c23877210d323da007e2ce8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-32097][Connectors/Kinesis] Implement support for Kinesis deaggregation [flink-connector-aws]

2025-02-07 Thread via GitHub
Lzgpom commented on PR #188: URL: https://github.com/apache/flink-connector-aws/pull/188#issuecomment-2643757305 @nicusX I was using the java 17 and the spotless did not work. I changed to java 11 and it worked. Thanks for notifying me about this. -- This is an automated message from

[jira] [Created] (FLINK-37283) Improved ability to split ‘db./.*./.*.’

2025-02-07 Thread ouyangwulin (Jira)
ouyangwulin created FLINK-37283: --- Summary: Improved ability to split ‘db./.*./.*.’ Key: FLINK-37283 URL: https://issues.apache.org/jira/browse/FLINK-37283 Project: Flink Issue Type: Improvement

Re: [PR] [FLINK-37274] Add examples for DataStream V2 [flink]

2025-02-07 Thread via GitHub
reswqa commented on code in PR #26118: URL: https://github.com/apache/flink/pull/26118#discussion_r1946022534 ## flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/dsv2/windowing/CountProductSalesWindowing.java: ## @@ -0,0 +1,235 @@ +/* + *

[jira] [Updated] (FLINK-37283) Improved ability to split ‘db.\.*.\.*.’

2025-02-07 Thread ouyangwulin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ouyangwulin updated FLINK-37283: Description: As flink cdc yaml table input is "db.\.*.\.*", we need parse dbname. (was: As flink

Re: [PR] [hotfix] Remove inappropriate annotation in `flink-statebackend-forst` [flink]

2025-02-07 Thread via GitHub
Zakelly commented on PR #26123: URL: https://github.com/apache/flink/pull/26123#issuecomment-2644455885 > ## What is the purpose of the change > Remove the `@Experimental` annotation for inner classes. Since 2.0 has not been released and this PR will backport to 2.0 before the release, we

Re: [PR] [hotfix] Remove inappropriate annotation in `flink-statebackend-forst` [flink]

2025-02-07 Thread via GitHub
flinkbot commented on PR #26123: URL: https://github.com/apache/flink/pull/26123#issuecomment-2644459939 ## CI report: * 5d6e288355c9a15191371f4947f03792419b81d2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-37276] Add missing state v2 access interfaces in `RuntimeContext` [flink]

2025-02-07 Thread via GitHub
Zakelly opened a new pull request, #26125: URL: https://github.com/apache/flink/pull/26125 Backport to 2.0 for #26120 ## What is the purpose of the change We have introduced the state v2 creating methods in `StreamingRuntimeContext`, but these methods have not exposed to `Run

[PR] [hotfix][state/rocksdb] Use try-with-resources to close RocksStateKeysIterator and fix some typos. [flink]

2025-02-07 Thread via GitHub
littleeleventhwolf opened a new pull request, #26126: URL: https://github.com/apache/flink/pull/26126 ## What is the purpose of the change Use try-with-resources to close RocksStateKeysIterator and fix some typos. ## Does this pull request potentially affect one

[jira] [Created] (FLINK-37285) Adapt DataSinkTranslator to support new Sink API of FLIP-372

2025-02-07 Thread Yanquan Lv (Jira)
Yanquan Lv created FLINK-37285: -- Summary: Adapt DataSinkTranslator to support new Sink API of FLIP-372 Key: FLINK-37285 URL: https://issues.apache.org/jira/browse/FLINK-37285 Project: Flink Iss

[jira] [Commented] (FLINK-37285) Adapt DataSinkTranslator to support new Sink API of FLIP-372

2025-02-07 Thread Yanquan Lv (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925166#comment-17925166 ] Yanquan Lv commented on FLINK-37285: Please assign to me. > Adapt DataSinkTranslato

[jira] [Assigned] (FLINK-37284) ForwardForConsecutiveHashPartitioner cannot be chained in Adaptive batch.

2025-02-07 Thread Junrui Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junrui Lee reassigned FLINK-37284: -- Assignee: Junrui Lee (was: Lei Yang) > ForwardForConsecutiveHashPartitioner cannot be chaine

[PR] [FLINK-37284][runtime] Fix ForwardForConsecutiveHashPartitioner cannot be chained in Adaptive batch. [flink]

2025-02-07 Thread via GitHub
JunRuiLee opened a new pull request, #26127: URL: https://github.com/apache/flink/pull/26127 ## What is the purpose of the change [FLINK-37284][runtime] Fix ForwardForConsecutiveHashPartitioner cannot be chained in Adaptive batch. ## Brief change log [FLINK-3

[jira] [Updated] (FLINK-37284) ForwardForConsecutiveHashPartitioner cannot be chained in Adaptive batch.

2025-02-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37284: --- Labels: pull-request-available (was: ) > ForwardForConsecutiveHashPartitioner cannot be cha

Re: [PR] [FLINK-37284][runtime] Fix ForwardForConsecutiveHashPartitioner cannot be chained in Adaptive batch. [flink]

2025-02-07 Thread via GitHub
flinkbot commented on PR #26127: URL: https://github.com/apache/flink/pull/26127#issuecomment-2644583068 ## CI report: * 425a9b7ad16096dbe1603d87f0dd9132dcb328be UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-37276) Missing state v2 access interfaces in `RuntimeContext`

2025-02-07 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan updated FLINK-37276: Summary: Missing state v2 access interfaces in `RuntimeContext` (was: Missing interfaces in `Runt

[jira] [Created] (FLINK-37276) Missing interfaces in `RuntimeContext`

2025-02-07 Thread Zakelly Lan (Jira)
Zakelly Lan created FLINK-37276: --- Summary: Missing interfaces in `RuntimeContext` Key: FLINK-37276 URL: https://issues.apache.org/jira/browse/FLINK-37276 Project: Flink Issue Type: Bug

Re: [PR] [FLINK-37035][release] Update dev-master point to 2.1 [flink-docker]

2025-02-07 Thread via GitHub
reswqa commented on code in PR #209: URL: https://github.com/apache/flink-docker/pull/209#discussion_r1946201535 ## .github/workflows/ci.yml: ## @@ -27,7 +27,7 @@ jobs: strategy: fail-fast: false matrix: -java_version: [ 8, 11, 17, 21 ] Review Comment

Re: [PR] [FLINK-37035][release] Update dev-master point to 2.1 [flink-docker]

2025-02-07 Thread via GitHub
reswqa commented on code in PR #209: URL: https://github.com/apache/flink-docker/pull/209#discussion_r1946193988 ## testing/docker-test-job/pom.xml: ## @@ -27,7 +27,7 @@ under the License. UTF-8 - 1.9.0 + 1.20.0 Review Com

Re: [PR] [FLINK-36664][Window]Window with offset need deal offset when cal nextTriggerWatermark. [flink]

2025-02-07 Thread via GitHub
xing1mo commented on PR #25629: URL: https://github.com/apache/flink/pull/25629#issuecomment-2642328991 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-37265) Document of python elasticsearch connector exeample has a mistake

2025-02-07 Thread Zhang Hechuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhang Hechuan updated FLINK-37265: -- Summary: Document of python elasticsearch connector exeample has a mistake (was: document of

Re: [PR] [FLINK-37035][release] Update dev-master point to 2.1 [flink-docker]

2025-02-07 Thread via GitHub
reswqa merged PR #209: URL: https://github.com/apache/flink-docker/pull/209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-36439][docs] Documents for Disaggregate State and new State APIs [flink]

2025-02-07 Thread via GitHub
Zakelly commented on code in PR #26107: URL: https://github.com/apache/flink/pull/26107#discussion_r1946224899 ## docs/content.zh/docs/dev/datastream/fault-tolerance/state_v2.md: ## @@ -0,0 +1,601 @@ +--- +title: "Working with State V2" +weight: 2 +type: docs +aliases: + - /dev

[jira] [Updated] (FLINK-37276) Missing state v2 access interfaces in `RuntimeContext`

2025-02-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37276: --- Labels: pull-request-available (was: ) > Missing state v2 access interfaces in `RuntimeCont

[PR] [FLINK-37276] Add missing state v2 access interfaces in `RuntimeContext` [flink]

2025-02-07 Thread via GitHub
Zakelly opened a new pull request, #26120: URL: https://github.com/apache/flink/pull/26120 ## What is the purpose of the change We have introduced the state v2 creating methods in `StreamingRuntimeContext`, but these methods have not exposed to `RuntimeContext`. Thus user may not be

Re: [PR] [FLINK-37267][table] Add support for UNNEST WITH ORDINALITY [flink]

2025-02-07 Thread via GitHub
gustavodemorais commented on code in PR #26113: URL: https://github.com/apache/flink/pull/26113#discussion_r1946227081 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/UnnestRowsFunctionBase.java: ## @@ -0,0 +1,198 @@ +/* + * Licens

Re: [PR] [FLINK-36998][table-planner] Keep same behavior about the RowKind of data in globalUpsertResult for KeyedUpsertingSinkFunction while being inserted or being restored [flink]

2025-02-07 Thread via GitHub
MartijnVisser commented on PR #25892: URL: https://github.com/apache/flink/pull/25892#issuecomment-2642404225 @xuyangzhong Are you still working on this PR? Because CI has failed. I think @xishuaidelin had the right analysis of the problem in https://github.com/apache/flink/pull/26015#is

[jira] [Comment Edited] (FLINK-37265) Document of python elasticsearch connector exeample has a little mistake

2025-02-07 Thread Hirson Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924827#comment-17924827 ] Hirson Zhang edited comment on FLINK-37265 at 2/7/25 9:34 AM:

[jira] [Commented] (FLINK-37049) Cross-team verification for "Remove all Scala APIs"

2025-02-07 Thread xuhuang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924829#comment-17924829 ] xuhuang commented on FLINK-37049: - Hi, [~Zhanghao Chen]  I believe the _flink-dist-scal

Re: [PR] [FLINK-36663][Window]Fix the first processWatermark has extra data after restore by restore timeService's watermark. [flink]

2025-02-07 Thread via GitHub
xing1mo commented on PR #25637: URL: https://github.com/apache/flink/pull/25637#issuecomment-2642326109 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-37267][table] Add support for UNNEST WITH ORDINALITY [flink]

2025-02-07 Thread via GitHub
dawidwys commented on code in PR #26113: URL: https://github.com/apache/flink/pull/26113#discussion_r1946250300 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/UnnestRowsFunctionBase.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to t

[jira] [Commented] (FLINK-37265) Document of python elasticsearch connector exeample has a mistake

2025-02-07 Thread Zhang Hechuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924827#comment-17924827 ] Zhang Hechuan commented on FLINK-37265: --- If possible, I want to try to fix this, b

[jira] [Resolved] (FLINK-37253) Add state size in application status and deployment metrics

2025-02-07 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels resolved FLINK-37253. Release Note: The current state size of the Flink cluster is available for the Fli

Re: [PR] [FLINK-37267][table] Add support for UNNEST WITH ORDINALITY [flink]

2025-02-07 Thread via GitHub
gustavodemorais commented on code in PR #26113: URL: https://github.com/apache/flink/pull/26113#discussion_r1946259454 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/UnnestRowsFunctionBase.java: ## @@ -0,0 +1,198 @@ +/* + * Licens

Re: [PR] [FLINK-37253] Add state size in application status and deployment metrics [flink-kubernetes-operator]

2025-02-07 Thread via GitHub
mxm merged PR #941: URL: https://github.com/apache/flink-kubernetes-operator/pull/941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

Re: [PR] [FLINK-37267][table] Add support for UNNEST WITH ORDINALITY [flink]

2025-02-07 Thread via GitHub
gustavodemorais commented on PR #26113: URL: https://github.com/apache/flink/pull/26113#issuecomment-2642452904 Thanks for the review, @dawidwys! Addressed the comments. I'm adding tests for arrays with rows since I realized a small difference compared to how calcite implements it. I

Re: [PR] [FLINK-37267][table] Add support for UNNEST WITH ORDINALITY [flink]

2025-02-07 Thread via GitHub
gustavodemorais commented on code in PR #26113: URL: https://github.com/apache/flink/pull/26113#discussion_r1946227081 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/UnnestRowsFunctionBase.java: ## @@ -0,0 +1,198 @@ +/* + * Licens

Re: [PR] Add Flink 1.20.1 release [flink-web]

2025-02-07 Thread via GitHub
1996fanrui commented on code in PR #772: URL: https://github.com/apache/flink-web/pull/772#discussion_r1946361103 ## docs/content/posts/2025-02-TBD-release-1.20.1.md: ## @@ -0,0 +1,213 @@ +--- +title: "Apache Flink 1.20.1 Release Announcement" +date: "2025-02-TBDT00:00:00.000Z"

[jira] [Updated] (FLINK-34227) Job doesn't disconnect from ResourceManager

2025-02-07 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-34227: -- Fix Version/s: 1.19.3 1.20.2 (was: 1.19.2)

[jira] [Commented] (FLINK-34227) Job doesn't disconnect from ResourceManager

2025-02-07 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924856#comment-17924856 ] Alexander Fedulov commented on FLINK-34227: --- [~mapohl] thanks for the heads up

Re: [PR] [FLINK-36352][doc] Remove Scala DataStream API related doc [flink]

2025-02-07 Thread via GitHub
X-czh commented on PR #26082: URL: https://github.com/apache/flink/pull/26082#issuecomment-2642693395 @codenohup I've updated the PR, could you help take a look again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Created] (FLINK-37277) Add guidance for configuring different kind of catalog of Paimon Sink.

2025-02-07 Thread Yanquan Lv (Jira)
Yanquan Lv created FLINK-37277: -- Summary: Add guidance for configuring different kind of catalog of Paimon Sink. Key: FLINK-37277 URL: https://issues.apache.org/jira/browse/FLINK-37277 Project: Flink

Re: [PR] [BP-2.0][FLINK-34227][runtime] Makes the JobMaster close procedure more robust to IO thread leaks from the scheduler side [flink]

2025-02-07 Thread via GitHub
XComp merged PR #26114: URL: https://github.com/apache/flink/pull/26114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

[jira] [Comment Edited] (FLINK-37265) Document of python elasticsearch connector exeample has a little mistake

2025-02-07 Thread Hirson Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924827#comment-17924827 ] Hirson Zhang edited comment on FLINK-37265 at 2/7/25 9:57 AM:

[jira] [Updated] (FLINK-37265) Document of python elasticsearch connector exeample has a little mistake

2025-02-07 Thread Hirson Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hirson Zhang updated FLINK-37265: - Summary: Document of python elasticsearch connector exeample has a little mistake (was: Documen

Re: [PR] [FLINK-36998][table-planner] Keep same behavior about the RowKind of data in globalUpsertResult for KeyedUpsertingSinkFunction while being inserted or being restored [flink]

2025-02-07 Thread via GitHub
xuyangzhong commented on PR #25892: URL: https://github.com/apache/flink/pull/25892#issuecomment-2642494401 Hi, @xishuaidelin can you take a look at this pr again if you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] [FLINK-36998][table-planner] Keep same behavior about the RowKind of data in globalUpsertResult for KeyedUpsertingSinkFunction while being inserted or being restored [flink]

2025-02-07 Thread via GitHub
xuyangzhong commented on code in PR #25892: URL: https://github.com/apache/flink/pull/25892#discussion_r1946286251 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TableSinkITCase.scala: ## @@ -630,4 +635,66 @@ class TableSinkIT

Re: [PR] [BP-1.20][FLINK-34227][runtime] Makes the JobMaster close procedure more robust to IO thread leaks from the scheduler side [flink]

2025-02-07 Thread via GitHub
XComp merged PR #26115: URL: https://github.com/apache/flink/pull/26115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [BP-1.19][FLINK-34227][runtime] Makes the JobMaster close procedure more robust to IO thread leaks from the scheduler side [flink]

2025-02-07 Thread via GitHub
XComp merged PR #26116: URL: https://github.com/apache/flink/pull/26116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [BP-1.20][FLINK-34227][runtime] Makes the JobMaster close procedure more robust to IO thread leaks from the scheduler side [flink]

2025-02-07 Thread via GitHub
XComp commented on PR #26115: URL: https://github.com/apache/flink/pull/26115#issuecomment-2642552714 I merged this one w/o an approval because the code change was approved in the parent PR, the conflict was minor and CI was successful -- This is an automated message from the Apache Git S

Re: [PR] [BP-1.19][FLINK-34227][runtime] Makes the JobMaster close procedure more robust to IO thread leaks from the scheduler side [flink]

2025-02-07 Thread via GitHub
XComp commented on PR #26116: URL: https://github.com/apache/flink/pull/26116#issuecomment-2642552996 I merged this one w/o an approval because the code change was approved in the parent PR, the conflict was minor and CI was successful -- This is an automated message from the Apache Git S

[jira] [Comment Edited] (FLINK-34227) Job doesn't disconnect from ResourceManager

2025-02-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924495#comment-17924495 ] Matthias Pohl edited comment on FLINK-34227 at 2/7/25 10:42 AM: --

[jira] [Comment Edited] (FLINK-34227) Job doesn't disconnect from ResourceManager

2025-02-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924495#comment-17924495 ] Matthias Pohl edited comment on FLINK-34227 at 2/7/25 10:45 AM: --

Re: [PR] [BP-2.0][FLINK-34227][runtime] Makes the JobMaster close procedure more robust to IO thread leaks from the scheduler side [flink]

2025-02-07 Thread via GitHub
XComp commented on PR #26114: URL: https://github.com/apache/flink/pull/26114#issuecomment-2642551405 I merged this one w/o an approval because the code change was approved in the parent PR -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (FLINK-34227) Job doesn't disconnect from ResourceManager

2025-02-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924846#comment-17924846 ] Matthias Pohl commented on FLINK-34227: --- [~afedulov] just as an fyi that this was

Re: [PR] [FLINK-37276] Add missing state v2 access interfaces in `RuntimeContext` [flink]

2025-02-07 Thread via GitHub
flinkbot commented on PR #26120: URL: https://github.com/apache/flink/pull/26120#issuecomment-2642479117 ## CI report: * 8e9f7befe6f193808588b5b0bbf1c08108d5399a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-37277) Add guidance for configuring different kind of catalog of Paimon Sink.

2025-02-07 Thread Yanquan Lv (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924871#comment-17924871 ] Yanquan Lv commented on FLINK-37277: I would like to take this. > Add guidance for

[jira] [Created] (FLINK-37278) Regular schema evolution process is too slow when starting from specific offset

2025-02-07 Thread yux (Jira)
yux created FLINK-37278: --- Summary: Regular schema evolution process is too slow when starting from specific offset Key: FLINK-37278 URL: https://issues.apache.org/jira/browse/FLINK-37278 Project: Flink

[jira] [Created] (FLINK-37279) Add Flink CDC Pipeline Clickhouse connector

2025-02-07 Thread qinghuan wang (Jira)
qinghuan wang created FLINK-37279: - Summary: Add Flink CDC Pipeline Clickhouse connector Key: FLINK-37279 URL: https://issues.apache.org/jira/browse/FLINK-37279 Project: Flink Issue Type: Imp

[jira] [Commented] (FLINK-21584) Support UNNEST in LEFT JOINs

2025-02-07 Thread Gustavo de Morais (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924913#comment-17924913 ] Gustavo de Morais commented on FLINK-21584: --- Reading the logs reported by [~nk

[jira] [Commented] (FLINK-35886) Incorrect watermark idleness timeout accounting when subtask is backpressured/blocked

2025-02-07 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924901#comment-17924901 ] Piotr Nowojski commented on FLINK-35886: Thanks for fixing it! > Incorrect wate

Re: [PR] [FLINK-37005][table] Make StreamExecDeduplicate ouput insert only where possible [flink]

2025-02-07 Thread via GitHub
pnowojski commented on code in PR #26051: URL: https://github.com/apache/flink/pull/26051#discussion_r1946598188 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecDeduplicate.java: ## @@ -339,25 +362,39 @@ OneInputSt

Re: [PR] [FLINK-37005][table] Make StreamExecDeduplicate ouput insert only where possible [flink]

2025-02-07 Thread via GitHub
pnowojski commented on code in PR #26051: URL: https://github.com/apache/flink/pull/26051#discussion_r1946606727 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalRank.scala: ## @@ -109,28 +109,34 @@ class S

[jira] [Commented] (FLINK-21584) Support UNNEST in LEFT JOINs

2025-02-07 Thread Gustavo de Morais (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924911#comment-17924911 ] Gustavo de Morais commented on FLINK-21584: --- Unnest has support for left join:

Re: [PR] [FLINK-37268][example] Use async state in flink-examples-streaming [flink]

2025-02-07 Thread via GitHub
Zakelly commented on code in PR #26117: URL: https://github.com/apache/flink/pull/26117#discussion_r1946487194 ## flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/asyncstate/AsyncStateWordCount.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed

[jira] [Resolved] (FLINK-34227) Job doesn't disconnect from ResourceManager

2025-02-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-34227. --- Fix Version/s: 2.0.0 1.19.2 1.20.1 2

Re: [PR] [FLINK-32097][Connectors/Kinesis] Implement support for Kinesis deaggregation [flink-connector-aws]

2025-02-07 Thread via GitHub
nicusX commented on PR #188: URL: https://github.com/apache/flink-connector-aws/pull/188#issuecomment-2643211998 @Lzgpom Building this locally and I've got a spotless-check format violation. `mvn spotless:apply` fixes it -- This is an automated message from the Apache Git Service. To r

Re: [PR] [FLINK-37225] Remove remaining test resources of Gelly [flink]

2025-02-07 Thread via GitHub
davidradl commented on PR #26081: URL: https://github.com/apache/flink/pull/26081#issuecomment-2643383940 I was looking to see when we decided that Gelly is no longer supported so should not be tested; I could not see anything in the Jira as to the history behind this. -- This is an auto

Re: [PR] [FLINK-37276] Add missing state v2 access interfaces in `RuntimeContext` [flink]

2025-02-07 Thread via GitHub
davidradl commented on code in PR #26120: URL: https://github.com/apache/flink/pull/26120#discussion_r1946811443 ## flink-core/src/main/java/org/apache/flink/api/common/state/v2/AggregatingStateDescriptor.java: ## @@ -72,6 +72,23 @@ public AggregatingStateDescriptor( th

Re: [PR] [FLINK-37276] Add missing state v2 access interfaces in `RuntimeContext` [flink]

2025-02-07 Thread via GitHub
davidradl commented on code in PR #26120: URL: https://github.com/apache/flink/pull/26120#discussion_r1946812865 ## flink-core/src/main/java/org/apache/flink/api/common/state/v2/AggregatingStateDescriptor.java: ## @@ -72,6 +72,23 @@ public AggregatingStateDescriptor( th

Re: [PR] [FLINK-37276] Add missing state v2 access interfaces in `RuntimeContext` [flink]

2025-02-07 Thread via GitHub
davidradl commented on code in PR #26120: URL: https://github.com/apache/flink/pull/26120#discussion_r1946817950 ## flink-core/src/main/java/org/apache/flink/api/common/state/v2/ReducingStateDescriptor.java: ## @@ -67,6 +67,23 @@ public ReducingStateDescriptor( this.red

Re: [PR] [FLINK-37276] Add missing state v2 access interfaces in `RuntimeContext` [flink]

2025-02-07 Thread via GitHub
davidradl commented on code in PR #26120: URL: https://github.com/apache/flink/pull/26120#discussion_r1946811443 ## flink-core/src/main/java/org/apache/flink/api/common/state/v2/AggregatingStateDescriptor.java: ## @@ -72,6 +72,23 @@ public AggregatingStateDescriptor( th

Re: [PR] [FLINK-37276] Add missing state v2 access interfaces in `RuntimeContext` [flink]

2025-02-07 Thread via GitHub
davidradl commented on code in PR #26120: URL: https://github.com/apache/flink/pull/26120#discussion_r1946810230 ## flink-core/src/main/java/org/apache/flink/api/common/functions/RuntimeContext.java: ## @@ -410,6 +411,95 @@ AggregatingState getAggregatingState( @PublicEvo

  1   2   >