[jira] [Resolved] (FLINK-34369) Elasticsearch connector supports SSL context

2024-12-12 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-34369. - Fix Version/s: elasticsearch-3.2.0 Resolution: Fixed > Elasticsearch connector su

[jira] [Commented] (FLINK-36889) Mention locking down a Flink cluster in the 'Production Readiness Checklist'

2024-12-12 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905051#comment-17905051 ] Robert Metzger commented on FLINK-36889: Thanks, assigned. > Mention locking do

Re: [PR] [FLINK-36883] Adapt time attributes from the VIEWs query (#25779) [flink]

2024-12-12 Thread via GitHub
dawidwys merged PR #25787: URL: https://github.com/apache/flink/pull/25787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Updated] (FLINK-34273) git fetch fails on CI

2024-12-12 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-34273: --- Summary: git fetch fails on CI (was: git fetch fails) > git fetch fails on CI > ---

[jira] [Commented] (FLINK-22258) Adaptive Scheduler: Show history of rescales in the Web UI

2024-12-12 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905062#comment-17905062 ] Rui Fan commented on FLINK-22258: - Hi [~rmetzger] , thanks for asking here. Currently,

[jira] [Commented] (FLINK-22258) Adaptive Scheduler: Show history of rescales in the Web UI

2024-12-12 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905054#comment-17905054 ] Robert Metzger commented on FLINK-22258: What's the status of this ticket? > Ad

[jira] [Closed] (FLINK-36883) Views should keep the time attributes of the query

2024-12-12 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-36883. Resolution: Fixed Fixed in: * master ** 529f64078a34d9840a26906bcf967a2147d305f9 * 1.20.1

[jira] [Assigned] (FLINK-36753) Adaptive Scheduler actively triggers a Checkpoint

2024-12-12 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-36753: --- Assignee: Samrat Deb > Adaptive Scheduler actively triggers a Checkpoint >

[jira] [Commented] (FLINK-36753) Adaptive Scheduler actively triggers a Checkpoint

2024-12-12 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905072#comment-17905072 ] Samrat Deb commented on FLINK-36753: Thank you, Rui, for assigning the Jira! :)  >

[PR] [FLINK-36067][runtime] Support optimize stream graph based on input info. [flink]

2024-12-12 Thread via GitHub
JunRuiLee opened a new pull request, #25790: URL: https://github.com/apache/flink/pull/25790 ## What is the purpose of the change [FLINK-36067][runtime] Support optimize stream graph based on input info. ## Brief change log - Introduce StreamGraphOptimizer

[jira] [Created] (FLINK-36896) Table API trim expression incorrectly translated to SQL

2024-12-12 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-36896: --- Summary: Table API trim expression incorrectly translated to SQL Key: FLINK-36896 URL: https://issues.apache.org/jira/browse/FLINK-36896 Project: Flink

[PR] [FLINK-36896] Table API trim expression incorrectly translated to SQL [flink]

2024-12-12 Thread via GitHub
snuyanzin opened a new pull request, #25791: URL: https://github.com/apache/flink/pull/25791 ## What is the purpose of the change While translation of `trim()` to SQL parenthesis are missed ## Brief change log `SqlCallSyntax` ## Verifying this change `Expres

[jira] [Updated] (FLINK-36067) Introducing the StreamGraphOptimizer component

2024-12-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36067: --- Labels: pull-request-available (was: ) > Introducing the StreamGraphOptimizer component > -

[jira] [Updated] (FLINK-36896) Table API trim expression incorrectly translated to SQL

2024-12-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36896: --- Labels: pull-request-available (was: ) > Table API trim expression incorrectly translated t

[PR] [FLINK-36892][Runtime] Properly handle the watermark status within async state processing [flink]

2024-12-12 Thread via GitHub
Zakelly opened a new pull request, #25792: URL: https://github.com/apache/flink/pull/25792 ## What is the purpose of the change The watermark status is not properly handle in async state processing. It is emitted to downstream synchronously, while the watermarks will respect the

[jira] [Updated] (FLINK-36892) Properly handle the watermark status

2024-12-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36892: --- Labels: pull-request-available (was: ) > Properly handle the watermark status > ---

Re: [PR] [FLINK-36896][table] Table API trim expression incorrectly translated to SQL [flink]

2024-12-12 Thread via GitHub
flinkbot commented on PR #25791: URL: https://github.com/apache/flink/pull/25791#issuecomment-2538287677 ## CI report: * fe52760343c6d429d8a586dda10a37030a3dbf98 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-36892][Runtime] Properly handle the watermark status within async state processing [flink]

2024-12-12 Thread via GitHub
flinkbot commented on PR #25792: URL: https://github.com/apache/flink/pull/25792#issuecomment-2538287976 ## CI report: * 2c6e7e5107048c628a13f4520034f940a23f2fab UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-36067][runtime] Support optimize stream graph based on input info. [flink]

2024-12-12 Thread via GitHub
flinkbot commented on PR #25790: URL: https://github.com/apache/flink/pull/25790#issuecomment-2538287409 ## CI report: * 28a209691af93e57a7efe44c6d5b754b89ac7a5f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Assigned] (FLINK-36889) Mention locking down a Flink cluster in the 'Production Readiness Checklist'

2024-12-12 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reassigned FLINK-36889: -- Assignee: Samrat Deb > Mention locking down a Flink cluster in the 'Production Readin

Re: [PR] [FLINK-36892][Runtime] Properly handle the watermark status within async state processing [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25792: URL: https://github.com/apache/flink/pull/25792#discussion_r1881730342 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/AbstractAsyncStateStreamOperatorV2.java: ## @@ -259,17 +265,35 @@ public void proces

Re: [PR] [FLINK-36851][table] Introduce TemporalProcessTimeJoinOperator in TemporalJoin with Async State API [flink]

2024-12-12 Thread via GitHub
Au-Miner commented on code in PR #25777: URL: https://github.com/apache/flink/pull/25777#discussion_r1881691868 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecTemporalJoin.java: ## @@ -276,12 +278,21 @@ private Tw

Re: [PR] [FLINK-36851][table] Introduce TemporalProcessTimeJoinOperator in TemporalJoin with Async State API [flink]

2024-12-12 Thread via GitHub
Au-Miner commented on code in PR #25777: URL: https://github.com/apache/flink/pull/25777#discussion_r1881691868 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecTemporalJoin.java: ## @@ -276,12 +278,21 @@ private Tw

Re: [PR] [WIP][FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2024-12-12 Thread via GitHub
yiyutian1 commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1881754173 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to

Re: [PR] [FLINK-36892][Runtime] Properly handle the watermark status within async state processing [flink]

2024-12-12 Thread via GitHub
Zakelly commented on code in PR #25792: URL: https://github.com/apache/flink/pull/25792#discussion_r1881755602 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/AbstractAsyncStateStreamOperatorV2.java: ## @@ -259,17 +265,35 @@ public void processW

Re: [PR] [FLINK-36858][pipeline-connector][kafka] Fix compatibility with Flink 1.20 JsonRowDataSerializationSchema [flink-cdc]

2024-12-12 Thread via GitHub
MOBIN-F commented on code in PR #3784: URL: https://github.com/apache/flink-cdc/pull/3784#discussion_r1881800085 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-kafka/src/main/java/org/apache/flink/cdc/connectors/kafka/utils/JsonRowDataSerializationSchema

[jira] [Commented] (FLINK-35887) Null Pointer Exception in TypeExtractor.isRecord when trying to provide type info for interface

2024-12-12 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905096#comment-17905096 ] lincoln lee commented on FLINK-35887: - Because the need to port to lower versions is

Re: [PR] [FLINK-36068][runtime] Support scheduling based on adaptive job graph. [flink]

2024-12-12 Thread via GitHub
JunRuiLee merged PR #25658: URL: https://github.com/apache/flink/pull/25658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[jira] [Closed] (FLINK-36068) Support for adaptive job scheduling based on StreamGraph

2024-12-12 Thread Junrui Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junrui Lee closed FLINK-36068. -- > Support for adaptive job scheduling based on StreamGraph > -

[jira] [Updated] (FLINK-36067) Support optimize stream graph based on input info.

2024-12-12 Thread Junrui Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junrui Lee updated FLINK-36067: --- Summary: Support optimize stream graph based on input info. (was: Introducing the StreamGraphOptimi

[jira] [Resolved] (FLINK-36068) Support for adaptive job scheduling based on StreamGraph

2024-12-12 Thread Junrui Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junrui Lee resolved FLINK-36068. Resolution: Fixed master: 1580b4dd53cf023a201f12d822df0f9c1fbe241d 2e7dfae5c3b58967d160aed99d0873b

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2024-12-12 Thread via GitHub
snuyanzin commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1881856608 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2024-12-12 Thread via GitHub
snuyanzin commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1881860996 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2024-12-12 Thread via GitHub
snuyanzin commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1881862749 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2024-12-12 Thread via GitHub
snuyanzin commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1881862749 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2024-12-12 Thread via GitHub
snuyanzin commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1881852846 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to

Re: [PR] [FLINK-36761][docs] Add document about how to use SQL Gateway and SQL Client to deploy script [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25784: URL: https://github.com/apache/flink/pull/25784#discussion_r1882174945 ## docs/content.zh/docs/dev/table/sqlClient.md: ## @@ -663,6 +663,24 @@ This configuration: Attention Compared to the interactive mode, SQL Client will stop execu

Re: [PR] [FLINK-36761][docs] Add document about how to use SQL Gateway and SQL Client to deploy script [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25784: URL: https://github.com/apache/flink/pull/25784#discussion_r1882176878 ## docs/content.zh/docs/dev/table/sqlClient.md: ## @@ -610,7 +610,7 @@ SQL Client will print success message if the statement is executed successfully. By default,

Re: [PR] [FLINK-36761][docs] Add document about how to use SQL Gateway and SQL Client to deploy script [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25784: URL: https://github.com/apache/flink/pull/25784#discussion_r1882178794 ## docs/content/docs/dev/table/sqlClient.md: ## @@ -601,6 +601,24 @@ This configuration: Attention Compared to the interactive mode, SQL Client will stop executio

Re: [PR] [FLINK-36881][table] Introduce GroupTableAggFunction in GroupTableAggregate with Async State API [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25789: URL: https://github.com/apache/flink/pull/25789#discussion_r1882324012 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/aggregate/utils/GroupTableAggHelper.java: ## @@ -0,0 +1,79 @@ +/* + * Licens

Re: [PR] [FLINK-36881][table] Introduce GroupTableAggFunction in GroupTableAggregate with Async State API [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25789: URL: https://github.com/apache/flink/pull/25789#discussion_r1882325785 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/aggregate/utils/GroupTableAggHelper.java: ## @@ -0,0 +1,79 @@ +/* + * Licens

Re: [PR] [FLINK-36881][table] Introduce GroupTableAggFunction in GroupTableAggregate with Async State API [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25789: URL: https://github.com/apache/flink/pull/25789#discussion_r1882325785 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/aggregate/utils/GroupTableAggHelper.java: ## @@ -0,0 +1,79 @@ +/* + * Licens

Re: [PR] [FLINK-36881][table] Introduce GroupTableAggFunction in GroupTableAggregate with Async State API [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25789: URL: https://github.com/apache/flink/pull/25789#discussion_r1882323328 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/aggregate/asyncprocessing/AsyncStateGroupTableAggFunction.java: ## @@ -0,0 +

Re: [PR] [FLINK-36067][runtime] Support optimize stream graph based on input info. [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25790: URL: https://github.com/apache/flink/pull/25790#discussion_r1882334476 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/IntermediateResult.java: ## @@ -207,6 +210,10 @@ public boolean isForward() { return i

[jira] [Commented] (FLINK-36893) Support periodic full checkpoint

2024-12-12 Thread Ryan van Huuksloot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905252#comment-17905252 ] Ryan van Huuksloot commented on FLINK-36893: We use both savepoint and check

Re: [PR] [hotfix][docs] Fix Apache Avro Specification Link. [flink]

2024-12-12 Thread via GitHub
donPain commented on code in PR #25769: URL: https://github.com/apache/flink/pull/25769#discussion_r1882539224 ## docs/content/docs/connectors/table/formats/avro.md: ## @@ -218,4 +218,4 @@ So the following table lists the type mapping from Flink type to Avro type. In additio

[jira] [Closed] (FLINK-36893) Support periodic full checkpoint

2024-12-12 Thread Xingcan Cui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingcan Cui closed FLINK-36893. --- Resolution: Won't Fix > Support periodic full checkpoint > > >

[jira] [Commented] (FLINK-36893) Support periodic full checkpoint

2024-12-12 Thread Xingcan Cui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905253#comment-17905253 ] Xingcan Cui commented on FLINK-36893: - Ah, gotcha. I just noticed https://issues.apa

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2024-12-12 Thread via GitHub
yiyutian1 commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1881765938 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/TemporalTypesTest.scala: ## @@ -1140,41 +1140,41 @@ class TemporalTypesTe

Re: [PR] [WIP][FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2024-12-12 Thread via GitHub
yiyutian1 commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1881732526 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to

Re: [PR] [FLINK-36578][MySQL] Added modified JsonStringFormatter and option use.legacy.json.format [flink-cdc]

2024-12-12 Thread via GitHub
SML0127 commented on PR #3658: URL: https://github.com/apache/flink-cdc/pull/3658#issuecomment-2538529346 @ruanhang1993 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2024-12-12 Thread via GitHub
snuyanzin commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1881831845 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/TemporalTypesTest.scala: ## @@ -1140,41 +1140,41 @@ class TemporalTypesTe

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2024-12-12 Thread via GitHub
snuyanzin commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1881834036 ## docs/data/sql_functions.yml: ## @@ -679,9 +679,15 @@ temporal: - sql: TO_DATE(string1[, string2]) table: toDate(STRING1[, STRING2]) description: Conve

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2024-12-12 Thread via GitHub
snuyanzin commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1881832830 ## docs/data/sql_functions.yml: ## @@ -679,9 +679,15 @@ temporal: - sql: TO_DATE(string1[, string2]) table: toDate(STRING1[, STRING2]) description: Conve

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2024-12-12 Thread via GitHub
snuyanzin commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1881841286 ## docs/data/sql_functions.yml: ## @@ -679,9 +679,15 @@ temporal: - sql: TO_DATE(string1[, string2]) table: toDate(STRING1[, STRING2]) description: Conve

Re: [PR] Bump io.netty:netty-common from 4.1.46.Final to 4.1.115.Final in /flink-end-to-end-tests/flink-end-to-end-tests-hive [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25750: URL: https://github.com/apache/flink/pull/25750#discussion_r1881901413 ## flink-end-to-end-tests/flink-end-to-end-tests-hive/pom.xml: ## @@ -198,7 +198,7 @@ under the License.

Re: [PR] [FLINK-12173][table] Optimize SELECT DISTINCT [flink]

2024-12-12 Thread via GitHub
snuyanzin commented on code in PR #25752: URL: https://github.com/apache/flink/pull/25752#discussion_r1881954651 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/RankTest.scala: ## @@ -1011,5 +1011,16 @@ class RankTest extends Tabl

[jira] [Commented] (FLINK-36896) Table API trim expression incorrectly translated to SQL

2024-12-12 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905140#comment-17905140 ] Sergey Nuyanzin commented on FLINK-36896: - Merged as [72b32fcd53f2d0d81329298a6

Re: [PR] [FLINK-36761][docs] Add document about how to use SQL Gateway and SQL Client to deploy script [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25784: URL: https://github.com/apache/flink/pull/25784#discussion_r1882178794 ## docs/content/docs/dev/table/sqlClient.md: ## @@ -601,6 +601,24 @@ This configuration: Attention Compared to the interactive mode, SQL Client will stop executio

Re: [PR] [FLINK-36761][docs] Add document about how to use SQL Gateway and SQL Client to deploy script [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25784: URL: https://github.com/apache/flink/pull/25784#discussion_r1882182035 ## docs/content/docs/dev/table/sqlClient.md: ## @@ -601,6 +601,24 @@ This configuration: Attention Compared to the interactive mode, SQL Client will stop executio

Re: [PR] [FLINK-35241][table]Support SQL FLOOR and CEIL functions with SECOND and MINUTE for TIMESTAMP_TLZ [flink]

2024-12-12 Thread via GitHub
hanyuzheng7 commented on PR #25759: URL: https://github.com/apache/flink/pull/25759#issuecomment-2539042873 @snuyanzin Yes, because this ticket just handle the SECOND and MINUTE case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] [FLINK-35241][table]Support SQL FLOOR and CEIL functions with SECOND and MINUTE for TIMESTAMP_TLZ [flink]

2024-12-12 Thread via GitHub
hanyuzheng7 commented on PR #25759: URL: https://github.com/apache/flink/pull/25759#issuecomment-2539408787 Support `MILLISECOND` now @snuyanzin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [FLINK-36892][Runtime] Properly handle the watermark status within async state processing [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25792: URL: https://github.com/apache/flink/pull/25792#discussion_r1882410030 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/AbstractAsyncStateStreamOperator.java: ## @@ -368,10 +385,12 @@ protected void proce

Re: [PR] [FLINK-36499][table]Remove deprecated method `SupportsProjectionPushD… [flink]

2024-12-12 Thread via GitHub
tomncooper commented on PR #25594: URL: https://github.com/apache/flink/pull/25594#issuecomment-2539395427 The CI failure looks unrelated, a rebase and re-run might fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] [FLINK-12173][table] Optimize SELECT DISTINCT [flink]

2024-12-12 Thread via GitHub
snuyanzin commented on code in PR #25752: URL: https://github.com/apache/flink/pull/25752#discussion_r1881952675 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/physical/stream/StreamLogicalOptimizeSelectDistinctRule.scala: ## @@ -0,0

Re: [PR] [FLINK-35241][table]Support SQL FLOOR and CEIL functions with SECOND and MINUTE for TIMESTAMP_TLZ [flink]

2024-12-12 Thread via GitHub
snuyanzin commented on PR #25759: URL: https://github.com/apache/flink/pull/25759#issuecomment-2539063947 the root cause is same, if you compare output for different inputs, it will be same. The jira issue was raised for the case the reporter faced however it does not mean it is limited

Re: [PR] [FLINK-36497][table]Remove all deprecated methods `CatalogTable` [flink]

2024-12-12 Thread via GitHub
tomncooper commented on PR #25585: URL: https://github.com/apache/flink/pull/25585#issuecomment-2539423237 Looks like you have failed the spotless check. You need to run `mvn spotless:apply` and commit the changes first and then you can actually test your code changes. -- This is an auto

Re: [PR] [FLINK-36504][table]Remove all deprecated methods `ModuleFactory` [flink]

2024-12-12 Thread via GitHub
tomncooper commented on PR #25584: URL: https://github.com/apache/flink/pull/25584#issuecomment-2539429673 Looks like you have actual [test failures](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=63833&view=logs&j=0c940707-2659-5648-cbe6-a1ad63045f0a&t=075c2716-8010-

Re: [PR] [FLINK-36617] migrate kyro package [flink]

2024-12-12 Thread via GitHub
tomncooper commented on PR #25583: URL: https://github.com/apache/flink/pull/25583#issuecomment-2539442790 Looks like you have conflicting versions of `org.ow2.asm:asm`. You may need to override the transitive versions of kryo from other packages (in this case the one coming from `com.twit

Re: [PR] [WIP][FLINK-36871] add rescale metrics in scheduler [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25770: URL: https://github.com/apache/flink/pull/25770#discussion_r1882108757 ## flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricNames.java: ## @@ -52,6 +52,7 @@ private MetricNames() {} public static final String NUM_PE

[jira] [Created] (FLINK-36897) Error in calling processElement for AbstractAsynchronous StateStreamOperator

2024-12-12 Thread Wang Qilong (Jira)
Wang Qilong created FLINK-36897: --- Summary: Error in calling processElement for AbstractAsynchronous StateStreamOperator Key: FLINK-36897 URL: https://issues.apache.org/jira/browse/FLINK-36897 Project: F

Re: [PR] [WIP][FLINK-36871] add rescale metrics in scheduler [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25770: URL: https://github.com/apache/flink/pull/25770#discussion_r1882114599 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveSchedulerTest.java: ## @@ -664,7 +740,7 @@ void testNumRestartsMetric() throws Exce

[jira] [Updated] (FLINK-36897) Error executing processElement when inheriting from AbstractAsyncStateStreamOperator

2024-12-12 Thread Wang Qilong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wang Qilong updated FLINK-36897: Description: When I created the AbstractAsynchronous StateMapBundleOperator and inherited it from

Re: [PR] [WIP][FLINK-36871] add rescale metrics in scheduler [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25770: URL: https://github.com/apache/flink/pull/25770#discussion_r1882124577 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java: ## @@ -641,6 +643,7 @@ public final void startScheduling() { jo

Re: [PR] [WIP][FLINK-36871] add rescale metrics in scheduler [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25770: URL: https://github.com/apache/flink/pull/25770#discussion_r1882119229 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/StateTransitions.java: ## @@ -139,7 +139,8 @@ void goToRestarting( Operato

[jira] [Updated] (FLINK-36897) Error executing processElement when inheriting from AbstractAsyncStateStreamOperator

2024-12-12 Thread Wang Qilong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wang Qilong updated FLINK-36897: Summary: Error executing processElement when inheriting from AbstractAsyncStateStreamOperator (wa

Re: [PR] [WIP][FLINK-36871] add rescale metrics in scheduler [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25770: URL: https://github.com/apache/flink/pull/25770#discussion_r1882114599 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveSchedulerTest.java: ## @@ -664,7 +740,7 @@ void testNumRestartsMetric() throws Exce

[jira] [Updated] (FLINK-36897) Error executing processElement when inheriting from AbstractAsyncStateStreamOperator

2024-12-12 Thread Wang Qilong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wang Qilong updated FLINK-36897: Description: When I created the AbstractAsynchronous StateMapBundleOperator and inherited it from

Re: [PR] [WIP][FLINK-36871] add rescale metrics in scheduler [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25770: URL: https://github.com/apache/flink/pull/25770#discussion_r1882125855 ## pom.xml: ## @@ -1819,7 +1819,7 @@ under the License.

Re: [PR] [FLINK-36896][table] Table API trim expression incorrectly translated to SQL [flink]

2024-12-12 Thread via GitHub
snuyanzin merged PR #25791: URL: https://github.com/apache/flink/pull/25791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [hotfix][docs] Fix Apache Avro Specification Link. [flink]

2024-12-12 Thread via GitHub
snuyanzin commented on PR #25769: URL: https://github.com/apache/flink/pull/25769#issuecomment-2539537588 can you also change it at https://github.com/apache/flink/blob/72b32fcd53f2d0d81329298a6c0a7d08e084f769/flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/Avr

Re: [PR] [hotfix] [gitignore] ignore .vscode folder in .gitignore [flink]

2024-12-12 Thread via GitHub
rmetzger merged PR #25774: URL: https://github.com/apache/flink/pull/25774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Assigned] (FLINK-36725) Add CompiledPlan annotations to BatchExecRuntimeFilter exec nodes

2024-12-12 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Hughes reassigned FLINK-36725: -- Assignee: (was: Jim Hughes) > Add CompiledPlan annotations to BatchExecRuntimeFilter exec

Re: [PR] [FLINK-36067][runtime] Support optimize stream graph based on input info. [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25790: URL: https://github.com/apache/flink/pull/25790#discussion_r1882345432 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/IntermediateResultInfo.java: ## @@ -35,6 +35,14 @@ public interface IntermediateResultInfo {

Re: [PR] [FLINK-36067][runtime] Support optimize stream graph based on input info. [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25790: URL: https://github.com/apache/flink/pull/25790#discussion_r1882334476 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/IntermediateResult.java: ## @@ -207,6 +210,10 @@ public boolean isForward() { return i

Re: [PR] [FLINK-36067][runtime] Support optimize stream graph based on input info. [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25790: URL: https://github.com/apache/flink/pull/25790#discussion_r1882345432 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/IntermediateResultInfo.java: ## @@ -35,6 +35,14 @@ public interface IntermediateResultInfo {

Re: [PR] [FLINK-22484][table] Add built-in MAP_KEYS, MAP_VALUES, MAP_FROM_ARRA… [flink]

2024-12-12 Thread via GitHub
twalthr commented on PR #15797: URL: https://github.com/apache/flink/pull/15797#issuecomment-2539112337 @chenshaojin please open a new issue in this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] [FLINK-36876] Support external eventLoopGroup for RestClient [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25788: URL: https://github.com/apache/flink/pull/25788#discussion_r1882245040 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java: ## @@ -317,7 +337,7 @@ private CompletableFuture shutdownInternally(Duration timeout) {

Re: [PR] [FLINK-36876] Support external eventLoopGroup for RestClient [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25788: URL: https://github.com/apache/flink/pull/25788#discussion_r1882256774 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java: ## @@ -264,15 +278,21 @@ protected void initChannel(SocketChannel socketChannel) {

Re: [PR] [FLINK-36876] Support external eventLoopGroup for RestClient [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25788: URL: https://github.com/apache/flink/pull/25788#discussion_r1882238434 ## flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java: ## @@ -230,15 +240,17 @@ public RestClusterClient( restCl

Re: [PR] [FLINK-35241][table]Support SQL FLOOR and CEIL functions with SECOND and MINUTE for TIMESTAMP_TLZ [flink]

2024-12-12 Thread via GitHub
hanyuzheng7 commented on PR #25759: URL: https://github.com/apache/flink/pull/25759#issuecomment-2539107679 @snuyanzin The reason we not support `millisecond`/`nanosecond` is that floor and ceil not support these two perfectly. You can see here ``` /** * Keep the algorithm c

Re: [PR] [FLINK-36876] Support external eventLoopGroup for RestClient [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25788: URL: https://github.com/apache/flink/pull/25788#discussion_r1882245040 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java: ## @@ -317,7 +337,7 @@ private CompletableFuture shutdownInternally(Duration timeout) {

[jira] [Commented] (FLINK-36893) Support periodic full checkpoint

2024-12-12 Thread Ryan van Huuksloot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905214#comment-17905214 ] Ryan van Huuksloot commented on FLINK-36893: We use the Kubernetes Operator

[jira] [Commented] (FLINK-36893) Support periodic full checkpoint

2024-12-12 Thread Xingcan Cui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905219#comment-17905219 ] Xingcan Cui commented on FLINK-36893: - [~ryanvanhuuksloot] I guess you meant savepoi

Re: [PR] [FLINK-36896][table] Table API trim expression incorrectly translated to SQL [flink]

2024-12-12 Thread via GitHub
snuyanzin commented on code in PR #25791: URL: https://github.com/apache/flink/pull/25791#discussion_r1881898765 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/expressions/ExpressionSerializationTest.java: ## @@ -172,13 +172,13 @@ public static Stream t

Re: [PR] [FLINK-36067][runtime] Support optimize stream graph based on input info. [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25790: URL: https://github.com/apache/flink/pull/25790#discussion_r1881899030 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchScheduler.java: ## @@ -937,6 +965,26 @@ SpeculativeExecutionHandler getS

Re: [PR] [FLINK-36761][docs] Add document about how to use SQL Gateway and SQL Client to deploy script [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25784: URL: https://github.com/apache/flink/pull/25784#discussion_r1882165452 ## docs/content.zh/docs/dev/table/sql-gateway/overview.md: ## @@ -116,6 +116,34 @@ $ curl --request GET http://localhost:8083/v1/sessions/${sessionHandle}/operatio

Re: [PR] [FLINK-36761][docs] Add document about how to use SQL Gateway and SQL Client to deploy script [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25784: URL: https://github.com/apache/flink/pull/25784#discussion_r1882166683 ## docs/content.zh/docs/dev/table/sql-gateway/overview.md: ## @@ -116,6 +116,34 @@ $ curl --request GET http://localhost:8083/v1/sessions/${sessionHandle}/operatio

Re: [PR] [FLINK-36761][docs] Add document about how to use SQL Gateway and SQL Client to deploy script [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25784: URL: https://github.com/apache/flink/pull/25784#discussion_r1882169373 ## docs/content.zh/docs/dev/table/sql-gateway/overview.md: ## @@ -116,6 +116,34 @@ $ curl --request GET http://localhost:8083/v1/sessions/${sessionHandle}/operatio

Re: [PR] [FLINK-36761][docs] Add document about how to use SQL Gateway and SQL Client to deploy script [flink]

2024-12-12 Thread via GitHub
davidradl commented on code in PR #25784: URL: https://github.com/apache/flink/pull/25784#discussion_r1882167903 ## docs/content.zh/docs/dev/table/sql-gateway/overview.md: ## @@ -116,6 +116,34 @@ $ curl --request GET http://localhost:8083/v1/sessions/${sessionHandle}/operatio

  1   2   >