[PR] [FLINK-4602] Change RocksDBKeyedStateBackend to new package. [flink-benchmarks]

2024-10-29 Thread via GitHub
AlexYinHan opened a new pull request, #98: URL: https://github.com/apache/flink-benchmarks/pull/98 This resolves the compilation errors introduced by [FLINK-4602](https://github.com/apache/flink/pull/25543), which moves the rocksdb classes to o.a.f.state.rocksdb package package. -- This

[jira] [Updated] (FLINK-36271) Support json and jsonb type in PostgreSQL JDBC Dialect

2024-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36271: --- Labels: pull-request-available (was: ) > Support json and jsonb type in PostgreSQL JDBC Dia

[jira] [Commented] (FLINK-36245) Remove legacy SourceFunction / SinkFunction / Sink V1 API and deprecated method/interface in Sink V2 in 2.0

2024-10-29 Thread LvYanquan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893798#comment-17893798 ] LvYanquan commented on FLINK-36245: --- Hi, Piotr. Kafka connector has not yet been adapt

[jira] [Created] (FLINK-36622) Remove the dependency of StateBenchmark on RocksDBKeyedStateBackend APIs.

2024-10-29 Thread Han Yin (Jira)
Han Yin created FLINK-36622: --- Summary: Remove the dependency of StateBenchmark on RocksDBKeyedStateBackend APIs. Key: FLINK-36622 URL: https://issues.apache.org/jira/browse/FLINK-36622 Project: Flink

Re: [PR] [FLINK-36592][state/forst] Support file cache for ForStStateBackend [flink]

2024-10-29 Thread via GitHub
Zakelly commented on code in PR #25561: URL: https://github.com/apache/flink/pull/25561#discussion_r1820533404 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed t

Re: [PR] [FLINK-36455] Sinks retry synchronously [flink]

2024-10-29 Thread via GitHub
AHeise commented on PR #25547: URL: https://github.com/apache/flink/pull/25547#issuecomment-2444290856 Reverted the deprecation of numFailed and added a config option for the retries. PTAL @fapaul -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] [FLINK-36493][TABLE API] Remove all deprecated methods in MapView [flink]

2024-10-29 Thread via GitHub
tinaselenge commented on PR #25566: URL: https://github.com/apache/flink/pull/25566#issuecomment-2443607410 Failing tests don't seem to be related as they pass locally for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] [FLINK-33722] Fix events ordering in MATCH_RECOGNIZE in batch mode [flink]

2024-10-29 Thread via GitHub
dawidwys commented on code in PR #24699: URL: https://github.com/apache/flink/pull/24699#discussion_r1820328447 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/batch/sql/MatchRecognizeITCase.java: ## @@ -567,7 +912,7 @@ void testUserDefine

[PR] [FLINK-4602][State] Add constructors for o.a.f.contrib.streaming.state.EmbeddedRocksDBStateBackend to maintain interface compatibility. [flink]

2024-10-29 Thread via GitHub
AlexYinHan opened a new pull request, #25586: URL: https://github.com/apache/flink/pull/25586 ## What is the purpose of the change Add constructors for o.a.f.contrib.streaming.state.EmbeddedRocksDBStateBackend to maintain interface compatibility. ## Bri

[jira] [Updated] (FLINK-36620) Add support for the flink-home parameter to be set in both “--flink-home $FLINK_HOME” and “--flink-home=$FLINK_HOME” formats

2024-10-29 Thread zjjiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zjjiang updated FLINK-36620: Description: Currently, most of FlinkCDC's command line arguments are supported in the format "--$KEY $VA

[jira] [Comment Edited] (FLINK-36245) Remove legacy SourceFunction / SinkFunction / Sink V1 API and deprecated method/interface in Sink V2 in 2.0

2024-10-29 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893764#comment-17893764 ] Piotr Nowojski edited comment on FLINK-36245 at 10/29/24 10:39 AM: ---

Re: [PR] [FLINK-4602][State] Add constructors for o.a.f.contrib.streaming.state.EmbeddedRocksDBStateBackend to maintain interface compatibility. [flink]

2024-10-29 Thread via GitHub
flinkbot commented on PR #25586: URL: https://github.com/apache/flink/pull/25586#issuecomment-2443963990 ## CI report: * 8a64c442363ad7af042796ee90a80e82f8fb47f2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-4602][State] Add constructors for o.a.f.contrib.streaming.state.EmbeddedRocksDBStateBackend to maintain interface compatibility. [flink]

2024-10-29 Thread via GitHub
AlexYinHan commented on PR #25586: URL: https://github.com/apache/flink/pull/25586#issuecomment-2443980646 @Zakelly This resolves the incompatibility of the constructors of EmbeddedRocksDBStateBackend. Can you take a look? -- This is an automated message from the Apache Git Service. To re

[jira] [Commented] (FLINK-16851) Add common metrics to the SourceReader base implementation.

2024-10-29 Thread Poorvank Bhatia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893806#comment-17893806 ] Poorvank Bhatia commented on FLINK-16851: - Hey [~becket_qin] , Is this still bei

[jira] [Commented] (FLINK-36621) Build failure: StatefulSink not found

2024-10-29 Thread LvYanquan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893812#comment-17893812 ] LvYanquan commented on FLINK-36621: --- This issue should be related to a bug https://yo

[PR] [FLINK-36622] Remove the dependency of StateBenchmark on RocksDBKeyedStateBackend APIs. [flink]

2024-10-29 Thread via GitHub
AlexYinHan opened a new pull request, #25587: URL: https://github.com/apache/flink/pull/25587 ## What is the purpose of the change Currently, flink-benchmarks relies on non-public APIs in Flink. For example, in StateBackendBenchmarkUtils.java, the function compactState

Re: [PR] [FLINK-36616] fix npe in GcpPublisherConfig [flink-connector-gcp-pubsub]

2024-10-29 Thread via GitHub
snuyanzin commented on code in PR #33: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/33#discussion_r1820768938 ## flink-connector-gcp-pubsub/src/main/java/org/apache/flink/connector/gcp/pubsub/sink/config/GcpPublisherConfig.java: ## @@ -52,7 +52,11 @@ public Cr

[jira] [Updated] (FLINK-36621) Build failure: StatefulSink not found

2024-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36621: --- Labels: pull-request-available (was: ) > Build failure: StatefulSink not found > --

[jira] [Created] (FLINK-36621) Build failure: StatefulSink not found

2024-10-29 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-36621: -- Summary: Build failure: StatefulSink not found Key: FLINK-36621 URL: https://issues.apache.org/jira/browse/FLINK-36621 Project: Flink Issue Type: Improve

Re: [PR] [FLINK-4602] Change RocksDBKeyedStateBackend to new package. [flink-benchmarks]

2024-10-29 Thread via GitHub
AlexYinHan commented on PR #98: URL: https://github.com/apache/flink-benchmarks/pull/98#issuecomment-2444005263 @Zakelly This should resolve the compilation errors once [Flink PR-25586](https://github.com/apache/flink/pull/25586) is merged. PTAL. -- This is an automated message from the A

Re: [PR] [FLINK-36621][flink-examples] Add comment in KafkaEventsGeneratorJob [flink]

2024-10-29 Thread via GitHub
flinkbot commented on PR #25588: URL: https://github.com/apache/flink/pull/25588#issuecomment-2444190248 ## CI report: * de83f7c5c6d6e57252dbf23a0677957e9164d3ac UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-36622] Remove the dependency of StateBenchmark on RocksDBKeyedStateBackend APIs. [flink]

2024-10-29 Thread via GitHub
flinkbot commented on PR #25587: URL: https://github.com/apache/flink/pull/25587#issuecomment-2444189745 ## CI report: * fdcf5f44ec979958a0f65c27b2685f443e70152c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-36621][flink-examples] Add comment in KafkaEventsGeneratorJob [flink]

2024-10-29 Thread via GitHub
lvyanquan opened a new pull request, #25588: URL: https://github.com/apache/flink/pull/25588 ## What is the purpose of the change Add comment to help developer avoiding compiling error in flink-examples module. ## Brief change log comment ## Verifying this change

[jira] [Updated] (FLINK-36622) Remove the dependency of StateBenchmark on RocksDBKeyedStateBackend APIs.

2024-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36622: --- Labels: pull-request-available (was: ) > Remove the dependency of StateBenchmark on RocksDB

[jira] [Closed] (FLINK-32483) RescaleCheckpointManuallyITCase.testCheckpointRescalingOutKeyedState fails on AZP

2024-10-29 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-32483. -- Resolution: Fixed > RescaleCheckpointManuallyITCase.testCheckpointRescalingOutKeyedState fails

Re: [PR] [FLINK-36271] Support reading json and jsonb types in PostgreSQL dialect [flink-connector-jdbc]

2024-10-29 Thread via GitHub
grzegorz8 commented on PR #141: URL: https://github.com/apache/flink-connector-jdbc/pull/141#issuecomment-2444020989 > > @grzegorz8 Can You Give me, Some Example to Build This Code and Add Jar and use in pyflink code for Streaming Data to JSONB in PostgreSQL. > > I'm sorry but there

[jira] [Commented] (FLINK-21909) Unify API and implementation for Hive and Filesystem source connector

2024-10-29 Thread Poorvank Bhatia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893792#comment-17893792 ] Poorvank Bhatia commented on FLINK-21909: - Hey [~jark] , If this is still unassi

[jira] [Commented] (FLINK-25921) Support different input parallelism for preCommit topology

2024-10-29 Thread Poorvank Bhatia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893796#comment-17893796 ] Poorvank Bhatia commented on FLINK-25921: - Hey [~fpaul] , If this is still unass

[jira] [Commented] (FLINK-36613) RescaleCheckpointManuallyITCase.testCheckpointRescalingInKeyedState fails on AZP

2024-10-29 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893856#comment-17893856 ] Piotr Nowojski commented on FLINK-36613: {quote} It is very likely that the reas

[jira] [Resolved] (FLINK-36410) Improve Lineage Info Collection for flink app

2024-10-29 Thread Zhenqiu Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenqiu Huang resolved FLINK-36410. --- Resolution: Done > Improve Lineage Info Collection for flink app > -

[jira] [Commented] (FLINK-36410) Improve Lineage Info Collection for flink app

2024-10-29 Thread Zhenqiu Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893955#comment-17893955 ] Zhenqiu Huang commented on FLINK-36410: --- PR is created and merged https://github.c

[jira] [Created] (FLINK-36625) Add helper classes for Lineage integration in connectors

2024-10-29 Thread Zhenqiu Huang (Jira)
Zhenqiu Huang created FLINK-36625: - Summary: Add helper classes for Lineage integration in connectors Key: FLINK-36625 URL: https://issues.apache.org/jira/browse/FLINK-36625 Project: Flink Is

[jira] [Updated] (FLINK-36626) Flink SQL temporal JOINs behavior change from Flink 1.15 to Flink 1.18+

2024-10-29 Thread Eduardo Breijo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eduardo Breijo updated FLINK-36626: --- Summary: Flink SQL temporal JOINs behavior change from Flink 1.15 to Flink 1.18+ (was: Flin

Re: [PR] [FLINK-35444][pipeline-connector][paimon] Paimon Pipeline Connector support changing column names to lowercase for Hive metastore [flink-cdc]

2024-10-29 Thread via GitHub
github-actions[bot] commented on PR #3569: URL: https://github.com/apache/flink-cdc/pull/3569#issuecomment-2445540069 This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. --

Re: [PR] Refactored Identifiers [flink-cdc]

2024-10-29 Thread via GitHub
github-actions[bot] commented on PR #3501: URL: https://github.com/apache/flink-cdc/pull/3501#issuecomment-2445540164 This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encou

Re: [PR] [FLINK-35599][cdc-connector][jdbc-mysql]Flink cdc pipeline sink jdbc mysql [flink-cdc]

2024-10-29 Thread via GitHub
github-actions[bot] commented on PR #3433: URL: https://github.com/apache/flink-cdc/pull/3433#issuecomment-2445540230 This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. --

[jira] [Updated] (FLINK-36626) Flink SQL JOINs behavior change from Flink 1.15 to Flink 1.18+

2024-10-29 Thread Eduardo Breijo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eduardo Breijo updated FLINK-36626: --- Description: There is a behavior change I found when migrating to Flink 1.18+ from Flink 1.

[jira] [Updated] (FLINK-36626) Flink SQL JOINs behavior change from Flink 1.15 to Flink 1.18+

2024-10-29 Thread Eduardo Breijo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eduardo Breijo updated FLINK-36626: --- Description: There is a behavior change I found when migrating to Flink 1.18+ from Flink 1.

[jira] [Assigned] (FLINK-36547) Add option to retain `RowKind` sematics after serialization/deserialization for cdc formats

2024-10-29 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-36547: -- Assignee: Yubin Li > Add option to retain `RowKind` sematics after serialization/deserializat

[jira] [Updated] (FLINK-36626) Flink SQL JOINs behavior change from Flink 1.15 to Flink 1.18+

2024-10-29 Thread Eduardo Breijo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eduardo Breijo updated FLINK-36626: --- Description: There is a behavior change I found when migrating to Flink 1.18+ from Flink 1.

Re: [PR] [hotfix] Replace System.out.println with logger for better log management [flink-connector-gcp-pubsub]

2024-10-29 Thread via GitHub
caicancai commented on code in PR #31: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/31#discussion_r1821701027 ## flink-examples-streaming-gcp-pubsub/src/main/java/org/apache/flink/streaming/examples/gcp/pubsub/PubSubPublisher.java: ## @@ -21,11 +21,14 @@ impo

[jira] [Updated] (FLINK-36626) Flink SQL temporal lookup JOINs behavior change from Flink 1.15 to Flink 1.18+

2024-10-29 Thread Eduardo Breijo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eduardo Breijo updated FLINK-36626: --- Description: There is a behavior change I found when migrating to Flink 1.18+ from Flink 1.

[jira] [Updated] (FLINK-36626) Flink SQL temporal lookup JOINs behavior change from Flink 1.15 to Flink 1.18+

2024-10-29 Thread Eduardo Breijo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eduardo Breijo updated FLINK-36626: --- Description: There is a behavior change I found when migrating to Flink 1.18+ from Flink 1.

[jira] [Updated] (FLINK-36626) Flink SQL temporal lookup JOINs behavior change from Flink 1.15 to Flink 1.18+

2024-10-29 Thread Eduardo Breijo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eduardo Breijo updated FLINK-36626: --- Description: There is a behavior change I found when migrating to Flink 1.18+ from Flink 1.

[jira] [Updated] (FLINK-36626) Flink SQL temporal lookup JOINs behavior change from Flink 1.15 to Flink 1.18+

2024-10-29 Thread Eduardo Breijo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eduardo Breijo updated FLINK-36626: --- Description: There is a behavior change I found when migrating to Flink 1.18+ from Flink 1.

Re: [PR] [FLINK-36011] [runtime] Generalize RescaleManager to become StateTransitionManager [flink]

2024-10-29 Thread via GitHub
rkhachatryan commented on code in PR #25280: URL: https://github.com/apache/flink/pull/25280#discussion_r1821594247 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/DefaultStateTransitionManager.java: ## @@ -0,0 +1,434 @@ +/* + * Licensed to the Apache

[jira] [Updated] (FLINK-36626) Flink SQL temporal lookup JOINs behavior change from Flink 1.15 to Flink 1.18+

2024-10-29 Thread Eduardo Breijo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eduardo Breijo updated FLINK-36626: --- Description: There is a behavior change I found when migrating to Flink 1.18+ from Flink 1.

[jira] [Updated] (FLINK-36626) Flink SQL temporal lookup JOINs behavior change from Flink 1.15 to Flink 1.18+

2024-10-29 Thread Eduardo Breijo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eduardo Breijo updated FLINK-36626: --- Description: There is a behavior change I found when migrating to Flink 1.18+ from Flink 1.

[jira] [Created] (FLINK-36627) Failure to process a CSV file in Flink due to a character encoding mismatch: the file is in ISO-8859 and the application expects UTF-8.

2024-10-29 Thread Hector Miuler Malpica Gallegos (Jira)
Hector Miuler Malpica Gallegos created FLINK-36627: -- Summary: Failure to process a CSV file in Flink due to a character encoding mismatch: the file is in ISO-8859 and the application expects UTF-8. Key: FLINK-3662

[jira] [Updated] (FLINK-36627) Failure to process a CSV file in Flink due to a character encoding mismatch: the file is in ISO-8859 and the application expects UTF-8.

2024-10-29 Thread Hector Miuler Malpica Gallegos (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hector Miuler Malpica Gallegos updated FLINK-36627: --- Description: I have error in read csv with charset ISO-8859,

[jira] [Updated] (FLINK-36626) Flink SQL temporal lookup JOINs behavior change from Flink 1.15 to Flink 1.18+

2024-10-29 Thread Eduardo Breijo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eduardo Breijo updated FLINK-36626: --- Summary: Flink SQL temporal lookup JOINs behavior change from Flink 1.15 to Flink 1.18+ (wa

[jira] [Updated] (FLINK-36626) Flink SQL temporal lookup JOINs behavior change from Flink 1.15 to Flink 1.18+

2024-10-29 Thread Eduardo Breijo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eduardo Breijo updated FLINK-36626: --- Description: There is a behavior change I found when migrating to Flink 1.18+ from Flink 1.

[jira] [Created] (FLINK-36626) Flink SQL JOINs behavior change from Flink 1.15 to Flink 1.18+

2024-10-29 Thread Eduardo Breijo (Jira)
Eduardo Breijo created FLINK-36626: -- Summary: Flink SQL JOINs behavior change from Flink 1.15 to Flink 1.18+ Key: FLINK-36626 URL: https://issues.apache.org/jira/browse/FLINK-36626 Project: Flink

[PR] [FLINK-36161][docs]Update Integration Test Example with Sink API. [flink]

2024-10-29 Thread via GitHub
RanJinh opened a new pull request, #25590: URL: https://github.com/apache/flink/pull/25590 ## What is the purpose of the change To update the `Testing Flink Jobs` Docs example from deprecated `SinkFunction` to `Sink`. ## Brief change log - Using `Sink` instead of `

Re: [PR] [FLINK-4602][State] Add constructors for o.a.f.contrib.streaming.state.EmbeddedRocksDBStateBackend to maintain interface compatibility. [flink]

2024-10-29 Thread via GitHub
Zakelly merged PR #25586: URL: https://github.com/apache/flink/pull/25586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

[jira] [Comment Edited] (FLINK-4602) Move RocksDB backend to proper package

2024-10-29 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893675#comment-17893675 ] Zakelly Lan edited comment on FLINK-4602 at 10/30/24 2:32 AM: -

[jira] [Assigned] (FLINK-36621) Build failure: StatefulSink not found

2024-10-29 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-36621: -- Assignee: LvYanquan > Build failure: StatefulSink not found > ---

[jira] [Assigned] (FLINK-36624) Log JobID in SourceCoordinator

2024-10-29 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-36624: -- Assignee: Piotr Nowojski > Log JobID in SourceCoordinator > -

[jira] [Created] (FLINK-36624) Log JobID in SourceCoordinator

2024-10-29 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-36624: -- Summary: Log JobID in SourceCoordinator Key: FLINK-36624 URL: https://issues.apache.org/jira/browse/FLINK-36624 Project: Flink Issue Type: Improvement

Re: [PR] [FLINK-34466] Lineage interfaces for kafka connector [flink-connector-kafka]

2024-10-29 Thread via GitHub
HuangZhenQiu commented on code in PR #130: URL: https://github.com/apache/flink-connector-kafka/pull/130#discussion_r1821361818 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/lineage/LineageUtilTest.java: ## @@ -0,0 +1,56 @@ +package org.apache.flink.co

Re: [PR] [FLINK-36077][Connectors/Google PubSub] Implement table api support for SinkV2 [flink-connector-gcp-pubsub]

2024-10-29 Thread via GitHub
vahmed-hamdy commented on PR #30: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/30#issuecomment-2444821498 @snuyanzin thanks for the review, I refactored the factory tests and removed unnecessary public access modifiers, PTAL -- This is an automated message from the Apac

[jira] [Commented] (FLINK-16851) Add common metrics to the SourceReader base implementation.

2024-10-29 Thread Jiangjie Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893911#comment-17893911 ] Jiangjie Qin commented on FLINK-16851: -- I think most of the metrics have been added

[jira] [Updated] (FLINK-36620) Add support for the flink-home parameter to be set in both “--flink-home $FLINK_HOME” and “--flink-home=$FLINK_HOME” formats

2024-10-29 Thread zjjiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zjjiang updated FLINK-36620: Description: Currently, most of FlinkCDC's command line arguments are supported in the format `--$KEY $VA

[jira] [Assigned] (FLINK-27632) Improve connector testing framework to support more cases

2024-10-29 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-27632: - Assignee: Poorvank Bhatia > Improve connector testing framework to support more cases >

Re: [PR] [FLINK-36011][runtime] Improved logging in StateTransitionManager [flink]

2024-10-29 Thread via GitHub
flinkbot commented on PR #25589: URL: https://github.com/apache/flink/pull/25589#issuecomment-2444516868 ## CI report: * b3233bfef81e4faf868f0bf92bcf742594e7e5a8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-36011][runtime] Improved logging in StateTransitionManager [flink]

2024-10-29 Thread via GitHub
ztison opened a new pull request, #25589: URL: https://github.com/apache/flink/pull/25589 ## What is the purpose of the change This PR fixes the log-level regression introduced in https://github.com/apache/flink/pull/25280#discussion_r1818949028 ## Brief change log *

Re: [PR] [FLINK-33722] Fix events ordering in MATCH_RECOGNIZE in batch mode [flink]

2024-10-29 Thread via GitHub
dawidwys commented on code in PR #24699: URL: https://github.com/apache/flink/pull/24699#discussion_r1820335891 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecMatch.java: ## @@ -51,7 +71,95 @@ public BatchExecMatch(

[jira] [Commented] (FLINK-28177) Elasticsearch6DynamicSinkITCase.testWritingDocumentsNoPrimaryKey failed with 503 Service Unavailable

2024-10-29 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893907#comment-17893907 ] Ahmed Hamdy commented on FLINK-28177: - [~martijnvisser] I see the [PR|https://githu

[jira] [Created] (FLINK-36623) Improve logging in DefaultStateTransitionManager

2024-10-29 Thread Roman Khachatryan (Jira)
Roman Khachatryan created FLINK-36623: - Summary: Improve logging in DefaultStateTransitionManager Key: FLINK-36623 URL: https://issues.apache.org/jira/browse/FLINK-36623 Project: Flink Is

Re: [PR] [FLINK-36455] Sinks retry synchronously [flink]

2024-10-29 Thread via GitHub
AHeise commented on code in PR #25547: URL: https://github.com/apache/flink/pull/25547#discussion_r1820836505 ## flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitterOperator.java: ## @@ -164,41 +165,37 @@ public void notifyCheckpointComplete(lo

Re: [PR] [FLINK-36011] [runtime] Generalize RescaleManager to become StateTransitionManager [flink]

2024-10-29 Thread via GitHub
ztison commented on code in PR #25280: URL: https://github.com/apache/flink/pull/25280#discussion_r1820968233 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/DefaultStateTransitionManager.java: ## @@ -0,0 +1,434 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] [hotfix] Replace System.out.println with logger for better log management [flink-connector-gcp-pubsub]

2024-10-29 Thread via GitHub
snuyanzin commented on code in PR #31: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/31#discussion_r1821436745 ## flink-examples-streaming-gcp-pubsub/src/main/java/org/apache/flink/streaming/examples/gcp/pubsub/PubSubPublisher.java: ## @@ -21,11 +21,14 @@ impo

[jira] [Commented] (FLINK-32315) Support local file upload in K8s mode

2024-10-29 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893734#comment-17893734 ] Ferenc Csaky commented on FLINK-32315: -- When I developed this, the "s3" related con

[jira] [Comment Edited] (FLINK-32315) Support local file upload in K8s mode

2024-10-29 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893734#comment-17893734 ] Ferenc Csaky edited comment on FLINK-32315 at 10/29/24 8:31 AM: --

Re: [PR] [FLINK-36497][table]Remove all deprecated methods `CatalogTable` [flink]

2024-10-29 Thread via GitHub
flinkbot commented on PR #25585: URL: https://github.com/apache/flink/pull/25585#issuecomment-2443475748 ## CI report: * 33ea97c1bdd9ca2a9e0265600ae2ea36cad24476 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-36547) Add option to retain `RowKind` sematics after serialization/deserialization for cdc formats

2024-10-29 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yubin Li updated FLINK-36547: - Description: As official docs said, `RowKind` sematics have been changed: -U -> -D, +D -> +I {code:java}

[jira] [Updated] (FLINK-36547) Add option to retain `RowKind` sematics after serialization/deserialization for cdc formats

2024-10-29 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yubin Li updated FLINK-36547: - Description: As official docs said, `RowKind` sematics have been changed: -U -> -D, +D -> +I {code:java}

[jira] [Updated] (FLINK-36547) Add option to retain `RowKind` sematics after serialization/deserialization for cdc formats

2024-10-29 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yubin Li updated FLINK-36547: - Description: As official docs said, `RowKind` sematics have been changed: -U -> -D, +D -> +I {code:java}

Re: [PR] [FLINK-35268][state] Add ttl interface for Async State API && implement TtlListStateV2/TtlValueStateV2 [flink]

2024-10-29 Thread via GitHub
fredia commented on code in PR #25515: URL: https://github.com/apache/flink/pull/25515#discussion_r1820233250 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/v2/ttl/TtlListState.java: ## @@ -0,0 +1,207 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[jira] [Updated] (FLINK-36497) Remove all deprecated methods in `CatalogTable`

2024-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36497: --- Labels: pull-request-available (was: ) > Remove all deprecated methods in `CatalogTable` >

[PR] [FLINK-36497][table]Remove all deprecated methods `CatalogTable` [flink]

2024-10-29 Thread via GitHub
Edward-Gavin opened a new pull request, #25585: URL: https://github.com/apache/flink/pull/25585 ## What is the purpose of the change Remove all deprecated methods in `CatalogTable` ## Brief change log Remove all deprecated methods in `CatalogTable` ## Verif

[jira] [Created] (FLINK-36620) Add support for the flink-home parameter to be set in both “--flink-home $FLINK_HOME” and “--flink-home=$FLINK_HOME” formats

2024-10-29 Thread zjjiang (Jira)
zjjiang created FLINK-36620: --- Summary: Add support for the flink-home parameter to be set in both “--flink-home $FLINK_HOME” and “--flink-home=$FLINK_HOME” formats Key: FLINK-36620 URL: https://issues.apache.org/jira/br

[jira] [Updated] (FLINK-36620) Add support for the flink-home parameter to be set in both “--flink-home $FLINK_HOME” and “--flink-home=$FLINK_HOME” formats

2024-10-29 Thread zjjiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zjjiang updated FLINK-36620: Description: Currently, most of FlinkCDC's command line arguments are supported in the format "--$KEY $VA

[jira] [Updated] (FLINK-36620) Add support for the flink-home parameter to be set in both “--flink-home $FLINK_HOME” and “--flink-home=$FLINK_HOME” formats

2024-10-29 Thread zjjiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zjjiang updated FLINK-36620: Description: Currently, most of FlinkCDC's command line arguments are supported in the format "--$KEY $VA

[jira] [Updated] (FLINK-36620) Add support for the flink-home parameter to be set in both “--flink-home $FLINK_HOME” and “--flink-home=$FLINK_HOME” formats

2024-10-29 Thread zjjiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zjjiang updated FLINK-36620: Description: Currently, most of FlinkCDC's command line arguments are supported in the format "-$KEY $VAL

[jira] [Updated] (FLINK-36620) Add support for the flink-home parameter to be set in both “--flink-home $FLINK_HOME” and “--flink-home=$FLINK_HOME” formats

2024-10-29 Thread zjjiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zjjiang updated FLINK-36620: Description: Currently, most of FlinkCDC's command line arguments are supported in the format "--$KEY $VA

Re: [PR] [FLINK-34466] Lineage interfaces for kafka connector [flink-connector-kafka]

2024-10-29 Thread via GitHub
pawel-big-lebowski commented on code in PR #130: URL: https://github.com/apache/flink-connector-kafka/pull/130#discussion_r1820485021 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchemaBuilder.java: ## @@ -369,5 +416,43 @@

[jira] [Commented] (FLINK-36245) Remove legacy SourceFunction / SinkFunction / Sink V1 API and deprecated method/interface in Sink V2 in 2.0

2024-10-29 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893764#comment-17893764 ] Piotr Nowojski commented on FLINK-36245: Hi [~kunni], [~renqs] and [~leonard]. I

[jira] [Updated] (FLINK-36620) Add support for the flink-home parameter to be set in both “--flink-home $FLINK_HOME” and “--flink-home=$FLINK_HOME” formats

2024-10-29 Thread zjjiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zjjiang updated FLINK-36620: Description: Currently, most of FlinkCDC's command line arguments are supported in the format `--$KEY $VA

Re: [PR] [FLINK-34466] Lineage interfaces for kafka connector [flink-connector-kafka]

2024-10-29 Thread via GitHub
AHeise commented on code in PR #130: URL: https://github.com/apache/flink-connector-kafka/pull/130#discussion_r1820444037 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/lineage/KafkaDatasetIdentifierProvider.java: ## @@ -0,0 +1,16 @@ +package org.apache

Re: [PR] [FLINK-34466] Lineage interfaces for kafka connector [flink-connector-kafka]

2024-10-29 Thread via GitHub
AHeise commented on code in PR #130: URL: https://github.com/apache/flink-connector-kafka/pull/130#discussion_r1820446158 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/lineage/LineageUtil.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] [FLINK-34466] Lineage interfaces for kafka connector [flink-connector-kafka]

2024-10-29 Thread via GitHub
AHeise commented on code in PR #130: URL: https://github.com/apache/flink-connector-kafka/pull/130#discussion_r1815659513 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchemaBuilder.java: ## @@ -369,5 +416,43 @@ public Prod

Re: [PR] [FLINK-36616] fix npe in GcpPublisherConfig [flink-connector-gcp-pubsub]

2024-10-29 Thread via GitHub
stankiewicz commented on PR #33: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/33#issuecomment-2443713018 fixed style errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-34466] Lineage interfaces for kafka connector [flink-connector-kafka]

2024-10-29 Thread via GitHub
AHeise commented on code in PR #130: URL: https://github.com/apache/flink-connector-kafka/pull/130#discussion_r1820453815 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchemaBuilder.java: ## @@ -369,5 +416,43 @@ public Prod

[jira] [Updated] (FLINK-36620) Add support for the flink-home parameter to be set in both “--flink-home $FLINK_HOME” and “--flink-home=$FLINK_HOME” formats

2024-10-29 Thread zjjiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zjjiang updated FLINK-36620: Description: Currently, most of FlinkCDC's command line arguments are supported in the format "--$KEY $VA

[jira] [Updated] (FLINK-36620) Add support for the flink-home parameter to be set in both “--flink-home $FLINK_HOME” and “--flink-home=$FLINK_HOME” formats

2024-10-29 Thread zjjiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zjjiang updated FLINK-36620: Description: Currently, most of FlinkCDC's command line arguments are supported in the format `\-\-$KEY $

[jira] [Updated] (FLINK-36547) Add option to retain `RowKind` sematics for cdc formats

2024-10-29 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yubin Li updated FLINK-36547: - Summary: Add option to retain `RowKind` sematics for cdc formats (was: Add option to retain `RowKind` s

[jira] [Updated] (FLINK-36547) Add option to retain `RowKind` sematics for cdc formats

2024-10-29 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yubin Li updated FLINK-36547: - Description: As official docs said, `RowKind` sematics have been changed: -U -> -D, +D -> +I {code:java}

[jira] [Updated] (FLINK-36547) Add option to retain `RowKind` sematics for cdc formats

2024-10-29 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yubin Li updated FLINK-36547: - Description: As official docs said, `RowKind` semantics have been changed: -U -> -D, +D -> +I {code:java

Re: [PR] [FLINK-36607][table-planner] Introduce AdaptiveBroadcastJoinProcessor to inject adaptive broadcast join. [flink]

2024-10-29 Thread via GitHub
JunRuiLee commented on code in PR #25578: URL: https://github.com/apache/flink/pull/25578#discussion_r1820633873 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/JoinUtil.scala: ## @@ -275,4 +281,32 @@ object JoinUtil { rowCount

  1   2   >