Re: [PR] [FLINK-36194][Runtime] Handle the Graceful close of ExecutionGraphInfoStore from ClusterEntrypoint [flink]

2024-10-21 Thread via GitHub
flinkbot commented on PR #25553: URL: https://github.com/apache/flink/pull/25553#issuecomment-2426917163 ## CI report: * af6861f7c46e6033e5b9afea5f5fce703be10c4c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-36194][Runtime] Handle the Graceful close of ExecutionGraphInfoStore from ClusterEntrypoint [flink]

2024-10-21 Thread via GitHub
eaugene opened a new pull request, #25553: URL: https://github.com/apache/flink/pull/25553 ## What is the purpose of the change This fixes the race-condition of writing to a closed file in the cluster shutdown is triggered ## Brief change log - removing the shut

[jira] [Updated] (FLINK-36194) Shutdown hook for ExecutionGraphInfo store runs concurrently to cluster shutdown hook causing race conditions

2024-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36194: --- Labels: pull-request-available starter (was: starter) > Shutdown hook for ExecutionGraphInf

Re: [PR] [FLINK-35136] Bump connector version to 4.0, adapt CI workflows [flink-connector-hbase]

2024-10-21 Thread via GitHub
JuliaBogdan commented on PR #46: URL: https://github.com/apache/flink-connector-hbase/pull/46#issuecomment-2427101306 > > Hi, @ferenc-csaky. I'm interested in the connector for Flink > 1.18 and glad to see this PR, thank you for the work! I wonder if there is there anything that is blockin

Re: [PR] [FLINK-36065][runtime] Support submit stream graph. [flink]

2024-10-21 Thread via GitHub
zhuzhurk commented on code in PR #25472: URL: https://github.com/apache/flink/pull/25472#discussion_r1808402242 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultSchedulerFactory.java: ## @@ -80,6 +83,14 @@ public SchedulerNG createInstance( f

Re: [PR] [FLINK-36510][rpc] bump pekko to 1.1.2, remove netty 3 (backport to release-1.20) [flink]

2024-10-21 Thread via GitHub
ferenc-csaky commented on code in PR #25550: URL: https://github.com/apache/flink/pull/25550#discussion_r1808220796 ## flink-rpc/flink-rpc-akka/src/main/resources/META-INF/NOTICE: ## @@ -6,17 +6,17 @@ The Apache Software Foundation (http://www.apache.org/). This project bundl

Re: [PR] [FLINK-36510][rpc] bump pekko to 1.1.2, remove netty 3 (backport to release-1.20) [flink]

2024-10-21 Thread via GitHub
ferenc-csaky commented on PR #25550: URL: https://github.com/apache/flink/pull/25550#issuecomment-2425809842 1.20 backport of https://github.com/apache/flink/pull/25494, will merge them together. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] [hotfix][tests] Separate Pipeline and Source E2e tests [flink-cdc]

2024-10-21 Thread via GitHub
yuxiqian closed pull request #3427: [hotfix][tests] Separate Pipeline and Source E2e tests URL: https://github.com/apache/flink-cdc/pull/3427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [hotfix][tests] Separate Pipeline and Source E2e tests [flink-cdc]

2024-10-21 Thread via GitHub
yuxiqian commented on PR #3427: URL: https://github.com/apache/flink-cdc/pull/3427#issuecomment-2425814837 Fixed in #3514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-36510][rpc] bump pekko to 1.1.2, remove netty 3 (backport to release-1.20) [flink]

2024-10-21 Thread via GitHub
gracegrimwood commented on code in PR #25550: URL: https://github.com/apache/flink/pull/25550#discussion_r1808227768 ## flink-rpc/flink-rpc-akka/src/main/resources/META-INF/NOTICE: ## @@ -6,17 +6,17 @@ The Apache Software Foundation (http://www.apache.org/). This project bund

Re: [PR] [FLINK-36576][runtime] Improving amount-based data balancing distribution algorithm for DefaultVertexParallelismAndInputInfosDecider [flink]

2024-10-21 Thread via GitHub
flinkbot commented on PR #25552: URL: https://github.com/apache/flink/pull/25552#issuecomment-2425962755 ## CI report: * 5765848fe5d10d5ea875a723f1683645c9efd9bd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-36575][runtime] ExecutionVertexInputInfo supports consuming subpartition groups [flink]

2024-10-21 Thread via GitHub
noorall opened a new pull request, #25551: URL: https://github.com/apache/flink/pull/25551 ## What is the purpose of the change Currently, the ExecutionVertexInputInfo describes the task's input through a combination of a PartitionRange and a SubpartitionRange. However, in the case o

[jira] [Updated] (FLINK-36575) ExecutionVertexInputInfo supports consuming subpartition groups

2024-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36575: --- Labels: pull-request-available (was: ) > ExecutionVertexInputInfo supports consuming subpar

Re: [PR] [FLINK-36575][runtime] ExecutionVertexInputInfo supports consuming subpartition groups [flink]

2024-10-21 Thread via GitHub
flinkbot commented on PR #25551: URL: https://github.com/apache/flink/pull/25551#issuecomment-2425912906 ## CI report: * b99b368660d7e45b2e5e8265e05c778bf4b7c372 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-36052][docs][elasticsearch] Add flink cdc elasticsearch pipeline sink to docs [flink-cdc]

2024-10-21 Thread via GitHub
beryllw commented on PR #3649: URL: https://github.com/apache/flink-cdc/pull/3649#issuecomment-2425946273 @leonardBang Vitess dead link causes CI to fail. Please help to re-trigger CI.Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[PR] [FLINK-36576][runtime] Improving amount-based data balancing distribution algorithm for DefaultVertexParallelismAndInputInfosDecider [flink]

2024-10-21 Thread via GitHub
noorall opened a new pull request, #25552: URL: https://github.com/apache/flink/pull/25552 ## What is the purpose of the change Currently, the DefaultVertexParallelismAndInputInfosDecider is able to implement a balanced distribution algorithm based on the amount of data and the numbe

[jira] [Updated] (FLINK-36576) Improving amount-based data balancing distribution algorithm for DefaultVertexParallelismAndInputInfosDecider

2024-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36576: --- Labels: pull-request-available (was: ) > Improving amount-based data balancing distribution

Re: [PR] [FLINK-36146][connector] Fix SingleThreadFetcherManager race condition [flink]

2024-10-21 Thread via GitHub
kimgr commented on PR #25340: URL: https://github.com/apache/flink/pull/25340#issuecomment-2427619439 @becketqin That test fails consistently (before and after fix) with `java.lang.IllegalStateException: The split fetcher manager has closed.` due to state validation in `SplitFetcherManager.

[PR] [FLINK-36332] Missed webhook okhttp reference. [flink-kubernetes-operator]

2024-10-21 Thread via GitHub
SamBarker opened a new pull request, #906: URL: https://github.com/apache/flink-kubernetes-operator/pull/906 ## What is the purpose of the change *(For example: This pull request adds a new feature to periodically create and maintain savepoints through the `FlinkDeployment` cu

Re: [PR] [FLINK-36573][cdc-connector][mysql] Add table information of binlog offsets when checkpointing [flink-cdc]

2024-10-21 Thread via GitHub
lvyanquan commented on code in PR #3656: URL: https://github.com/apache/flink-cdc/pull/3656#discussion_r1808363691 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/split/MySqlBinlogSplit.java: #

Re: [PR] [FLINK-36568][rest] Fix incorrect http url for ClientCoordinationHeaders. [flink]

2024-10-21 Thread via GitHub
zhuzhurk merged PR #25542: URL: https://github.com/apache/flink/pull/25542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Closed] (FLINK-36568) IllegalStateException Causes Collect Sink to Fail to Collect Result

2024-10-21 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-36568. --- Fix Version/s: 2.0.0 Resolution: Fixed 2c830898640fe65016763c747c05110bd79b8894 > IllegalStateExcept

[PR] [tests] Add migration tests from CDC 3.2.0 [flink-cdc]

2024-10-21 Thread via GitHub
yuxiqian opened a new pull request, #3657: URL: https://github.com/apache/flink-cdc/pull/3657 Flink CDC has been released and we're preparing for the following 3.3 release. Adding it to migration testing matrix should help us ensuring state backwards compatibility. -- This is an automate

[jira] [Updated] (FLINK-34636) Requesting exclusive buffers timeout causes repeated restarts and cannot be automatically recovered

2024-10-21 Thread Vincent Woo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Woo updated FLINK-34636: Affects Version/s: 1.13.2 > Requesting exclusive buffers timeout causes repeated restarts and cann

Re: [PR] [FLINK-36542] Enable upToDateChecking to speed up the spotless [flink]

2024-10-21 Thread via GitHub
ruanwenjun commented on PR #25525: URL: https://github.com/apache/flink/pull/25525#issuecomment-2426100238 @ferenc-csaky Thanks for your review, as far as I know, the index file will be generated under root/target, this will not be put into binary package, so will not break the RAT license

Re: [PR] [FLINK-36517][cdc-connect][paimon] use filterAndCommit API for Avoid commit the same datafile duplicate [flink-cdc]

2024-10-21 Thread via GitHub
lvyanquan commented on code in PR #3639: URL: https://github.com/apache/flink-cdc/pull/3639#discussion_r1808408534 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-paimon/src/test/java/org/apache/flink/cdc/connectors/paimon/sink/v2/PaimonSinkITCase.java: #

[jira] [Assigned] (FLINK-35387) PG CDC source support heart beat

2024-10-21 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-35387: -- Assignee: Hongshun Wang > PG CDC source support heart beat >

Re: [PR] [FLINK-36285] Pass default value expression in AlterColumnTypeEvent [flink-cdc]

2024-10-21 Thread via GitHub
yuxiqian closed pull request #3614: [FLINK-36285] Pass default value expression in AlterColumnTypeEvent URL: https://github.com/apache/flink-cdc/pull/3614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [FLINK-36285] Pass default value expression in AlterColumnTypeEvent [flink-cdc]

2024-10-21 Thread via GitHub
yuxiqian commented on PR #3614: URL: https://github.com/apache/flink-cdc/pull/3614#issuecomment-2425837181 Fixed in https://github.com/apache/doris-flink-connector/pull/490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] [W.I.P] Run tests [flink]

2024-10-21 Thread via GitHub
JunRuiLee closed pull request #25431: [W.I.P] Run tests URL: https://github.com/apache/flink/pull/25431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (FLINK-36575) ExecutionVertexInputInfo supports consuming subpartition groups

2024-10-21 Thread Lei Yang (Jira)
Lei Yang created FLINK-36575: Summary: ExecutionVertexInputInfo supports consuming subpartition groups Key: FLINK-36575 URL: https://issues.apache.org/jira/browse/FLINK-36575 Project: Flink Issu

[jira] [Created] (FLINK-36576) Improving amount-based data balancing distribution algorithm for DefaultVertexParallelismAndInputInfosDecider

2024-10-21 Thread Lei Yang (Jira)
Lei Yang created FLINK-36576: Summary: Improving amount-based data balancing distribution algorithm for DefaultVertexParallelismAndInputInfosDecider Key: FLINK-36576 URL: https://issues.apache.org/jira/browse/FLINK-36

[jira] [Updated] (FLINK-36576) Improving amount-based data balancing distribution algorithm for DefaultVertexParallelismAndInputInfosDecider

2024-10-21 Thread Lei Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lei Yang updated FLINK-36576: - Description: Currently, the DefaultVertexParallelismAndInputInfosDecider is able to implement a balance

Re: [PR] [FLINK-36542] Enable upToDateChecking to speed up the spotless [flink]

2024-10-21 Thread via GitHub
ferenc-csaky commented on PR #25525: URL: https://github.com/apache/flink/pull/25525#issuecomment-2425881444 I think this would be pretty useful, just wondering about if we enable it by default could it break something in any CI? My understanding is that by default the index file is placed

[jira] [Commented] (FLINK-34636) Requesting exclusive buffers timeout causes repeated restarts and cannot be automatically recovered

2024-10-21 Thread Vincent Woo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891463#comment-17891463 ] Vincent Woo commented on FLINK-34636: - This issue is occurring in version 1.13.2, an

[jira] [Assigned] (FLINK-36568) IllegalStateException Causes Collect Sink to Fail to Collect Result

2024-10-21 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-36568: --- Assignee: Junrui Li > IllegalStateException Causes Collect Sink to Fail to Collect Result > ---

[jira] [Comment Edited] (FLINK-34636) Requesting exclusive buffers timeout causes repeated restarts and cannot be automatically recovered

2024-10-21 Thread Vincent Woo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891463#comment-17891463 ] Vincent Woo edited comment on FLINK-34636 at 10/21/24 9:32 AM: ---

[jira] [Comment Edited] (FLINK-34636) Requesting exclusive buffers timeout causes repeated restarts and cannot be automatically recovered

2024-10-21 Thread Vincent Woo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891463#comment-17891463 ] Vincent Woo edited comment on FLINK-34636 at 10/21/24 9:32 AM: ---

[jira] [Created] (FLINK-36577) Add compatibility check for FlinkStateSnapshot CRD

2024-10-21 Thread Mate Czagany (Jira)
Mate Czagany created FLINK-36577: Summary: Add compatibility check for FlinkStateSnapshot CRD Key: FLINK-36577 URL: https://issues.apache.org/jira/browse/FLINK-36577 Project: Flink Issue Type

[jira] [Updated] (FLINK-36577) Add compatibility check for FlinkStateSnapshot CRD

2024-10-21 Thread Mate Czagany (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mate Czagany updated FLINK-36577: - Description: There are already two CRD compatibility checks in the flink-kubernetes-operator-ap

Re: [PR] [FLINK-35977][doc] Missing an import in datastream.md [flink]

2024-10-21 Thread via GitHub
guluo2016 commented on PR #25153: URL: https://github.com/apache/flink/pull/25153#issuecomment-2426468450 > Thanks for the contribution > > can you please also update `process_function.md` and `sourceSincks.md`, probably `data_stream_api.md` as well since they have the same issue. May

Re: [PR] Flink Kubernetes Operator 1.10.0 [flink-web]

2024-10-21 Thread via GitHub
mateczagany commented on code in PR #758: URL: https://github.com/apache/flink-web/pull/758#discussion_r1808609610 ## docs/content/posts/2024-10-30-release-kubernetes-operator-1.10.0.md: ## @@ -0,0 +1,75 @@ +--- +title: "Apache Flink Kubernetes Operator 1.10.0 Release Announcem

Re: [PR] [FLINK-35136] Bump connector version to 4.0, adapt CI workflows [flink-connector-hbase]

2024-10-21 Thread via GitHub
ferenc-csaky commented on PR #46: URL: https://github.com/apache/flink-connector-hbase/pull/46#issuecomment-2426418591 > Hi, @ferenc-csaky. I'm interested in the connector for Flink > 1.18 and glad to see this PR, thank you for the work! I wonder if there is there anything that is blocking

[jira] [Commented] (FLINK-36502) Remove all deprecated methods in `FactoryUtil`

2024-10-21 Thread Shengbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891523#comment-17891523 ] Shengbo commented on FLINK-36502: - Hi [~xuyangzhong], I'd like to work on this subtask a

Re: [PR] [runtime-web] chore: update Angular to v15 [flink]

2024-10-21 Thread via GitHub
michalmw commented on PR #25450: URL: https://github.com/apache/flink/pull/25450#issuecomment-2426504565 @simplejason or @yangjunhan can you check this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-34467] bump flink version to 1.20.0 [flink-connector-jdbc]

2024-10-21 Thread via GitHub
boring-cyborg[bot] commented on PR #137: URL: https://github.com/apache/flink-connector-jdbc/pull/137#issuecomment-2426275936 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Updated] (FLINK-34467) Implement Lineage Interface in Jdbc Connector

2024-10-21 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-34467: --- Fix Version/s: cdc-3.3.0 > Implement Lineage Interface in Jdbc Connector > -

Re: [PR] [FLINK-34467] bump flink version to 1.20.0 [flink-connector-jdbc]

2024-10-21 Thread via GitHub
leonardBang merged PR #137: URL: https://github.com/apache/flink-connector-jdbc/pull/137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Commented] (FLINK-34467) Implement Lineage Interface in Jdbc Connector

2024-10-21 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891492#comment-17891492 ] Leonard Xu commented on FLINK-34467: [~arvid] [~ZhenqiuHuang] Could you check your l

[jira] [Commented] (FLINK-36476) Remove all deprecated methods under public APIs in table modules and adapt the related tests to make them pass

2024-10-21 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891481#comment-17891481 ] xuyang commented on FLINK-36476: [~davidradl] Good idea. The vast majority of the deleti

Re: [PR] [FLINK-33926][kubernetes]: Allow using job jars in the system classpath in native mode [flink]

2024-10-21 Thread via GitHub
tinaselenge commented on code in PR #25445: URL: https://github.com/apache/flink/pull/25445#discussion_r1808630829 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterDescriptor.java: ## @@ -214,9 +215,12 @@ public ClusterClientProvider deployApplicat

[jira] [Comment Edited] (FLINK-34467) Implement Lineage Interface in Jdbc Connector

2024-10-21 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891488#comment-17891488 ] Leonard Xu edited comment on FLINK-34467 at 10/21/24 10:35 AM: ---

[jira] [Commented] (FLINK-34467) Implement Lineage Interface in Jdbc Connector

2024-10-21 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891488#comment-17891488 ] Leonard Xu commented on FLINK-34467: merged into jdbc connector repo vias main: 72f

Re: [PR] [FLINK-35136] Bump connector version to 4.0, adapt CI workflows [flink-connector-hbase]

2024-10-21 Thread via GitHub
JuliaBogdan commented on PR #46: URL: https://github.com/apache/flink-connector-hbase/pull/46#issuecomment-2426326123 Hi, @ferenc-csaky. I'm interested in the connector for Flink > 1.18 and glad to see this PR, thank you for the work! I wonder if there is there anything that is blocking

Re: [PR] [FLINK-35016] catalog changes for model resource [flink]

2024-10-21 Thread via GitHub
twalthr merged PR #25211: URL: https://github.com/apache/flink/pull/25211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

[jira] [Closed] (FLINK-35016) Catalog changes for model CRUD

2024-10-21 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-35016. Fix Version/s: 2.0.0 Assignee: Hao Li Resolution: Fixed Fixed in master: 2d17f6148

Re: [PR] [FLINK-36542] Enable upToDateChecking to speed up the spotless [flink]

2024-10-21 Thread via GitHub
ferenc-csaky commented on PR #25525: URL: https://github.com/apache/flink/pull/25525#issuecomment-2426536625 > @ferenc-csaky Thanks for your review, as far as I know, the index file will be generated under root/target, this will not be put into binary package, so will not break the RAT lice

[jira] [Updated] (FLINK-34467) Implement Lineage Interface in Jdbc Connector

2024-10-21 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-34467: --- Affects Version/s: jdbc-3.2.0 (was: 1.19.0) > Implement Lineage Interface

[PR] [hotfix][docs] Add FlinkStateSnapshot to upgrade docs [flink-kubernetes-operator]

2024-10-21 Thread via GitHub
mateczagany opened a new pull request, #905: URL: https://github.com/apache/flink-kubernetes-operator/pull/905 With the usual `helm upgrade`, the new FlinkStateSnapshot CRD won't be installed, and it will need to be installed with `kubectl create`. -- This is an automated message from the

[jira] [Commented] (FLINK-36557) Stale Autoscaler Context in Kubernetes Operator

2024-10-21 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891612#comment-17891612 ] Sai Sharath Dandi commented on FLINK-36557: --- Hi [~gyfora] , Could you please h

Re: [PR] [FLINK-36542] Enable upToDateChecking to speed up the spotless [flink]

2024-10-21 Thread via GitHub
ferenc-csaky commented on PR #25525: URL: https://github.com/apache/flink/pull/25525#issuecomment-2427353187 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[jira] [Updated] (FLINK-36557) Stale Autoscaler Context in Kubernetes Operator

2024-10-21 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sai Sharath Dandi updated FLINK-36557: -- Description: The KubernetesJobAutoScalerContext is [cached|https://github.com/apache/

[jira] [Assigned] (FLINK-36542) Enable upToDateChecking to speed up the spotless

2024-10-21 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Csaky reassigned FLINK-36542: Assignee: Wenjun Ruan > Enable upToDateChecking to speed up the spotless > --

[jira] [Updated] (FLINK-36542) Enable upToDateChecking to speed up the spotless

2024-10-21 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Csaky updated FLINK-36542: - Fix Version/s: 2.0.0 > Enable upToDateChecking to speed up the spotless > --

Re: [PR] [FLINK-36146][connector] Fix SingleThreadFetcherManager race condition [flink]

2024-10-21 Thread via GitHub
becketqin commented on PR #25340: URL: https://github.com/apache/flink/pull/25340#issuecomment-2427417285 @kimgr Sorry for the late reply. And thanks for the patch. The patch itself looks good to me. Usually, a test needs to be added to verify the bug is actually fixed. For race cond

Re: [PR] Use chronological order timestamp for timers [flink-benchmarks]

2024-10-21 Thread via GitHub
pnowojski commented on PR #94: URL: https://github.com/apache/flink-benchmarks/pull/94#issuecomment-2427270392 I think the problem got resolved by https://github.com/apache/flink-benchmarks/pull/97 -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] Use chronological order timestamp for timers [flink-benchmarks]

2024-10-21 Thread via GitHub
pnowojski merged PR #94: URL: https://github.com/apache/flink-benchmarks/pull/94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flin

Re: [PR] [FLINK-36146][connector] Fix SingleThreadFetcherManager race condition [flink]

2024-10-21 Thread via GitHub
kimgr commented on PR #25340: URL: https://github.com/apache/flink/pull/25340#issuecomment-2427449905 Thanks, I'll try to hack up a testcase! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] [FLINK-36573][cdc-connector][mysql] Add table information of binlog offsets when checkpointing [flink-cdc]

2024-10-21 Thread via GitHub
herunkang2018 commented on code in PR #3656: URL: https://github.com/apache/flink-cdc/pull/3656#discussion_r1809715176 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/split/MySqlBinlogSplit.java: #

Re: [PR] [FLINK-35029][state/forst] Store timer in JVM heap when use async state backend [flink]

2024-10-21 Thread via GitHub
yunfengzhou-hub commented on code in PR #25501: URL: https://github.com/apache/flink/pull/25501#discussion_r1809757295 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/operators/StreamOperatorStateContext.java: ## @@ -67,6 +67,12 @@ default boolean isRestored() {

[jira] [Created] (FLINK-36578) Fixed bug when converting json to string

2024-10-21 Thread Lee SeungMin (Jira)
Lee SeungMin created FLINK-36578: Summary: Fixed bug when converting json to string Key: FLINK-36578 URL: https://issues.apache.org/jira/browse/FLINK-36578 Project: Flink Issue Type: Bug

Re: [PR] [FLINK-36052] Add elasticsearch.md for elasticsearch pipeline connector [flink-cdc]

2024-10-21 Thread via GitHub
github-actions[bot] commented on PR #3539: URL: https://github.com/apache/flink-cdc/pull/3539#issuecomment-2427952115 This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. --

Re: [PR] Optimize log level [flink-cdc]

2024-10-21 Thread via GitHub
github-actions[bot] commented on PR #3538: URL: https://github.com/apache/flink-cdc/pull/3538#issuecomment-2427952144 This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. --

Re: [PR] [FLINK-36573][cdc-connector][mysql] Add table information of binlog offsets when checkpointing [flink-cdc]

2024-10-21 Thread via GitHub
herunkang2018 commented on code in PR #3656: URL: https://github.com/apache/flink-cdc/pull/3656#discussion_r1809718242 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/reader/MySqlSourceReader.java: ###

[jira] [Updated] (FLINK-36578) Fixed bug when converting json to string

2024-10-21 Thread Lee SeungMin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lee SeungMin updated FLINK-36578: - Description: The function to convert json to string is different in the snapshot step and the b

[jira] [Updated] (FLINK-36578) Fixed bug when converting json to string

2024-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36578: --- Labels: pull-request-available (was: ) > Fixed bug when converting json to string > ---

[PR] [FLINK-36578][mysql] Add table information of binlog offsets when checkpointing added modified JsonStringFormatter [flink-cdc]

2024-10-21 Thread via GitHub
SML0127 opened a new pull request, #3658: URL: https://github.com/apache/flink-cdc/pull/3658 The function to convert json to string is different in the snapshot step and the binlog step. This causes the following differences. ```d original data : {"key": "value", "key1": "value1"}

[jira] [Commented] (FLINK-36578) Fixed bug when converting json to string

2024-10-21 Thread Lee SeungMin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891704#comment-17891704 ] Lee SeungMin commented on FLINK-36578: -- assign this pr to me PTAL [~Leonard], [~re

[jira] [Updated] (FLINK-36578) Fixed bug when converting json to string

2024-10-21 Thread Lee SeungMin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lee SeungMin updated FLINK-36578: - Description: The function to convert json to string is different in the snapshot step and the b

[jira] [Updated] (FLINK-36578) Fixed bug when converting json to string

2024-10-21 Thread Lee SeungMin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lee SeungMin updated FLINK-36578: - Description: The function to convert json to string is different in the snapshot step and the b

[jira] [Commented] (FLINK-36578) Fixed bug when converting json to string

2024-10-21 Thread Lee SeungMin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891706#comment-17891706 ] Lee SeungMin commented on FLINK-36578: -- PR: https://github.com/apache/flink-cdc/pul

Re: [PR] [FLINK-36578][mysql] Add table information of binlog offsets when checkpointing added modified JsonStringFormatter [flink-cdc]

2024-10-21 Thread via GitHub
SML0127 commented on PR #3658: URL: https://github.com/apache/flink-cdc/pull/3658#issuecomment-2428093914 @leonardBang @PatrickRen PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [FLINK-35029][state/forst] Store timer in JVM heap when use async state backend [flink]

2024-10-21 Thread via GitHub
fredia commented on code in PR #25501: URL: https://github.com/apache/flink/pull/25501#discussion_r1809809121 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/operators/StreamOperatorStateContext.java: ## @@ -67,6 +67,12 @@ default boolean isRestored() { */

[jira] [Updated] (FLINK-36578) Fixed bug when converting json to string

2024-10-21 Thread Lee SeungMin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lee SeungMin updated FLINK-36578: - Description: The function to convert json to string is different in the snapshot step and the b

[jira] [Commented] (FLINK-36506) Remove all deprecated methods in `ColumnStats`

2024-10-21 Thread Atul Sharma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891724#comment-17891724 ] Atul Sharma commented on FLINK-36506: - Hi [~xuyangzhong] can i work on this? > Remo

[jira] [Commented] (FLINK-36503) Remove deprecated method `FunctionDefinitionFactory#createFunctionDefinition`

2024-10-21 Thread Atul Sharma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891725#comment-17891725 ] Atul Sharma commented on FLINK-36503: - Hi [~xuyangzhong] can i work on this? > Remo

[PR] [FLINK-36521][runtime] Introduce TtlAwareSerializer and TtlAwareSerializerSnapshot [flink]

2024-10-21 Thread via GitHub
xiangyuf opened a new pull request, #25554: URL: https://github.com/apache/flink/pull/25554 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them o

[PR] FLINK-36506: Remove all deprecated methods in `ColumnStats` [flink]

2024-10-21 Thread via GitHub
atu-sharm opened a new pull request, #2: URL: https://github.com/apache/flink/pull/2 ## What is the purpose of the change Removing all deprecated methods as per [FLINK-36506](https://issues.apache.org/jira/browse/FLINK-36506) in `ColumnStats` *(For example: This pu

[jira] [Updated] (FLINK-36506) Remove all deprecated methods in `ColumnStats`

2024-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36506: --- Labels: pull-request-available (was: ) > Remove all deprecated methods in `ColumnStats` > -

[jira] [Updated] (FLINK-36521) Introduce TtlAwareSerializer to resolve the compatibility check between ttlSerializer and original serializer

2024-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36521: --- Labels: pull-request-available (was: ) > Introduce TtlAwareSerializer to resolve the compat

Re: [PR] [FLINK-36521][runtime] Introduce TtlAwareSerializer and TtlAwareSerializerSnapshot [flink]

2024-10-21 Thread via GitHub
flinkbot commented on PR #25554: URL: https://github.com/apache/flink/pull/25554#issuecomment-2428292508 ## CI report: * 98ea2df3c759b9d866b0e0327ec6a06883ff6dc9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] FLINK-36506: Remove all deprecated methods in `ColumnStats` [flink]

2024-10-21 Thread via GitHub
flinkbot commented on PR #2: URL: https://github.com/apache/flink/pull/2#issuecomment-2428292787 ## CI report: * 1656356a2b283dbffa1dcec3685025dd32b24cb8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33722] Fix events ordering in MATCH_RECOGNIZE in batch mode [flink]

2024-10-21 Thread via GitHub
jnh5y commented on code in PR #24699: URL: https://github.com/apache/flink/pull/24699#discussion_r1809434479 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/batch/sql/MatchRecognizeITCase.java: ## @@ -567,7 +912,7 @@ void testUserDefinedFu

[jira] [Commented] (FLINK-34825) [flink-cdc-pipeline-connectors] Add Implementation of DataSource in MongoDB

2024-10-21 Thread JunboWang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891714#comment-17891714 ] JunboWang commented on FLINK-34825: --- Interested in this. Please assign it to me. Thank

Re: [PR] FLINK-36506: Remove all deprecated methods in `ColumnStats` [flink]

2024-10-21 Thread via GitHub
atu-sharm commented on PR #2: URL: https://github.com/apache/flink/pull/2#issuecomment-2428292821 Hi @xuyangzhong can you please review this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [FLINK-35029][state/forst] Store timer in JVM heap when use async state backend [flink]

2024-10-21 Thread via GitHub
yunfengzhou-hub commented on PR #25501: URL: https://github.com/apache/flink/pull/25501#issuecomment-2428319498 Thanks for the update. The runtime part LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Comment Edited] (FLINK-36569) flink kafka connector do not close kafka produer when it checkpoint success

2024-10-21 Thread Jake.zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891735#comment-17891735 ] Jake.zhang edited comment on FLINK-36569 at 10/22/24 6:34 AM:

[jira] [Commented] (FLINK-36569) flink kafka connector do not close kafka produer when it checkpoint success

2024-10-21 Thread Jake.zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891735#comment-17891735 ] Jake.zhang commented on FLINK-36569: add schedule close service in `org.apache.flin