Re: [PR] [FLINK-20625] Implement V2 Google Cloud PubSub Source in accordance with FLIP-27 [flink-connector-gcp-pubsub]

2024-10-09 Thread via GitHub
clmccart commented on PR #32: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/32#issuecomment-2402775724 looks like the sink rewrite was completed in [FLINK-24298](https://issues.apache.org/jira/browse/FLINK-24298). will need to take a look at that and probably remove the si

[jira] [Updated] (FLINK-36456) Improve Security in DatadogHttpReporterFactory by providing ENV alternative to retrieve API key

2024-10-09 Thread Raul Garcia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Garcia updated FLINK-36456: Component/s: Runtime / Configuration (was: Runtime / Metrics) > Improve Secur

[PR] [FLINK-36456] [Runtime/Configuration] Improve Security in DatadogHttpReporterFactory by providing ENV alternative to retrieve API key [flink]

2024-10-09 Thread via GitHub
rxp90 opened a new pull request, #25470: URL: https://github.com/apache/flink/pull/25470 … DD_API_KEY if not present ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way

[jira] [Updated] (FLINK-36456) Improve Security in DatadogHttpReporterFactory by providing ENV alternative to retrieve API key

2024-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36456: --- Labels: pull-request-available (was: ) > Improve Security in DatadogHttpReporterFactory by

Re: [PR] [FLINK-36456] [Runtime/Configuration] Improve Security in DatadogHttpReporterFactory by providing ENV alternative to retrieve API key [flink]

2024-10-09 Thread via GitHub
Juoelenis commented on PR #25470: URL: https://github.com/apache/flink/pull/25470#issuecomment-2403211335 Very legit 👍👍👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-36445][runtime] Introduce ExecutionPlan interface. [flink]

2024-10-09 Thread via GitHub
Juoelenis commented on PR #25469: URL: https://github.com/apache/flink/pull/25469#issuecomment-2403214920 Big W -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] [FLINK-36440] Bump log4j from 2.17.1 to 2.23.1 [flink]

2024-10-09 Thread via GitHub
Juoelenis commented on PR #25463: URL: https://github.com/apache/flink/pull/25463#issuecomment-2403221800 1+ aura -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (FLINK-36440) Bump log4j from 2.17.1 to 2.23.1

2024-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36440: --- Labels: pull-request-available (was: ) > Bump log4j from 2.17.1 to 2.23.1 > ---

Re: [PR] [FLINK-36440] Bump log4j from 2.17.1 to 2.23.1 [flink]

2024-10-09 Thread via GitHub
ferenc-csaky commented on code in PR #25463: URL: https://github.com/apache/flink/pull/25463#discussion_r1794118721 ## pom.xml: ## @@ -127,7 +127,7 @@ under the License. true 11 1.7.36 - 2.17.1 + 2.23.1

Re: [PR] [FLINK-36456] [Runtime/Configuration] Improve Security in DatadogHttpReporterFactory by providing ENV alternative to retrieve API key [flink]

2024-10-09 Thread via GitHub
flinkbot commented on PR #25470: URL: https://github.com/apache/flink/pull/25470#issuecomment-2402739010 ## CI report: * 8e38de9c2f05656c51131a9d241ccab6fa8824c2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] Final [flink-connector-gcp-pubsub]

2024-10-09 Thread via GitHub
clmccart commented on code in PR #32: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/32#discussion_r1793804145 ## ordering-keys-prober/README.md: ## @@ -0,0 +1,75 @@ +### Introduction + +The prober is designed to demonstrate effective use of Cloud Pub/Sub's +[or

Re: [PR] Final [flink-connector-gcp-pubsub]

2024-10-09 Thread via GitHub
clmccart commented on code in PR #32: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/32#discussion_r1793804145 ## ordering-keys-prober/README.md: ## @@ -0,0 +1,75 @@ +### Introduction + +The prober is designed to demonstrate effective use of Cloud Pub/Sub's +[or

Re: [PR] Donate PubSub source and sink rewrite back to Apache [flink-connector-gcp-pubsub]

2024-10-09 Thread via GitHub
clmccart commented on code in PR #32: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/32#discussion_r1793809868 ## .gitignore: ## @@ -35,4 +35,8 @@ out/ tools/flink tools/flink-* tools/releasing/release -tools/japicmp-output \ No newline at end of file +tools/

Re: [PR] [FLINK-33926][kubernetes]: Allow using job jars in the system classpath in native mode [flink]

2024-10-09 Thread via GitHub
SamBarker commented on code in PR #25445: URL: https://github.com/apache/flink/pull/25445#discussion_r1794173964 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterDescriptor.java: ## @@ -214,9 +215,12 @@ public ClusterClientProvider deployApplicatio

[PR] [FlINK-XXXX] Expand the matrix for the smoke test. [flink-kubernetes-operator]

2024-10-09 Thread via GitHub
SamBarker opened a new pull request, #892: URL: https://github.com/apache/flink-kubernetes-operator/pull/892 The goal is to remove namespace from the main CI run based on https://github.com/apache/flink-kubernetes-operator/pull/881#discussion_r1790257507 ## What is the purpose

Re: [PR] [FlINK-XXXX] Expand the matrix for the smoke test. [flink-kubernetes-operator]

2024-10-09 Thread via GitHub
SamBarker closed pull request #892: [FlINK-] Expand the matrix for the smoke test. URL: https://github.com/apache/flink-kubernetes-operator/pull/892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (FLINK-33926) Can't start a job with a jar in the system classpath in native k8s mode

2024-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33926: --- Labels: pull-request-available (was: ) > Can't start a job with a jar in the system classpa

[jira] [Commented] (FLINK-36455) Sink should commit everything on notifyCheckpointCompleted

2024-10-09 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17887987#comment-17887987 ] Arvid Heise commented on FLINK-36455: - I'm not an expert of the SFS but from cross c

[jira] [Commented] (FLINK-36455) Sink should commit everything on notifyCheckpointCompleted

2024-10-09 Thread Galen Warren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17887988#comment-17887988 ] Galen Warren commented on FLINK-36455: -- Thanks for checking, much appreciated. I ma

[jira] [Created] (FLINK-36456) Improve Security in DatadogHttpReporterFactory by providing ENV alternative to retrieve API key

2024-10-09 Thread Raul Garcia (Jira)
Raul Garcia created FLINK-36456: --- Summary: Improve Security in DatadogHttpReporterFactory by providing ENV alternative to retrieve API key Key: FLINK-36456 URL: https://issues.apache.org/jira/browse/FLINK-36456

Re: [PR] [FLINK-36440] Bump log4j from 2.17.1 to 2.23.1 [flink]

2024-10-09 Thread via GitHub
Juoelenis commented on code in PR #25463: URL: https://github.com/apache/flink/pull/25463#discussion_r1794127775 ## pom.xml: ## @@ -127,7 +127,7 @@ under the License. true 11 1.7.36 - 2.17.1 + 2.23.1 Re

Re: [PR] [FLINK-25546][flink-connector-base][JUnit5 Migration] Module: flink-connector-base [flink]

2024-10-09 Thread via GitHub
snuyanzin commented on PR #21161: URL: https://github.com/apache/flink/pull/21161#issuecomment-2403319420 @Jiabao-Sun since you are one of those who contributed a lot in JUnit5 migration may I ask you to have a look here? -- This is an automated message from the Apache Git Service. To res

Re: [PR] [FLINK-36456] [Runtime/Configuration] Improve Security in DatadogHttpReporterFactory by providing ENV alternative to retrieve API key [flink]

2024-10-09 Thread via GitHub
wcoqscwx commented on PR #25470: URL: https://github.com/apache/flink/pull/25470#issuecomment-2402733236 Same change as this PR opened > 24 months ago: https://github.com/apache/flink/pull/19684 -- This is an automated message from the Apache Git Service. To respond to the message, please

[PR] [FLINK-36437][hive] Remove hive connector dependency usage [flink]

2024-10-09 Thread via GitHub
Sxnan opened a new pull request, #25467: URL: https://github.com/apache/flink/pull/25467 ## What is the purpose of the change Remove hive connector dependency usage ## Brief change log - Remove hive connector dependency usage ## Verifying this change

Re: [PR] [FLINK-36315][cdc-base]The flink-cdc-base module supports source metric statistics [flink-cdc]

2024-10-09 Thread via GitHub
liuxiao2shf commented on code in PR #3619: URL: https://github.com/apache/flink-cdc/pull/3619#discussion_r1793080478 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/metrics/SourceEnumeratorMetrics.java: ##

Re: [PR] [FLINK-36315][cdc-base]The flink-cdc-base module supports source metric statistics [flink-cdc]

2024-10-09 Thread via GitHub
liuxiao2shf commented on code in PR #3619: URL: https://github.com/apache/flink-cdc/pull/3619#discussion_r1793078972 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/metrics/SourceReaderMetrics.java: ## @@

[jira] [Created] (FLINK-36450) Exclude log4j from curator-test

2024-10-09 Thread Siddharth R (Jira)
Siddharth R created FLINK-36450: --- Summary: Exclude log4j from curator-test Key: FLINK-36450 URL: https://issues.apache.org/jira/browse/FLINK-36450 Project: Flink Issue Type: Improvement

Re: [PR] [FLINK-36445][runtime] Introduce ExecutionPlan interface. [flink]

2024-10-09 Thread via GitHub
flinkbot commented on PR #25469: URL: https://github.com/apache/flink/pull/25469#issuecomment-2401882499 ## CI report: * 477c3c2050a7fc508519b9806ac84cc9e3eab32a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-36451) Kubernetes Application JobManager Potential Deadlock and TaskManager Pod Residuals

2024-10-09 Thread xiechenling (Jira)
xiechenling created FLINK-36451: --- Summary: Kubernetes Application JobManager Potential Deadlock and TaskManager Pod Residuals Key: FLINK-36451 URL: https://issues.apache.org/jira/browse/FLINK-36451 Proj

[PR] [FLINK-36449] Bump apache-rat-plugin [flink-kubernetes-operator]

2024-10-09 Thread via GitHub
r-sidd opened a new pull request, #890: URL: https://github.com/apache/flink-kubernetes-operator/pull/890 ## What is the purpose of the change Bump apache-rat-plugin ## Brief change log Bump apache-rat-plugin from 0.12 to 0.16.1 to remediate the underlying vulnerabilitie

[jira] [Updated] (FLINK-36449) Bump apache-rat-plugin from 0.12 to 0.16.1

2024-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36449: --- Labels: pull-request-available (was: ) > Bump apache-rat-plugin from 0.12 to 0.16.1 > -

Re: [PR] [FLINK-33977][runtime] Adaptive scheduler may not minimize the number of TMs during downscaling [flink]

2024-10-09 Thread via GitHub
ztison commented on PR #25218: URL: https://github.com/apache/flink/pull/25218#issuecomment-2401913141 Hi, I was wondering if it's advisable to change the default slot assigner. Wouldn't it be more appropriate to keep the default setting, which spreads the workload across as many workers as

[jira] [Assigned] (FLINK-36455) Sink should commit everything on notifyCheckpointCompleted

2024-10-09 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arvid Heise reassigned FLINK-36455: --- Assignee: Arvid Heise > Sink should commit everything on notifyCheckpointCompleted > --

[jira] [Commented] (FLINK-36455) Sink should commit everything on notifyCheckpointCompleted

2024-10-09 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17887948#comment-17887948 ] Arvid Heise commented on FLINK-36455: - Yes, all sinks following the FLIP-143 API are

[jira] [Commented] (FLINK-36455) Sink should commit everything on notifyCheckpointCompleted

2024-10-09 Thread Galen Warren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17887949#comment-17887949 ] Galen Warren commented on FLINK-36455: -- Gotcha, thanks. Presumably that wouldn't in

Re: [PR] [FLINK-36315][cdc-base]The flink-cdc-base module supports source metric statistics [flink-cdc]

2024-10-09 Thread via GitHub
liuxiao2shf commented on code in PR #3619: URL: https://github.com/apache/flink-cdc/pull/3619#discussion_r1793008830 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/metrics/SourceEnumeratorMetrics.java: ##

[jira] [Updated] (FLINK-36421) Missing fsync in FsCheckpointStreamFactory

2024-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36421: --- Labels: pull-request-available (was: ) > Missing fsync in FsCheckpointStreamFactory > -

[PR] [FLINK-36421] [fs] [checkpoint] Sync outputStream before returning handle in FsCheckpointStreamFactory [flink]

2024-10-09 Thread via GitHub
Planet-X opened a new pull request, #25468: URL: https://github.com/apache/flink/pull/25468 ## What is the purpose of the change The `FsCheckpointStreamFactory` returns handles to files containing larger serialized data for checkpoint creation. However, these files are not synced per

[jira] [Assigned] (FLINK-36322) Fix compile error of flink benchmark caused by breaking changes

2024-10-09 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan reassigned FLINK-36322: --- Assignee: Zakelly Lan > Fix compile error of flink benchmark caused by breaking changes > -

Re: [PR] [FLINK-36315][cdc-base]The flink-cdc-base module supports source metric statistics [flink-cdc]

2024-10-09 Thread via GitHub
liuxiao2shf commented on code in PR #3619: URL: https://github.com/apache/flink-cdc/pull/3619#discussion_r1793008455 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/metrics/SourceEnumeratorMetrics.java: ##

[jira] [Commented] (FLINK-36455) Sink should commit everything on notifyCheckpointCompleted

2024-10-09 Thread Galen Warren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17887940#comment-17887940 ] Galen Warren commented on FLINK-36455: -- [~arvid] I'm trying to understand the scope

[jira] [Commented] (FLINK-36421) Missing fsync in FsCheckpointStreamFactory

2024-10-09 Thread Marc Aurel Fritz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17887822#comment-17887822 ] Marc Aurel Fritz commented on FLINK-36421: -- [~gaborgsomogyi] We're been running

[jira] [Assigned] (FLINK-36446) Refactor Job Submission Process to Use ExecutionPlan Instead of JobGraph

2024-10-09 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-36446: --- Assignee: Junrui Li > Refactor Job Submission Process to Use ExecutionPlan Instead of JobGraph > --

[jira] [Assigned] (FLINK-36445) Introducing an ExecutionPlan interface

2024-10-09 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-36445: --- Assignee: Junrui Li > Introducing an ExecutionPlan interface >

[jira] [Assigned] (FLINK-36158) Refactor Job Recovery Process to Use ExecutionPlan Instead of JobGraph

2024-10-09 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-36158: --- Assignee: Junrui Li > Refactor Job Recovery Process to Use ExecutionPlan Instead of JobGraph >

[jira] [Updated] (FLINK-36445) Introducing an ExecutionPlan interface

2024-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36445: --- Labels: pull-request-available (was: ) > Introducing an ExecutionPlan interface > -

Re: [PR] [FLINK-36441] Ensure producers are not leaked [flink-connector-kafka]

2024-10-09 Thread via GitHub
AHeise merged PR #126: URL: https://github.com/apache/flink-connector-kafka/pull/126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[PR] [FLINK-36445][runtime] Introduce ExecutionPlan interface. [flink]

2024-10-09 Thread via GitHub
JunRuiLee opened a new pull request, #25469: URL: https://github.com/apache/flink/pull/25469 ## What is the purpose of the change [FLINK-36445][runtime] Introduce ExecutionPlan interface. ## Brief change log Introduce ExecutionPlan interface and JobGraph implement

[jira] [Commented] (FLINK-36441) Resource leaks in Kafka connector (Tests)

2024-10-09 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17887871#comment-17887871 ] Arvid Heise commented on FLINK-36441: - Merged as f888d5afa7b62fe52ddad7575f3f7a4895

Re: [PR] [FLINK-35109] Bump to Flink 1.19 and support Flink 1.20 [flink-connector-kafka]

2024-10-09 Thread via GitHub
AHeise commented on PR #122: URL: https://github.com/apache/flink-connector-kafka/pull/122#issuecomment-2401873098 I forked out FLINK-36441 for the test fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Resolved] (FLINK-36441) Resource leaks in Kafka connector (Tests)

2024-10-09 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arvid Heise resolved FLINK-36441. - Fix Version/s: kafka-3.3.0 Resolution: Fixed > Resource leaks in Kafka connector (Tests)

Re: [PR] [FLINK-36421] [fs] [checkpoint] Sync outputStream before returning handle in FsCheckpointStreamFactory [flink]

2024-10-09 Thread via GitHub
gaborgsomogyi commented on PR #25468: URL: https://github.com/apache/flink/pull/25468#issuecomment-2402241930 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Commented] (FLINK-36421) Missing fsync in FsCheckpointStreamFactory

2024-10-09 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17887922#comment-17887922 ] Gabor Somogyi commented on FLINK-36421: --- I would backport it to at least 1.20 line

Re: [PR] [FLINK-36421] [fs] [checkpoint] Sync outputStream before returning handle in FsCheckpointStreamFactory [flink]

2024-10-09 Thread via GitHub
gaborgsomogyi commented on PR #25468: URL: https://github.com/apache/flink/pull/25468#issuecomment-2402249199 Needs a green azure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [FLINK-36009] Architecture tests fixes [flink-connector-jdbc]

2024-10-09 Thread via GitHub
eskabetxe commented on PR #140: URL: https://github.com/apache/flink-connector-jdbc/pull/140#issuecomment-2401637907 Created another PR only with new module for architecture change [here](https://github.com/apache/flink-connector-jdbc/pull/143/files) This is keeped to allow the discussio

Re: [PR] [FLINK-31234][kubernetes] Add an option to redirect stdout to log dir. [flink]

2024-10-09 Thread via GitHub
xiaows08 commented on PR #22138: URL: https://github.com/apache/flink/pull/22138#issuecomment-2401639724 @huwh 感谢回复,环境如下: flink-kubernetes-operator 1.9.0 flink: flink:1.18.1-scala_2.12 log4j-console.properties 是镜像默认的 ```yaml apiVersion: flink.apache.org/v1beta1 kind: Fli

Re: [PR] [FLINK-36421] [fs] [checkpoint] Sync outputStream before returning handle in FsCheckpointStreamFactory [flink]

2024-10-09 Thread via GitHub
flinkbot commented on PR #25468: URL: https://github.com/apache/flink/pull/25468#issuecomment-2401668508 ## CI report: * fd427ffdeaa9b9fc6c31dee3dc09ca982ad7b5ba UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Comment Edited] (FLINK-36421) Missing fsync in FsCheckpointStreamFactory

2024-10-09 Thread Marc Aurel Fritz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17887822#comment-17887822 ] Marc Aurel Fritz edited comment on FLINK-36421 at 10/9/24 8:43 AM: ---

[jira] [Closed] (FLINK-36064) Refactor REST API for Client and Operator Coordinator Communication to Use operatorUid.

2024-10-09 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-36064. --- Fix Version/s: 2.0.0 Resolution: Done 63b92bd88ac32be5b3e70550ba90d828b7b655d1 > Refactor REST API f

[jira] [Commented] (FLINK-36440) Bump log4j from 2.17.1 to 2.23.1

2024-10-09 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17887927#comment-17887927 ] Ferenc Csaky commented on FLINK-36440: -- Latest version is 2.24.1 [1], any specific

Re: [PR] [FLINK-36241] Table API .plus should support string concatenation [flink]

2024-10-09 Thread via GitHub
dawidwys commented on PR #25298: URL: https://github.com/apache/flink/pull/25298#issuecomment-2402337798 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (FLINK-36455) Sink should commit everything on notifyCheckpointCompleted

2024-10-09 Thread Arvid Heise (Jira)
Arvid Heise created FLINK-36455: --- Summary: Sink should commit everything on notifyCheckpointCompleted Key: FLINK-36455 URL: https://issues.apache.org/jira/browse/FLINK-36455 Project: Flink Issu

[jira] [Commented] (FLINK-36448) Compilation fails in IntelliJ

2024-10-09 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17887865#comment-17887865 ] Xintong Song commented on FLINK-36448: -- [~mallikarjuna], I'm not entirely sure, bu

[PR] [FLINK-36450] exclude log4j from curator-test [flink-kubernetes-operator]

2024-10-09 Thread via GitHub
r-sidd opened a new pull request, #889: URL: https://github.com/apache/flink-kubernetes-operator/pull/889 ## What is the purpose of the change Exclude the vulnerable log4j dependency from curator-test ## Verifying this change This change is a trivial rework / code cle

[jira] [Updated] (FLINK-36450) Exclude log4j from curator-test

2024-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36450: --- Labels: pull-request-available (was: ) > Exclude log4j from curator-test >

Re: [PR] [FLINK-36064][runtime] Refactor REST API for Client and Operator Coordinator Communication to Use String OperatorUid. [flink]

2024-10-09 Thread via GitHub
zhuzhurk closed pull request #25227: [FLINK-36064][runtime] Refactor REST API for Client and Operator Coordinator Communication to Use String OperatorUid. URL: https://github.com/apache/flink/pull/25227 -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] [FLINK-36315][cdc-base]The flink-cdc-base module supports source metric statistics [flink-cdc]

2024-10-09 Thread via GitHub
liuxiao2shf commented on code in PR #3619: URL: https://github.com/apache/flink-cdc/pull/3619#discussion_r1792981064 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/assigner/HybridSplitAssigner.java: ## @@

Re: [PR] [FLINK-36315][cdc-base]The flink-cdc-base module supports source metric statistics [flink-cdc]

2024-10-09 Thread via GitHub
liuxiao2shf commented on code in PR #3619: URL: https://github.com/apache/flink-cdc/pull/3619#discussion_r1792984158 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/metrics/SourceReaderMetrics.java: ## @@

Re: [PR] [FLINK-36315][cdc-base]The flink-cdc-base module supports source metric statistics [flink-cdc]

2024-10-09 Thread via GitHub
liuxiao2shf commented on code in PR #3619: URL: https://github.com/apache/flink-cdc/pull/3619#discussion_r1792988134 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/metrics/SourceReaderMetrics.java: ## @@

Re: [PR] [FLINK-36315][cdc-base]The flink-cdc-base module supports source metric statistics [flink-cdc]

2024-10-09 Thread via GitHub
liuxiao2shf commented on code in PR #3619: URL: https://github.com/apache/flink-cdc/pull/3619#discussion_r1792988461 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/metrics/SourceReaderMetrics.java: ## @@

Re: [PR] [FLINK-36315][cdc-base]The flink-cdc-base module supports source metric statistics [flink-cdc]

2024-10-09 Thread via GitHub
liuxiao2shf commented on code in PR #3619: URL: https://github.com/apache/flink-cdc/pull/3619#discussion_r1792989625 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/metrics/SourceReaderMetrics.java: ## @@

Re: [PR] [FLINK-36315][cdc-base]The flink-cdc-base module supports source metric statistics [flink-cdc]

2024-10-09 Thread via GitHub
liuxiao2shf commented on code in PR #3619: URL: https://github.com/apache/flink-cdc/pull/3619#discussion_r1792982379 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/assigner/HybridSplitAssigner.java: ## @@

Re: [PR] [FLINK-36315][cdc-base]The flink-cdc-base module supports source metric statistics [flink-cdc]

2024-10-09 Thread via GitHub
liuxiao2shf commented on code in PR #3619: URL: https://github.com/apache/flink-cdc/pull/3619#discussion_r1792986970 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/reader/IncrementalSourceRecordEmitter.java:

[jira] [Created] (FLINK-36453) Backport DBZ-6502 patch to fix Oracle 23.x JDBC driver compatbility

2024-10-09 Thread yux (Jira)
yux created FLINK-36453: --- Summary: Backport DBZ-6502 patch to fix Oracle 23.x JDBC driver compatbility Key: FLINK-36453 URL: https://issues.apache.org/jira/browse/FLINK-36453 Project: Flink Issue Type

[jira] [Created] (FLINK-36452) Avoid EOFException when reading binlog after a large table has just completed snapshot reading

2024-10-09 Thread LvYanquan (Jira)
LvYanquan created FLINK-36452: - Summary: Avoid EOFException when reading binlog after a large table has just completed snapshot reading Key: FLINK-36452 URL: https://issues.apache.org/jira/browse/FLINK-36452

[jira] [Updated] (FLINK-36453) Backport DBZ-6502 patch to fix Oracle 23.x JDBC driver compatbility

2024-10-09 Thread yux (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yux updated FLINK-36453: Description: DBZ-6502 fixes Oracle JDBC 23.x compatibility, but it wasn't shipped in versions prior to 2.2. We m

[jira] [Commented] (FLINK-36453) Backport DBZ-6502 patch to fix Oracle 23.x JDBC driver compatbility

2024-10-09 Thread yux (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17887877#comment-17887877 ] yux commented on FLINK-36453: - I'd love to take this ticket. [~leonard] > Backport DBZ-6502

[jira] [Updated] (FLINK-36322) Fix compile error of flink benchmark caused by breaking changes

2024-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36322: --- Labels: pull-request-available (was: ) > Fix compile error of flink benchmark caused by bre

[jira] [Updated] (FLINK-36452) Avoid EOFException when reading binlog after a large table has just completed snapshot reading

2024-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36452: --- Labels: pull-request-available (was: ) > Avoid EOFException when reading binlog after a lar

[jira] [Assigned] (FLINK-36453) Backport DBZ-6502 patch to fix Oracle 23.x JDBC driver compatbility

2024-10-09 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-36453: -- Assignee: yux > Backport DBZ-6502 patch to fix Oracle 23.x JDBC driver compatbility > ---

[jira] [Assigned] (FLINK-36452) Avoid EOFException when reading binlog after a large table has just completed snapshot reading

2024-10-09 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-36452: -- Assignee: LvYanquan > Avoid EOFException when reading binlog after a large table has just com

[jira] [Created] (FLINK-36448) Compilation fails in IntelliJ

2024-10-09 Thread Kumar Mallikarjuna (Jira)
Kumar Mallikarjuna created FLINK-36448: -- Summary: Compilation fails in IntelliJ Key: FLINK-36448 URL: https://issues.apache.org/jira/browse/FLINK-36448 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-36448) Compilation fails in IntelliJ

2024-10-09 Thread Kumar Mallikarjuna (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17887846#comment-17887846 ] Kumar Mallikarjuna commented on FLINK-36448: Hi [~xtsong] , would you know w

[jira] [Updated] (FLINK-36448) Compilation fails in IntelliJ

2024-10-09 Thread Kumar Mallikarjuna (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kumar Mallikarjuna updated FLINK-36448: --- Description: I'm unable to build master (as of "c9c946f") with IntelliJ. Compilation

[jira] [Created] (FLINK-36449) Bump apache-rat-plugin from 0.12 to 0.16.1

2024-10-09 Thread Siddharth R (Jira)
Siddharth R created FLINK-36449: --- Summary: Bump apache-rat-plugin from 0.12 to 0.16.1 Key: FLINK-36449 URL: https://issues.apache.org/jira/browse/FLINK-36449 Project: Flink Issue Type: Improvem

[PR] [FLINK-35363] Architecture tests refactor [flink-connector-jdbc]

2024-10-09 Thread via GitHub
eskabetxe opened a new pull request, #143: URL: https://github.com/apache/flink-connector-jdbc/pull/143 Created the module [flink-connector-jdbc-architecture](https://issues.apache.org/jira/browse/FLINK-connector-jdbc-architecture) to have all tests, we need to add the modules as dependency

Re: [PR] [FLINK-36437][hive] Remove hive connector dependency usage [flink]

2024-10-09 Thread via GitHub
flinkbot commented on PR #25467: URL: https://github.com/apache/flink/pull/25467#issuecomment-2401656939 ## CI report: * 8675be3d2aef7c1bd59b40573b01741181702929 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-36454) FlinkContainer always overwrites default config

2024-10-09 Thread Arvid Heise (Jira)
Arvid Heise created FLINK-36454: --- Summary: FlinkContainer always overwrites default config Key: FLINK-36454 URL: https://issues.apache.org/jira/browse/FLINK-36454 Project: Flink Issue Type: Bug

[PR] [hotfix] Fix testfail due to data race with after migration to Fabric8 interceptor [flink-kubernetes-operator]

2024-10-09 Thread via GitHub
aplyusnin opened a new pull request, #891: URL: https://github.com/apache/flink-kubernetes-operator/pull/891 Tests that perform requests are usualy fail now on CI due to race conditions. To fix it, I addeв busywait for metrics with timeout as it is done in RestApiMetricsCollectorTes

Re: [PR] [hotfix] Fix testfail due to data race with after migration to Fabric8 interceptor [flink-kubernetes-operator]

2024-10-09 Thread via GitHub
aplyusnin commented on PR #891: URL: https://github.com/apache/flink-kubernetes-operator/pull/891#issuecomment-2403691503 ```kubernetesClient.resource(deployment).delete()``` has to be a blocking call, but when I run the tests wtih some extra logging I saw, that 404 response code doesn't a

Re: [PR] [FLINK-25546][flink-connector-base][JUnit5 Migration] Module: flink-connector-base [flink]

2024-10-09 Thread via GitHub
Jiabao-Sun commented on code in PR #21161: URL: https://github.com/apache/flink/pull/21161#discussion_r1794452407 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/AsyncSinkBaseITCase.java: ## @@ -32,7 +32,7 @@ /** Integration tests o

[jira] [Updated] (FLINK-36458) Use original 'OceanBaseCEContainer' of testcontainers in testing

2024-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36458: --- Labels: pull-request-available (was: ) > Use original 'OceanBaseCEContainer' of testcontain

Re: [PR] [FLINK-30899][connector/filesystem] Fix FileSystemTableSource incorrectly selecting fields on partitioned tables [flink]

2024-10-09 Thread via GitHub
flinkbot commented on PR #25476: URL: https://github.com/apache/flink/pull/25476#issuecomment-2404177936 ## CI report: * 4cf5dec3610ec538a01e66210e753478fb6ff216 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-30899][connector/filesystem] Fix FileSystemTableSource incorrectly selecting fields on partitioned tables [flink]

2024-10-09 Thread via GitHub
flinkbot commented on PR #25477: URL: https://github.com/apache/flink/pull/25477#issuecomment-2404181439 ## CI report: * ea2e19fbae18568d95b7195492cbe3ef448f1892 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-36460] Refactoring the CI matrix [flink-kubernetes-operator]

2024-10-09 Thread via GitHub
SamBarker opened a new pull request, #893: URL: https://github.com/apache/flink-kubernetes-operator/pull/893 ## What is the purpose of the change As observed in [FLINK-36332](https://github.com/apache/flink-kubernetes-operator/pull/881#issuecomment-2378765602) the CI workflow has bec

[jira] [Updated] (FLINK-36460) Refactor Kubernetes Operator Edge to Edge test setup

2024-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36460: --- Labels: pull-request-available (was: ) > Refactor Kubernetes Operator Edge to Edge test set

[PR] Fix flaky tests in classes [flink]

2024-10-09 Thread via GitHub
nikunjagarwal321 opened a new pull request, #25471: URL: https://github.com/apache/flink/pull/25471 ## What is the purpose of the change [NonDex](https://github.com/TestingResearchIllinois/NonDex) is a tool for detecting and debugging wrong assumptions on under-determined Java APIs. W

Re: [PR] [hotfix][state/forst] Remove string.format() in critical path [flink]

2024-10-09 Thread via GitHub
flinkbot commented on PR #25473: URL: https://github.com/apache/flink/pull/25473#issuecomment-2403913805 ## CI report: * dd54c09afab52f3178da592cd9196ad3036e66b4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-36460) Refactor Kubernetes Operator Edge to Edge test setup

2024-10-09 Thread Sam Barker (Jira)
Sam Barker created FLINK-36460: -- Summary: Refactor Kubernetes Operator Edge to Edge test setup Key: FLINK-36460 URL: https://issues.apache.org/jira/browse/FLINK-36460 Project: Flink Issue Type:

[PR] [hotfix][state/forst] Remove string.format() in critical path [flink]

2024-10-09 Thread via GitHub
fredia opened a new pull request, #25473: URL: https://github.com/apache/flink/pull/25473 ## What is the purpose of the change This PR removes string.format() in critical path in ForSt map state. ## Brief change log - Remove string.format() in `ForStMapState#buildDBPu

  1   2   >