Re: [PR] [FLINK-29741][scala] Delete flink-scala and flink-streaming-scala modules [flink]

2024-09-25 Thread via GitHub
reswqa merged PR #25393: URL: https://github.com/apache/flink/pull/25393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Updated] (FLINK-36375) Missing default value in AddColumnEvent

2024-09-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36375: --- Labels: pull-request-available (was: ) > Missing default value in AddColumnEvent >

Re: [PR] [FLINK-36375][cdc-runtime] fix missing default value in AddColumnEvent [flink-cdc]

2024-09-25 Thread via GitHub
qg-lin commented on PR #3622: URL: https://github.com/apache/flink-cdc/pull/3622#issuecomment-2375891374 @lvyanquan @yuxiqian PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Assigned] (FLINK-36374) Bundle forst statebackend in flink-dist and provide shortcut to enable

2024-09-25 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan reassigned FLINK-36374: --- Assignee: Zakelly Lan > Bundle forst statebackend in flink-dist and provide shortcut to ena

[jira] [Created] (FLINK-36374) Bundle forst statebackend in flink-dist and provide shortcut to enable

2024-09-25 Thread Zakelly Lan (Jira)
Zakelly Lan created FLINK-36374: --- Summary: Bundle forst statebackend in flink-dist and provide shortcut to enable Key: FLINK-36374 URL: https://issues.apache.org/jira/browse/FLINK-36374 Project: Flink

Re: [PR] [minor][cdc-connector][mongodb] Add `op_type` metadata column [flink-cdc]

2024-09-25 Thread via GitHub
qg-lin commented on PR #3615: URL: https://github.com/apache/flink-cdc/pull/3615#issuecomment-2375852444 Since DeduplicateFunctionHelper#processLastRowOnChangelog returns the row before deletion, the `delete` type is temporarily missing. -- This is an automated message from the Apache Git

[jira] [Created] (FLINK-36375) Missing default value in AddColumnEvent

2024-09-25 Thread linqigeng (Jira)
linqigeng created FLINK-36375: - Summary: Missing default value in AddColumnEvent Key: FLINK-36375 URL: https://issues.apache.org/jira/browse/FLINK-36375 Project: Flink Issue Type: Bug C

[PR] [FLINK-36374] Bundle forst statebackend in flink-dist and provide shortcut to enable [flink]

2024-09-25 Thread via GitHub
Zakelly opened a new pull request, #25402: URL: https://github.com/apache/flink/pull/25402 ## What is the purpose of the change Currently, the forst statebackend are built under `flink-statebackend-forst`, but is not included in the `flink-dist`'s jar. This PR make forst statebackend

[jira] [Updated] (FLINK-36374) Bundle forst statebackend in flink-dist and provide shortcut to enable

2024-09-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36374: --- Labels: pull-request-available (was: ) > Bundle forst statebackend in flink-dist and provid

Re: [PR] [FLINK-36374][state/forst] Bundle forst statebackend in flink-dist and provide shortcut to enable [flink]

2024-09-25 Thread via GitHub
flinkbot commented on PR #25402: URL: https://github.com/apache/flink/pull/25402#issuecomment-2375878995 ## CI report: * 3b63165442e17ced06c405d00f575fa02307cb2d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [Flink 36245] Remove legacy SourceFunction / SinkFunction / Sink V1 API in 2.0 [flink]

2024-09-25 Thread via GitHub
lvyanquan commented on PR #25331: URL: https://github.com/apache/flink/pull/25331#issuecomment-2375887294 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[PR] [FLINK-36375][cdc-runtime] fix missing default value in AddColumnEvent [flink-cdc]

2024-09-25 Thread via GitHub
qg-lin opened a new pull request, #3622: URL: https://github.com/apache/flink-cdc/pull/3622 SchemaOperator receives an AddColumnEvent, the default value will be lost when sent downstream. JIRA: [https://issues.apache.org/jira/browse/FLINK-36375](url) -- This is an automated message fro

[jira] [Updated] (FLINK-36375) Missing default value in AddColumnEvent/RenameColumnEvent

2024-09-25 Thread linqigeng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] linqigeng updated FLINK-36375: -- Description: SchemaOperator receives an AddColumnEvent or RenameColumnEvent, the default value will b

[PR] [FLINK-35709][table-planner] Allow reordering source columns in CTAS and RTAS [flink]

2024-09-25 Thread via GitHub
spena opened a new pull request, #25401: URL: https://github.com/apache/flink/pull/25401 ## What is the purpose of the change This PR allows you to use CTAS to reorder the columns defined in the `SELECT` part by specifying all column names without data types in the `CREATE` part. Thi

Re: [PR] [FLINK-35709][table-planner] Allow reordering source columns in CTAS and RTAS [flink]

2024-09-25 Thread via GitHub
flinkbot commented on PR #25401: URL: https://github.com/apache/flink/pull/25401#issuecomment-2375351231 ## CI report: * dfb06e8b80b48a4c25a0c50a1fb3841426ccb7e5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-36292][Connectors/Common]: remove timeout to avoid timeout exception [flink]

2024-09-25 Thread via GitHub
showuon commented on code in PR #25371: URL: https://github.com/apache/flink/pull/25371#discussion_r1776302945 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManagerTest.java: ## @@ -71,7 +71,7 @@ public v

Re: [PR] [FLINK-30614][serializer] Remove old method of resolving schema compa… [flink]

2024-09-25 Thread via GitHub
Zakelly commented on PR #25384: URL: https://github.com/apache/flink/pull/25384#issuecomment-2375806647 I'd suggest removing `GenericArraySerializerConfigSnapshot` and `EitherSerializerSnapshot` with another commit by this PR. -- This is an automated message from the Apache Git Service. T

[jira] [Created] (FLINK-36372) Can not insert data to sink with reserved keywords column name

2024-09-25 Thread Tan Nguyen (Jira)
Tan Nguyen created FLINK-36372: -- Summary: Can not insert data to sink with reserved keywords column name Key: FLINK-36372 URL: https://issues.apache.org/jira/browse/FLINK-36372 Project: Flink I

[jira] [Updated] (FLINK-36372) Can not insert data to sink with reserved keywords column name

2024-09-25 Thread Tan Nguyen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tan Nguyen updated FLINK-36372: --- Description: Hi teams, I created a flink application running as batch mode, we read data from kafka

[jira] [Updated] (FLINK-36372) Can not insert data to sink with reserved keywords column name

2024-09-25 Thread Tan Nguyen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tan Nguyen updated FLINK-36372: --- Description: Hi teams, I created a flink application running as batch mode, we read data from kafka

[jira] [Created] (FLINK-36373) Support distribute state requests in task thread

2024-09-25 Thread Yanfei Lei (Jira)
Yanfei Lei created FLINK-36373: -- Summary: Support distribute state requests in task thread Key: FLINK-36373 URL: https://issues.apache.org/jira/browse/FLINK-36373 Project: Flink Issue Type: Sub-

[jira] [Commented] (FLINK-36364) Do not reuse serialized key in Forst map state and/or other namespaces

2024-09-25 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884842#comment-17884842 ] Zakelly Lan commented on FLINK-36364: - Merge 82582b3a7b75b7ffae9d48895088189b1324caa

[jira] [Assigned] (FLINK-35928) ForSt supports compiling with RocksDB

2024-09-25 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan reassigned FLINK-35928: --- Assignee: Yanfei Lei (was: Hangxiang Yu) > ForSt supports compiling with RocksDB > ---

[jira] [Resolved] (FLINK-36364) Do not reuse serialized key in Forst map state and/or other namespaces

2024-09-25 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan resolved FLINK-36364. - Fix Version/s: 2.0-preview Resolution: Fixed > Do not reuse serialized key in Forst map s

Re: [PR] [FLINK-36364][state/forst] Do not reuse serialized key in Forst map state and/or other namespaces [flink]

2024-09-25 Thread via GitHub
Zakelly merged PR #25394: URL: https://github.com/apache/flink/pull/25394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] [FLINK-35291] Improve the ROW data deserialization performance of DebeziumEventDeserializationScheme [flink-cdc]

2024-09-25 Thread via GitHub
github-actions[bot] commented on PR #3289: URL: https://github.com/apache/flink-cdc/pull/3289#issuecomment-2375474952 This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. --

[jira] [Commented] (FLINK-21820) JDBC connector shouldn't read all rows in per statement by default

2024-09-25 Thread zhanghuaibei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884829#comment-17884829 ] zhanghuaibei commented on FLINK-21820: -- h4. [~leonard] [~jark] [~yangsanity] [~nich

Re: [PR] [FLINK-36335][runtime] Improving Method Reusability in StreamGraphGenerator with JobVertexBuildContext [flink]

2024-09-25 Thread via GitHub
noorall commented on PR #25366: URL: https://github.com/apache/flink/pull/25366#issuecomment-2375736309 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-36355][runtime] Remove deprecated KeydStream#asQueryableState [flink]

2024-09-25 Thread via GitHub
yunfengzhou-hub closed pull request #25391: [FLINK-36355][runtime] Remove deprecated KeydStream#asQueryableState URL: https://github.com/apache/flink/pull/25391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] [FLINK-36355][runtime] Remove deprecated KeydStream#asQueryableState [flink]

2024-09-25 Thread via GitHub
yunfengzhou-hub commented on PR #25391: URL: https://github.com/apache/flink/pull/25391#issuecomment-2376037028 According to offline discussion with @Zakelly, this component will temporarily not be removed until a new query state solution is proposed in Flink 2.x. -- This is an automated

[jira] [Comment Edited] (FLINK-36166) testJoinDisorderChangeLog failed on AZP

2024-09-25 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884867#comment-17884867 ] xuyang edited comment on FLINK-36166 at 9/26/24 6:37 AM: - Everyt

[jira] [Comment Edited] (FLINK-36166) testJoinDisorderChangeLog failed on AZP

2024-09-25 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884867#comment-17884867 ] xuyang edited comment on FLINK-36166 at 9/26/24 6:14 AM: - I'm no

Re: [PR] [FLINK-36375][cdc-runtime] fix missing default value in AddColumnEvent [flink-cdc]

2024-09-25 Thread via GitHub
qg-lin commented on PR #3622: URL: https://github.com/apache/flink-cdc/pull/3622#issuecomment-2376090149 > Thanks for @qg-lin's contribution! Seems lenientized `RenameColumnEvent` is also prone to this issue. Would you like to fix this in this PR? my pleasure -- This is an automate

Re: [PR] FLINK-36332 Add option to select the Fabric8 httpclient implemention [flink-kubernetes-operator]

2024-09-25 Thread via GitHub
SamBarker commented on code in PR #881: URL: https://github.com/apache/flink-kubernetes-operator/pull/881#discussion_r1776061626 ## pom.xml: ## @@ -110,6 +110,7 @@ under the License. 10.15.2.0 +24.1.0 Review Comment: I've removed `@NotNull` from

Re: [PR] FLINK-36332 Add option to select the Fabric8 httpclient implemention [flink-kubernetes-operator]

2024-09-25 Thread via GitHub
SamBarker commented on code in PR #881: URL: https://github.com/apache/flink-kubernetes-operator/pull/881#discussion_r1776062522 ## .github/workflows/ci.yml: ## @@ -78,6 +79,7 @@ jobs: namespace: ["default","flink"] mode: ["native", "standalone"] java

Re: [PR] FLINK-36332 Add option to select the Fabric8 httpclient implemention [flink-kubernetes-operator]

2024-09-25 Thread via GitHub
SamBarker commented on code in PR #881: URL: https://github.com/apache/flink-kubernetes-operator/pull/881#discussion_r1776062259 ## .github/workflows/ci.yml: ## @@ -47,7 +48,7 @@ jobs: ${{ runner.os }}-maven- - name: Build with Maven run: | -

Re: [PR] [FLINK-36364][state/forst] Do not reuse serialized key in Forst map state and/or other namespaces [flink]

2024-09-25 Thread via GitHub
fredia commented on code in PR #25394: URL: https://github.com/apache/flink/pull/25394#discussion_r1776219418 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStSerializerUtils.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-36344][runtime/metrics] Introduce lastCheckpointCompletedTimestamp metric [flink]

2024-09-25 Thread via GitHub
Myasuka commented on PR #25399: URL: https://github.com/apache/flink/pull/25399#issuecomment-2375646639 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-34702][table-planner] Refactor Deduplicate optimization to defer to StreamPhysicalRank for valid StreamExecDeduplicate node conversion to avoid exceptions [flink]

2024-09-25 Thread via GitHub
lincoln-lil commented on code in PR #25380: URL: https://github.com/apache/flink/pull/25380#discussion_r1774875365 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/RankUtil.scala: ## @@ -352,21 +352,55 @@ object RankUtil { }

[jira] [Created] (FLINK-36367) Use RexNormalize in EquivalentExprShuttle

2024-09-25 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-36367: --- Summary: Use RexNormalize in EquivalentExprShuttle Key: FLINK-36367 URL: https://issues.apache.org/jira/browse/FLINK-36367 Project: Flink Issue Type: B

Re: [PR] [FLINK-36361][table] Do not use StringBuilder for EquivalentExprShuttle [flink]

2024-09-25 Thread via GitHub
snuyanzin commented on code in PR #25388: URL: https://github.com/apache/flink/pull/25388#discussion_r1774883976 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/FlinkRexUtil.scala: ## @@ -439,17 +439,16 @@ object FlinkRexUtil { })

[jira] [Created] (FLINK-36368) Fix subtask management in CommittableCollector

2024-09-25 Thread Arvid Heise (Jira)
Arvid Heise created FLINK-36368: --- Summary: Fix subtask management in CommittableCollector Key: FLINK-36368 URL: https://issues.apache.org/jira/browse/FLINK-36368 Project: Flink Issue Type: Bug

Re: [PR] [FLINK-36361][table] Do not use StringBuilder for EquivalentExprShuttle [flink]

2024-09-25 Thread via GitHub
snuyanzin commented on PR #25388: URL: https://github.com/apache/flink/pull/25388#issuecomment-2373541247 thanks for taking a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [FLINK-36287] Disallow UC for inner sink channels [flink]

2024-09-25 Thread via GitHub
AHeise commented on PR #25353: URL: https://github.com/apache/flink/pull/25353#issuecomment-2373541699 Addressed feedback and slimmed down PR a bit to the essentials. I have created FLINK-36368 for follow-up work. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [FLINK-36275][rest] Remove deprecated ProgramArgsQueryParameter [flink]

2024-09-25 Thread via GitHub
reswqa merged PR #25323: URL: https://github.com/apache/flink/pull/25323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Resolved] (FLINK-36275) Remove deprecated ProgramArgsQueryParameter

2024-09-25 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo resolved FLINK-36275. Fix Version/s: 2.0-preview Resolution: Done master(2.0) via f58a3e02a63b094e8c64344a7a74808

[jira] [Assigned] (FLINK-36275) Remove deprecated ProgramArgsQueryParameter

2024-09-25 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-36275: -- Assignee: Weijie Guo > Remove deprecated ProgramArgsQueryParameter >

Re: [PR] [FLINK-30614][serializer] Remove old method of resolving schema compa… [flink]

2024-09-25 Thread via GitHub
AlexYinHan commented on PR #25384: URL: https://github.com/apache/flink/pull/25384#issuecomment-2373451676 @masteryhx Thanks for the comments. I have update the docs. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] [FLINK-36325][statebackend] Implement basic restore from checkpoint for ForStStateBackend [flink]

2024-09-25 Thread via GitHub
flinkbot commented on PR #25397: URL: https://github.com/apache/flink/pull/25397#issuecomment-2373503514 ## CI report: * 28d1f2ed93431e3ec739b3f5af700dc0704accc9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-35035) Reduce job pause time when cluster resources are expanded in adaptive mode

2024-09-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-35035: -- Fix Version/s: 2.0-preview > Reduce job pause time when cluster resources are expanded in adap

Re: [PR] [FLINK-36292][Connectors/Common]: remove timeout to avoid timeout exception [flink]

2024-09-25 Thread via GitHub
showuon commented on code in PR #25371: URL: https://github.com/apache/flink/pull/25371#discussion_r1774665859 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManagerTest.java: ## @@ -71,7 +71,7 @@ public v

[jira] [Resolved] (FLINK-35035) Reduce job pause time when cluster resources are expanded in adaptive mode

2024-09-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-35035. --- Resolution: Fixed Closing this parent issue. All subtasks are addressed and the no new test

Re: [PR] [DRAFT][FLINK-36366][core] Remove deprecate API in flink-core exclude connector and state part [flink]

2024-09-25 Thread via GitHub
flinkbot commented on PR #25396: URL: https://github.com/apache/flink/pull/25396#issuecomment-2373400996 ## CI report: * 9f67d79ffaceec279e944054d51880ebb8d340cd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-36325][statebackend] Implement basic restore from checkpoint for ForStStateBackend [flink]

2024-09-25 Thread via GitHub
zoltar9264 opened a new pull request, #25397: URL: https://github.com/apache/flink/pull/25397 ## What is the purpose of the change Impletement basic restore from checkpoint in ForStStateBackend, the checkpoint implement in [FLINK-35510](https://issues.apache.org/jira/browse/FLINK-355

[jira] [Updated] (FLINK-36325) Implement basic restore from checkpoint for ForStStateBackend

2024-09-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36325: --- Labels: pull-request-available (was: ) > Implement basic restore from checkpoint for ForStS

[jira] [Commented] (FLINK-36011) Generalize RescaleManager to become StateTransitionManager

2024-09-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884537#comment-17884537 ] Matthias Pohl commented on FLINK-36011: --- master: [c869326d089705475481c2c2ea42a6e

Re: [PR] [DRAFT][FLINK-29741][scala] Remove flink-dist-scala, flink-scala, flink-streaming-scala module [flink]

2024-09-25 Thread via GitHub
reswqa commented on PR #25393: URL: https://github.com/apache/flink/pull/25393#issuecomment-2373310633 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[jira] [Created] (FLINK-36366) Remove deprecate API in flink-core exclude connector and state part

2024-09-25 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-36366: -- Summary: Remove deprecate API in flink-core exclude connector and state part Key: FLINK-36366 URL: https://issues.apache.org/jira/browse/FLINK-36366 Project: Flink

[jira] [Updated] (FLINK-36366) Remove deprecate API in flink-core exclude connector and state part

2024-09-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36366: --- Labels: pull-request-available (was: ) > Remove deprecate API in flink-core exclude connect

[PR] [DRAFT][FLINK-36366][core] Remove deprecate API in flink-core exclude connector and state part [flink]

2024-09-25 Thread via GitHub
reswqa opened a new pull request, #25396: URL: https://github.com/apache/flink/pull/25396 ## What is the purpose of the change *Remove deprecate API in flink-core exclude connector and state part* ## Verifying this change This change is a trivial rework / code cleanup

Re: [PR] [FLINK-36335][runtime] Improving Method Reusability in StreamGraphGenerator with JobVertexBuildContext [flink]

2024-09-25 Thread via GitHub
JunRuiLee commented on code in PR #25366: URL: https://github.com/apache/flink/pull/25366#discussion_r1772938079 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/graph/util/JobVertexBuildContext.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] [FLINK-36361][table] Do not use StringBuilder for EquivalentExprShuttle [flink]

2024-09-25 Thread via GitHub
snuyanzin merged PR #25388: URL: https://github.com/apache/flink/pull/25388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[jira] [Commented] (FLINK-36361) Do not use StringBuilder for EquivalentExprShuttle

2024-09-25 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884527#comment-17884527 ] Sergey Nuyanzin commented on FLINK-36361: - Merged as [0578c8e17dddc88444635e7ad

[jira] [Resolved] (FLINK-36361) Do not use StringBuilder for EquivalentExprShuttle

2024-09-25 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-36361. - Fix Version/s: 2.0-preview Resolution: Fixed > Do not use StringBuilder for Equiv

[jira] [Closed] (FLINK-36273) Remove deprecated Table/SQL configuration in 2.0

2024-09-25 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-36273. --- Assignee: xuyang Resolution: Fixed Fixed in master: 733a56682bcceabab6625b621547538c6d993976

Re: [PR] [FLINK-36273][table] Remove deprecated Table/SQL configuration in 2.0 [flink]

2024-09-25 Thread via GitHub
lincoln-lil merged PR #25334: URL: https://github.com/apache/flink/pull/25334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-36188] Fix disable buffer flush lose efficacy [flink-connector-hbase]

2024-09-25 Thread via GitHub
boring-cyborg[bot] commented on PR #49: URL: https://github.com/apache/flink-connector-hbase/pull/49#issuecomment-2373679524 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Assigned] (FLINK-36188) HBase disable buffer flush lose efficacy

2024-09-25 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Csaky reassigned FLINK-36188: Assignee: MOBIN > HBase disable buffer flush lose efficacy >

Re: [PR] [FLINK-36188] Fix disable buffer flush lose efficacy [flink-connector-hbase]

2024-09-25 Thread via GitHub
ferenc-csaky merged PR #49: URL: https://github.com/apache/flink-connector-hbase/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Closed] (FLINK-36188) HBase disable buffer flush lose efficacy

2024-09-25 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Csaky closed FLINK-36188. Resolution: Fixed [{{c6eb87f}}|https://github.com/apache/flink-connector-hbase/commit/c6eb87f809cd

[jira] [Updated] (FLINK-36188) HBase disable buffer flush lose efficacy

2024-09-25 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Csaky updated FLINK-36188: - Fix Version/s: hbase-4.0.0 > HBase disable buffer flush lose efficacy >

Re: [PR] [FLINK-35233][BP v3.0] Fix lookup cache reuse RowData object problem. [flink-connector-hbase]

2024-09-25 Thread via GitHub
ferenc-csaky merged PR #48: URL: https://github.com/apache/flink-connector-hbase/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [FLINK-36292][Connectors/Common]: remove timeout to avoid timeout exception [flink]

2024-09-25 Thread via GitHub
becketqin commented on code in PR #25371: URL: https://github.com/apache/flink/pull/25371#discussion_r1775726090 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManagerTest.java: ## @@ -71,7 +71,7 @@ public

Re: [PR] [FLINK-36292][Connectors/Common]: remove timeout to avoid timeout exception [flink]

2024-09-25 Thread via GitHub
becketqin commented on code in PR #25371: URL: https://github.com/apache/flink/pull/25371#discussion_r1775726090 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManagerTest.java: ## @@ -71,7 +71,7 @@ public

Re: [PR] [DRAFT][FLINK-36336] Remove deprecated dataset API dependency exclude table module [flink]

2024-09-25 Thread via GitHub
codenohup commented on PR #25365: URL: https://github.com/apache/flink/pull/25365#issuecomment-2374836433 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [hotfix] Fix Stale label automatically removed with no update [flink-cdc]

2024-09-25 Thread via GitHub
leonardBang merged PR #3621: URL: https://github.com/apache/flink-cdc/pull/3621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

Re: [PR] [FLINK-36273][table] Remove deprecated Table/SQL configuration in 2.0 [flink]

2024-09-25 Thread via GitHub
lincoln-lil commented on PR #25334: URL: https://github.com/apache/flink/pull/25334#issuecomment-2373644347 For 2nd commit, went over all options mentioned in https://issues.apache.org/jira/browse/FLINK-35473 All deprecated options there were remove except the occurrences in correspondi

Re: [PR] [FLINK-36369][table] Move deprecated user-visible classes in table modules to the legacy package [flink]

2024-09-25 Thread via GitHub
xuyangzhong commented on PR #25400: URL: https://github.com/apache/flink/pull/25400#issuecomment-2374388353 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[jira] [Closed] (FLINK-34702) Rank should not convert to StreamExecDuplicate when the input is not insert only

2024-09-25 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-34702. --- Fix Version/s: 2.0-preview (was: 2.0.0) Resolution: Fixed fixed in mas

Re: [PR] [FLINK-34702][table-planner] Refactor Deduplicate optimization to defer to StreamPhysicalRank for valid StreamExecDeduplicate node conversion to avoid exceptions [flink]

2024-09-25 Thread via GitHub
lincoln-lil merged PR #25380: URL: https://github.com/apache/flink/pull/25380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] FLINK-36332 Add option to select the Fabric8 httpclient implemention [flink-kubernetes-operator]

2024-09-25 Thread via GitHub
gyfora commented on code in PR #881: URL: https://github.com/apache/flink-kubernetes-operator/pull/881#discussion_r1774650443 ## .github/workflows/ci.yml: ## @@ -47,7 +48,7 @@ jobs: ${{ runner.os }}-maven- - name: Build with Maven run: | -

Re: [PR] FLINK-36332 Add option to select the Fabric8 httpclient implemention [flink-kubernetes-operator]

2024-09-25 Thread via GitHub
gyfora commented on code in PR #881: URL: https://github.com/apache/flink-kubernetes-operator/pull/881#discussion_r1774647193 ## .github/workflows/ci.yml: ## @@ -78,6 +79,7 @@ jobs: namespace: ["default","flink"] mode: ["native", "standalone"] java-ve

Re: [PR] 【update】Add new operator config "savepoint-create-subdir" to allow user to configure whether to create sub-directories named by job id under the 'state.savepoints.dir' [flink-kubernetes-opera

2024-09-25 Thread via GitHub
gyfora commented on PR #882: URL: https://github.com/apache/flink-kubernetes-operator/pull/882#issuecomment-2373230412 Hi @xieyang1994 ! New features need a JIRA first and the PR should be opened against main in any case unless we are back porting a bug fix to one of the supported re

Re: [PR] [FLINK-36335][runtime] Improving Method Reusability in StreamGraphGenerator with JobVertexBuildContext [flink]

2024-09-25 Thread via GitHub
noorall commented on code in PR #25366: URL: https://github.com/apache/flink/pull/25366#discussion_r1774908113 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java: ## @@ -593,15 +616,22 @@ private Map buildChainedInputsAndGetHeadI

Re: [PR] [FLINK-36335][runtime] Improving Method Reusability in StreamGraphGenerator with JobVertexBuildContext [flink]

2024-09-25 Thread via GitHub
noorall commented on PR #25366: URL: https://github.com/apache/flink/pull/25366#issuecomment-2373601784 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-36109) Improve FlinkStateSnapshot resource labels for efficient filtering

2024-09-25 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884626#comment-17884626 ] Gyula Fora commented on FLINK-36109: I think adding these labels makes sense for now

Re: [PR] [FLINK-34876][transform] Support UDF functions in transform [flink-cdc]

2024-09-25 Thread via GitHub
yuxiqian commented on PR #3465: URL: https://github.com/apache/flink-cdc/pull/3465#issuecomment-2374215861 Hi @mamineturki, `flink-cdc-pipeline-udf-examples` are for testing purposes only. If you'd like to test it, using `org.apache.flink.cdc.udf.examples.scala.AddOneFunctionClass` should w

Re: [PR] [FLINK-34876][transform] Support UDF functions in transform [flink-cdc]

2024-09-25 Thread via GitHub
mamineturki commented on PR #3465: URL: https://github.com/apache/flink-cdc/pull/3465#issuecomment-2374187978 @yuxiqian Hi, I have been trying to run an example with this new feature but I always get `java.lang.ClassNotFoundException: org.example.udf.AddOneFunctionClass` I tried load

Re: [PR] [FLINK-34876][transform] Support UDF functions in transform [flink-cdc]

2024-09-25 Thread via GitHub
mamineturki commented on PR #3465: URL: https://github.com/apache/flink-cdc/pull/3465#issuecomment-2374243091 Thanks for the speedy reply @yuxiqian . moving the jar to `Flink lib` did not help. passing the jar with `--jar` caused the `Flink-cdc.sh` command to get stuck with no logs, and no

Re: [PR] [FLINK-34876][transform] Support UDF functions in transform [flink-cdc]

2024-09-25 Thread via GitHub
mamineturki commented on PR #3465: URL: https://github.com/apache/flink-cdc/pull/3465#issuecomment-2374250013 Thanks for the speedy response @yuxiqian . passing the jar using `--jar` worked for me. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] [FLINK-36369][table] Move deprecated user-visible classes in table modules to the legacy package [flink]

2024-09-25 Thread via GitHub
flinkbot commented on PR #25400: URL: https://github.com/apache/flink/pull/25400#issuecomment-2374256737 ## CI report: * 259abc16084da0205bae73b37033c29ecb079b29 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-36370) Flink 1.18 fails with Empty server certificate chain when High Availability and mTLS both enabled

2024-09-25 Thread Aniruddh J (Jira)
Aniruddh J created FLINK-36370: -- Summary: Flink 1.18 fails with Empty server certificate chain when High Availability and mTLS both enabled Key: FLINK-36370 URL: https://issues.apache.org/jira/browse/FLINK-36370

[jira] [Updated] (FLINK-36370) Flink 1.18 fails with Empty server certificate chain when High Availability and mTLS both enabled

2024-09-25 Thread Aniruddh J (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aniruddh J updated FLINK-36370: --- Attachment: flink-cert-issue.log Description: Hi, in my kubernetes cluster I have flink-kuberne

[jira] [Updated] (FLINK-36371) Field BinaryStringData as keySelector would lead the same records hash shuffle into different tumble windows

2024-09-25 Thread Eason Ye (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eason Ye updated FLINK-36371: - Description: The pipeline is Source(Kafka serialize msg to RowData type) -> FlatMap --(keyby)–> TumbleP

[jira] [Created] (FLINK-36371) Field BinaryStringData as keySelector would lead the same records hash shuffle into different tumble windows

2024-09-25 Thread Eason Ye (Jira)
Eason Ye created FLINK-36371: Summary: Field BinaryStringData as keySelector would lead the same records hash shuffle into different tumble windows Key: FLINK-36371 URL: https://issues.apache.org/jira/browse/FLINK-363

[jira] [Updated] (FLINK-36371) Field BinaryStringData as keySelector would lead the same records hash shuffle into different tumble windows

2024-09-25 Thread Eason Ye (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eason Ye updated FLINK-36371: - Description: The pipeline is Source(Kafka serialize msg to RowData type) -> FlatMap --(keyby)–> TumbleP

Re: [PR] [FLINK-36369][table] Move deprecated user-visible classes in table modules to the legacy package [flink]

2024-09-25 Thread via GitHub
xuyangzhong commented on PR #25400: URL: https://github.com/apache/flink/pull/25400#issuecomment-2374330934 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[jira] [Updated] (FLINK-36370) Flink 1.18 fails with Empty server certificate chain when High Availability and mTLS both enabled

2024-09-25 Thread Aniruddh J (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aniruddh J updated FLINK-36370: --- Priority: Major (was: Minor) > Flink 1.18 fails with Empty server certificate chain when High Avail

Re: [PR] [DRAFT][FLINK-29741][scala] Remove flink-dist-scala, flink-scala, flink-streaming-scala module [flink]

2024-09-25 Thread via GitHub
codenohup commented on PR #25393: URL: https://github.com/apache/flink/pull/25393#issuecomment-2373796766 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33977][runtime] Adaptive scheduler may not minimize the number of TMs during downscaling [flink]

2024-09-25 Thread via GitHub
RocMarshal commented on code in PR #25218: URL: https://github.com/apache/flink/pull/25218#discussion_r1775043513 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/DefaultSlotAssigner.java: ## @@ -43,35 +47,43 @@ public Collection assignSlots(

  1   2   >