[PR] [FLINK-35776] Simplify job status handling [flink-kubernetes-operator]

2024-07-07 Thread via GitHub
gyfora opened a new pull request, #851: URL: https://github.com/apache/flink-kubernetes-operator/pull/851 ## What is the purpose of the change There is a fairly complicated listing / observe logic for jobs currently that is no longer necessary as we have a stable logic to always recor

[jira] [Updated] (FLINK-35776) Simplify job observe logic

2024-07-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35776: --- Labels: pull-request-available (was: ) > Simplify job observe logic > -

[jira] [Created] (FLINK-35777) Observe session jobs during cleanup

2024-07-07 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-35777: -- Summary: Observe session jobs during cleanup Key: FLINK-35777 URL: https://issues.apache.org/jira/browse/FLINK-35777 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-35624) Release Testing: Verify FLIP-306 Unified File Merging Mechanism for Checkpoints

2024-07-07 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863545#comment-17863545 ] Zakelly Lan commented on FLINK-35624: - Thanks [~fanrui] ! I think it is related with

[jira] [Created] (FLINK-35778) Escape URI reserved characters when creating file-merging directories

2024-07-07 Thread Zakelly Lan (Jira)
Zakelly Lan created FLINK-35778: --- Summary: Escape URI reserved characters when creating file-merging directories Key: FLINK-35778 URL: https://issues.apache.org/jira/browse/FLINK-35778 Project: Flink

[jira] [Updated] (FLINK-35778) Escape URI reserved characters when creating file-merging directories

2024-07-07 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan updated FLINK-35778: Priority: Blocker (was: Major) > Escape URI reserved characters when creating file-merging direct

[PR] [FLINK-35778] Escape URI reserved characters when creating file-merging directories [flink]

2024-07-07 Thread via GitHub
Zakelly opened a new pull request, #25030: URL: https://github.com/apache/flink/pull/25030 ## What is the purpose of the change Currently, the file-merging manager for checkpoint files will create directories based on tm resource id, job id and operator ids. While in some cases, thes

[jira] [Updated] (FLINK-35778) Escape URI reserved characters when creating file-merging directories

2024-07-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35778: --- Labels: pull-request-available (was: ) > Escape URI reserved characters when creating file-

Re: [PR] [FLINK-35778] Escape URI reserved characters when creating file-merging directories [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25030: URL: https://github.com/apache/flink/pull/25030#issuecomment-2212368322 ## CI report: * 7e0567cd69b36759b378a88f9cf3693060f30f5e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [BP-1.20][FLINK-35778] Escape URI reserved characters when creating file-merging directories [flink]

2024-07-07 Thread via GitHub
Zakelly opened a new pull request, #25031: URL: https://github.com/apache/flink/pull/25031 ## What is the purpose of the change Currently, the file-merging manager for checkpoint files will create directories based on tm resource id, job id and operator ids. While in some cases, thes

Re: [PR] [BP-1.20][FLINK-35778] Escape URI reserved characters when creating file-merging directories [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25031: URL: https://github.com/apache/flink/pull/25031#issuecomment-2212370332 ## CI report: * b47550e43a1d71c35c476ce69fbbb26bec549e68 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35126] Rework default checkpoint progress check window [flink-kubernetes-operator]

2024-07-07 Thread via GitHub
gyfora commented on code in PR #850: URL: https://github.com/apache/flink-kubernetes-operator/pull/850#discussion_r1667639016 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/ClusterHealthEvaluator.java: ## @@ -178,30 +178,46 @@ private b

Re: [PR] [FLINK-35265] Implement FlinkStateSnapshot custom resource [flink-kubernetes-operator]

2024-07-07 Thread via GitHub
gyfora commented on PR #821: URL: https://github.com/apache/flink-kubernetes-operator/pull/821#issuecomment-2212378196 A small addition to the previous comments. The SnapshotObserver currently also observes and updates the lastSavepointInfo for terminal jobs. This is a key mechanism to be

Re: [PR] [FLINK-35265] Implement FlinkStateSnapshot custom resource [flink-kubernetes-operator]

2024-07-07 Thread via GitHub
gyfora commented on code in PR #821: URL: https://github.com/apache/flink-kubernetes-operator/pull/821#discussion_r1667645251 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java: ## @@ -266,19 +304,31

[PR] [FLINK-33192] Fix Memory Leak in WindowOperator due to Improper Timer Cleanup [flink]

2024-07-07 Thread via GitHub
kartikeypant opened a new pull request, #25032: URL: https://github.com/apache/flink/pull/25032 ## What is the purpose of the change * This Pull Request addresses an important state memory leak issue identified within the default window operator of Apache Flink. * After this change, t

Re: [PR] [FLINK-33192] Fix Memory Leak in WindowOperator due to Improper Timer Cleanup [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25032: URL: https://github.com/apache/flink/pull/25032#issuecomment-2212419439 ## CI report: * 7a901d8684e59a19dddb7db926adc89c3ca30ead UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35265] Implement FlinkStateSnapshot custom resource [flink-kubernetes-operator]

2024-07-07 Thread via GitHub
mateczagany commented on code in PR #821: URL: https://github.com/apache/flink-kubernetes-operator/pull/821#discussion_r1667680584 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/snapshot/StateSnapshotReconciler.java: ## @@ -0,0 +1,235

Re: [PR] [FLINK-35265] Implement FlinkStateSnapshot custom resource [flink-kubernetes-operator]

2024-07-07 Thread via GitHub
mateczagany commented on code in PR #821: URL: https://github.com/apache/flink-kubernetes-operator/pull/821#discussion_r1667680584 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/snapshot/StateSnapshotReconciler.java: ## @@ -0,0 +1,235

Re: [PR] [BP-1.19] [FLINK-33192] Fix Memory Leak in WindowOperator due to Improper Timer Cleanup [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25033: URL: https://github.com/apache/flink/pull/25033#issuecomment-2212437163 ## CI report: * d65b869026b08f322bb719516d3dac76da8f1b32 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [BP-1.20] [FLINK-33192] Fix Memory Leak in WindowOperator due to Improper Timer Cleanup [flink]

2024-07-07 Thread via GitHub
kartikeypant opened a new pull request, #25034: URL: https://github.com/apache/flink/pull/25034 1.20 backport for parent PR https://github.com/apache/flink/pull/24917 --- ## What is the purpose of the change * This Pull Request addresses an important state memory leak issue

Re: [PR] [BP-1.20] [FLINK-33192] Fix Memory Leak in WindowOperator due to Improper Timer Cleanup [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25034: URL: https://github.com/apache/flink/pull/25034#issuecomment-2212439134 ## CI report: * e1f98fb556f5e6a4392c65a2bb67ef577a28232a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-07-07 Thread via GitHub
FangYongs commented on PR #25012: URL: https://github.com/apache/flink/pull/25012#issuecomment-2212441328 Thanks @HuangZhenQiu , +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-07-07 Thread via GitHub
FangYongs merged PR #25012: URL: https://github.com/apache/flink/pull/25012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [docs][minor] Fix typo in log message: "oder" to "order" [flink-cdc]

2024-07-07 Thread via GitHub
Karl-WangSK commented on PR #3451: URL: https://github.com/apache/flink-cdc/pull/3451#issuecomment-2212443087 CI shows that NewlyAddedTableITCase.testNewlyAddedTableForExistsPipelineThrice failed, but I tested locally,it shows success. can trigger the CI again? -- This is an automated m

Re: [PR] [FLINK-35265] Implement FlinkStateSnapshot custom resource [flink-kubernetes-operator]

2024-07-07 Thread via GitHub
mateczagany commented on code in PR #821: URL: https://github.com/apache/flink-kubernetes-operator/pull/821#discussion_r1667707042 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java: ## @@ -266,19 +30

[jira] [Created] (FLINK-35779) Update documentation for PubSubSinkV2

2024-07-07 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35779: --- Summary: Update documentation for PubSubSinkV2 Key: FLINK-35779 URL: https://issues.apache.org/jira/browse/FLINK-35779 Project: Flink Issue Type: Sub-task

[PR] [FLINK-35779][Connectors/Google PubSub] Update documentation for PubSubSinkV2 [flink-connector-gcp-pubsub]

2024-07-07 Thread via GitHub
vahmed-hamdy opened a new pull request, #29: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/29 ## Description Update PubSub documentation to include `PubSubSinkV2` changes ## Testing - This is a documentation change and need no additional testing -- This is an

Re: [PR] [FLINK-35779][Connectors/Google PubSub] Update documentation for PubSubSinkV2 [flink-connector-gcp-pubsub]

2024-07-07 Thread via GitHub
vahmed-hamdy commented on PR #29: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/29#issuecomment-2212482167 @snuyanzin could you please take a look at this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Updated] (FLINK-35779) Update documentation for PubSubSinkV2

2024-07-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35779: --- Labels: pull-request-available (was: ) > Update documentation for PubSubSinkV2 > --

[jira] [Created] (FLINK-35780) Support state migration from disabling to enabling ttl in RocksDBState

2024-07-07 Thread xiangyu feng (Jira)
xiangyu feng created FLINK-35780: Summary: Support state migration from disabling to enabling ttl in RocksDBState Key: FLINK-35780 URL: https://issues.apache.org/jira/browse/FLINK-35780 Project: Flink

[PR] [WIP][FLINK-35780] Support state migration from disabling to enabling ttl for RocksDBState [flink]

2024-07-07 Thread via GitHub
xiangyuf opened a new pull request, #25035: URL: https://github.com/apache/flink/pull/25035 [FLINK-35780][state] Support state migration from disabling to enabling ttl in RocksDBState ## What is the purpose of the change *(For example: This pull request makes task deployment go

[jira] [Updated] (FLINK-35780) Support state migration from disabling to enabling ttl in RocksDBState

2024-07-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35780: --- Labels: pull-request-available (was: ) > Support state migration from disabling to enabling

Re: [PR] [WIP][FLINK-35780] Support state migration from disabling to enabling ttl for RocksDBState [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25035: URL: https://github.com/apache/flink/pull/25035#issuecomment-2212509210 ## CI report: * 55b44e1f22d3443912f6a9c150b8b22cdd9ed525 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [BP-1.18] [FLINK-33192] Fix Memory Leak in WindowOperator due to Improper Timer Cleanup [flink]

2024-07-07 Thread via GitHub
kartikeypant commented on PR #25032: URL: https://github.com/apache/flink/pull/25032#issuecomment-2212518819 @flinkbot - run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [FLINK-35265] Implement FlinkStateSnapshot custom resource [flink-kubernetes-operator]

2024-07-07 Thread via GitHub
gyfora commented on code in PR #821: URL: https://github.com/apache/flink-kubernetes-operator/pull/821#discussion_r1667757174 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java: ## @@ -266,19 +304,31

[PR] [FLINK-35016] catalog changes for model resource [flink]

2024-07-07 Thread via GitHub
lihaosky opened a new pull request, #25036: URL: https://github.com/apache/flink/pull/25036 ## What is the purpose of the change Catalog changes to support model resource ## Brief change log * Add `CatalogModel` related resource * Add model CRUD operations in `Cata

[jira] [Updated] (FLINK-35016) Catalog changes for model CRUD

2024-07-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35016: --- Labels: pull-request-available (was: ) > Catalog changes for model CRUD > -

Re: [PR] [FLINK-35016] catalog changes for model resource [flink]

2024-07-07 Thread via GitHub
lihaosky commented on PR #25036: URL: https://github.com/apache/flink/pull/25036#issuecomment-2212606448 cc @twalthr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [FLINK-35016] catalog changes for model resource [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25036: URL: https://github.com/apache/flink/pull/25036#issuecomment-2212607683 ## CI report: * dd6632371c5404780ab79e7ed308db46c6152154 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35750][runtime/metrics] Fix that the latency marker metrics ar… [flink]

2024-07-07 Thread via GitHub
RocMarshal opened a new pull request, #25037: URL: https://github.com/apache/flink/pull/25037 …en't updated after failover. (cherry picked from commit 615d19735b0691b57262a110e6078c3488349f5a) ## What is the purpose of the change BP for 1.17 of https://github.com/

[PR] [FLINK-35750][runtime/metrics] Fix that the latency marker metrics aren't updated after failover. [flink]

2024-07-07 Thread via GitHub
RocMarshal opened a new pull request, #25038: URL: https://github.com/apache/flink/pull/25038 (cherry picked from commit 615d19735b0691b57262a110e6078c3488349f5a) ## What is the purpose of the change BP for 1.18 of https://github.com/apache/flink/pull/25021 -- This is

[PR] [FLINK-35750][runtime/metrics] Fix that the latency marker metrics aren't updated after failover. [flink]

2024-07-07 Thread via GitHub
RocMarshal opened a new pull request, #25039: URL: https://github.com/apache/flink/pull/25039 (cherry picked from commit 615d19735b0691b57262a110e6078c3488349f5a) ## What is the purpose of the change BP for 1.19 of https://github.com/apache/flink/pull/25021 -- This is

[PR] [FLINK-35750][runtime/metrics] Fix that the latency marker metrics aren't updated after failover. [flink]

2024-07-07 Thread via GitHub
RocMarshal opened a new pull request, #25040: URL: https://github.com/apache/flink/pull/25040 (cherry picked from commit 615d19735b0691b57262a110e6078c3488349f5a) ## What is the purpose of the change BP for 1.20 of https://github.com/apache/flink/pull/25021 --

Re: [PR] [FLINK-35750][runtime/metrics] Fix that the latency marker metrics aren't updated after failover. [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25037: URL: https://github.com/apache/flink/pull/25037#issuecomment-221297 ## CI report: * 1300c054a1ffa88c18f4c6c28a154207ce12bf98 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35750][runtime/metrics] Fix that the latency marker metrics aren't updated after failover. [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25038: URL: https://github.com/apache/flink/pull/25038#issuecomment-2212777977 ## CI report: * 8cb40a599c1e127b5f427be710f4a840c7fa4ca1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35750][runtime/metrics] Fix that the latency marker metrics aren't updated after failover. [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25039: URL: https://github.com/apache/flink/pull/25039#issuecomment-2212781383 ## CI report: * f1c40d72af10e7ba07304c018cdd2588a07bf395 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35750][runtime/metrics] Fix that the latency marker metrics aren't updated after failover. [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25040: URL: https://github.com/apache/flink/pull/25040#issuecomment-2212781614 ## CI report: * 7f1b9491efa0ce3bb7a4815732d9ff10a82056bb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35778] Escape URI reserved characters when creating file-merging directories [flink]

2024-07-07 Thread via GitHub
1996fanrui commented on code in PR #25030: URL: https://github.com/apache/flink/pull/25030#discussion_r1667861271 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -773,6 +773,13 @@ static boolean shouldSyn

[jira] [Created] (FLINK-35781) Make pipeline parallelism config optional

2024-07-07 Thread yux (Jira)
yux created FLINK-35781: --- Summary: Make pipeline parallelism config optional Key: FLINK-35781 URL: https://issues.apache.org/jira/browse/FLINK-35781 Project: Flink Issue Type: Improvement Com

Re: [PR] [BP-1.18] [FLINK-33192] Fix Memory Leak in WindowOperator due to Improper Timer Cleanup [flink]

2024-07-07 Thread via GitHub
fredia merged PR #25032: URL: https://github.com/apache/flink/pull/25032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [BP-1.18] [FLINK-33192] Fix Memory Leak in WindowOperator due to Improper Timer Cleanup [flink]

2024-07-07 Thread via GitHub
fredia commented on PR #25032: URL: https://github.com/apache/flink/pull/25032#issuecomment-2212848554 @kartikeypant Thanks for the PR, LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [FLINK-35781][cli] Provide a default parallelism (1) for pipeline jobs [flink-cdc]

2024-07-07 Thread via GitHub
yuxiqian commented on PR #3458: URL: https://github.com/apache/flink-cdc/pull/3458#issuecomment-2212862904 @ruanhang1993 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-35781) Make pipeline parallelism config optional

2024-07-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35781: --- Labels: pull-request-available (was: ) > Make pipeline parallelism config optional > --

[jira] [Commented] (FLINK-35345) FLIP-448: Introduce Pluggable Workflow Scheduler Interface for Materialized Table

2024-07-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863643#comment-17863643 ] Rui Fan commented on FLINK-35345: - Hi [~lsy] [~hackergin] , I saw FLINK-35187 has the re

[PR] [hotfix][doc] missing "STATISTICS" sql reserved keyword in zh doc [flink]

2024-07-07 Thread via GitHub
showuon opened a new pull request, #25041: URL: https://github.com/apache/flink/pull/25041 ## What is the purpose of the change In [FLINK-28493](https://github.com/apache/flink/pull/20506/), we implemented "ANALYZE TABLE" syntax feature and documented the reserved keyword: **

[jira] [Commented] (FLINK-35345) FLIP-448: Introduce Pluggable Workflow Scheduler Interface for Materialized Table

2024-07-07 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863644#comment-17863644 ] Feng Jin commented on FLINK-35345: -- [~fanrui]   This is mainly for use by FLINK-35187 a

Re: [PR] [hotfix][doc] missing "STATISTICS" sql reserved keyword in zh doc [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25041: URL: https://github.com/apache/flink/pull/25041#issuecomment-2212873141 ## CI report: * aa4b31c68b9831a2e78bfff7d976e2b32dd229bb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-35345) FLIP-448: Introduce Pluggable Workflow Scheduler Interface for Materialized Table

2024-07-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863645#comment-17863645 ] Rui Fan commented on FLINK-35345: - thanks [~hackergin] for the quick feedback! :) > FLI

Re: [PR] [FLINK-35737] Prevent Memory Leak by Closing MemoryExecutionGraphInfoStore on MiniCluster Shutdown [flink]

2024-07-07 Thread via GitHub
fengjiajie commented on PR #25009: URL: https://github.com/apache/flink/pull/25009#issuecomment-2212880693 Could you please take a look when you have time? @Samrat002 @1996fanrui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[jira] [Commented] (FLINK-35533) FLIP-459: Support Flink hybrid shuffle integration with Apache Celeborn

2024-07-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863648#comment-17863648 ] Rui Fan commented on FLINK-35533: - Hi [~tanyuxin] [~Weijie Guo] , may I know do we need

[jira] [Commented] (FLINK-35137) Release flink-connector-jdbc v3.2.0 for Flink 1.19

2024-07-07 Thread He Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863653#comment-17863653 ] He Wang commented on FLINK-35137: - [~dannycranmer]  Sorry I didn't make it clear, I was

Re: [PR] [FLINK-35778] Escape URI reserved characters when creating file-merging directories [flink]

2024-07-07 Thread via GitHub
Zakelly commented on code in PR #25030: URL: https://github.com/apache/flink/pull/25030#discussion_r1667911678 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -773,6 +773,13 @@ static boolean shouldSyncAf

Re: [PR] [FLINK-35750][runtime/metrics] Fix that the latency marker metrics aren't updated after failover. [flink]

2024-07-07 Thread via GitHub
RocMarshal commented on PR #25038: URL: https://github.com/apache/flink/pull/25038#issuecomment-2212931466 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[PR] [hotfix] Fix the broken link of standalone deployment [flink]

2024-07-07 Thread via GitHub
Zakelly opened a new pull request, #25042: URL: https://github.com/apache/flink/pull/25042 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[PR] [BP-1.20][hotfix] Fix the broken link of standalone deployment [flink]

2024-07-07 Thread via GitHub
Zakelly opened a new pull request, #25043: URL: https://github.com/apache/flink/pull/25043 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] [hotfix] Fix the broken link of standalone deployment [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25042: URL: https://github.com/apache/flink/pull/25042#issuecomment-2212952936 ## CI report: * b334fec2d8479c8e9e30928fc3fd6e6fa3f8f296 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [BP-1.19][hotfix] Fix the broken link of standalone deployment [flink]

2024-07-07 Thread via GitHub
Zakelly opened a new pull request, #25044: URL: https://github.com/apache/flink/pull/25044 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] [BP-1.20][hotfix] Fix the broken link of standalone deployment [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25043: URL: https://github.com/apache/flink/pull/25043#issuecomment-2212960152 ## CI report: * 3639c3545b47b7a06562c3deb316a11dccf3c885 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix] Fix the broken link of standalone deployment [flink]

2024-07-07 Thread via GitHub
Zakelly opened a new pull request, #25045: URL: https://github.com/apache/flink/pull/25045 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] [BP-1.19][hotfix][doc] Fix the broken link of standalone deployment [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25044: URL: https://github.com/apache/flink/pull/25044#issuecomment-2212968492 ## CI report: * aa3002c4d9433402793d85bccbba3d0768c1761a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [BP-1.18][hotfix][doc] Fix the broken link of standalone deployment [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25045: URL: https://github.com/apache/flink/pull/25045#issuecomment-2212968868 ## CI report: * 9dc582bf8e0ed6e19306431c9a71542bb238784b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [BP-1.18] [FLINK-33192] Fix Memory Leak in WindowOperator due to Improper Timer Cleanup [flink]

2024-07-07 Thread via GitHub
kartikeypant commented on PR #25032: URL: https://github.com/apache/flink/pull/25032#issuecomment-2213000911 Thanks for the merge, @fredia. I have also created backport PRs for 1.19 (https://github.com/apache/flink/pull/25033) and 1.20 versions (https://github.com/apache/flink/pull/25034),

[jira] [Commented] (FLINK-35753) ParquetColumnarRowInputFormatTest.testContinuousRepetition(int) failed due to ArrayIndexOutOfBoundsException

2024-07-07 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863669#comment-17863669 ] Jingsong Lee commented on FLINK-35753: -- CC [~stephenwoo]  > ParquetColumnarRowInpu

Re: [PR] [BP-1.17][FLINK-35750][runtime/metrics] Fix that the latency marker metrics aren't updated after failover. [flink]

2024-07-07 Thread via GitHub
RocMarshal commented on PR #25037: URL: https://github.com/apache/flink/pull/25037#issuecomment-2213100328 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [BP-1.18][FLINK-35750][runtime/metrics] Fix that the latency marker metrics aren't updated after failover. [flink]

2024-07-07 Thread via GitHub
RocMarshal commented on PR #25038: URL: https://github.com/apache/flink/pull/25038#issuecomment-2213100224 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [BP-1.19][FLINK-35731][runtime] Fix incorrect parallelism configured detection for Sink V2. [flink]

2024-07-07 Thread via GitHub
zhuzhurk merged PR #25024: URL: https://github.com/apache/flink/pull/25024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Closed] (FLINK-35731) Sink V2 operator is mistakenly assumed always to be parallelism configured

2024-07-07 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-35731. --- Fix Version/s: 1.20.0 1.19.2 Resolution: Fixed 1.20: 2b3a47d98bf06ffde3d6d7c850414

[jira] [Assigned] (FLINK-35781) Make pipeline parallelism config optional

2024-07-07 Thread Ruan Hang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruan Hang reassigned FLINK-35781: - Assignee: yux > Make pipeline parallelism config optional > ---

Re: [PR] [FLINK-35713][cdc-compose] Add sink PARALLELISM for flink-cdc. [flink-cdc]

2024-07-07 Thread via GitHub
yuxiqian commented on code in PR #3438: URL: https://github.com/apache/flink-cdc/pull/3438#discussion_r1668075424 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/pipeline/PipelineOptions.java: ## Review Comment: In the future, defining multiple sink in one sin

[jira] [Updated] (FLINK-35713) Add sink PARALLELISM for flink-cdc

2024-07-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35713: --- Labels: pull-request-available (was: ) > Add sink PARALLELISM for flink-cdc > -

Re: [PR] [FLINK-34572] Support OceanBase Jdbc Catalog [flink-connector-jdbc]

2024-07-07 Thread via GitHub
whhe commented on code in PR #109: URL: https://github.com/apache/flink-connector-jdbc/pull/109#discussion_r1668077202 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalogUtils.java: ## @@ -82,6 +84,14 @@ public static AbstractJdbcCatalog cr

Re: [PR] [FLINK-35781][cli] Provide a default parallelism (1) for pipeline jobs [flink-cdc]

2024-07-07 Thread via GitHub
ruanhang1993 commented on code in PR #3458: URL: https://github.com/apache/flink-cdc/pull/3458#discussion_r1668081572 ## docs/content.zh/docs/core-concept/data-pipeline.md: ## @@ -98,5 +98,5 @@ The following config options of Data Pipeline level are supported: | parameter

Re: [PR] [FLINK-35781][cli] Provide a default parallelism (1) for pipeline jobs [flink-cdc]

2024-07-07 Thread via GitHub
ruanhang1993 commented on code in PR #3458: URL: https://github.com/apache/flink-cdc/pull/3458#discussion_r1668081572 ## docs/content.zh/docs/core-concept/data-pipeline.md: ## @@ -98,5 +98,5 @@ The following config options of Data Pipeline level are supported: | parameter

Re: [PR] [FLINK-34572] Support OceanBase Jdbc Catalog [flink-connector-jdbc]

2024-07-07 Thread via GitHub
whhe commented on code in PR #109: URL: https://github.com/apache/flink-connector-jdbc/pull/109#discussion_r1668082863 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/oceanbase/catalog/OceanBaseTypeMapper.java: ## @@ -0,0 +1,167 @@ +/* + * Licens

[jira] [Updated] (FLINK-35665) Release Testing: FLIP-441: Show the JobType and remove Execution Mode on Flink WebUI

2024-07-07 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan updated FLINK-35665: Attachment: image-2024-07-08-14-51-11-241.png > Release Testing: FLIP-441: Show the JobType and r

[jira] [Updated] (FLINK-35665) Release Testing: FLIP-441: Show the JobType and remove Execution Mode on Flink WebUI

2024-07-07 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan updated FLINK-35665: Attachment: image-2024-07-08-14-51-35-796.png > Release Testing: FLIP-441: Show the JobType and r

[jira] [Updated] (FLINK-35665) Release Testing: FLIP-441: Show the JobType and remove Execution Mode on Flink WebUI

2024-07-07 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan updated FLINK-35665: Attachment: image-2024-07-08-14-52-32-778.png > Release Testing: FLIP-441: Show the JobType and r

Re: [PR] [FLINK-35713][cdc-compose] Add sink PARALLELISM for flink-cdc. [flink-cdc]

2024-07-07 Thread via GitHub
proletarians commented on code in PR #3438: URL: https://github.com/apache/flink-cdc/pull/3438#discussion_r1668085508 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/pipeline/PipelineOptions.java: ## Review Comment: Got it! I will follow up on this. -- Thi

[jira] [Commented] (FLINK-35665) Release Testing: FLIP-441: Show the JobType and remove Execution Mode on Flink WebUI

2024-07-07 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863677#comment-17863677 ] Zakelly Lan commented on FLINK-35665: - Verified via: # Download flink-1.20-rc0 from

[jira] [Resolved] (FLINK-35665) Release Testing: FLIP-441: Show the JobType and remove Execution Mode on Flink WebUI

2024-07-07 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan resolved FLINK-35665. - Resolution: Fixed > Release Testing: FLIP-441: Show the JobType and remove Execution Mode on >