[jira] [Commented] (FLINK-35157) Sources with watermark alignment get stuck once some subtasks finish

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854901#comment-17854901 ] Rui Fan commented on FLINK-35157: - Merged to master(1.20.0) via: 93b9bdf798aec933122bdee

[jira] [Commented] (FLINK-35157) Sources with watermark alignment get stuck once some subtasks finish

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854902#comment-17854902 ] Rui Fan commented on FLINK-35157: - Hi [~elon] , would you mind backporting this fix to 1

[jira] [Updated] (FLINK-35157) Sources with watermark alignment get stuck once some subtasks finish

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-35157: Fix Version/s: 1.20.0 > Sources with watermark alignment get stuck once some subtasks finish > ---

[jira] [Created] (FLINK-35597) Fix unstable LocatableSplitAssignerTest#testConcurrentSplitAssignmentForMultipleHosts

2024-06-13 Thread Yubin Li (Jira)
Yubin Li created FLINK-35597: Summary: Fix unstable LocatableSplitAssignerTest#testConcurrentSplitAssignmentForMultipleHosts Key: FLINK-35597 URL: https://issues.apache.org/jira/browse/FLINK-35597 Project

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-13 Thread via GitHub
1996fanrui commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1639106337 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -93,16 +90,18 @@ spec: ``` {{< hint info >}} -When using the operator with Flink nat

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-13 Thread via GitHub
1996fanrui commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1639106337 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -93,16 +90,18 @@ spec: ``` {{< hint info >}} -When using the operator with Flink nat

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-13 Thread via GitHub
1996fanrui commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1639108031 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -125,4 +124,4 @@ arr1: [{name: a, p2: v2}, {name: c, p2: v2}] merged: [{name: a, p1: v1

Re: [PR] [FLINK-35121][common] Adds validation for pipeline definition options [flink-cdc]

2024-06-13 Thread via GitHub
Jiabao-Sun commented on code in PR #3382: URL: https://github.com/apache/flink-cdc/pull/3382#discussion_r1639108698 ## flink-cdc-composer/src/test/java/org/apache/flink/cdc/composer/definition/PipelineValidationTest.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Softwa

[PR] [FLINK-35597][test] Fix unstable LocatableSplitAssignerTest#testConcurrentSplitAssignmentForMultipleHosts [flink]

2024-06-13 Thread via GitHub
liyubin117 opened a new pull request, #24936: URL: https://github.com/apache/flink/pull/24936 ## Brief change log * it should be ia.getNumberOfLocalAssignments() as before -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Updated] (FLINK-35597) Fix unstable LocatableSplitAssignerTest#testConcurrentSplitAssignmentForMultipleHosts

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35597: --- Labels: pull-request-available (was: ) > Fix unstable > LocatableSplitAssignerTest#testCon

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-06-13 Thread via GitHub
HuangXingBo commented on PR #24426: URL: https://github.com/apache/flink/pull/24426#issuecomment-2167064115 Thanks @morazow for the update. I downloaded the wheel package and found that the wheel package after repair is manylinux_2_5. It may be related to not using `dev/glibc_version_fix.

Re: [PR] [FLINK-33461][Connector/JDBC] Support streaming related semantics for the new JDBC source [flink-connector-jdbc]

2024-06-13 Thread via GitHub
1996fanrui merged PR #119: URL: https://github.com/apache/flink-connector-jdbc/pull/119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-06-13 Thread via GitHub
HuangXingBo commented on code in PR #24426: URL: https://github.com/apache/flink/pull/24426#discussion_r1639115041 ## .github/workflows/nightly.yml: ## @@ -28,69 +28,131 @@ jobs: name: "Pre-compile Checks" uses: ./.github/workflows/template.pre-compile-checks.yml -

[jira] [Resolved] (FLINK-33462) Sort out the document page about the new Jdbc source.

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-33462. - Resolution: Fixed > Sort out the document page about the new Jdbc source. >

[jira] [Commented] (FLINK-33462) Sort out the document page about the new Jdbc source.

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854905#comment-17854905 ] Rui Fan commented on FLINK-33462: - Merged to main(jdbc-3.3.0) via 1bab53304c65384b4fbe6a

[jira] [Updated] (FLINK-33462) Sort out the document page about the new Jdbc source.

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33462: Fix Version/s: jdbc-3.3.0 > Sort out the document page about the new Jdbc source. > --

[jira] [Resolved] (FLINK-33461) Support streaming related semantics for the new JDBC source

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-33461. - Fix Version/s: jdbc-3.3.0 Resolution: Fixed > Support streaming related semantics for the new JDB

[jira] [Commented] (FLINK-33461) Support streaming related semantics for the new JDBC source

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854906#comment-17854906 ] Rui Fan commented on FLINK-33461: - Merged to main(jdbc-3.3.0) via 190238a05bebe9a092e9ce

Re: [PR] [FLINK-35597][test] Fix unstable LocatableSplitAssignerTest#testConcurrentSplitAssignmentForMultipleHosts [flink]

2024-06-13 Thread via GitHub
flinkbot commented on PR #24936: URL: https://github.com/apache/flink/pull/24936#issuecomment-2167073330 ## CI report: * 971edbe445dc16987a149bda399cf235f2ed5554 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Assigned] (FLINK-35591) Azure Pipelines not running for master since c9def981

2024-06-13 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-35591: -- Assignee: Lorenzo Affetti > Azure Pipelines not running for master since c9def981 > -

[jira] [Commented] (FLINK-35591) Azure Pipelines not running for master since c9def981

2024-06-13 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854907#comment-17854907 ] Weijie Guo commented on FLINK-35591: Thanks [~lorenzo.affetti]! I have checked it wo

[jira] [Closed] (FLINK-35591) Azure Pipelines not running for master since c9def981

2024-06-13 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-35591. -- Fix Version/s: 1.20.0 Resolution: Fixed > Azure Pipelines not running for master since c9def981

Re: [PR] [FLINK-34545][cdc-pipeline-connector]Add OceanBase pipeline connector to Flink CDC [flink-cdc]

2024-06-13 Thread via GitHub
whhe commented on code in PR #3360: URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1639119977 ## docs/content/docs/connectors/pipeline-connectors/oceanbase.md: ## @@ -0,0 +1,343 @@ +--- +title: "OceanBase" +weight: 7 +type: docs +aliases: +- /connectors/pipeline-

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-13 Thread via GitHub
caicancai commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1639121989 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -125,4 +124,4 @@ arr1: [{name: a, p2: v2}, {name: c, p2: v2}] merged: [{name: a, p1: v1,

[jira] [Commented] (FLINK-35597) Fix unstable LocatableSplitAssignerTest#testConcurrentSplitAssignmentForMultipleHosts

2024-06-13 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854910#comment-17854910 ] Jane Chan commented on FLINK-35597: --- https://dev.azure.com/apache-flink/apache-flink/_

[jira] [Updated] (FLINK-35597) Fix unstable LocatableSplitAssignerTest#testConcurrentSplitAssignmentForMultipleHosts

2024-06-13 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yubin Li updated FLINK-35597: - Description: To ensure at least one fraction of hosts to be local, it should be {{ia.getNumberOfLocalAss

[jira] [Commented] (FLINK-34914) FLIP-436: Introduce Catalog-related Syntax

2024-06-13 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854911#comment-17854911 ] Weijie Guo commented on FLINK-34914: I'm glad to hear that, but with a friendly remi

[jira] [Comment Edited] (FLINK-34914) FLIP-436: Introduce Catalog-related Syntax

2024-06-13 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854911#comment-17854911 ] Weijie Guo edited comment on FLINK-34914 at 6/14/24 2:16 AM: -

[jira] [Updated] (FLINK-35237) Allow Sink to Choose HashFunction in PrePartitionOperator

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35237: --- Labels: pull-request-available (was: ) > Allow Sink to Choose HashFunction in PrePartitionO

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-13 Thread via GitHub
caicancai commented on PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#issuecomment-2167127192 @1996fanrui cli fail, but it doesn't seem to be caused by my pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] [FLINK-33461][Connector/JDBC] Support streaming related semantics for the new JDBC source [flink-connector-jdbc]

2024-06-13 Thread via GitHub
RocMarshal commented on PR #119: URL: https://github.com/apache/flink-connector-jdbc/pull/119#issuecomment-2167128684 👍 Thank you @1996fanrui @eskabetxe very much for your review and attention for the feature ! -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [FLINK-35597][test] Fix unstable LocatableSplitAssignerTest#testConcurrentSplitAssignmentForMultipleHosts [flink]

2024-06-13 Thread via GitHub
GOODBOY008 commented on PR #24936: URL: https://github.com/apache/flink/pull/24936#issuecomment-2167128712 @1996fanrui It's indeed my mistake. @liyubin117 Great catch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] [FLINK-34545][cdc-pipeline-connector]Add OceanBase pipeline connector to Flink CDC [flink-cdc]

2024-06-13 Thread via GitHub
yuanoOo commented on code in PR #3360: URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1639167796 ## docs/content/docs/connectors/pipeline-connectors/oceanbase.md: ## @@ -0,0 +1,343 @@ +--- +title: "OceanBase" +weight: 7 +type: docs +aliases: +- /connectors/pipeli

Re: [PR] [FLINK-35167][cdc-connector] Introduce MaxCompute pipeline DataSink [flink-cdc]

2024-06-13 Thread via GitHub
dingxin-tech commented on code in PR #3254: URL: https://github.com/apache/flink-cdc/pull/3254#discussion_r1639171927 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-maxcompute/src/main/java/org/apache/flink/cdc/connectors/maxcompute/sink/MaxComputeEventW

[jira] [Commented] (FLINK-35157) Sources with watermark alignment get stuck once some subtasks finish

2024-06-13 Thread elon_X (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854914#comment-17854914 ] elon_X commented on FLINK-35157: [~fanrui] Sure, I will backport this fix to 1.17, 1.18,

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-13 Thread via GitHub
1996fanrui merged PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

[jira] [Commented] (FLINK-35448) Translate pod templates documentation into Chinese

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854915#comment-17854915 ] Rui Fan commented on FLINK-35448: - Merged to main(1.9.0) via: d920a235a3357311b96e3c087d

[jira] [Commented] (FLINK-33463) Support the implementation of dynamic source tables based on the new source

2024-06-13 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854916#comment-17854916 ] RocMarshal commented on FLINK-33463: Hi, [~fanrui] [~eskabetxe]  Should we split the

[jira] [Resolved] (FLINK-35448) Translate pod templates documentation into Chinese

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-35448. - Fix Version/s: kubernetes-operator-1.9.0 Assignee: Caican Cai Resolution: Fixed > Transl

Re: [PR] [FLINK-35167][cdc-connector] Introduce MaxCompute pipeline DataSink [flink-cdc]

2024-06-13 Thread via GitHub
dingxin-tech commented on code in PR #3254: URL: https://github.com/apache/flink-cdc/pull/3254#discussion_r1639174241 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-maxcompute/src/main/java/org/apache/flink/cdc/connectors/maxcompute/sink/MaxComputeEventS

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-13 Thread via GitHub
caicancai commented on PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#issuecomment-2167139959 @1996fanrui @RocMarshal Thank you for your review and patient reply -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [FLINK-34918][table] Introduce comment for CatalogStore & Support enhanced `CREATE CATALOG` syntax [flink]

2024-06-13 Thread via GitHub
LadyForest commented on code in PR #24934: URL: https://github.com/apache/flink/pull/24934#discussion_r1639160703 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ddl/CreateCatalogOperation.java: ## @@ -39,10 +41,18 @@ public class CreateCatal

Re: [PR] [FLINK-35237] Allow Sink to Choose HashFunction in PrePartitionOperator [flink-cdc]

2024-06-13 Thread via GitHub
lvyanquan commented on code in PR #3414: URL: https://github.com/apache/flink-cdc/pull/3414#discussion_r1639176999 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/sink/HashFunction.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] [FLINK-35237] Allow Sink to Choose HashFunction in PrePartitionOperator [flink-cdc]

2024-06-13 Thread via GitHub
lvyanquan commented on code in PR #3414: URL: https://github.com/apache/flink-cdc/pull/3414#discussion_r1639176999 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/sink/HashFunction.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] [FLINK-35543][HIVE] Upgrade Hive 2.3 connector to version 2.3.10 [flink]

2024-06-13 Thread via GitHub
1996fanrui merged PR #24905: URL: https://github.com/apache/flink/pull/24905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[jira] [Assigned] (FLINK-35543) Upgrade Hive 2.3 connector to version 2.3.10

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-35543: --- Assignee: Cheng Pan > Upgrade Hive 2.3 connector to version 2.3.10 > --

[jira] [Resolved] (FLINK-35543) Upgrade Hive 2.3 connector to version 2.3.10

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-35543. - Fix Version/s: 1.20.0 Resolution: Fixed > Upgrade Hive 2.3 connector to version 2.3.10 >

[jira] [Commented] (FLINK-35543) Upgrade Hive 2.3 connector to version 2.3.10

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854919#comment-17854919 ] Rui Fan commented on FLINK-35543: - Merged to master(1.20.0) via : 6c05981948ea72f79fef94

Re: [PR] [FLINK-32091][checkpoint] Add file size metrics for file-merging [flink]

2024-06-13 Thread via GitHub
fredia commented on PR #24922: URL: https://github.com/apache/flink/pull/24922#issuecomment-2167153534 > Thanks for the PR! Overall LGTM. How about adding some docs under `docs/ops/metrics#checkpointing`? @Zakelly Thanks for the review, added into `docs/ops/metrics#checkpointing` and

Re: [PR] [FLINK-35543][HIVE] Upgrade Hive 2.3 connector to version 2.3.10 [flink]

2024-06-13 Thread via GitHub
pan3793 commented on PR #24905: URL: https://github.com/apache/flink/pull/24905#issuecomment-2167155520 thank you, @1996fanrui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [FLINK-35237] Allow Sink to Choose HashFunction in PrePartitionOperator [flink-cdc]

2024-06-13 Thread via GitHub
lvyanquan commented on code in PR #3414: URL: https://github.com/apache/flink-cdc/pull/3414#discussion_r1639192510 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/sink/HashFunction.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[jira] [Created] (FLINK-35598) Fix error comparison type ExtendedSqlRowTypeNameSpec#equalsDeep

2024-06-13 Thread Frank Wong (Jira)
Frank Wong created FLINK-35598: -- Summary: Fix error comparison type ExtendedSqlRowTypeNameSpec#equalsDeep Key: FLINK-35598 URL: https://issues.apache.org/jira/browse/FLINK-35598 Project: Flink

[jira] [Updated] (FLINK-35598) Fix error comparison type ExtendedSqlRowTypeNameSpec#equalsDeep

2024-06-13 Thread Frank Wong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frank Wong updated FLINK-35598: --- Labels: pull_request_available (was: pull-request-available) > Fix error comparison type ExtendedSq

[jira] [Updated] (FLINK-35598) Fix error comparison type ExtendedSqlRowTypeNameSpec#equalsDeep

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35598: --- Labels: pull-request-available (was: ) > Fix error comparison type ExtendedSqlRowTypeNameSp

Re: [PR] [FLINK-35598] Fix error comparison type ExtendedSqlRowTypeNameSpec#equalsDeep [flink]

2024-06-13 Thread via GitHub
flinkbot commented on PR #24937: URL: https://github.com/apache/flink/pull/24937#issuecomment-2167173883 ## CI report: * 0438cd927e430131c07b0555265696e34e1606a0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-35598) Fix error comparison type ExtendedSqlRowTypeNameSpec#equalsDeep

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35598: --- Labels: pull-request-available pull_request_available (was: pull_request_available) > Fix

[jira] [Created] (FLINK-35599) test

2024-06-13 Thread ZhengJunZhou (Jira)
ZhengJunZhou created FLINK-35599: Summary: test Key: FLINK-35599 URL: https://issues.apache.org/jira/browse/FLINK-35599 Project: Flink Issue Type: Bug Reporter: ZhengJunZhou

Re: [PR] [FLINK-35598][sql-parser] Fix error comparison type ExtendedSqlRowTypeNameSpec#equalsDeep [flink]

2024-06-13 Thread via GitHub
wzx140 commented on PR #24937: URL: https://github.com/apache/flink/pull/24937#issuecomment-2167176948 @1996fanrui Could you please review it? Really thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Updated] (FLINK-35599) Add JDBC Sink Plugin to Flink-CDC-Pipeline

2024-06-13 Thread ZhengJunZhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZhengJunZhou updated FLINK-35599: - Component/s: Flink CDC Affects Version/s: cdc-3.2.0 Description: TODO

Re: [PR] [FLINK-35121][common] Adds validation for pipeline definition options [flink-cdc]

2024-06-13 Thread via GitHub
Jiabao-Sun merged PR #3382: URL: https://github.com/apache/flink-cdc/pull/3382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [FLINK-35121][pipeline-connector][cdc-base] CDC pipeline connector provide ability to verify requiredOptions and optionalOptions [flink-cdc]

2024-06-13 Thread via GitHub
Jiabao-Sun closed pull request #3412: [FLINK-35121][pipeline-connector][cdc-base] CDC pipeline connector provide ability to verify requiredOptions and optionalOptions URL: https://github.com/apache/flink-cdc/pull/3412 -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [FLINK-35121][pipeline-connector][cdc-base] CDC pipeline connector provide ability to verify requiredOptions and optionalOptions [flink-cdc]

2024-06-13 Thread via GitHub
Jiabao-Sun commented on PR #3412: URL: https://github.com/apache/flink-cdc/pull/3412#issuecomment-2167182112 Closed by #3382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Resolved] (FLINK-35121) CDC pipeline connector should verify requiredOptions and optionalOptions

2024-06-13 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiabao Sun resolved FLINK-35121. Assignee: yux Resolution: Implemented Implemented by flink-cdc master: 2bd2e4ce24ec0cc6a1112

Re: [PR] Out of use [flink-cdc]

2024-06-13 Thread via GitHub
Jiabao-Sun closed pull request #3318: Out of use URL: https://github.com/apache/flink-cdc/pull/3318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

Re: [PR] [FLINK-34918][table] Introduce comment for CatalogStore & Support enhanced `CREATE CATALOG` syntax [flink]

2024-06-13 Thread via GitHub
liyubin117 commented on code in PR #24934: URL: https://github.com/apache/flink/pull/24934#discussion_r1639240721 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateCatalog.java: ## @@ -45,11 +48,18 @@ public class SqlCreateCatalog extends Sql

Re: [PR] [FLINK-34918][table] Introduce comment for CatalogStore & Support enhanced `CREATE CATALOG` syntax [flink]

2024-06-13 Thread via GitHub
liyubin117 commented on code in PR #24934: URL: https://github.com/apache/flink/pull/24934#discussion_r1639243865 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogDescriptor.java: ## @@ -48,18 +55,34 @@ public Configuration getConfiguration()

Re: [PR] [FLINK-34918][table] Introduce comment for CatalogStore & Support enhanced `CREATE CATALOG` syntax [flink]

2024-06-13 Thread via GitHub
liyubin117 commented on code in PR #24934: URL: https://github.com/apache/flink/pull/24934#discussion_r1639244453 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ddl/CreateCatalogOperation.java: ## @@ -39,10 +41,18 @@ public class CreateCatal

Re: [PR] [FLINK-34918][table] Introduce comment for CatalogStore & Support enhanced `CREATE CATALOG` syntax [flink]

2024-06-13 Thread via GitHub
liyubin117 commented on code in PR #24934: URL: https://github.com/apache/flink/pull/24934#discussion_r1639244971 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlCreateCatalogConverter.java: ## @@ -41,6 +43,10 @@ public Op

Re: [PR] [FLINK-34918][table] Introduce comment for CatalogStore & Support enhanced `CREATE CATALOG` syntax [flink]

2024-06-13 Thread via GitHub
liyubin117 commented on code in PR #24934: URL: https://github.com/apache/flink/pull/24934#discussion_r1639245307 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java: ## @@ -295,31 +295,42 @@ public DataTypeFactory getDataTypeFact

Re: [PR] [FLINK-34918][table] Introduce comment for CatalogStore & Support enhanced `CREATE CATALOG` syntax [flink]

2024-06-13 Thread via GitHub
liyubin117 commented on code in PR #24934: URL: https://github.com/apache/flink/pull/24934#discussion_r1639245472 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/CatalogManagerTest.java: ## @@ -367,14 +368,28 @@ void testCatalogStore() throws Exc

[PR] [FLINK-35593][Kubernetes Operator] Add Apache 2 License to docker image [flink-kubernetes-operator]

2024-06-13 Thread via GitHub
anupamaggarwal opened a new pull request, #839: URL: https://github.com/apache/flink-kubernetes-operator/pull/839 ## What is the purpose of the change Adds Apache 2 LICENSE to Apache Kubernetes Operator Docker image ## Brief change log - Adds LICENSE file to docker stage image

[jira] [Updated] (FLINK-35593) Apache Kubernetes Operator Docker image does not contain Apache LICENSE

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35593: --- Labels: pull-request-available (was: ) > Apache Kubernetes Operator Docker image does not c

Re: [PR] [FLINK-35597][test] Fix unstable LocatableSplitAssignerTest#testConcurrentSplitAssignmentForMultipleHosts [flink]

2024-06-13 Thread via GitHub
liyubin117 commented on PR #24936: URL: https://github.com/apache/flink/pull/24936#issuecomment-2167237003 @1996fanrui @GOODBOY008 Thanks for your attention, I found that CI e2e tests have stucked for hours, As the code is about to be frozen, could you help cancel some tasks? For example, t

[jira] [Commented] (FLINK-35564) The topic cannot be distributed on subtask when calculatePartitionOwner returns -1

2024-06-13 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854929#comment-17854929 ] Yufan Sheng commented on FLINK-35564: - Hi, thanks for mention this. I think this bug

[jira] [Created] (FLINK-35600) Data read duplication during the full-to-incremental conversion phase

2024-06-13 Thread Di Wu (Jira)
Di Wu created FLINK-35600: - Summary: Data read duplication during the full-to-incremental conversion phase Key: FLINK-35600 URL: https://issues.apache.org/jira/browse/FLINK-35600 Project: Flink Issu

[jira] [Updated] (FLINK-35600) Data read duplication during the full-to-incremental conversion phase

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35600: --- Labels: pull-request-available (was: ) > Data read duplication during the full-to-increment

Re: [PR] [FLINK-35597][test] Fix unstable LocatableSplitAssignerTest#testConcurrentSplitAssignmentForMultipleHosts [flink]

2024-06-13 Thread via GitHub
1996fanrui commented on PR #24936: URL: https://github.com/apache/flink/pull/24936#issuecomment-2167246199 > @1996fanrui @GOODBOY008 Thanks for your attention, I found that CI e2e tests have stucked for hours, As the code is about to be frozen, could you help cancel some tasks? For example,

[jira] [Updated] (FLINK-35600) Data read duplication during the full-to-incremental conversion phase

2024-06-13 Thread Di Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Di Wu updated FLINK-35600: -- Description: Assume that the table has been split into 3 Chunks Timeline t1: chunk1 is read t2: a piece of da

Re: [PR] [cdc-common] add field of defaultValue to Column. [flink-cdc]

2024-06-13 Thread via GitHub
yuxiqian commented on code in PR #2944: URL: https://github.com/apache/flink-cdc/pull/2944#discussion_r1639295066 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/serializer/schema/PhysicalColumnSerializer.java: ## Review Comment: Seems this is a breaking cha

Re: [PR] [FLINK-35167][cdc-connector] Introduce MaxCompute pipeline DataSink [flink-cdc]

2024-06-13 Thread via GitHub
dingxin-tech commented on code in PR #3254: URL: https://github.com/apache/flink-cdc/pull/3254#discussion_r1639304610 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-maxcompute/src/test/java/org/apache/flink/cdc/connectors/maxcompute/utils/SchemaEvolution

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-06-13 Thread via GitHub
XComp commented on code in PR #24426: URL: https://github.com/apache/flink/pull/24426#discussion_r1639305664 ## .github/workflows/nightly.yml: ## @@ -28,69 +28,131 @@ jobs: name: "Pre-compile Checks" uses: ./.github/workflows/template.pre-compile-checks.yml - java8:

Re: [PR] [FLINK-35167][cdc-connector] Introduce MaxCompute pipeline DataSink [flink-cdc]

2024-06-13 Thread via GitHub
dingxin-tech commented on code in PR #3254: URL: https://github.com/apache/flink-cdc/pull/3254#discussion_r1639306007 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-maxcompute/src/main/java/org/apache/flink/cdc/connectors/maxcompute/utils/TypeConvertUtil

Re: [PR] [cdc-common] add field of defaultValue to Column. [flink-cdc]

2024-06-13 Thread via GitHub
yuxiqian commented on code in PR #2944: URL: https://github.com/apache/flink-cdc/pull/2944#discussion_r1639295066 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/serializer/schema/PhysicalColumnSerializer.java: ## Review Comment: Seems this is a breaking cha

Re: [PR] [FLINK-35167][cdc-connector] Introduce MaxCompute pipeline DataSink [flink-cdc]

2024-06-13 Thread via GitHub
dingxin-tech commented on code in PR #3254: URL: https://github.com/apache/flink-cdc/pull/3254#discussion_r1639307538 ## docs/content.zh/docs/connectors/maxcompute.md: ## @@ -0,0 +1,342 @@ +--- +title: "MaxCompute" +weight: 7 +type: docs +aliases: + - /connectors/maxcompute +--

Re: [PR] [FLINK-35593][Kubernetes Operator] Add Apache 2 License to docker image [flink-kubernetes-operator]

2024-06-13 Thread via GitHub
rmetzger commented on PR #839: URL: https://github.com/apache/flink-kubernetes-operator/pull/839#issuecomment-2167276203 +1 to merge. I don't think the `[Kubernetes Operator]` tag in the commit message is needed, since this is the operator repo. -- This is an automated message from th

Re: [PR] [FLINK-35237] Allow Sink to Choose HashFunction in PrePartitionOperator [flink-cdc]

2024-06-13 Thread via GitHub
dingxin-tech commented on code in PR #3414: URL: https://github.com/apache/flink-cdc/pull/3414#discussion_r1639312924 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/sink/HashFunction.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] [FLINK-35237] Allow Sink to Choose HashFunction in PrePartitionOperator [flink-cdc]

2024-06-13 Thread via GitHub
dingxin-tech commented on code in PR #3414: URL: https://github.com/apache/flink-cdc/pull/3414#discussion_r1639313828 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/sink/HashFunctionProvider.java: ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] [FLINK-33192] Fix Memory Leak in WindowOperator due to Improper Timer Cleanup [flink]

2024-06-13 Thread via GitHub
fredia commented on PR #24917: URL: https://github.com/apache/flink/pull/24917#issuecomment-2167284732 @kartikeypant Thanks for the PR, overall LGTM, would you like to add a test about this in `WindowOperatorTest`? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [FLINK-35593][Kubernetes Operator] Add Apache 2 License to docker image [flink-kubernetes-operator]

2024-06-13 Thread via GitHub
anupamaggarwal commented on PR #839: URL: https://github.com/apache/flink-kubernetes-operator/pull/839#issuecomment-2167310593 > +1 to merge. I don't think the `[Kubernetes Operator]` tag in the commit message is needed, since this is the operator repo. ack @rmetzger I was following

Re: [PR] [FLINK-34918][table] Support `ALTER CATALOG COMMENT` syntax [flink]

2024-06-13 Thread via GitHub
liyubin117 commented on code in PR #24932: URL: https://github.com/apache/flink/pull/24932#discussion_r1639332192 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogDescriptor.java: ## @@ -48,18 +51,29 @@ public Configuration getConfiguration()

Re: [PR] [FLINK-34918][table] Support `ALTER CATALOG COMMENT` syntax [flink]

2024-06-13 Thread via GitHub
liyubin117 commented on code in PR #24932: URL: https://github.com/apache/flink/pull/24932#discussion_r1639333418 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlAlterCatalogComment.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] [FLINK-34918][table] Support `ALTER CATALOG COMMENT` syntax [flink]

2024-06-13 Thread via GitHub
liyubin117 commented on code in PR #24932: URL: https://github.com/apache/flink/pull/24932#discussion_r1639333766 ## flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl: ## @@ -176,6 +176,15 @@ SqlAlterCatalog SqlAlterCatalog() : ca

[jira] [Commented] (FLINK-35592) MysqlDebeziumTimeConverter miss timezone convert to timestamp

2024-06-13 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854943#comment-17854943 ] Qingsheng Ren commented on FLINK-35592: --- release-3.1: f476a5b1dd99fc63962bc75048c0

Re: [PR] [FLINK-34918][table] Support `ALTER CATALOG COMMENT` syntax [flink]

2024-06-13 Thread via GitHub
liyubin117 commented on code in PR #24932: URL: https://github.com/apache/flink/pull/24932#discussion_r1639333058 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogDescriptor.java: ## @@ -48,18 +51,29 @@ public Configuration getConfiguration()

Re: [PR] [FLINK-34918][table] Support `ALTER CATALOG COMMENT` syntax [flink]

2024-06-13 Thread via GitHub
liyubin117 commented on code in PR #24932: URL: https://github.com/apache/flink/pull/24932#discussion_r1639333418 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlAlterCatalogComment.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] [FLINK-35593][Kubernetes Operator] Add Apache 2 License to docker image [flink-kubernetes-operator]

2024-06-13 Thread via GitHub
rmetzger commented on PR #839: URL: https://github.com/apache/flink-kubernetes-operator/pull/839#issuecomment-2167326372 Ah, I see. That guide was written before Flink started having many repositories. Back then everything was in apache/flink. Here, the component tags are used for things

[jira] [Comment Edited] (FLINK-35042) Streaming File Sink s3 end-to-end test failed as TM lost

2024-06-13 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854944#comment-17854944 ] Matthias Pohl edited comment on FLINK-35042 at 6/14/24 6:37 AM: --

[jira] [Commented] (FLINK-35042) Streaming File Sink s3 end-to-end test failed as TM lost

2024-06-13 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854944#comment-17854944 ] Matthias Pohl commented on FLINK-35042: --- I noticed that the build failure in the d

Re: [PR] [hotfix][checkpointing] Normalize file-merging sub dir [flink]

2024-06-13 Thread via GitHub
zoltar9264 closed pull request #24928: [hotfix][checkpointing] Normalize file-merging sub dir URL: https://github.com/apache/flink/pull/24928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [hotfix][checkpointing] Normalize file-merging sub dir [flink]

2024-06-13 Thread via GitHub
zoltar9264 commented on PR #24928: URL: https://github.com/apache/flink/pull/24928#issuecomment-2167344359 This fix already as a part of [PR-24933](https://github.com/apache/flink/pull/24933), so close this pr. -- This is an automated message from the Apache Git Service. To respond to the

<    1   2   3   >