Re: [PR] [FLINK-35121][pipeline-connector][cdc-base] CDC pipeline connector provide ability to verify requiredOptions and optionalOptions [flink-cdc]

2024-06-12 Thread via GitHub
morazow commented on code in PR #3412: URL: https://github.com/apache/flink-cdc/pull/3412#discussion_r1635917238 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlDataSourceFactoryTest.ja

Re: [PR] [FLINK-35467][cdc-dist][bin] Respect externally set FLINK_CONF_DIR for CDC task configuration. [flink-cdc]

2024-06-12 Thread via GitHub
joyCurry30 commented on code in PR #3398: URL: https://github.com/apache/flink-cdc/pull/3398#discussion_r1635923711 ## flink-cdc-dist/src/main/flink-cdc-bin/bin/flink-cdc.sh: ## @@ -34,11 +34,11 @@ if [[ -z $FLINK_HOME ]]; then exit 1 fi -# Setup Flink related configuratio

Re: [PR] [FLINK-35121][common] Adds validation for pipeline definition options [flink-cdc]

2024-06-12 Thread via GitHub
morazow commented on code in PR #3382: URL: https://github.com/apache/flink-cdc/pull/3382#discussion_r1635924042 ## flink-cdc-common/src/test/java/org/apache/flink/cdc/common/factories/FactoryHelperTests.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] [FLINK-35143][cdc-connector][mysql] Expose newly added tables capture in mysql pipeline connector. [flink-cdc]

2024-06-12 Thread via GitHub
morazow commented on code in PR #3411: URL: https://github.com/apache/flink-cdc/pull/3411#discussion_r1635930879 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MysqlPipelineNewlyAddedTableI

Re: [PR] [FLINK-35121][common] Adds validation for pipeline definition options [flink-cdc]

2024-06-12 Thread via GitHub
yuxiqian commented on code in PR #3382: URL: https://github.com/apache/flink-cdc/pull/3382#discussion_r1635956703 ## flink-cdc-common/src/test/java/org/apache/flink/cdc/common/factories/FactoryHelperTests.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] [FLINK-34990][cdc-connector][oracle] Oracle cdc support newly add table [flink-cdc]

2024-06-12 Thread via GitHub
GOODBOY008 commented on code in PR #3203: URL: https://github.com/apache/flink-cdc/pull/3203#discussion_r1635937545 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-oracle-cdc/src/test/java/org/apache/flink/cdc/connectors/oracle/testutils/OracleTestUtils.java: ##

Re: [PR] [FLINK-35143][cdc-connector][mysql] Expose newly added tables capture in mysql pipeline connector. [flink-cdc]

2024-06-12 Thread via GitHub
qg-lin commented on code in PR #3411: URL: https://github.com/apache/flink-cdc/pull/3411#discussion_r1635967850 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MysqlPipelineNewlyAddedTableIT

[jira] [Commented] (FLINK-35261) Flink CDC pipeline transform doesn't support decimal-type comparison

2024-06-12 Thread Wenkai Qi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854300#comment-17854300 ] Wenkai Qi commented on FLINK-35261: --- [[FLINK-34877][cdc] Flink CDC pipeline transform

[jira] [Commented] (FLINK-35261) Flink CDC pipeline transform doesn't support decimal-type comparison

2024-06-12 Thread yux (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854308#comment-17854308 ] yux commented on FLINK-35261: - Thanks for [~wink] 's clarification! I'll put this ticket as

Re: [PR] [FLINK-35121][common] Adds validation for pipeline definition options [flink-cdc]

2024-06-12 Thread via GitHub
morazow commented on code in PR #3382: URL: https://github.com/apache/flink-cdc/pull/3382#discussion_r1635999340 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-kafka/src/test/java/org/apache/flink/cdc/connectors/kafka/sink/KafkaDataSinkFactoryTest.java:

[jira] [Updated] (FLINK-35261) Flink CDC pipeline transform doesn't support decimal-type comparison

2024-06-12 Thread yux (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yux updated FLINK-35261: Parent: FLINK-34877 Issue Type: Sub-task (was: Improvement) > Flink CDC pipeline transform doesn't suppor

Re: [PR] [FLINK-35121][common] Adds validation for pipeline definition options [flink-cdc]

2024-06-12 Thread via GitHub
morazow commented on code in PR #3382: URL: https://github.com/apache/flink-cdc/pull/3382#discussion_r1636001422 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/test/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksDataSinkFactor

Re: [PR] [FLINK-35143][cdc-connector][mysql] Expose newly added tables capture in mysql pipeline connector. [flink-cdc]

2024-06-12 Thread via GitHub
morazow commented on code in PR #3411: URL: https://github.com/apache/flink-cdc/pull/3411#discussion_r1636002649 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MysqlPipelineNewlyAddedTableI

[jira] [Commented] (FLINK-34879) [Feature][Pipeline] Flink CDC pipeline transform supports the strategy of schema evolution

2024-06-12 Thread Wenkai Qi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854311#comment-17854311 ] Wenkai Qi commented on FLINK-34879: --- https://issues.apache.org/jira/browse/FLINK-35242

Re: [PR] [FLINK-20217][task] Allow certains operators to yield to unaligned checkpoint in case timers are firing [flink]

2024-06-12 Thread via GitHub
pnowojski commented on PR #24895: URL: https://github.com/apache/flink/pull/24895#issuecomment-2162389538 Yes, fixed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [FLINK-35570] Consider PlaceholderStreamStateHandle in checkpoint file merging [flink]

2024-06-12 Thread via GitHub
Zakelly commented on code in PR #24924: URL: https://github.com/apache/flink/pull/24924#discussion_r1636034323 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/SnapshotFileMergingCompatibilityITCase.java: ## @@ -167,22 +166,25 @@ private void verifyStateHandleTyp

[jira] [Commented] (FLINK-35568) Add the imagePullSecrets property for FlinkDeployment spec

2024-06-12 Thread Mate Czagany (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854319#comment-17854319 ] Mate Czagany commented on FLINK-35568: -- Hi, you can use the config option `kubernet

[jira] [Updated] (FLINK-35573) [FLIP-447] Upgrade FRocksDB from 6.20.3 to 8.10.0

2024-06-12 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yue Ma updated FLINK-35573: --- Description: The FLIP: [https://cwiki.apache.org/confluence/display/FLINK/FLIP-447%3A+Upgrade+FRocksDB+from

[jira] [Created] (FLINK-35573) [FLIP-447] Upgrade FRocksDB from 6.20.3 to 8.10.0

2024-06-12 Thread Yue Ma (Jira)
Yue Ma created FLINK-35573: -- Summary: [FLIP-447] Upgrade FRocksDB from 6.20.3 to 8.10.0 Key: FLINK-35573 URL: https://issues.apache.org/jira/browse/FLINK-35573 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-35574) Set up base branch for FrocksDB-8.10

2024-06-12 Thread Yue Ma (Jira)
Yue Ma created FLINK-35574: -- Summary: Set up base branch for FrocksDB-8.10 Key: FLINK-35574 URL: https://issues.apache.org/jira/browse/FLINK-35574 Project: Flink Issue Type: Sub-task Compo

[jira] [Created] (FLINK-35575) FRocksDB supports disabling perf context during compilation

2024-06-12 Thread Yue Ma (Jira)
Yue Ma created FLINK-35575: -- Summary: FRocksDB supports disabling perf context during compilation Key: FLINK-35575 URL: https://issues.apache.org/jira/browse/FLINK-35575 Project: Flink Issue Type:

[jira] [Commented] (FLINK-26951) Add HASH supported in SQL & Table API

2024-06-12 Thread Kartikey Pant (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854329#comment-17854329 ] Kartikey Pant commented on FLINK-26951: --- Hey [~lincoln.86xy], thanks for the addit

[jira] [Comment Edited] (FLINK-26951) Add HASH supported in SQL & Table API

2024-06-12 Thread Kartikey Pant (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854329#comment-17854329 ] Kartikey Pant edited comment on FLINK-26951 at 6/12/24 9:10 AM: --

[jira] [Comment Edited] (FLINK-26951) Add HASH supported in SQL & Table API

2024-06-12 Thread Kartikey Pant (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854329#comment-17854329 ] Kartikey Pant edited comment on FLINK-26951 at 6/12/24 9:11 AM: --

[jira] [Comment Edited] (FLINK-26951) Add HASH supported in SQL & Table API

2024-06-12 Thread Kartikey Pant (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854329#comment-17854329 ] Kartikey Pant edited comment on FLINK-26951 at 6/12/24 9:11 AM: --

[jira] [Created] (FLINK-35576) FRocksdb Cherry pick IngestDB requires commit

2024-06-12 Thread Yue Ma (Jira)
Yue Ma created FLINK-35576: -- Summary: FRocksdb Cherry pick IngestDB requires commit Key: FLINK-35576 URL: https://issues.apache.org/jira/browse/FLINK-35576 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-35577) Setup the CI environment for FRocksDB-8.10

2024-06-12 Thread Yue Ma (Jira)
Yue Ma created FLINK-35577: -- Summary: Setup the CI environment for FRocksDB-8.10 Key: FLINK-35577 URL: https://issues.apache.org/jira/browse/FLINK-35577 Project: Flink Issue Type: Sub-task

[jira] [Updated] (FLINK-35574) Setup base branch for FrocksDB-8.10

2024-06-12 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yue Ma updated FLINK-35574: --- Summary: Setup base branch for FrocksDB-8.10 (was: Set up base branch for FrocksDB-8.10) > Setup base bran

[jira] [Updated] (FLINK-35576) FRocksdb cherry pick IngestDB related commits

2024-06-12 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yue Ma updated FLINK-35576: --- Summary: FRocksdb cherry pick IngestDB related commits (was: FRocksdb Cherry pick IngestDB requires commit

[jira] [Created] (FLINK-35578) Release Frocksdb-8.10.0 official products

2024-06-12 Thread Yue Ma (Jira)
Yue Ma created FLINK-35578: -- Summary: Release Frocksdb-8.10.0 official products Key: FLINK-35578 URL: https://issues.apache.org/jira/browse/FLINK-35578 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-35579) Update the FrocksDB version in FLINK

2024-06-12 Thread Yue Ma (Jira)
Yue Ma created FLINK-35579: -- Summary: Update the FrocksDB version in FLINK Key: FLINK-35579 URL: https://issues.apache.org/jira/browse/FLINK-35579 Project: Flink Issue Type: Sub-task Compo

[jira] [Created] (FLINK-35581) Remove comments from the code related to ingestDB

2024-06-12 Thread Yue Ma (Jira)
Yue Ma created FLINK-35581: -- Summary: Remove comments from the code related to ingestDB Key: FLINK-35581 URL: https://issues.apache.org/jira/browse/FLINK-35581 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-35580) Fix ingestDB recovery mode related bugs

2024-06-12 Thread Yue Ma (Jira)
Yue Ma created FLINK-35580: -- Summary: Fix ingestDB recovery mode related bugs Key: FLINK-35580 URL: https://issues.apache.org/jira/browse/FLINK-35580 Project: Flink Issue Type: Sub-task Co

[jira] [Created] (FLINK-35582) Marking ingestDB as the default recovery mode for rescaling

2024-06-12 Thread Yue Ma (Jira)
Yue Ma created FLINK-35582: -- Summary: Marking ingestDB as the default recovery mode for rescaling Key: FLINK-35582 URL: https://issues.apache.org/jira/browse/FLINK-35582 Project: Flink Issue Type:

[jira] [Commented] (FLINK-33338) Bump FRocksDB version

2024-06-12 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854337#comment-17854337 ] Yue Ma commented on FLINK-8: [~pnowojski] [~roman] [~srichter] As we discussed befor

Re: [PR] [FLINK-35570] Consider PlaceholderStreamStateHandle in checkpoint file merging [flink]

2024-06-12 Thread via GitHub
Zakelly commented on PR #24924: URL: https://github.com/apache/flink/pull/24924#issuecomment-2162569651 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Revert [FLINK-34123][FLINK-35068]: Add built-in dedicated serialization support for Maps, Lists, Sets, and Collections [flink]

2024-06-12 Thread via GitHub
reswqa merged PR #24925: URL: https://github.com/apache/flink/pull/24925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-34977][API] Introduce State Access on DataStream API V2 [flink]

2024-06-12 Thread via GitHub
jeyhunkarimov commented on PR #24725: URL: https://github.com/apache/flink/pull/24725#issuecomment-2162579459 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Commented] (FLINK-35068) Introduce built-in serialization support for Set

2024-06-12 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854357#comment-17854357 ] Weijie Guo commented on FLINK-35068: Reverted in 894feed5f3eb4fb38c53001a7cc8727d7fe

[jira] [Created] (FLINK-35583) Flinker-connector-jdbc is expected to support DDL synchronization for mysql

2024-06-12 Thread linux (Jira)
linux created FLINK-35583: - Summary: Flinker-connector-jdbc is expected to support DDL synchronization for mysql Key: FLINK-35583 URL: https://issues.apache.org/jira/browse/FLINK-35583 Project: Flink

[jira] [Commented] (FLINK-34123) Introduce built-in serialization support for Map and List

2024-06-12 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854356#comment-17854356 ] Weijie Guo commented on FLINK-34123: Reverted in 894feed5f3eb4fb38c53001a7cc8727d7fe

[jira] [Assigned] (FLINK-35573) [FLIP-447] Upgrade FRocksDB from 6.20.3 to 8.10.0

2024-06-12 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan reassigned FLINK-35573: --- Assignee: Yue Ma > [FLIP-447] Upgrade FRocksDB from 6.20.3 to 8.10.0 >

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: core [flink]

2024-06-12 Thread via GitHub
1996fanrui commented on code in PR #24881: URL: https://github.com/apache/flink/pull/24881#discussion_r1636152962 ## flink-core/src/test/java/org/apache/flink/core/fs/InitOutputPathTest.java: ## @@ -23,59 +23,52 @@ import org.apache.flink.core.fs.local.LocalFileSystem; import

Re: [PR] [FLINK-35533][runtime] Support Flink hybrid shuffle integration with Apache Celeborn [flink]

2024-06-12 Thread via GitHub
reswqa merged PR #24900: URL: https://github.com/apache/flink/pull/24900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Closed] (FLINK-35533) FLIP-459: Support Flink hybrid shuffle integration with Apache Celeborn

2024-06-12 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-35533. -- Fix Version/s: 1.20.0 Resolution: Done master(1.20) via 23fa2aeb01861a6f8b85f911c5a3f989a1f7589

Re: [PR] [FLINK-34990][cdc-connector][oracle] Oracle cdc support newly add table [flink-cdc]

2024-06-12 Thread via GitHub
gong commented on code in PR #3203: URL: https://github.com/apache/flink-cdc/pull/3203#discussion_r1636249435 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-oracle-cdc/src/test/java/org/apache/flink/cdc/connectors/oracle/source/NewlyAddedTableITCase.java: ## @@

Re: [PR] [FLINK-35157][runtime] Sources with watermark alignment get stuck once some subtasks finish [flink]

2024-06-12 Thread via GitHub
elon-X commented on code in PR #24757: URL: https://github.com/apache/flink/pull/24757#discussion_r1636303927 ## flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorAlignmentTest.java: ## @@ -310,6 +310,53 @@ void testWatermarkAggregatorRando

Re: [PR] [FLINK-35371][security] Add configuration for SSL keystore and truststore type [flink]

2024-06-12 Thread via GitHub
gaborgsomogyi commented on PR #24919: URL: https://github.com/apache/flink/pull/24919#issuecomment-2162792331 Unless there are further comments I'm intended to merge it beginning of next week. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] [FLINK-34111][table] Add JSON_QUOTE and JSON_UNQUOTE function [flink]

2024-06-12 Thread via GitHub
anupamaggarwal commented on PR #24156: URL: https://github.com/apache/flink/pull/24156#issuecomment-2162795228 Hi @jeyhunkarimov thank you for contributing this PR!. Just wanted to check if you were planning on working further on this, otherwise I'd be happy to continue and address some of

[jira] [Resolved] (FLINK-35509) Slack community invite link has expired

2024-06-12 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger resolved FLINK-35509. Resolution: Fixed > Slack community invite link has expired >

[jira] [Commented] (FLINK-35569) SnapshotFileMergingCompatibilityITCase#testSwitchFromEnablingToDisablingFileMerging failed

2024-06-12 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854409#comment-17854409 ] Jane Chan commented on FLINK-35569: --- https://github.com/apache/flink/actions/runs/9480

Re: [PR] [FLINK-35140][docs] Update Opensearch connector docs for 1.2.0 and 2.0.0 releases [flink]

2024-06-12 Thread via GitHub
dannycranmer commented on code in PR #24921: URL: https://github.com/apache/flink/pull/24921#discussion_r1636357425 ## docs/setup_docs.sh: ## @@ -59,7 +59,7 @@ if [ "$SKIP_INTEGRATE_CONNECTOR_DOCS" = false ]; then integrate_connector_docs rabbitmq v3.0 integrate_connector_

Re: [PR] [FLINK-20217][task] Allow certains operators to yield to unaligned checkpoint in case timers are firing [flink]

2024-06-12 Thread via GitHub
pnowojski merged PR #24895: URL: https://github.com/apache/flink/pull/24895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[jira] [Commented] (FLINK-20217) More fine-grained timer processing

2024-06-12 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854413#comment-17854413 ] Piotr Nowojski commented on FLINK-20217: Merged to master as 503593ab2d4..986d06

Re: [PR] [FLINK-35528][task] Skip execution of interruptible mails when yielding [flink]

2024-06-12 Thread via GitHub
pnowojski merged PR #24904: URL: https://github.com/apache/flink/pull/24904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-35140][docs] Update Opensearch connector docs for 1.2.0 and 2.0.0 releases [flink]

2024-06-12 Thread via GitHub
snuyanzin commented on code in PR #24921: URL: https://github.com/apache/flink/pull/24921#discussion_r1636362092 ## docs/setup_docs.sh: ## @@ -59,7 +59,7 @@ if [ "$SKIP_INTEGRATE_CONNECTOR_DOCS" = false ]; then integrate_connector_docs rabbitmq v3.0 integrate_connector_doc

[jira] [Closed] (FLINK-35528) Skip execution of interruptible mails when yielding

2024-06-12 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-35528. -- Fix Version/s: 1.20.0 Resolution: Fixed merged commit 77cd1cd into apache:master now >

[jira] [Closed] (FLINK-20217) More fine-grained timer processing

2024-06-12 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-20217. -- Fix Version/s: 1.20.0 Resolution: Fixed Firing timers can now be interrupted to speed u

[jira] [Created] (FLINK-35584) Support Java 21 in flink-docker

2024-06-12 Thread Josh England (Jira)
Josh England created FLINK-35584: Summary: Support Java 21 in flink-docker Key: FLINK-35584 URL: https://issues.apache.org/jira/browse/FLINK-35584 Project: Flink Issue Type: Improvement

[PR] [hotfix] Improve execution.checkpointing.unaligned.interruptible-timers.enabled documentation [flink]

2024-06-12 Thread via GitHub
pnowojski opened a new pull request, #24926: URL: https://github.com/apache/flink/pull/24926 Simple documentation improvement. ## Verifying this change N/A ## Does this pull request potentially affect one of the following parts: N/A ## Documentation

[jira] [Reopened] (FLINK-20217) More fine-grained timer processing

2024-06-12 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reopened FLINK-20217: > More fine-grained timer processing > -- > >

[jira] (FLINK-20217) More fine-grained timer processing

2024-06-12 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20217 ] Piotr Nowojski deleted comment on FLINK-20217: was (Author: pnowojski): Firing timers can now be interrupted to speed up checkpointing. Timers that were interrupted by a checkpoint, will

[jira] [Closed] (FLINK-20217) More fine-grained timer processing

2024-06-12 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-20217. -- Release Note: Firing timers can now be interrupted to speed up checkpointing. Timers that wer

Re: [PR] [hotfix] Improve execution.checkpointing.unaligned.interruptible-timers.enabled documentation [flink]

2024-06-12 Thread via GitHub
flinkbot commented on PR #24926: URL: https://github.com/apache/flink/pull/24926#issuecomment-2162942962 ## CI report: * b88ad00e20b5f2e76c3d7eb02c7adc3239faed8a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-28915) Make application mode could support remote DFS schema(e.g. S3, OSS, HDFS, etc.)

2024-06-12 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854429#comment-17854429 ] Robert Metzger commented on FLINK-28915: Quick question on this feature: Is this

Re: [PR] [FLINK-35570] Consider PlaceholderStreamStateHandle in checkpoint file merging [flink]

2024-06-12 Thread via GitHub
Zakelly closed pull request #24924: [FLINK-35570] Consider PlaceholderStreamStateHandle in checkpoint file merging URL: https://github.com/apache/flink/pull/24924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[PR] Update flink-operations-playground.md for a typo [flink]

2024-06-12 Thread via GitHub
rohimsh opened a new pull request, #24927: URL: https://github.com/apache/flink/pull/24927 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on

Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]

2024-06-12 Thread via GitHub
snuyanzin commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636475673 ## pom.xml: ## @@ -2371,6 +2371,11 @@ under the License. org.apache.flink.util.function.SerializableF

[jira] [Updated] (FLINK-35574) Setup base branch for FrocksDB-8.10

2024-06-12 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yue Ma updated FLINK-35574: --- Description: As the first part of FLINK-35573, we need to prepare a base branch for FRocksDB-8.10.0 first.

[jira] [Updated] (FLINK-35576) FRocksdb cherry pick IngestDB related commits

2024-06-12 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yue Ma updated FLINK-35576: --- Description: We support the API related to ingest DB in FRocksDb-8.10.0, but many of the fixes related to i

[jira] [Commented] (FLINK-33338) Bump FRocksDB version

2024-06-12 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854439#comment-17854439 ] Roman Khachatryan commented on FLINK-8: --- Thanks [~mayuehappy], makes sense

[jira] [Closed] (FLINK-33338) Bump FRocksDB version

2024-06-12 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan closed FLINK-8. - Resolution: Duplicate > Bump FRocksDB version > - > >

Re: [PR] [FLINK-34172] Add support for altering a distribution via ALTER TABLE [flink]

2024-06-12 Thread via GitHub
twalthr commented on code in PR #24886: URL: https://github.com/apache/flink/pull/24886#discussion_r1636474722 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlDistribution.java: ## @@ -70,17 +70,28 @@ public List getOperandList() { @Overri

[jira] [Commented] (FLINK-28915) Make application mode could support remote DFS schema(e.g. S3, OSS, HDFS, etc.)

2024-06-12 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854440#comment-17854440 ] Ferenc Csaky commented on FLINK-28915: -- I did not test it with the operator, but my

Re: [PR] Update flink-operations-playground.md for a typo [flink]

2024-06-12 Thread via GitHub
flinkbot commented on PR #24927: URL: https://github.com/apache/flink/pull/24927#issuecomment-2163075264 ## CI report: * 658b68a6bb0f6227fa16f7e990ee67db64e471e9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]

2024-06-12 Thread via GitHub
MartijnVisser commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636516611 ## pom.xml: ## @@ -2371,6 +2371,11 @@ under the License. org.apache.flink.util.function.Serializa

Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]

2024-06-12 Thread via GitHub
snuyanzin commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636561747 ## pom.xml: ## @@ -2371,6 +2371,11 @@ under the License. org.apache.flink.util.function.SerializableF

Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]

2024-06-12 Thread via GitHub
MartijnVisser commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636572746 ## pom.xml: ## @@ -2371,6 +2371,11 @@ under the License. org.apache.flink.util.function.Serializa

Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]

2024-06-12 Thread via GitHub
snuyanzin commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636579070 ## pom.xml: ## @@ -2371,6 +2371,11 @@ under the License. org.apache.flink.util.function.SerializableF

Re: [PR] [FLINK-34172] Add support for altering a distribution via ALTER TABLE [flink]

2024-06-12 Thread via GitHub
jnh5y commented on code in PR #24886: URL: https://github.com/apache/flink/pull/24886#discussion_r1636579991 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlDdlToOperationConverterTest.java: ## @@ -1361,16 +1374,36 @@ public void tes

Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]

2024-06-12 Thread via GitHub
MartijnVisser commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636585255 ## pom.xml: ## @@ -2371,6 +2371,11 @@ under the License. org.apache.flink.util.function.Serializa

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-12 Thread via GitHub
caicancai commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1636591482 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -26,21 +26,18 @@ under the License. # Pod template -The operator CRD is designed to

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-12 Thread via GitHub
caicancai commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1636591874 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -26,21 +26,18 @@ under the License. # Pod template -The operator CRD is designed to

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-12 Thread via GitHub
caicancai commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1636593004 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -93,16 +90,18 @@ spec: ``` {{< hint info >}} -When using the operator with Flink nati

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-12 Thread via GitHub
caicancai commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1636593737 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -113,10 +112,10 @@ arr1: [{name: a, p2: v2}, {name: c, p2: v2}] merged: [{name: a, p1: v

Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]

2024-06-12 Thread via GitHub
snuyanzin commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636593978 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/PrintSinkFunction.java: ## @@ -33,7 +33,10 @@ * no {@code sinkIdentifier} provid

Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]

2024-06-12 Thread via GitHub
snuyanzin commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636593978 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/PrintSinkFunction.java: ## @@ -33,7 +33,10 @@ * no {@code sinkIdentifier} provid

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-12 Thread via GitHub
caicancai commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1636594307 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -125,4 +124,4 @@ arr1: [{name: a, p2: v2}, {name: c, p2: v2}] merged: [{name: a, p1: v1,

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-12 Thread via GitHub
caicancai commented on PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#issuecomment-2163186911 @1996fanrui I'm very sorry for the late revision. I've been a bit busy recently. I'll check it again tomorrow. You don't need to review it yet. -- This is an automate

Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]

2024-06-12 Thread via GitHub
MartijnVisser commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636642416 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/PrintSinkFunction.java: ## @@ -33,7 +33,10 @@ * no {@code sinkIdentifier} pr

Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]

2024-06-12 Thread via GitHub
snuyanzin commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636593978 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/PrintSinkFunction.java: ## @@ -33,7 +33,10 @@ * no {@code sinkIdentifier} provid

Re: [PR] [FLINK-34977][API] Introduce State Access on DataStream API V2 [flink]

2024-06-12 Thread via GitHub
jeyhunkarimov commented on PR #24725: URL: https://github.com/apache/flink/pull/24725#issuecomment-2163282560 Thanks a lot @reswqa -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [FLINK-35371][security] Add configuration for SSL keystore and truststore type [flink]

2024-06-12 Thread via GitHub
ammar-master commented on PR #24919: URL: https://github.com/apache/flink/pull/24919#issuecomment-2163411240 @gaborgsomogyi Can this go in before the feature freeze on June 15? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Commented] (FLINK-35569) SnapshotFileMergingCompatibilityITCase#testSwitchFromEnablingToDisablingFileMerging failed

2024-06-12 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854480#comment-17854480 ] Zakelly Lan commented on FLINK-35569: - Fixed by FLINK-35570, Newest run: https://git

[jira] [Commented] (FLINK-35570) Consider PlaceholderStreamStateHandle in checkpoint file merging

2024-06-12 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854477#comment-17854477 ] Zakelly Lan commented on FLINK-35570: - master: fb5fd483f91f524c81130c0fc4125d3382a7f

[jira] [Resolved] (FLINK-35570) Consider PlaceholderStreamStateHandle in checkpoint file merging

2024-06-12 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan resolved FLINK-35570. - Resolution: Fixed > Consider PlaceholderStreamStateHandle in checkpoint file merging > -

[jira] [Resolved] (FLINK-35569) SnapshotFileMergingCompatibilityITCase#testSwitchFromEnablingToDisablingFileMerging failed

2024-06-12 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan resolved FLINK-35569. - Resolution: Fixed > SnapshotFileMergingCompatibilityITCase#testSwitchFromEnablingToDisablingFile

[jira] [Commented] (FLINK-28915) Make application mode could support remote DFS schema(e.g. S3, OSS, HDFS, etc.)

2024-06-12 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854505#comment-17854505 ] Robert Metzger commented on FLINK-28915: Awesome, thanks a lot. > Make applica

[PR] [hotfix][checkpointing] Normalize file-merging sub dir [flink]

2024-06-12 Thread via GitHub
zoltar9264 opened a new pull request, #24928: URL: https://github.com/apache/flink/pull/24928 ## What is the purpose of the change As title said, normalize file-merging sub dir, including subtask dir and exclusive dir. ## Brief change log *(for example:)* - *The

Re: [PR] [hotfix][checkpointing] Normalize file-merging sub dir [flink]

2024-06-12 Thread via GitHub
flinkbot commented on PR #24928: URL: https://github.com/apache/flink/pull/24928#issuecomment-2163701730 ## CI report: * a0719f7e58a3666e9ea39ce673c47a58679c38e6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

  1   2   >