Re: [PR] [FLINK-35424][connectors/elasticsearch] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
reta commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1613490458 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8AsyncSinkBuilder.java: ## @@ -100,16 +111,

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-05-24 Thread via GitHub
caicancai commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1613512120 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -93,16 +90,18 @@ spec: ``` {{< hint info >}} -When using the operator with Flink nati

[jira] [Commented] (FLINK-35446) FileMergingSnapshotManagerBase throws a NullPointerException

2024-05-24 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849323#comment-17849323 ] Zakelly Lan commented on FLINK-35446: - [~rskraba] Thanks for letting me know! I'll f

[PR] [FLINK-35446] Fix NPE when disabling checkpoint file merging but restore from merged files [flink]

2024-05-24 Thread via GitHub
Zakelly opened a new pull request, #24840: URL: https://github.com/apache/flink/pull/24840 ## What is the purpose of the change See FLINK-35446. It seems the file merging is disabled, thus the `FileMergingSnapshotManagerBase#initFileSystem` is never called. And at this time if we res

[jira] [Updated] (FLINK-35446) FileMergingSnapshotManagerBase throws a NullPointerException

2024-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35446: --- Labels: pull-request-available test-stability (was: test-stability) > FileMergingSnapshotMa

Re: [PR] [FLINK-35355][State] Internal async aggregating state and corresponding state descriptor [flink]

2024-05-24 Thread via GitHub
Zakelly commented on PR #24810: URL: https://github.com/apache/flink/pull/24810#issuecomment-2129836350 CI green, merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-35446] Fix NPE when disabling checkpoint file merging but restore from merged files [flink]

2024-05-24 Thread via GitHub
Zakelly commented on PR #24840: URL: https://github.com/apache/flink/pull/24840#issuecomment-2129858482 @fredia @ljz2051 Would you please take a look? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] [FLINK-35355][State] Internal async aggregating state and corresponding state descriptor [flink]

2024-05-24 Thread via GitHub
Zakelly closed pull request #24810: [FLINK-35355][State] Internal async aggregating state and corresponding state descriptor URL: https://github.com/apache/flink/pull/24810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Resolved] (FLINK-35355) Async aggregating state

2024-05-24 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan resolved FLINK-35355. - Fix Version/s: 2.0.0 Assignee: Jie Pu Resolution: Fixed > Async aggregating stat

[jira] [Commented] (FLINK-35355) Async aggregating state

2024-05-24 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849335#comment-17849335 ] Zakelly Lan commented on FLINK-35355: - Merged into master via 467f94f9ecef91b671ebbd

[jira] [Commented] (FLINK-35411) Optimize wait logic in draining of async state requests

2024-05-24 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849336#comment-17849336 ] Zakelly Lan commented on FLINK-35411: - [~spoon-lz] sure, will do. Thanks for your vo

Re: [PR] [FLINK-35424][connectors/elasticsearch] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
liuml07 commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1613694681 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8AsyncSinkBuilder.java: ## @@ -100,16 +1

Re: [PR] [FLINK-35316][tests] Run CDC E2e test with Flink 1.19 [flink-cdc]

2024-05-24 Thread via GitHub
yuxiqian commented on PR #3305: URL: https://github.com/apache/flink-cdc/pull/3305#issuecomment-2129877441 Addressed in #3348. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-35316][tests] Run CDC E2e test with Flink 1.19 [flink-cdc]

2024-05-24 Thread via GitHub
yuxiqian closed pull request #3305: [FLINK-35316][tests] Run CDC E2e test with Flink 1.19 URL: https://github.com/apache/flink-cdc/pull/3305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [FLINK-35446] Fix NPE when disabling checkpoint file merging but restore from merged files [flink]

2024-05-24 Thread via GitHub
flinkbot commented on PR #24840: URL: https://github.com/apache/flink/pull/24840#issuecomment-2129877895 ## CI report: * 5a78e68711f02ccaeb069376270649229d8c53c8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-34333) Fix FLINK-34007 LeaderElector bug in 1.18

2024-05-24 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-34333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849337#comment-17849337 ] Pedro Mázala commented on FLINK-34333: -- I've just done it. Thank you for porting it

Re: [PR] [FLINK-35424][connectors/elasticsearch] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
liuml07 commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1613711076 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java: ## @@ -0,0 +1,69 @@ +pa

Re: [PR] [FLINK-35424] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
reta commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1613717772 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java: ## @@ -0,0 +1,69 @@ +packa

Re: [PR] [FLINK-35424] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
liuml07 commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1613758123 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java: ## @@ -0,0 +1,69 @@ +pa

Re: [PR] [FLINK-31223][sqlgateway] Introduce getFlinkConfigurationOptions to [flink]

2024-05-24 Thread via GitHub
davidradl commented on PR #24741: URL: https://github.com/apache/flink/pull/24741#issuecomment-2130035074 @reswqa all clean now. I did not backport the 1.19 change at that method was not there at 1.18. I was hoping that I could backport commit 06b3708 which introduces the getMap change to

[jira] [Commented] (FLINK-35285) Autoscaler key group optimization can interfere with scale-down.max-factor

2024-05-24 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849352#comment-17849352 ] Trystan commented on FLINK-35285: - [~gyfora] is there maybe another setting that can hel

[jira] [Comment Edited] (FLINK-35285) Autoscaler key group optimization can interfere with scale-down.max-factor

2024-05-24 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849352#comment-17849352 ] Trystan edited comment on FLINK-35285 at 5/24/24 5:34 PM: -- [~gy

Re: [PR] [FLINK-33759] [flink-parquet] Add support for nested array with row/map/array type [flink]

2024-05-24 Thread via GitHub
JingGe commented on PR #24795: URL: https://github.com/apache/flink/pull/24795#issuecomment-2130067792 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-33759] [flink-parquet] Add support for nested array with row/map/array type [flink]

2024-05-24 Thread via GitHub
JingGe commented on PR #24795: URL: https://github.com/apache/flink/pull/24795#issuecomment-2130068966 @ViktorCosenza did you rebase? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-30687][table] Support pushdown for aggregate filters [flink]

2024-05-24 Thread via GitHub
jeyhunkarimov commented on PR #24660: URL: https://github.com/apache/flink/pull/24660#issuecomment-2130159573 Hi @JingGe , I added support for multiple aggregates with the same filter (to push down their filters). Could you please check the PR in your available time? Thanks! -- This is a

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-24 Thread via GitHub
dannycranmer commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1613883830 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBase.java: ## @@ -54,6 +54,8 @@ public abstract class AsyncSin

Re: [PR] [FLINK-33759] [flink-parquet] Add support for nested array with row/map/array type [flink]

2024-05-24 Thread via GitHub
ViktorCosenza commented on PR #24795: URL: https://github.com/apache/flink/pull/24795#issuecomment-2130263489 > @ViktorCosenza did you rebase? Yes, i did an interactive rebase and then force-pushed the squashed commits -- This is an automated message from the Apache Git Service. To

[jira] [Comment Edited] (FLINK-35285) Autoscaler key group optimization can interfere with scale-down.max-factor

2024-05-24 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849352#comment-17849352 ] Trystan edited comment on FLINK-35285 at 5/24/24 8:41 PM: -- [~gy

Re: [PR] [FLINK-35424] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
liuml07 commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1614194871 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java: ## @@ -0,0 +1,69 @@ +pa

Re: [PR] [FLINK-35424] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
reta commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1614235030 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java: ## @@ -0,0 +1,69 @@ +packa

Re: [PR] [FLINK-35424] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
liuml07 commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1614242366 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java: ## @@ -0,0 +1,69 @@ +pa

Re: [PR] [FLINK-33892][runtime] Support Job Recovery from JobMaster Failures for Batch Jobs. [flink]

2024-05-24 Thread via GitHub
JunRuiLee commented on PR #24771: URL: https://github.com/apache/flink/pull/24771#issuecomment-2130666752 Thanks @zhuzhurk for the thorough review. I have refactored the BatchJobRecoveryTest and JMFailoverITCase based on your comments. PTAL. -- This is an automated message from th

[jira] [Created] (FLINK-35449) MySQL CDC Flink SQL column names are case-sensitive

2024-05-24 Thread linweijiang (Jira)
linweijiang created FLINK-35449: --- Summary: MySQL CDC Flink SQL column names are case-sensitive Key: FLINK-35449 URL: https://issues.apache.org/jira/browse/FLINK-35449 Project: Flink Issue Type:

Re: [PR] [FLINK-35242] Optimize schema evolution & add SE IT cases [flink-cdc]

2024-05-24 Thread via GitHub
hk-lrzy commented on code in PR #3339: URL: https://github.com/apache/flink-cdc/pull/3339#discussion_r1612861870 ## flink-cdc-composer/src/main/java/org/apache/flink/cdc/composer/flink/translator/SchemaOperatorTranslator.java: ## @@ -58,12 +59,18 @@ public DataStream translate(

Re: [PR] [FLINK-35242] Optimize schema evolution & add SE IT cases [flink-cdc]

2024-05-24 Thread via GitHub
hk-lrzy commented on code in PR #3339: URL: https://github.com/apache/flink-cdc/pull/3339#discussion_r1614307385 ## flink-cdc-composer/src/main/java/org/apache/flink/cdc/composer/flink/translator/SchemaOperatorTranslator.java: ## @@ -58,12 +59,18 @@ public DataStream translate(

<    1   2