GOODBOY008 commented on PR #24730:
URL: https://github.com/apache/flink/pull/24730#issuecomment-2094663611
@afedulov Would you help review this pr? Thank you~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
Samrat002 commented on code in PR #114:
URL:
https://github.com/apache/flink-connector-aws/pull/114#discussion_r1590269554
##
flink-connector-aws/flink-connector-redshift/src/main/java/org/apache/flink/connector/redshift/table/RedshiftDynamicTableFactory.java:
##
@@ -0,0 +1,213
Samrat002 commented on code in PR #114:
URL:
https://github.com/apache/flink-connector-aws/pull/114#discussion_r1590270090
##
flink-connector-aws/flink-connector-redshift/src/main/java/org/apache/flink/connector/redshift/table/RedshiftDynamicTableFactory.java:
##
@@ -0,0 +1,213
Samrat002 commented on PR #114:
URL:
https://github.com/apache/flink-connector-aws/pull/114#issuecomment-2094737962
> I have left some comments, I will continue the review later. I believe
this PR is incomplete right? we still need to add tests.
yes , tests were not added , since it
wzorgdrager opened a new pull request, #24756:
URL: https://github.com/apache/flink/pull/24756
## What is the purpose of the change
This pull request adds support for a membership check for field names in a
Row in PyFlink. If field names are not defined, it will check membership i
[
https://issues.apache.org/jira/browse/FLINK-35112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-35112:
---
Labels: pull-request-available (was: )
> Membership for Row class does not include field na
flinkbot commented on PR #24756:
URL: https://github.com/apache/flink/pull/24756#issuecomment-2094773254
## CI report:
* ebca67d26c29e755aef515140ad2aacc6a6e6835 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
Wouter Zorgdrager created FLINK-35290:
-
Summary: Wrong Instant type conversion TableAPI to Datastream in
thread mode
Key: FLINK-35290
URL: https://issues.apache.org/jira/browse/FLINK-35290
Project
[
https://issues.apache.org/jira/browse/FLINK-35290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843572#comment-17843572
]
Wouter Zorgdrager commented on FLINK-35290:
---
It seems this bug has already bee
[
https://issues.apache.org/jira/browse/FLINK-35290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wouter Zorgdrager closed FLINK-35290.
-
Resolution: Duplicate
> Wrong Instant type conversion TableAPI to Datastream in thread m
[
https://issues.apache.org/jira/browse/FLINK-35180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843573#comment-17843573
]
Wouter Zorgdrager commented on FLINK-35180:
---
I have encountered the same bug.
HCTommy commented on PR #24747:
URL: https://github.com/apache/flink/pull/24747#issuecomment-2094854809
Hi, @fredia . I optimized some logs, which I think is helpful for people to
debug in production environment. Could you please review in your available time.
--
This is an automated mess
LiuZeshan created FLINK-35291:
-
Summary: Improve the ROW data deserialization performance of
DebeziumEventDeserializationScheme
Key: FLINK-35291
URL: https://issues.apache.org/jira/browse/FLINK-35291
Proj
[
https://issues.apache.org/jira/browse/FLINK-35291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-35291:
---
Labels: pull-request-available (was: )
> Improve the ROW data deserialization performance o
[
https://issues.apache.org/jira/browse/FLINK-35291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
LiuZeshan updated FLINK-35291:
--
Description:
We are doing performance testing on Flink cdc 3.0 and found through the arthas
profile t
jeyhunkarimov commented on PR #24744:
URL: https://github.com/apache/flink/pull/24744#issuecomment-2094879998
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
jeyhunkarimov commented on PR #24743:
URL: https://github.com/apache/flink/pull/24743#issuecomment-2094931086
Hi @lsyldliu should be fixed now. Could you please check? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
jeyhunkarimov commented on PR #24744:
URL: https://github.com/apache/flink/pull/24744#issuecomment-2094931570
Hi @lsyldliu the failure was related to sth else IMO, I could not reproduce
locally. In fact, retriggering the CI seems to green.
--
This is an automated message from the Apache
lsyldliu merged PR #24743:
URL: https://github.com/apache/flink/pull/24743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apac
Jiabao-Sun merged PR #24723:
URL: https://github.com/apache/flink/pull/24723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.ap
lsyldliu merged PR #24744:
URL: https://github.com/apache/flink/pull/24744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apac
[
https://issues.apache.org/jira/browse/FLINK-34379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842220#comment-17842220
]
dalongliu edited comment on FLINK-34379 at 5/6/24 1:16 AM:
---
Re
[
https://issues.apache.org/jira/browse/FLINK-34379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dalongliu updated FLINK-34379:
--
Fix Version/s: 1.17.3
1.18.2
> table.optimizer.dynamic-filtering.enabled lead to Ou
[
https://issues.apache.org/jira/browse/FLINK-32843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiabao Sun resolved FLINK-32843.
Fix Version/s: 1.20.0
Resolution: Fixed
Resolved via master: beb0b167bdcf95f27be87a214a69a1
luoyuxia commented on PR #24656:
URL: https://github.com/apache/flink/pull/24656#issuecomment-2095050182
@JustinLeesin Thanks for the pr!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
luoyuxia merged PR #24656:
URL: https://github.com/apache/flink/pull/24656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apac
[
https://issues.apache.org/jira/browse/FLINK-34517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823069#comment-17823069
]
luoyuxia edited comment on FLINK-34517 at 5/6/24 1:27 AM:
--
1.18
[
https://issues.apache.org/jira/browse/FLINK-34517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
luoyuxia resolved FLINK-34517.
--
Fix Version/s: 1.18.2
1.20.0
1.19.1
Resolution: Fixed
> e
Jiabao-Sun merged PR #3265:
URL: https://github.com/apache/flink-cdc/pull/3265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.
[
https://issues.apache.org/jira/browse/FLINK-35244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiabao Sun updated FLINK-35244:
---
Summary: Correct the package for flink-connector-tidb-cdc test (was: Move
package for flink-connec
[
https://issues.apache.org/jira/browse/FLINK-35244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiabao Sun resolved FLINK-35244.
Fix Version/s: cdc-3.2.0
Resolution: Fixed
Resolved via cdc-master: 002b16ed4e155b01374040f
[
https://issues.apache.org/jira/browse/FLINK-35244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiabao Sun closed FLINK-35244.
--
> Correct the package for flink-connector-tidb-cdc test
> ---
xieyi888 closed pull request #1974: [tidb] Add metrics for tidb connector
URL: https://github.com/apache/flink-cdc/pull/1974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
AidenPerce closed pull request #2968: [fix] repair a snapshot-split bug:
URL: https://github.com/apache/flink-cdc/pull/2968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
xieyi888 commented on code in PR #3266:
URL: https://github.com/apache/flink-cdc/pull/3266#discussion_r1590486774
##
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-tidb-cdc/src/test/java/org/apache/flink/cdc/connectors/tidb/metrics/TiDBSourceMetricsTest.java:
##
@
[
https://issues.apache.org/jira/browse/FLINK-35232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843606#comment-17843606
]
Xintong Song commented on FLINK-35232:
--
I think we can just move forward with this
masteryhx commented on code in PR #24740:
URL: https://github.com/apache/flink/pull/24740#discussion_r1590495309
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/asyncprocessing/AbstractAsyncStateStreamOperator.java:
##
@@ -74,15 +76,20 @@ publi
AidenPerce commented on PR #2968:
URL: https://github.com/apache/flink-cdc/pull/2968#issuecomment-2095121064
> Hi @AidenPerce, could you please rebase this PR with latest `master`
branch before it could be merged? Renaming like `com.ververica.cdc` to
`org.apache.flink.cdc` might be necessar
[
https://issues.apache.org/jira/browse/FLINK-35232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843612#comment-17843612
]
Vikas M commented on FLINK-35232:
-
> BTW, the ticket is currently assigned to [~singhrav
[
https://issues.apache.org/jira/browse/FLINK-35232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843615#comment-17843615
]
Xintong Song commented on FLINK-35232:
--
Thanks for the information. I'm assigning t
[
https://issues.apache.org/jira/browse/FLINK-35232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xintong Song reassigned FLINK-35232:
Assignee: Oleksandr Nitavskyi (was: Ravi Singh)
> Support for retry settings on GCS conn
fredia commented on code in PR #24740:
URL: https://github.com/apache/flink/pull/24740#discussion_r1590503035
##
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java:
##
@@ -104,15 +105,21 @@ public class AsyncExecutionController imp
yuxiqian commented on PR #2968:
URL: https://github.com/apache/flink-cdc/pull/2968#issuecomment-2095235515
Hi @AidenPerce, sorry about the inconvenience. I think it's related to a
glitch in Db2 incremental connector and should be fixed by #3283. Will try to
get it merged asap.
--
This is
xieyi888 commented on PR #3266:
URL: https://github.com/apache/flink-cdc/pull/3266#issuecomment-2095236881
@yuxiqian @czy006 I had made changes, Please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
Jiabao-Sun merged PR #3284:
URL: https://github.com/apache/flink-cdc/pull/3284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.
Jiabao-Sun merged PR #3283:
URL: https://github.com/apache/flink-cdc/pull/3283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.
[
https://issues.apache.org/jira/browse/FLINK-35274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiabao Sun reassigned FLINK-35274:
--
Assignee: Xin Gong
> Occasional failure issue with Flink CDC Db2 UT
> ---
yuxiqian commented on PR #2968:
URL: https://github.com/apache/flink-cdc/pull/2968#issuecomment-2095245702
Hi @AidenPerce, the Db2 CI fix has been merged into `master` branch, could
you please rebase this PR and see if this problem persists? Thank you!
--
This is an automated message from
[
https://issues.apache.org/jira/browse/FLINK-35274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiabao Sun resolved FLINK-35274.
Resolution: Fixed
Fixed via cdc
* master: a7cb46f7621568486a069a7ae01a7b86ebb0a801
* release-3.1:
[
https://issues.apache.org/jira/browse/FLINK-35274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiabao Sun closed FLINK-35274.
--
> Occasional failure issue with Flink CDC Db2 UT
> --
>
>
Zakelly commented on code in PR #24739:
URL: https://github.com/apache/flink/pull/24739#discussion_r1590582493
##
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStStateRequestClassifier.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to t
Zakelly commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1590597054
##
flink-core/src/main/java/org/apache/flink/core/state/StateFutureImpl.java:
##
@@ -61,23 +66,34 @@ public StateFuture thenApply(Function fn) {
retur
masteryhx commented on code in PR #24740:
URL: https://github.com/apache/flink/pull/24740#discussion_r1590604525
##
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java:
##
@@ -104,15 +105,21 @@ public class AsyncExecutionController
masteryhx commented on code in PR #24740:
URL: https://github.com/apache/flink/pull/24740#discussion_r1590608598
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamingRuntimeContext.java:
##
@@ -242,6 +248,25 @@ private KeyedStateStore
checkPre
masteryhx commented on code in PR #24740:
URL: https://github.com/apache/flink/pull/24740#discussion_r1590609918
##
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStKeyedStateBackendBuilder.java:
##
@@ -54,7 +59,14 @@ public class For
55 matches
Mail list logo
