[jira] [Assigned] (FLINK-34190) Deprecate RestoreMode#LEGACY

2024-01-22 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan reassigned FLINK-34190: --- Assignee: Zakelly Lan > Deprecate RestoreMode#LEGACY > > >

[jira] [Created] (FLINK-34192) Update flink-connector-kafka to be compatible with updated SinkV2 interfaces

2024-01-22 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-34192: -- Summary: Update flink-connector-kafka to be compatible with updated SinkV2 interfaces Key: FLINK-34192 URL: https://issues.apache.org/jira/browse/FLINK-34192 Proj

[jira] [Created] (FLINK-34193) Remove usage of Flink-Shaded Jackson and Snakeyaml in flink-connector-kafka

2024-01-22 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-34193: -- Summary: Remove usage of Flink-Shaded Jackson and Snakeyaml in flink-connector-kafka Key: FLINK-34193 URL: https://issues.apache.org/jira/browse/FLINK-34193 Proje

[jira] [Updated] (FLINK-33728) Do not rewatch when KubernetesResourceManagerDriver watch fail

2024-01-22 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaogang zhou updated FLINK-33728: -- Summary: Do not rewatch when KubernetesResourceManagerDriver watch fail (was: do not rewatch

Re: [PR] [FLINK-34029][runtime-web] Support different profiling mode on Flink WEB [flink]

2024-01-22 Thread via GitHub
Myasuka commented on code in PR #24130: URL: https://github.com/apache/flink/pull/24130#discussion_r1461481473 ## flink-runtime-web/web-dashboard/src/app/pages/job-manager/profiler/job-manager-profiler.component.html: ## @@ -31,6 +31,58 @@ > +

Re: [PR] [FLINK-32732][Connectors/Kafka] auto offset reset should be exposed t… [flink-connector-kafka]

2024-01-22 Thread via GitHub
MartijnVisser commented on PR #43: URL: https://github.com/apache/flink-connector-kafka/pull/43#issuecomment-1903470974 That should always be {{main}} Scanning through your PR, I would not expect this PR to be currently mergable. It's a one line code change, there's no test involved, and

[jira] [Created] (FLINK-34194) Upgrade Flink CI Docker container to Ubuntu 22.04

2024-01-22 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-34194: - Summary: Upgrade Flink CI Docker container to Ubuntu 22.04 Key: FLINK-34194 URL: https://issues.apache.org/jira/browse/FLINK-34194 Project: Flink Issue Typ

Re: [PR] [hotfix] Update version to 18.0 [flink-shaded]

2024-01-22 Thread via GitHub
MartijnVisser commented on code in PR #133: URL: https://github.com/apache/flink-shaded/pull/133#discussion_r1461508729 ## flink-shaded-asm-9/pom.xml: ## @@ -25,11 +25,11 @@ under the License. org.apache.flink flink-shaded -17.0 +18.0 Rev

[PR] [FLINK-33728] Do not rewatch when KubernetesResourceManagerDriver wat… [flink]

2024-01-22 Thread via GitHub
zhougit86 opened a new pull request, #24163: URL: https://github.com/apache/flink/pull/24163 …ch fail ## What is the purpose of the change prevent jm restart in case kubernetes fails to handle watch request ## Brief change log use ExponentialBackoffRetr

[jira] [Commented] (FLINK-24544) Failure when using Kafka connector in Table API with Avro and Confluent schema registry

2024-01-22 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809306#comment-17809306 ] Martijn Visser commented on FLINK-24544: Not soon, but we're looking into it >

Re: [PR] [FLINK-33728] Do not rewatch when KubernetesResourceManagerDriver wat… [flink]

2024-01-22 Thread via GitHub
flinkbot commented on PR #24163: URL: https://github.com/apache/flink/pull/24163#issuecomment-1903516752 ## CI report: * 67741049ceefd714af4f21588c63d222104a9e88 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-34135) A number of ci failures with Access to the path '.../_work/_temp/containerHandlerInvoker.js' is denied.

2024-01-22 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809307#comment-17809307 ] Martijn Visser commented on FLINK-34135: It looks to be stable again > A number

[jira] [Assigned] (FLINK-34174) Remove SlotMatchingStrategy related logic

2024-01-22 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-34174: --- Assignee: RocMarshal > Remove SlotMatchingStrategy related logic >

[jira] [Created] (FLINK-34195) PythonEnvUtils creates python environment instead of python3

2024-01-22 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-34195: - Summary: PythonEnvUtils creates python environment instead of python3 Key: FLINK-34195 URL: https://issues.apache.org/jira/browse/FLINK-34195 Project: Flink

[jira] [Commented] (FLINK-34195) PythonEnvUtils creates python environment instead of python3

2024-01-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809312#comment-17809312 ] Matthias Pohl commented on FLINK-34195: --- [~hxbks2ks] I'm curious what's your take

[jira] [Updated] (FLINK-34195) PythonEnvUtils creates python environment instead of python3

2024-01-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34195: -- Component/s: Build System / CI > PythonEnvUtils creates python environment instead of python3

Re: [PR] [FLINK-32738][formats] PROTOBUF format supports projection push down [flink]

2024-01-22 Thread via GitHub
zhougit86 commented on PR #23323: URL: https://github.com/apache/flink/pull/23323#issuecomment-1903547494 @ljw-hit @libenchao Hi Bro, would you please help review this commit again? Do you think it necessary to create 2 constructor [PbDecodingFormat.java](https://github.com/apache/flink/pul

Re: [PR] [FLINK-33198][Format/Avro] support local timezone timestamp logic type in AVRO [flink]

2024-01-22 Thread via GitHub
leonardBang commented on code in PR #23511: URL: https://github.com/apache/flink/pull/23511#discussion_r1461554379 ## flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowDeserializationSchema.java: ## @@ -339,7 +365,7 @@ private Time convertToTime(Object

Re: [PR] [FLINK-33198][Format/Avro] support local timezone timestamp logic type in AVRO [flink]

2024-01-22 Thread via GitHub
HuangZhenQiu commented on code in PR #23511: URL: https://github.com/apache/flink/pull/23511#discussion_r1461558894 ## pom.xml: ## @@ -1840,7 +1840,7 @@ under the License.

[jira] [Commented] (FLINK-33696) FLIP-385: Add OpenTelemetryTraceReporter and OpenTelemetryMetricReporter

2024-01-22 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809320#comment-17809320 ] Yun Tang commented on FLINK-33696: -- [~pnowojski], is this ticket done for FLIP-385? >

Re: [PR] [FLINK-34055][table] Introduce a new annotation for named parameters [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #24106: URL: https://github.com/apache/flink/pull/24106#discussion_r1461382300 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/annotation/ProcedureHint.java: ## @@ -139,6 +139,17 @@ */ String[] argumentNames()

Re: [PR] [FLINK-21949][table] Support ARRAY_AGG aggregate function [flink]

2024-01-22 Thread via GitHub
Jiabao-Sun commented on PR #23411: URL: https://github.com/apache/flink/pull/23411#issuecomment-1903588731 Hi @dawidwys, please help review it again when you have time. Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-33198][Format/Avro] support local timezone timestamp logic type in AVRO [flink]

2024-01-22 Thread via GitHub
HuangZhenQiu commented on PR #23511: URL: https://github.com/apache/flink/pull/23511#issuecomment-1903590986 @leonardBang Thanks for the comprehensive review. It not help me dig out the bug, and also make the feature easy to use by adding more context in variable name, flag description

Re: [PR] [FLINK-33198][Format/Avro] support local timezone timestamp logic type in AVRO [flink]

2024-01-22 Thread via GitHub
leonardBang commented on code in PR #23511: URL: https://github.com/apache/flink/pull/23511#discussion_r1461573969 ## flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroFormatFactory.java: ## @@ -61,6 +62,7 @@ public DecodingFormat> createDecodingFormat(

Re: [PR] [FLINK-25509][connector/kafka] Add RecordEvaluator to dynamically stop source based on de-serialized records [flink-connector-kafka]

2024-01-22 Thread via GitHub
ruanhang1993 commented on PR #76: URL: https://github.com/apache/flink-connector-kafka/pull/76#issuecomment-1903610004 Thanks, @MartijnVisser . This PR relies on the API changes in FLIP-208, which released in 1.18. So we need wait until the Flink 1.17 is dropped in Kafka connector

Re: [PR] [FLINK-33721][core] Extend BashJavaUtils to support reading and writing standard yaml file. [flink]

2024-01-22 Thread via GitHub
zhuzhurk commented on code in PR #24091: URL: https://github.com/apache/flink/pull/24091#discussion_r1461460681 ## flink-runtime/src/main/java/org/apache/flink/runtime/util/bash/BashJavaUtils.java: ## @@ -175,6 +176,9 @@ public enum Command { GET_TM_RESOURCE_PARAMS,

Re: [PR] [FLINK-34178][autoscaler] Fix the bug that observed scaling restart time is always great than `stabilization.interval` [flink-kubernetes-operator]

2024-01-22 Thread via GitHub
mxm commented on code in PR #759: URL: https://github.com/apache/flink-kubernetes-operator/pull/759#discussion_r1461587441 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java: ## @@ -160,14 +160,23 @@ private void runScalingLogic(Context ctx, A

Re: [PR] [hotfix][table] Avoid KeyedLookupJoinWrapper sending duplicate delete record for left join when state expired [flink]

2024-01-22 Thread via GitHub
flinkbot commented on PR #24164: URL: https://github.com/apache/flink/pull/24164#issuecomment-1903627979 ## CI report: * 3df653a9d45cfe8f65818a6556020042c4429e55 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-25509][connector/kafka] Add RecordEvaluator to dynamically stop source based on de-serialized records [flink-connector-kafka]

2024-01-22 Thread via GitHub
MartijnVisser commented on PR #76: URL: https://github.com/apache/flink-connector-kafka/pull/76#issuecomment-1903631209 > So we need wait until the Flink 1.17 is dropped in Kafka connector and use the 1.18 Flink to check this PR. @ruanhang1993 I think that means that in this PR, you'

Re: [PR] [FLINK-33198][Format/Avro] support local timezone timestamp logic type in AVRO [flink]

2024-01-22 Thread via GitHub
HuangZhenQiu commented on code in PR #23511: URL: https://github.com/apache/flink/pull/23511#discussion_r1461602408 ## flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroFormatFactory.java: ## @@ -61,6 +62,7 @@ public DecodingFormat> createDecodingFormat(

[jira] [Assigned] (FLINK-34194) Upgrade Flink CI Docker container to Ubuntu 22.04

2024-01-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-34194: - Assignee: Matthias Pohl > Upgrade Flink CI Docker container to Ubuntu 22.04 > -

[jira] [Updated] (FLINK-34194) Upgrade Flink CI Docker container to Ubuntu 22.04

2024-01-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34194: -- Description: The current CI Docker image is based on Ubuntu 16.04. We already use 20.04 for t

[PR] [FLINK-34194][ci] Updates test CI container to be based on Ubuntu 22.04 [flink]

2024-01-22 Thread via GitHub
XComp opened a new pull request, #24165: URL: https://github.com/apache/flink/pull/24165 ## What is the purpose of the change The GitHub Actions workflow (FLINK-33901) requires us to upgrade to Ubuntu 22.04 (or 20.04) (see further details in sub-issue FLINK-33923). The Azure Pipeline

[jira] [Updated] (FLINK-34194) Upgrade Flink CI Docker container to Ubuntu 22.04

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34194: --- Labels: github-actions pull-request-available (was: github-actions) > Upgrade Flink CI Dock

Re: [PR] [FLINK-34194][ci] Updates test CI container to be based on Ubuntu 22.04 [flink]

2024-01-22 Thread via GitHub
flinkbot commented on PR #24165: URL: https://github.com/apache/flink/pull/24165#issuecomment-1903676042 ## CI report: * 3422abec3d7a03b3e98bed92d300a630b14b3f86 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34029][runtime-web] Support different profiling mode on Flink WEB [flink]

2024-01-22 Thread via GitHub
yuchen-ecnu commented on code in PR #24130: URL: https://github.com/apache/flink/pull/24130#discussion_r1461682660 ## flink-runtime-web/web-dashboard/src/app/pages/job-manager/profiler/job-manager-profiler.component.html: ## @@ -31,6 +31,58 @@ > +

[PR] Reference flink-connector-parent new 1.1.0 release [flink-web]

2024-01-22 Thread via GitHub
echauchot opened a new pull request, #717: URL: https://github.com/apache/flink-web/pull/717 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] [FLINK-33565][Scheduler] ConcurrentExceptions works with exception merging [flink]

2024-01-22 Thread via GitHub
1996fanrui commented on PR #24003: URL: https://github.com/apache/flink/pull/24003#issuecomment-1903758592 > LGTM 👍 Thanks for your efforts, @1996fanrui, and for keeping up with my nitty comments. I enjoyed the discussions in this PR. Thanks @XComp for the patient review, I definitely

Re: [PR] [FLINK-33768] Support dynamic source parallelism inference for batch jobs [flink]

2024-01-22 Thread via GitHub
zhuzhurk closed pull request #24087: [FLINK-33768] Support dynamic source parallelism inference for batch jobs URL: https://github.com/apache/flink/pull/24087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-33728] Do not rewatch when KubernetesResourceManagerDriver wat… [flink]

2024-01-22 Thread via GitHub
zhougit86 commented on PR #24163: URL: https://github.com/apache/flink/pull/24163#issuecomment-1903769843 @xintongsong Would you please take a look and let me know your thinking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Closed] (FLINK-33768) Support dynamic source parallelism inference for batch jobs

2024-01-22 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-33768. --- Fix Version/s: 1.19.0 Resolution: Done master/release-1.19: c3c836216eaaaf24c1add3b490c8f425fda01d7c

Re: [PR] [FLINK-23687][table-planner] Introduce partitioned lookup join to enforce input of LookupJoin to hash shuffle by lookup keys [flink]

2024-01-22 Thread via GitHub
LB-Yu commented on code in PR #24104: URL: https://github.com/apache/flink/pull/24104#discussion_r1461708094 ## docs/content/docs/dev/table/sql/queries/joins.md: ## @@ -326,6 +326,17 @@ FROM Orders AS o In the example above, the Orders table is enriched with data from the Cu

[jira] [Closed] (FLINK-34179) More than one taskmanager is not coming up in flink (session mode) in aws eks cluster

2024-01-22 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-34179. -- Resolution: Information Provided > More than one taskmanager is not coming up in flink (sessio

Re: [PR] [FLINK-23687][table-planner] Introduce partitioned lookup join to enforce input of LookupJoin to hash shuffle by lookup keys [flink]

2024-01-22 Thread via GitHub
LB-Yu commented on code in PR #24104: URL: https://github.com/apache/flink/pull/24104#discussion_r1461708094 ## docs/content/docs/dev/table/sql/queries/joins.md: ## @@ -326,6 +326,17 @@ FROM Orders AS o In the example above, the Orders table is enriched with data from the Cu

[jira] [Created] (FLINK-34196) FLIP-389 Annotate SingleThreadFetcherManager as PublicEvolving.

2024-01-22 Thread Hongshun Wang (Jira)
Hongshun Wang created FLINK-34196: - Summary: FLIP-389 Annotate SingleThreadFetcherManager as PublicEvolving. Key: FLINK-34196 URL: https://issues.apache.org/jira/browse/FLINK-34196 Project: Flink

[jira] [Commented] (FLINK-34196) FLIP-389 Annotate SingleThreadFetcherManager as PublicEvolving.

2024-01-22 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809400#comment-17809400 ] Hongshun Wang commented on FLINK-34196: --- [~renqs] , [~Leonard] , CC, WDYT? > FLIP

[jira] [Updated] (FLINK-33683) FLIP-407 Improve Flink Client performance in interactive scenarios

2024-01-22 Thread xiangyu feng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiangyu feng updated FLINK-33683: - Summary: FLIP-407 Improve Flink Client performance in interactive scenarios (was: Improve the p

[jira] [Created] (FLINK-34197) How can i recover job by savepoint with multi-job run by executeAsync in application mode

2024-01-22 Thread mazhenzz (Jira)
mazhenzz created FLINK-34197: Summary: How can i recover job by savepoint with multi-job run by executeAsync in application mode Key: FLINK-34197 URL: https://issues.apache.org/jira/browse/FLINK-34197 Pro

Re: [PR] [FLINK-34048][table] Support session window agg in table runtime instead of using legacy group window agg op [flink]

2024-01-22 Thread via GitHub
lsyldliu commented on code in PR #24150: URL: https://github.com/apache/flink/pull/24150#discussion_r1461306740 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/logical/WindowSpec.java: ## @@ -26,9 +27,19 @@ @JsonSubTypes({ @JsonSubTypes

Re: [PR] [FLINK-33565][Scheduler] ConcurrentExceptions works with exception merging [flink]

2024-01-22 Thread via GitHub
XComp commented on PR #24003: URL: https://github.com/apache/flink/pull/24003#issuecomment-1903887636 Fair enough. What about squashing the FLINK-33565-related commits into a single one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [FLINK-33721][core] Extend BashJavaUtils to support reading and writing standard yaml file. [flink]

2024-01-22 Thread via GitHub
zhuzhurk commented on code in PR #24091: URL: https://github.com/apache/flink/pull/24091#discussion_r1461756156 ## flink-dist/src/main/flink-bin/bin/config.sh: ## @@ -243,25 +210,13 @@ export FLINK_LIB_DIR # export /opt dir to access it for the SQL client export FLINK_OPT_DIR

[jira] [Closed] (FLINK-34197) How can i recover job by savepoint with multi-job run by executeAsync in application mode

2024-01-22 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-34197. -- Resolution: Not A Problem Please reach out to the User mailing list, Stackoverflow or Slack fo

Re: [PR] [hotfix][table] Avoid KeyedLookupJoinWrapper sending duplicate delete record for left join when state expired [flink]

2024-01-22 Thread via GitHub
lincoln-lil merged PR #24164: URL: https://github.com/apache/flink/pull/24164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

[jira] [Commented] (FLINK-33819) Support setting CompressType in RocksDBStateBackend

2024-01-22 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809419#comment-17809419 ] Yue Ma commented on FLINK-33819: [~pnowojski] [~masteryhx]  I conducted benchmark tests

[PR] [FLINK-34166][table] Fix KeyedLookupJoinWrapper incorrectly process delete message for inner join when previous lookup result is empty [flink]

2024-01-22 Thread via GitHub
lincoln-lil opened a new pull request, #24166: URL: https://github.com/apache/flink/pull/24166 This is a backport pr of FLINK-34166 into release-1.18 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[PR] [FLINK-34166][table] Fix KeyedLookupJoinWrapper incorrectly process delete message for inner join when previous lookup result is empty [flink]

2024-01-22 Thread via GitHub
lincoln-lil opened a new pull request, #24167: URL: https://github.com/apache/flink/pull/24167 This is a backport pr of [FLINK-34166](https://issues.apache.org/jira/browse/FLINK-34166) into release-1.17 branch. -- This is an automated message from the Apache Git Service. To respond to th

[jira] [Commented] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2024-01-22 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809424#comment-17809424 ] Martijn Visser commented on FLINK-33365: What's the status of this ticket? Are w

Re: [PR] [FLINK-34166][table] Fix KeyedLookupJoinWrapper incorrectly process delete message for inner join when previous lookup result is empty [flink]

2024-01-22 Thread via GitHub
flinkbot commented on PR #24166: URL: https://github.com/apache/flink/pull/24166#issuecomment-1903946231 ## CI report: * 19f63b20dac0bb49738e1a8c78a5935ce8e3d0cb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34166][table] Fix KeyedLookupJoinWrapper incorrectly process delete message for inner join when previous lookup result is empty [flink]

2024-01-22 Thread via GitHub
flinkbot commented on PR #24167: URL: https://github.com/apache/flink/pull/24167#issuecomment-1903947584 ## CI report: * 5667c5b74d23be1d5ed949729a5864f24ff30081 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] introduce BufferBundle for minibatch join [flink]

2024-01-22 Thread via GitHub
lsyldliu commented on code in PR #24159: URL: https://github.com/apache/flink/pull/24159#discussion_r1461803316 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/bundle/InputSideHasNoUniqueKeyBundle.java: ## @@ -0,0 +1,145 @@ +

Re: [PR] [FLINK-32073][checkpoint] Implement file merging in snapshot [flink]

2024-01-22 Thread via GitHub
AlexYinHan commented on PR #23514: URL: https://github.com/apache/flink/pull/23514#issuecomment-1903992993 @curcur I have addressed your comments by removing the unused codes and squashing the commits. The PR is now free of conflicts and has passed the CI tests. PTAL. -- This is an autom

Re: [PR] [FLINK-24024][table-planner] support session window tvf in plan [flink]

2024-01-22 Thread via GitHub
LadyForest commented on code in PR #23505: URL: https://github.com/apache/flink/pull/23505#discussion_r1461562152 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/SqlSessionTableFunction.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to

Re: [PR] [FLINK-34081][configuration] Refactor all callers of deprecated `getXxx(ConfigOption)`, `getXxx(ConfigOption, Xxx)` and `setXxx(ConfigOption, Xxx)` methods of Configuratio

2024-01-22 Thread via GitHub
1996fanrui commented on PR #24116: URL: https://github.com/apache/flink/pull/24116#issuecomment-1904004513 Thanks @Sxnan for the review. The CI is green, merging~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-34081][configuration] Refactor all callers of deprecated `getXxx(ConfigOption)`, `getXxx(ConfigOption, Xxx)` and `setXxx(ConfigOption, Xxx)` methods of Configuratio

2024-01-22 Thread via GitHub
1996fanrui merged PR #24116: URL: https://github.com/apache/flink/pull/24116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[jira] [Commented] (FLINK-34081) Refactor all callers that using the public Xxx getXxx(ConfigOption configOption) and public void setXxx(ConfigOption key, Xxx value)

2024-01-22 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809442#comment-17809442 ] Rui Fan commented on FLINK-34081: - Merged to master(1.19.0) via: c8f27c25e8726360bd09fd2

[jira] [Resolved] (FLINK-34081) Refactor all callers that using the public Xxx getXxx(ConfigOption configOption) and public void setXxx(ConfigOption key, Xxx value)

2024-01-22 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-34081. - Fix Version/s: 1.19.0 Resolution: Fixed > Refactor all callers that using the public Xxx getXxx(C

[jira] [Commented] (FLINK-30310) Re-enable e2e test error check

2024-01-22 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809448#comment-17809448 ] Gabor Somogyi commented on FLINK-30310: --- There are too many false positives becaus

[jira] [Resolved] (FLINK-30310) Re-enable e2e test error check

2024-01-22 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi resolved FLINK-30310. --- Resolution: Won't Fix > Re-enable e2e test error check > -- > >

[jira] [Closed] (FLINK-30310) Re-enable e2e test error check

2024-01-22 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi closed FLINK-30310. - > Re-enable e2e test error check > -- > > Key: FLINK-303

[jira] [Resolved] (FLINK-30147) Evaluate operator error log whitelist entry: Failed to submit a listener notification task

2024-01-22 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi resolved FLINK-30147. --- Resolution: Won't Fix See comment in FLINK-30310. > Evaluate operator error log whitelist e

[jira] [Closed] (FLINK-30148) Evaluate operator error log whitelist entry: Failed to submit job to session cluster

2024-01-22 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi closed FLINK-30148. - > Evaluate operator error log whitelist entry: Failed to submit job to session > cluster >

[jira] [Resolved] (FLINK-30148) Evaluate operator error log whitelist entry: Failed to submit job to session cluster

2024-01-22 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi resolved FLINK-30148. --- Resolution: Won't Fix See comment in FLINK-30310. > Evaluate operator error log whitelist e

[jira] [Closed] (FLINK-30147) Evaluate operator error log whitelist entry: Failed to submit a listener notification task

2024-01-22 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi closed FLINK-30147. - > Evaluate operator error log whitelist entry: Failed to submit a listener > notification task > --

[jira] [Closed] (FLINK-30149) Evaluate operator error log whitelist entry: Error during event processing

2024-01-22 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi closed FLINK-30149. - > Evaluate operator error log whitelist entry: Error during event processing > -

[jira] [Resolved] (FLINK-30149) Evaluate operator error log whitelist entry: Error during event processing

2024-01-22 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi resolved FLINK-30149. --- Resolution: Won't Fix See comment in FLINK-30310. > Evaluate operator error log whitelist e

[jira] [Closed] (FLINK-30117) Evaluate operator error log whitelist entries added in FLINK-29475

2024-01-22 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi closed FLINK-30117. - > Evaluate operator error log whitelist entries added in FLINK-29475 > -

[jira] [Resolved] (FLINK-30311) CI error: Back-off pulling image "flink:1.14"

2024-01-22 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi resolved FLINK-30311. --- Resolution: Won't Fix See comment in FLINK-30310. > CI error: Back-off pulling image "flink

[jira] [Closed] (FLINK-30283) Evaluate operator error log entry: Error while patching status

2024-01-22 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi closed FLINK-30283. - > Evaluate operator error log entry: Error while patching status > -

[jira] [Resolved] (FLINK-30283) Evaluate operator error log entry: Error while patching status

2024-01-22 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi resolved FLINK-30283. --- Resolution: Won't Fix See comment in FLINK-30310. > Evaluate operator error log entry: Erro

[jira] [Closed] (FLINK-30311) CI error: Back-off pulling image "flink:1.14"

2024-01-22 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi closed FLINK-30311. - > CI error: Back-off pulling image "flink:1.14" > - > >

[jira] [Resolved] (FLINK-30117) Evaluate operator error log whitelist entries added in FLINK-29475

2024-01-22 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi resolved FLINK-30117. --- Resolution: Won't Fix See comment in FLINK-30310. > Evaluate operator error log whitelist e

[jira] [Created] (FLINK-34198) Remove e2e test operator log error check

2024-01-22 Thread Gabor Somogyi (Jira)
Gabor Somogyi created FLINK-34198: - Summary: Remove e2e test operator log error check Key: FLINK-34198 URL: https://issues.apache.org/jira/browse/FLINK-34198 Project: Flink Issue Type: Improv

[jira] [Assigned] (FLINK-34198) Remove e2e test operator log error check

2024-01-22 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi reassigned FLINK-34198: - Assignee: Gabor Somogyi > Remove e2e test operator log error check > --

Re: [PR] [FLINK-32073][checkpoint] Implement file merging in snapshot [flink]

2024-01-22 Thread via GitHub
curcur merged PR #23514: URL: https://github.com/apache/flink/pull/23514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Comment Edited] (FLINK-34166) KeyedLookupJoinWrapper incorrectly process delete message for inner join when previous lookup result is empty

2024-01-22 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809254#comment-17809254 ] lincoln lee edited comment on FLINK-34166 at 1/22/24 2:03 PM:

[jira] [Commented] (FLINK-32073) Implement file merging in snapshot

2024-01-22 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809461#comment-17809461 ] Yuan Mei commented on FLINK-32073: -- merged commit  [{{f9f9299}}|https://github.com/apac

[jira] [Updated] (FLINK-34166) KeyedLookupJoinWrapper incorrectly process delete message for inner join when previous lookup result is empty

2024-01-22 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-34166: Fix Version/s: 1.17.3 > KeyedLookupJoinWrapper incorrectly process delete message for inner join w

[jira] [Resolved] (FLINK-34166) KeyedLookupJoinWrapper incorrectly process delete message for inner join when previous lookup result is empty

2024-01-22 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee resolved FLINK-34166. - Resolution: Fixed > KeyedLookupJoinWrapper incorrectly process delete message for inner join whe

[jira] [Closed] (FLINK-32073) Implement file merging in snapshot

2024-01-22 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Mei closed FLINK-32073. Resolution: Done > Implement file merging in snapshot > -- > >

[jira] [Updated] (FLINK-34165) It seems that Apache download link has been changed

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34165: --- Labels: pull-request-available (was: ) > It seems that Apache download link has been change

[jira] [Created] (FLINK-34199) Add tracing for durations of rescaling/restoring from local state

2024-01-22 Thread Stefan Richter (Jira)
Stefan Richter created FLINK-34199: -- Summary: Add tracing for durations of rescaling/restoring from local state Key: FLINK-34199 URL: https://issues.apache.org/jira/browse/FLINK-34199 Project: Flink

[jira] [Updated] (FLINK-34198) Remove e2e test operator log error check

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34198: --- Labels: pull-request-available (was: ) > Remove e2e test operator log error check > ---

Re: [PR] [FLINK-33914][ci] Adds basic Flink CI workflow [flink]

2024-01-22 Thread via GitHub
XComp commented on PR #23970: URL: https://github.com/apache/flink/pull/23970#issuecomment-1904151874 The past two force pushes add the following changes: * `--privileged` parameter was added * container image was changed to the result of FLINK-34194 -- This is an automated message f

[PR] [FLINK-34198] Remove e2e test operator log error check [flink-kubernetes-operator]

2024-01-22 Thread via GitHub
gaborgsomogyi opened a new pull request, #760: URL: https://github.com/apache/flink-kubernetes-operator/pull/760 ## What is the purpose of the change There is a dead test code inside the operator tests which was planned to be fixed and re-enabled. The code is planned to be checking th

Re: [PR] [FLINK-34198] Remove e2e test operator log error check [flink-kubernetes-operator]

2024-01-22 Thread via GitHub
gaborgsomogyi commented on PR #760: URL: https://github.com/apache/flink-kubernetes-operator/pull/760#issuecomment-1904149837 cc @gyfora -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [FLINK-33721][core] Extend BashJavaUtils to support reading and writing standard yaml file. [flink]

2024-01-22 Thread via GitHub
JunRuiLee commented on PR #24091: URL: https://github.com/apache/flink/pull/24091#issuecomment-1904156267 Thanks @zhuzhurk for the review, I've updated this pr accordingly, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] [FLINK-34199] Add tracing for durations of rescaling/restoring from local state [flink]

2024-01-22 Thread via GitHub
StefanRRichter opened a new pull request, #24168: URL: https://github.com/apache/flink/pull/24168 ## What is the purpose of the change This PR extends #24031 with traces for the rescaling/restore times from local state. ## Brief change log *(for example:)* - *Th

[jira] [Updated] (FLINK-34199) Add tracing for durations of rescaling/restoring from local state

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34199: --- Labels: pull-request-available (was: ) > Add tracing for durations of rescaling/restoring f

[jira] [Commented] (FLINK-31724) SqlClientITCase.testMatchRecognize fails with "bash -c rm -rf /opt/flink/checkpoint/*" returned non-zero exit code 1

2024-01-22 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809489#comment-17809489 ] Jiabao Sun commented on FLINK-31724: https://dev.azure.com/apache-flink/apache-flink

Re: [PR] [FLINK-34165] Update apache download url [flink-docker]

2024-01-22 Thread via GitHub
JingGe commented on PR #170: URL: https://github.com/apache/flink-docker/pull/170#issuecomment-1904192403 @MartijnVisser yes, https://dlcdn.apache.org/ is another option which works too. I will update to use that one. Thanks! -- This is an automated message from the Apache Git Service. To

  1   2   3   >