Re: [PR] [FLINK-33771] Add cluster capacity awareness to autoscaler [flink-kubernetes-operator]

2024-01-12 Thread via GitHub
gyfora commented on code in PR #751: URL: https://github.com/apache/flink-kubernetes-operator/pull/751#discussion_r1449992691 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/FlinkOperator.java: ## @@ -165,7 +167,12 @@ void registerDeploymentContr

Re: [PR] [FLINK-33771] Add cluster capacity awareness to autoscaler [flink-kubernetes-operator]

2024-01-12 Thread via GitHub
gyfora commented on code in PR #751: URL: https://github.com/apache/flink-kubernetes-operator/pull/751#discussion_r1450004070 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/resources/ClusterResourceManager.java: ## @@ -0,0 +1,282 @@ +/* + * Lice

Re: [PR] [FLINK-33771] Add cluster capacity awareness to autoscaler [flink-kubernetes-operator]

2024-01-12 Thread via GitHub
gyfora commented on code in PR #751: URL: https://github.com/apache/flink-kubernetes-operator/pull/751#discussion_r1450006326 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/resources/ClusterResourceManager.java: ## @@ -0,0 +1,282 @@ +/* + * Lice

[jira] [Commented] (FLINK-34066) LagFunction throw NPE when input argument are not null

2024-01-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805925#comment-17805925 ] Martijn Visser commented on FLINK-34066: Can you please elaborate a bit more and

Re: [PR] [FLINK-33771] Add cluster capacity awareness to autoscaler [flink-kubernetes-operator]

2024-01-12 Thread via GitHub
gyfora commented on code in PR #751: URL: https://github.com/apache/flink-kubernetes-operator/pull/751#discussion_r1450008152 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/RestApiMetricsCollector.java: ## @@ -103,6 +106,42 @@ protected Map queryAggregatedVertex

Re: [PR] [FLINK-33819] support set CompressionType for RocksDBStateBackend [flink]

2024-01-12 Thread via GitHub
masteryhx commented on code in PR #24072: URL: https://github.com/apache/flink/pull/24072#discussion_r1450005923 ## flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java: ## @@ -557,6 +559,9 @@ p

Re: [PR] [FLINK-33771] Add cluster capacity awareness to autoscaler [flink-kubernetes-operator]

2024-01-12 Thread via GitHub
gyfora commented on code in PR #751: URL: https://github.com/apache/flink-kubernetes-operator/pull/751#discussion_r1450008701 ## flink-autoscaler/src/test/java/org/apache/flink/autoscaler/RestApiMetricsCollectorTest.java: ## @@ -122,6 +126,56 @@ CompletableFuture sendRequest(

Re: [PR] [FLINK-33697][state][metrics] Trace RocksDBIncremental remote files download time [flink]

2024-01-12 Thread via GitHub
pnowojski merged PR #24023: URL: https://github.com/apache/flink/pull/24023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[jira] [Updated] (FLINK-34063) When snapshot compression is enabled, rescaling of a source operator leads to some splits getting lost

2024-01-12 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-34063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Morávek updated FLINK-34063: -- Affects Version/s: 1.18.0 > When snapshot compression is enabled, rescaling of a source operat

[jira] [Updated] (FLINK-34063) When snapshot compression is enabled, rescaling of a source operator leads to some splits getting lost

2024-01-12 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-34063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Morávek updated FLINK-34063: -- Priority: Blocker (was: Critical) > When snapshot compression is enabled, rescaling of a sour

Re: [PR] [FLINK-34015][checkpoint] fix that passing ignore-unclaimed-state through dynamic props does not take effect [flink]

2024-01-12 Thread via GitHub
masteryhx commented on code in PR #24058: URL: https://github.com/apache/flink/pull/24058#discussion_r1450021637 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/SavepointRestoreSettings.java: ## @@ -163,14 +163,16 @@ public static SavepointRestoreSettings forPat

[jira] [Closed] (FLINK-33697) FLIP-386: Support adding custom metrics in Recovery Spans

2024-01-12 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-33697. -- Release Note: A braking change has been introduced to the `StateBackend` interface. This is r

[jira] [Assigned] (FLINK-34063) When snapshot compression is enabled, rescaling of a source operator leads to some splits getting lost

2024-01-12 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-34063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Morávek reassigned FLINK-34063: - Assignee: David Morávek > When snapshot compression is enabled, rescaling of a source o

[jira] [Commented] (FLINK-34063) When snapshot compression is enabled, rescaling of a source operator leads to some splits getting lost

2024-01-12 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805934#comment-17805934 ] Piotr Nowojski commented on FLINK-34063: Could this issue be discovered by our I

[jira] [Commented] (FLINK-34066) LagFunction throw NPE when input argument are not null

2024-01-12 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805933#comment-17805933 ] Yunhong Zheng commented on FLINK-34066: --- hi, [~martijnvisser] . This is a related

[jira] [Comment Edited] (FLINK-34063) When snapshot compression is enabled, rescaling of a source operator leads to some splits getting lost

2024-01-12 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805934#comment-17805934 ] Piotr Nowojski edited comment on FLINK-34063 at 1/12/24 8:32 AM: -

[jira] [Commented] (FLINK-34066) LagFunction throw NPE when input argument are not null

2024-01-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805935#comment-17805935 ] Martijn Visser commented on FLINK-34066: [~337361...@qq.com] OK. For next time,

Re: [PR] [FLINK-34020] Bump CI flink version on flink-connector-rabbitmq [flink-connector-rabbitmq]

2024-01-12 Thread via GitHub
MartijnVisser merged PR #22: URL: https://github.com/apache/flink-connector-rabbitmq/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

Re: [PR] [hotfix] Run push_pr.yml against multiple Flink versions [flink-connector-rabbitmq]

2024-01-12 Thread via GitHub
MartijnVisser closed pull request #21: [hotfix] Run push_pr.yml against multiple Flink versions URL: https://github.com/apache/flink-connector-rabbitmq/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [hotfix] Run push_pr.yml against multiple Flink versions [flink-connector-rabbitmq]

2024-01-12 Thread via GitHub
MartijnVisser commented on PR #21: URL: https://github.com/apache/flink-connector-rabbitmq/pull/21#issuecomment-1888655408 Superseded by https://github.com/apache/flink-connector-rabbitmq/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Commented] (FLINK-34066) LagFunction throw NPE when input argument are not null

2024-01-12 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805936#comment-17805936 ] Yunhong Zheng commented on FLINK-34066: --- Hi, [~martijnvisser] . The new test case

[jira] [Commented] (FLINK-34009) Apache flink: Checkpoint restoration issue on Application Mode of deployment

2024-01-12 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805937#comment-17805937 ] Hangxiang Yu commented on FLINK-34009: -- [~vrang...@in.ibm.com] Hi, You could reorg

Re: [PR] [FLINK-33697][state][metrics] Trace RocksDBIncremental remote files download time [flink]

2024-01-12 Thread via GitHub
pnowojski commented on code in PR #24023: URL: https://github.com/apache/flink/pull/24023#discussion_r1450048228 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateDownloader.java: ## @@ -41,8 +43,14 @@ /** He

[jira] [Commented] (FLINK-34066) LagFunction throw NPE when input argument are not null

2024-01-12 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805938#comment-17805938 ] Yunhong Zheng commented on FLINK-34066: --- [~martijnvisser] ,Sorry for not adding mo

[jira] [Updated] (FLINK-30400) Stop bundling connector-base in externalized connectors

2024-01-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-30400: --- Fix Version/s: (was: rabbitmq-3.0.2) > Stop bundling connector-base in externalized conn

[jira] [Updated] (FLINK-30400) Stop bundling connector-base in externalized connectors

2024-01-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-30400: --- Fix Version/s: rabbitmq-3.0.2 > Stop bundling connector-base in externalized connectors > --

[jira] [Closed] (FLINK-30400) Stop bundling connector-base in externalized connectors

2024-01-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-30400. -- Resolution: Fixed > Stop bundling connector-base in externalized connectors >

[jira] [Updated] (FLINK-34066) LagFunction throw NPE when input argument are not null

2024-01-12 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yunhong Zheng updated FLINK-34066: -- Description: This issue is related to  (was: LagFunction throw NPE when input argument are no

[jira] [Updated] (FLINK-34066) LagFunction throw NPE when input argument are not null

2024-01-12 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yunhong Zheng updated FLINK-34066: -- Description: This issue is related to https://issues.apache.org/jira/browse/FLINK-31967. In F

Re: [PR] [FLINK-34066][table-planner] Fix LagFunction throw NPE when input argument are not null [flink]

2024-01-12 Thread via GitHub
swuferhong commented on PR #24075: URL: https://github.com/apache/flink/pull/24075#issuecomment-1888673025 > Why are we no longer testing the previous behavior? Thanks, @MartijnVisser . I add more details about how the NPE error will be produce. Thanks for kindly remainder. -- Thi

[jira] [Commented] (FLINK-30417) RabbitMQ error is not clear

2024-01-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805939#comment-17805939 ] Martijn Visser commented on FLINK-30417: This wasn't released with rabbitmq-3.0.

[jira] [Updated] (FLINK-30417) RabbitMQ error is not clear

2024-01-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-30417: --- Fix Version/s: rabbitmq-3.0.2 (was: rabbitmq-3.0.1) > RabbitMQ error

[jira] [Comment Edited] (FLINK-30417) RabbitMQ error is not clear

2024-01-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805939#comment-17805939 ] Martijn Visser edited comment on FLINK-30417 at 1/12/24 8:50 AM: -

Re: [PR] [FLINK-33743][runtime] Support consuming multiple subpartitions on a single channel [flink]

2024-01-12 Thread via GitHub
yunfengzhou-hub commented on code in PR #23927: URL: https://github.com/apache/flink/pull/23927#discussion_r1450086954 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartition.java: ## @@ -301,6 +302,24 @@ public void setMetricGroup(TaskIOMetr

Re: [PR] [FLINK-33743][runtime] Support consuming multiple subpartitions on a single channel [flink]

2024-01-12 Thread via GitHub
yunfengzhou-hub commented on code in PR #23927: URL: https://github.com/apache/flink/pull/23927#discussion_r1450088659 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java: ## @@ -229,6 +245,14 @@ ResultSubpartition

[PR] [FLINK-34020][BP v3.0] Bump CI flink version on flink-connector-rabbitmq. [flink-connector-rabbitmq]

2024-01-12 Thread via GitHub
MartijnVisser opened a new pull request, #23: URL: https://github.com/apache/flink-connector-rabbitmq/pull/23 (cherry picked from commit 33d125f591cc5f99e12280fbe2725bd374f7738b) This also includes syncs `main` to `v3.0` for some dependency versions/convergences -- This is an a

[jira] [Updated] (FLINK-34063) When snapshot compression is enabled, rescaling of a source operator leads to some splits getting lost

2024-01-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-34063: --- Fix Version/s: 1.18.2 > When snapshot compression is enabled, rescaling of a source operator

Re: [PR] [FLINK-32256][table] Add built-in ARRAY_ MIN function. [flink]

2024-01-12 Thread via GitHub
dawidwys merged PR #24071: URL: https://github.com/apache/flink/pull/24071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Closed] (FLINK-32256) Add ARRAY_MIN support in SQL & Table API

2024-01-12 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-32256. Resolution: Implemented Implemented in 2c70bd346d37f96f01007c89e3eb66e919c0c0a8 > Add ARR

Re: [PR] [FLINK-32256][table] Add built-in ARRAY_ MIN function. [flink]

2024-01-12 Thread via GitHub
dawidwys commented on PR #22922: URL: https://github.com/apache/flink/pull/22922#issuecomment-1888707479 subsumed by #24071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-32256][table] Add built-in ARRAY_ MIN function. [flink]

2024-01-12 Thread via GitHub
dawidwys closed pull request #22922: [FLINK-32256][table] Add built-in ARRAY_ MIN function. URL: https://github.com/apache/flink/pull/22922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] [FLINK-34020][BP v3.0] Bump CI flink version on flink-connector-rabbitmq [flink-connector-rabbitmq]

2024-01-12 Thread via GitHub
MartijnVisser merged PR #23: URL: https://github.com/apache/flink-connector-rabbitmq/pull/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

[jira] [Closed] (FLINK-34020) Bump CI flink version on flink-connector-rabbitmq

2024-01-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-34020. -- Fix Version/s: elasticsearch-3.0.2 Resolution: Fixed Fixed in apache/flink-connector-ra

Re: [PR] [FLINK-33973] Add new interfaces for SinkV2 to synchronize the API with the SourceV2 API [flink]

2024-01-12 Thread via GitHub
gyfora merged PR #24022: URL: https://github.com/apache/flink/pull/24022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-33971]Specifies whether to use HBase table that supports dynamic columns. [flink-connector-hbase]

2024-01-12 Thread via GitHub
MOBIN-F commented on PR #36: URL: https://github.com/apache/flink-connector-hbase/pull/36#issuecomment-1888713741 > > @ferenc-csaky Want to take a look? > > I'll review it in the next 2 days. Thanks for your contribution @MOBIN-F! I added some test cases -- This is an automa

[jira] [Closed] (FLINK-33973) Add new interfaces for SinkV2 to synchronize the API with the SourceV2 API

2024-01-12 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-33973. -- Resolution: Fixed Merged to master 6afe98daf6190a77a67a1fa8ac8f12337a75f8e7 > Add new interfaces for

[jira] [Assigned] (FLINK-33974) Implement the Sink transformation depending on the new SinkV2 interfaces

2024-01-12 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-33974: -- Assignee: Peter Vary > Implement the Sink transformation depending on the new SinkV2 interfac

[jira] [Assigned] (FLINK-34043) Remove deprecated Sink V2 interfaces

2024-01-12 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-34043: -- Assignee: Peter Vary > Remove deprecated Sink V2 interfaces > ---

[jira] [Assigned] (FLINK-33973) Add new interfaces for SinkV2 to synchronize the API with the SourceV2 API

2024-01-12 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-33973: -- Assignee: Peter Vary > Add new interfaces for SinkV2 to synchronize the API with the SourceV2

[jira] [Assigned] (FLINK-33975) Tests for the new Sink V2 transformations

2024-01-12 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-33975: -- Assignee: Peter Vary > Tests for the new Sink V2 transformations > --

[jira] [Updated] (FLINK-34063) When snapshot compression is enabled, rescaling of a source operator leads to some splits getting lost

2024-01-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-34063: --- Component/s: Runtime / State Backends > When snapshot compression is enabled, rescaling of a

[jira] [Assigned] (FLINK-34042) Update the documentation for Sink V2

2024-01-12 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-34042: -- Assignee: Peter Vary > Update the documentation for Sink V2 > ---

Re: [PR] [FLINK-31511][doc-zh] Update the document sql_functions_zh.yml and fix some parts in sql_functions.yml [flink]

2024-01-12 Thread via GitHub
leonardBang commented on PR #5: URL: https://github.com/apache/flink/pull/5#issuecomment-1888723152 @ruanhang1993 Thanks for the contribution, the CI failed during docs_404_check, could you fix it ? -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (FLINK-34007) Flink Job stuck in suspend state after losing leadership in HA Mode

2024-01-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805960#comment-17805960 ] Matthias Pohl commented on FLINK-34007: --- I couldn't find anything related to Confi

Re: [PR] [FLINK-33906][ci] tools/azure-pipelines/debug_files_utils.sh should support GHA output as well [flink]

2024-01-12 Thread via GitHub
XComp commented on PR #23964: URL: https://github.com/apache/flink/pull/23964#issuecomment-1888727106 I rebased the change onto master after the preceeding PR of FLINK-34047 was merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (FLINK-33928) Should not throw exception while creating view with specify field names even if the query conflicts in field names

2024-01-12 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805962#comment-17805962 ] Yunhong Zheng commented on FLINK-33928: --- Hi, [~xuyangzhong]. I want to take this i

[jira] [Commented] (FLINK-33998) Flink Job Manager restarted after kube-apiserver connection intermittent

2024-01-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805965#comment-17805965 ] Matthias Pohl commented on FLINK-33998: --- Thanks for reporting the issue, [~xiangya

Re: [PR] [FLINK-31481][table] Support enhanced show databases syntax [flink]

2024-01-12 Thread via GitHub
dawidwys commented on code in PR #23612: URL: https://github.com/apache/flink/pull/23612#discussion_r1450129925 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dql/SqlShowDatabases.java: ## @@ -29,14 +33,64 @@ import java.util.Collections; import java

Re: [PR] [FLINK-31481][table] Support enhanced show databases syntax [flink]

2024-01-12 Thread via GitHub
dawidwys commented on code in PR #23612: URL: https://github.com/apache/flink/pull/23612#discussion_r1450130950 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlShowDatabasesConverter.java: ## @@ -0,0 +1,51 @@ +/* + * Licen

[jira] [Updated] (FLINK-34063) When snapshot compression is enabled, rescaling of a source operator leads to some splits getting lost

2024-01-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34063: --- Labels: pull-request-available (was: ) > When snapshot compression is enabled, rescaling of

Re: [PR] [FLINK-33819] support set CompressionType for RocksDBStateBackend [flink]

2024-01-12 Thread via GitHub
mayuehappy commented on code in PR #24072: URL: https://github.com/apache/flink/pull/24072#discussion_r1450153620 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBConfigurableOptions.java: ## @@ -139,6 +149,25 @@ pu

Re: [PR] [FLINK-34066][table-planner] Fix LagFunction throw NPE when input argument are not null [flink]

2024-01-12 Thread via GitHub
swuferhong commented on PR #24075: URL: https://github.com/apache/flink/pull/24075#issuecomment-1888771396 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-33819] support set CompressionType for RocksDBStateBackend [flink]

2024-01-12 Thread via GitHub
mayuehappy commented on code in PR #24072: URL: https://github.com/apache/flink/pull/24072#discussion_r1450153620 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBConfigurableOptions.java: ## @@ -139,6 +149,25 @@ pu

[jira] [Commented] (FLINK-34044) Kinesis Sink Cannot be Created via TableDescriptor

2024-01-12 Thread Khanh Vu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805970#comment-17805970 ] Khanh Vu commented on FLINK-34044: -- I can take this one. > Kinesis Sink Cannot be Crea

[jira] [Comment Edited] (FLINK-34044) Kinesis Sink Cannot be Created via TableDescriptor

2024-01-12 Thread Khanh Vu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805970#comment-17805970 ] Khanh Vu edited comment on FLINK-34044 at 1/12/24 9:51 AM: --- I

Re: [PR] [FLINK-34063][runtime] Always flush compression buffers, when retrieving stream position during OperatorState snapshot. [flink]

2024-01-12 Thread via GitHub
flinkbot commented on PR #24079: URL: https://github.com/apache/flink/pull/24079#issuecomment-1888781951 ## CI report: * 0ea3238afa0d7da0e52f5065fe3c469585fb6b03 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Assigned] (FLINK-33928) Should not throw exception while creating view with specify field names even if the query conflicts in field names

2024-01-12 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-33928: - Assignee: Yunhong Zheng > Should not throw exception while creating view with specify f

[jira] [Updated] (FLINK-34063) When snapshot compression is enabled, rescaling of a source operator leads to some splits getting lost

2024-01-12 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-34063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Morávek updated FLINK-34063: -- Affects Version/s: 1.18.1 > When snapshot compression is enabled, rescaling of a source operat

Re: [PR] [FLINK-34063][runtime] Always flush compression buffers, when retrieving stream position during OperatorState snapshot. [flink]

2024-01-12 Thread via GitHub
dmvk commented on PR #24079: URL: https://github.com/apache/flink/pull/24079#issuecomment-1888797223 fyi @echauchot @dawidwys -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-32815] Implement internal HASHCODE function [flink]

2024-01-12 Thread via GitHub
twalthr commented on code in PR #24070: URL: https://github.com/apache/flink/pull/24070#discussion_r1450172362 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/HashcodeITCase.java: ## @@ -0,0 +1,208 @@ +/* + * Licensed to the Apache Softw

Re: [PR] [FLINK-34066][table-planner] Fix LagFunction throw NPE when input argument are not null [flink]

2024-01-12 Thread via GitHub
swuferhong commented on PR #24075: URL: https://github.com/apache/flink/pull/24075#issuecomment-102003 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [hotfix] Correct release date for flink-shaded 18.0 [flink-web]

2024-01-12 Thread via GitHub
XComp merged PR #710: URL: https://github.com/apache/flink-web/pull/710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [FLINK-33973] Add new interfaces for SinkV2 to synchronize the API with the SourceV2 API [flink]

2024-01-12 Thread via GitHub
dmvk commented on PR #24022: URL: https://github.com/apache/flink/pull/24022#issuecomment-111191 @pvary @gyfora This PR seems to break master. https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=56314&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54

Re: [PR] [FLINK-34063][runtime] Always flush compression buffers, when retrieving stream position during OperatorState snapshot. [flink]

2024-01-12 Thread via GitHub
dmvk commented on PR #24079: URL: https://github.com/apache/flink/pull/24079#issuecomment-112016 CI seems broken by https://github.com/apache/flink/pull/24022#issuecomment-111191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [FLINK-33973] Add new interfaces for SinkV2 to synchronize the API with the SourceV2 API [flink]

2024-01-12 Thread via GitHub
dmvk commented on PR #24022: URL: https://github.com/apache/flink/pull/24022#issuecomment-113784 https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=56312&view=results -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Comment Edited] (FLINK-34007) Flink Job stuck in suspend state after losing leadership in HA Mode

2024-01-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805960#comment-17805960 ] Matthias Pohl edited comment on FLINK-34007 at 1/12/24 10:19 AM: -

Re: [PR] [FLINK-32815] Implement internal HASHCODE function [flink]

2024-01-12 Thread via GitHub
dawidwys commented on code in PR #24070: URL: https://github.com/apache/flink/pull/24070#discussion_r1450194376 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/HashcodeITCase.java: ## @@ -0,0 +1,208 @@ +/* + * Licensed to the Apache Soft

Re: [PR] [hotfix] Use valid url for flink-shaded [flink-web]

2024-01-12 Thread via GitHub
snuyanzin merged PR #711: URL: https://github.com/apache/flink-web/pull/711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-33973] Add new interfaces for SinkV2 to synchronize the API with the SourceV2 API [flink]

2024-01-12 Thread via GitHub
gyfora commented on PR #24022: URL: https://github.com/apache/flink/pull/24022#issuecomment-125329 Thanks @dmvk strange as we had a passed CI run, @pvary is taking a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-32815] Implement internal HASHCODE function [flink]

2024-01-12 Thread via GitHub
dawidwys commented on code in PR #24070: URL: https://github.com/apache/flink/pull/24070#discussion_r1450194376 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/HashcodeITCase.java: ## @@ -0,0 +1,208 @@ +/* + * Licensed to the Apache Soft

[jira] [Commented] (FLINK-27756) Fix intermittently failing test in AsyncSinkWriterTest.checkLoggedSendTimesAreWithinBounds

2024-01-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805977#comment-17805977 ] Matthias Pohl commented on FLINK-27756: --- https://dev.azure.com/apache-flink/apache

Re: [PR] [FLINK-32815] Implement internal HASHCODE function [flink]

2024-01-12 Thread via GitHub
dawidwys commented on code in PR #24070: URL: https://github.com/apache/flink/pull/24070#discussion_r1450194376 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/HashcodeITCase.java: ## @@ -0,0 +1,208 @@ +/* + * Licensed to the Apache Soft

[jira] [Commented] (FLINK-26974) Python EmbeddedThreadDependencyTests.test_add_python_file failed on azure

2024-01-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805979#comment-17805979 ] Matthias Pohl commented on FLINK-26974: --- https://dev.azure.com/apache-flink/apache

[jira] [Closed] (FLINK-34011) EmbeddedThreadDependencyTests.test_add_python_file fails with This function should not be called!

2024-01-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl closed FLINK-34011. - Resolution: Duplicate Closing this issue in favor of FLINK-26974. > EmbeddedThreadDependencyTes

[jira] [Commented] (FLINK-26644) python StreamExecutionEnvironmentTests.test_generate_stream_graph_with_dependencies failed on azure

2024-01-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805983#comment-17805983 ] Matthias Pohl commented on FLINK-26644: --- https://dev.azure.com/apache-flink/apache

Re: [PR] [FLINK-32815] Implement internal HASHCODE function [flink]

2024-01-12 Thread via GitHub
twalthr commented on code in PR #24070: URL: https://github.com/apache/flink/pull/24070#discussion_r1450207302 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/HashcodeITCase.java: ## @@ -0,0 +1,208 @@ +/* + * Licensed to the Apache Softw

[jira] [Updated] (FLINK-34068) build_wheels_on_macos fails due to connection error

2024-01-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34068: -- Summary: build_wheels_on_macos fails due to connection error (was: build_wheels_on_macos fail

[jira] [Commented] (FLINK-33414) MiniClusterITCase.testHandleStreamingJobsWhenNotEnoughSlot fails due to unexpected TimeoutException

2024-01-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805986#comment-17805986 ] Matthias Pohl commented on FLINK-33414: --- https://dev.azure.com/apache-flink/apache

[jira] [Created] (FLINK-34068) build_wheels_on_macos fails due to OSError

2024-01-12 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-34068: - Summary: build_wheels_on_macos fails due to OSError Key: FLINK-34068 URL: https://issues.apache.org/jira/browse/FLINK-34068 Project: Flink Issue Type: Bug

Re: [PR] [FLINK-33973] Add new interfaces for SinkV2 to synchronize the API with the SourceV2 API [flink]

2024-01-12 Thread via GitHub
gyfora commented on PR #24022: URL: https://github.com/apache/flink/pull/24022#issuecomment-148837 @dmvk we reverted that commit, seems like there was some mess-up with the passing CI / rebasing. Sorry about that -- This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (FLINK-33414) MiniClusterITCase.testHandleStreamingJobsWhenNotEnoughSlot fails due to unexpected TimeoutException

2024-01-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805987#comment-17805987 ] Matthias Pohl commented on FLINK-33414: --- https://dev.azure.com/apache-flink/apache

Re: [PR] [FLINK-32416] initial implementation of DynamicKafkaSource with bound… [flink-connector-kafka]

2024-01-12 Thread via GitHub
mxm commented on PR #44: URL: https://github.com/apache/flink-connector-kafka/pull/44#issuecomment-152652 Awesome, thanks a lot! Merging once tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[PR] [FLINK-33973] Add new interfaces for SinkV2 to synchronize the API with the SourceV2 API [flink]

2024-01-12 Thread via GitHub
pvary opened a new pull request, #24080: URL: https://github.com/apache/flink/pull/24080 ## What is the purpose of the change Add new SinkV2 API interfaces, set inheritance and deprecation for the old interfaces. Added fix for the concurrent commit ## Brief change log

[jira] [Created] (FLINK-34069) build_wheels_on_macos times out and gets cancelled

2024-01-12 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-34069: - Summary: build_wheels_on_macos times out and gets cancelled Key: FLINK-34069 URL: https://issues.apache.org/jira/browse/FLINK-34069 Project: Flink Issue Ty

[jira] [Updated] (FLINK-31724) SqlClientITCase.testMatchRecognize fails with "bash -c rm -rf /opt/flink/checkpoint/*" returned non-zero exit code 1

2024-01-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31724: -- Affects Version/s: 1.19.0 > SqlClientITCase.testMatchRecognize fails with "bash -c rm -rf > /

[jira] [Commented] (FLINK-31724) SqlClientITCase.testMatchRecognize fails with "bash -c rm -rf /opt/flink/checkpoint/*" returned non-zero exit code 1

2024-01-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805990#comment-17805990 ] Matthias Pohl commented on FLINK-31724: --- Happened again: https://dev.azure.com/ap

[jira] [Updated] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31472: -- Affects Version/s: 1.18.0 > AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread >

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805992#comment-17805992 ] Matthias Pohl commented on FLINK-31472: --- 1.18: https://dev.azure.com/apache-flink

Re: [PR] [FLINK-33973] Add new interfaces for SinkV2 to synchronize the API with the SourceV2 API [flink]

2024-01-12 Thread via GitHub
flinkbot commented on PR #24080: URL: https://github.com/apache/flink/pull/24080#issuecomment-174136 ## CI report: * ee54a07048685165fb17e3c57ebcd968e959deac UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-32815] Implement internal HASHCODE function [flink]

2024-01-12 Thread via GitHub
dawidwys commented on PR #24070: URL: https://github.com/apache/flink/pull/24070#issuecomment-175890 CI seems broken by https://github.com/apache/flink/pull/24022#issuecomment-111191 -- This is an automated message from the Apache Git Service. To respond to the message, please log

  1   2   >