Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-11-30 Thread via GitHub
snuyanzin commented on code in PR #23844: URL: https://github.com/apache/flink/pull/23844#discussion_r1410685672 ## flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/HadoopS3AccessHelper.java: ## @@ -84,13 +84,14 @@ public UploadPartResult uploadPar

[PR] [FLINK-33559] Externalize Kafka Python connector code [flink-connector-kafka]

2023-11-30 Thread via GitHub
pvary opened a new pull request, #69: URL: https://github.com/apache/flink-connector-kafka/pull/69 Moves the `kafka.py` and the `kafka_test.py` code from the main Flink repository here. When running `mvn clean install` downloads the testing infra scripts from the main Flink repo (`fl

Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-11-30 Thread via GitHub
snuyanzin commented on code in PR #23844: URL: https://github.com/apache/flink/pull/23844#discussion_r1410685019 ## flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/HadoopS3AccessHelper.java: ## @@ -68,7 +68,7 @@ public HadoopS3AccessHelper(S3AFile

Re: [PR] Draft FLINK-32898 ci [flink]

2023-11-30 Thread via GitHub
caodizhou commented on PR #23842: URL: https://github.com/apache/flink/pull/23842#issuecomment-1833800682 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33559] Externalize Kafka Python connector code [flink-connector-kafka]

2023-11-30 Thread via GitHub
boring-cyborg[bot] commented on PR #69: URL: https://github.com/apache/flink-connector-kafka/pull/69#issuecomment-1833804379 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is a

[jira] [Updated] (FLINK-33559) Externalize Kafka Python connector code

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33559: --- Labels: pull-request-available (was: ) > Externalize Kafka Python connector code >

Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-11-30 Thread via GitHub
flinkbot commented on PR #23844: URL: https://github.com/apache/flink/pull/23844#issuecomment-1833806488 ## CI report: * db953b7ab86a704cc8393bc6e813cf8ae310cd41 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] Add flink-shaded 18.0 release [flink-web]

2023-11-30 Thread via GitHub
snuyanzin commented on code in PR #701: URL: https://github.com/apache/flink-web/pull/701#discussion_r1410699644 ## docs/data/additional_components.yml: ## @@ -21,11 +21,11 @@ flink-connector-parent: source_release_asc_url: "https://downloads.apache.org/flink/flink-connector

Re: [PR] [FLINK-33559] Externalize Kafka Python connector code [flink-connector-kafka]

2023-11-30 Thread via GitHub
pvary commented on code in PR #69: URL: https://github.com/apache/flink-connector-kafka/pull/69#discussion_r1410705227 ## .github/workflows/push_pr.yml: ## @@ -29,3 +29,11 @@ jobs: uses: apache/flink-connector-shared-utils/.github/workflows/ci.yml@ci_utils with:

Re: [PR] [FLINK-33470] Implement restore tests for Join node [flink]

2023-11-30 Thread via GitHub
jnh5y commented on code in PR #23680: URL: https://github.com/apache/flink/pull/23680#discussion_r1410763255 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java: ## @@ -106,6 +113,8 @@ public static final class Builder extends

[jira] [Created] (FLINK-33708) Add Span and TraceReporter concepts

2023-11-30 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-33708: -- Summary: Add Span and TraceReporter concepts Key: FLINK-33708 URL: https://issues.apache.org/jira/browse/FLINK-33708 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-33709) Report CheckpointStats as Spans

2023-11-30 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-33709: -- Summary: Report CheckpointStats as Spans Key: FLINK-33709 URL: https://issues.apache.org/jira/browse/FLINK-33709 Project: Flink Issue Type: Sub-task

[PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-11-30 Thread via GitHub
pnowojski opened a new pull request, #23845: URL: https://github.com/apache/flink/pull/23845 ## What is the purpose of the change This PR adds a concept of `Span` and `TraceReporter` and uses that to report checkpointing traces. ## Brief change log Please check individua

[jira] [Updated] (FLINK-33708) Add Span and TraceReporter concepts

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33708: --- Labels: pull-request-available (was: ) > Add Span and TraceReporter concepts >

Re: [PR] FLINK-33600][table] print the query time cost for batch query in cli [flink]

2023-11-30 Thread via GitHub
JingGe commented on PR #23809: URL: https://github.com/apache/flink/pull/23809#issuecomment-1833917568 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-11-30 Thread via GitHub
flinkbot commented on PR #23845: URL: https://github.com/apache/flink/pull/23845#issuecomment-1833924058 ## CI report: * 40ca70685630bfc2173a6375f56781edceda00d7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33422] Move Calc restore tests [flink]

2023-11-30 Thread via GitHub
dawidwys merged PR #23822: URL: https://github.com/apache/flink/pull/23822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Commented] (FLINK-33422) Implement restore tests for Calc node

2023-11-30 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791666#comment-17791666 ] Dawid Wysakowicz commented on FLINK-33422: -- Moved classes in 645afd89e90e3f52c

Re: [PR] [FLINK-33704][Filesytems] Update GCS filesystems to latest available versions [flink]

2023-11-30 Thread via GitHub
MartijnVisser merged PR #23837: URL: https://github.com/apache/flink/pull/23837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

Re: [PR] [FLINK-33638][table] Support variable-length data generation for variable-length data types [flink]

2023-11-30 Thread via GitHub
lincoln-lil commented on code in PR #23810: URL: https://github.com/apache/flink/pull/23810#discussion_r1410805913 ## flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/RandomGeneratorVisitor.java: ## @@ -503,10 +524,14 @@ private stat

Re: [PR] [FLINK-33694][gs-fs-hadoop] Support overriding GCS root URL [flink]

2023-11-30 Thread via GitHub
patricklucas commented on PR #23836: URL: https://github.com/apache/flink/pull/23836#issuecomment-1833953627 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[jira] [Commented] (FLINK-33694) GCS filesystem does not respect gs.storage.root.url config option

2023-11-30 Thread Patrick Lucas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791670#comment-17791670 ] Patrick Lucas commented on FLINK-33694: --- [~martijnvisser] aye, have a PR open but

Re: [PR] [FLINK-33698][datastream] Fix the backoff time calculation in ExponentialBackoffDelayRetryStrategy [flink]

2023-11-30 Thread via GitHub
lincoln-lil commented on code in PR #23830: URL: https://github.com/apache/flink/pull/23830#discussion_r1410826099 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/util/retryable/AsyncRetryStrategies.java: ## @@ -181,11 +180,12 @@ public boolean canRetry(int curr

Re: [PR] [FLINK-33698][datastream] Fix the backoff time calculation in ExponentialBackoffDelayRetryStrategy [flink]

2023-11-30 Thread via GitHub
xiangyuf commented on code in PR #23830: URL: https://github.com/apache/flink/pull/23830#discussion_r1410877781 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/util/retryable/AsyncRetryStrategies.java: ## @@ -181,11 +180,12 @@ public boolean canRetry(int current

Re: [PR] [FLINK-33305] Allow to customize arg line for connector's surefire plugin [flink-connector-shared-utils]

2023-11-30 Thread via GitHub
echauchot commented on PR #25: URL: https://github.com/apache/flink-connector-shared-utils/pull/25#issuecomment-1834048030 @snuyanzin can you elaborate on the use cases you have in mind for systemPropertyVariable surefire.module.config ? -- This is an automated message from the Apache Gi

[jira] [Commented] (FLINK-33694) GCS filesystem does not respect gs.storage.root.url config option

2023-11-30 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791695#comment-17791695 ] Martijn Visser commented on FLINK-33694: [~plucas] Just a question, you state th

[PR] Release 1.6 [flink-kubernetes-operator]

2023-11-30 Thread via GitHub
breezykermo opened a new pull request, #718: URL: https://github.com/apache/flink-kubernetes-operator/pull/718 ## What is the purpose of the change *(For example: This pull request adds a new feature to periodically create and maintain savepoints through the `FlinkDeployment`

Re: [PR] Release 1.6 [flink-kubernetes-operator]

2023-11-30 Thread via GitHub
breezykermo closed pull request #718: Release 1.6 URL: https://github.com/apache/flink-kubernetes-operator/pull/718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[jira] [Created] (FLINK-33710) Autoscaler redeploys pipeline for a NOOP parallelism change

2023-11-30 Thread Maximilian Michels (Jira)
Maximilian Michels created FLINK-33710: -- Summary: Autoscaler redeploys pipeline for a NOOP parallelism change Key: FLINK-33710 URL: https://issues.apache.org/jira/browse/FLINK-33710 Project: Flin

[PR] [FLINK-33710] Prevent NOOP spec updates from the autoscaler parallelism override map [flink-kubernetes-operator]

2023-11-30 Thread via GitHub
mxm opened a new pull request, #720: URL: https://github.com/apache/flink-kubernetes-operator/pull/720 The operator supports two modes to apply autoscaler changes: # Use the internal Flink config {{pipeline.jobvertex-parallelism-overrides}} # Make use of Flink's Rescale API

[jira] [Updated] (FLINK-33710) Autoscaler redeploys pipeline for a NOOP parallelism change

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33710: --- Labels: pull-request-available (was: ) > Autoscaler redeploys pipeline for a NOOP paralleli

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-11-30 Thread via GitHub
qingwei91 commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1411250155 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java: ## @@ -92,9 +104,18 @@ public JdbcRowDataLookupF

[PR] Bump @adobe/css-tools from 4.0.1 to 4.3.2 in /flink-runtime-web/web-dashboard [flink]

2023-11-30 Thread via GitHub
dependabot[bot] opened a new pull request, #23846: URL: https://github.com/apache/flink/pull/23846 Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.0.1 to 4.3.2. Changelog Sourced from https://github.com/adobe/css-tools/blob/main/History.md";>@​adobe/css-tools's

Re: [PR] Bump @adobe/css-tools from 4.0.1 to 4.3.1 in /flink-runtime-web/web-dashboard [flink]

2023-11-30 Thread via GitHub
dependabot[bot] commented on PR #23785: URL: https://github.com/apache/flink/pull/23785#issuecomment-1834592317 Superseded by #23846. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump @adobe/css-tools from 4.0.1 to 4.3.1 in /flink-runtime-web/web-dashboard [flink]

2023-11-30 Thread via GitHub
dependabot[bot] closed pull request #23785: Bump @adobe/css-tools from 4.0.1 to 4.3.1 in /flink-runtime-web/web-dashboard URL: https://github.com/apache/flink/pull/23785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Bump @adobe/css-tools from 4.0.1 to 4.3.2 in /flink-runtime-web/web-dashboard [flink]

2023-11-30 Thread via GitHub
flinkbot commented on PR #23846: URL: https://github.com/apache/flink/pull/23846#issuecomment-1834595897 ## CI report: * 409279e0bb32062c49662db17b6958a9e017d241 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33545][Connectors/Kafka] KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching [flink-connector-kafka]

2023-11-30 Thread via GitHub
aeolus811tw opened a new pull request, #70: URL: https://github.com/apache/flink-connector-kafka/pull/70 ## What is the purpose of the change To address the current flow of KafkaProducer having exact same behavior for `DeliveryGuarantee.NONE` and `DeliveryGuarantee.AT_LEAST_ON

Re: [PR] [FLINK-33545][Connectors/Kafka] KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching [flink-connector-kafka]

2023-11-30 Thread via GitHub
boring-cyborg[bot] commented on PR #70: URL: https://github.com/apache/flink-connector-kafka/pull/70#issuecomment-1834763669 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is a

[jira] [Updated] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33545: --- Labels: pull-request-available (was: ) > KafkaSink implementation can cause dataloss during

Re: [PR] [FLINK-33647] Implement restore tests for LookupJoin node [flink]

2023-11-30 Thread via GitHub
bvarghese1 commented on code in PR #23814: URL: https://github.com/apache/flink/pull/23814#discussion_r1411425256 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/LookupJoinTestPrograms.java: ## @@ -0,0 +1,287 @@ +/* + * Lice

Re: [PR] [FLINK-33638][table] Support variable-length data generation for variable-length data types [flink]

2023-11-30 Thread via GitHub
lincoln-lil commented on PR #23810: URL: https://github.com/apache/flink/pull/23810#issuecomment-1835240650 @liyubin117 Could you also synchronize the latest changes to the documentation to the Chinese version? -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2023-11-30 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791866#comment-17791866 ] Mason Chen commented on FLINK-33545: Hi all, I just saw this ticket. I've read throu

[jira] [Comment Edited] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2023-11-30 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791866#comment-17791866 ] Mason Chen edited comment on FLINK-33545 at 12/1/23 1:24 AM: -

[jira] [Comment Edited] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2023-11-30 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791866#comment-17791866 ] Mason Chen edited comment on FLINK-33545 at 12/1/23 1:24 AM: -

[jira] [Comment Edited] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2023-11-30 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791866#comment-17791866 ] Mason Chen edited comment on FLINK-33545 at 12/1/23 1:29 AM: -

[jira] [Comment Edited] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2023-11-30 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791866#comment-17791866 ] Mason Chen edited comment on FLINK-33545 at 12/1/23 1:29 AM: -

Re: [PR] [FLINK-33638][table] Support variable-length data generation for variable-length data types [flink]

2023-11-30 Thread via GitHub
liyubin117 commented on PR #23810: URL: https://github.com/apache/flink/pull/23810#issuecomment-1835257286 @lincoln-lil surely, I will finish the doc synchronization right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Comment Edited] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2023-11-30 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791866#comment-17791866 ] Mason Chen edited comment on FLINK-33545 at 12/1/23 1:30 AM: -

[jira] [Created] (FLINK-33711) Fix numbers of field of the taxi event / Fix broken link

2023-11-30 Thread Leona Yoda (Jira)
Leona Yoda created FLINK-33711: -- Summary: Fix numbers of field of the taxi event / Fix broken link Key: FLINK-33711 URL: https://issues.apache.org/jira/browse/FLINK-33711 Project: Flink Issue T

[PR] [FLINK-33711] Fix numbers of field of the taxi event / Fix broken link [flink-training]

2023-11-30 Thread via GitHub
yoda-mon opened a new pull request, #66: URL: https://github.com/apache/flink-training/pull/66 - Fix number of fields of the taxi event from 11 to 10. - According to https://issues.apache.org/jira/browse/FLINK-23926, the number of fields decreased from 11 to 10. - Fix broken link

[jira] [Updated] (FLINK-33711) Fix numbers of field of the taxi event / Fix broken link

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33711: --- Labels: pull-request-available (was: ) > Fix numbers of field of the taxi event / Fix brok

Re: [PR] Draft FLINK-32898 [CI] [flink]

2023-11-30 Thread via GitHub
caodizhou commented on PR #23842: URL: https://github.com/apache/flink/pull/23842#issuecomment-1835330908 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Updated] (FLINK-29741) [FLIP-265] Remove all Scala APIs

2023-11-30 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-29741: --- Labels: 2.0-related (was: ) > [FLIP-265] Remove all Scala APIs > >

[jira] [Commented] (FLINK-33581) FLIP-381: Deprecate configuration getters/setters that return/set complex Java objects

2023-11-30 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791875#comment-17791875 ] Rui Fan commented on FLINK-33581: - Hey [~JunRuiLi] , thank you for the feedback! Great w

[jira] [Updated] (FLINK-4602) Move RocksDB backend to proper package

2023-11-30 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-4602: -- Labels: 2.0-related auto-unassigned (was: auto-unassigned) > Move RocksDB backend to proper package >

Re: [PR] [FLINK-33710] Prevent NOOP spec updates from the autoscaler parallelism override map [flink-kubernetes-operator]

2023-11-30 Thread via GitHub
1996fanrui commented on code in PR #720: URL: https://github.com/apache/flink-kubernetes-operator/pull/720#discussion_r1411546956 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/autoscaler/KubernetesScalingRealizerTest.java: ## @@ -0,0 +1,53 @@ +

[jira] [Updated] (FLINK-32383) 2.0 Breaking configuration changes

2023-11-30 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-32383: --- Labels: 2.0-related (was: ) > 2.0 Breaking configuration changes >

Re: [PR] Draft FLINK-32898 [CI] [flink]

2023-11-30 Thread via GitHub
caodizhou commented on PR #23842: URL: https://github.com/apache/flink/pull/23842#issuecomment-1835388181 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Updated] (FLINK-23620) Introduce proper YAML parsing to Flink's configuration

2023-11-30 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-23620: --- Labels: 2.0-related (was: pull-request-available stale-assigned) > Introduce proper YAML parsing to

[jira] [Updated] (FLINK-33297) FLIP-366: Support standard YAML for FLINK configuration

2023-11-30 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-33297: --- Fix Version/s: 1.19.0 > FLIP-366: Support standard YAML for FLINK configuration > --

[jira] [Updated] (FLINK-33297) FLIP-366: Support standard YAML for FLINK configuration

2023-11-30 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-33297: --- Labels: 2.0-related pull-request-available (was: pull-request-available) > FLIP-366: Support standa

Re: [PR] [FLINK-33638][table] Support variable-length data generation for variable-length data types [flink]

2023-11-30 Thread via GitHub
liyubin117 commented on PR #23810: URL: https://github.com/apache/flink/pull/23810#issuecomment-1835401600 @lincoln-lil Since update outdated chinese doc is seperated with var-len feature, I have divided commits into two, Could you please retain the structure to make commits clear, thanks :

Re: [PR] Release 1.6 Added new Metrics for custom autoscaler implementation [flink-kubernetes-operator]

2023-11-30 Thread via GitHub
orkhand closed pull request #719: Release 1.6 Added new Metrics for custom autoscaler implementation URL: https://github.com/apache/flink-kubernetes-operator/pull/719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[jira] [Commented] (FLINK-33702) Add IncrementalDelayRetryStrategy in AsyncRetryStrategies

2023-11-30 Thread xiangyu feng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791883#comment-17791883 ] xiangyu feng commented on FLINK-33702: -- Hi [~huwh] , would u kindly assign this to

[PR] [FLINK-33669][doc] Update the documentation for RestartStrategy, Checkpoint Storage, and State Backend. [flink]

2023-11-30 Thread via GitHub
JunRuiLee opened a new pull request, #23847: URL: https://github.com/apache/flink/pull/23847 ## What is the purpose of the change After the deprecation of complex Java object getter and setter methods in FLIP-381, Flink now recommends the use of ConfigOptions for the configura

[jira] [Updated] (FLINK-33669) Update the documentation for RestartStrategy, Checkpoint Storage, and State Backend.

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33669: --- Labels: pull-request-available (was: ) > Update the documentation for RestartStrategy, Chec

Re: [PR] [hotfix][core][test] fix ArchUnit typo in pom [flink]

2023-11-30 Thread via GitHub
JingGe commented on code in PR #23826: URL: https://github.com/apache/flink/pull/23826#discussion_r1411584321 ## flink-formats/flink-orc/pom.xml: ## @@ -182,7 +182,7 @@ under the License. test-jar - + Revi

Re: [PR] [FLINK-33669][doc] Update the documentation for RestartStrategy, Checkpoint Storage, and State Backend. [flink]

2023-11-30 Thread via GitHub
flinkbot commented on PR #23847: URL: https://github.com/apache/flink/pull/23847#issuecomment-1835433869 ## CI report: * f586ad401d51d9f23acaa11e35ff90871b9bc5b2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] FLINK-33600][table] print the query time cost for batch query in cli [flink]

2023-11-30 Thread via GitHub
JingGe commented on PR #23809: URL: https://github.com/apache/flink/pull/23809#issuecomment-1835434229 Thanks @fsk119 for your reviews! Appreciate it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-33669][doc] Update the documentation for RestartStrategy, Checkpoint Storage, and State Backend. [flink]

2023-11-30 Thread via GitHub
JingGe commented on code in PR #23847: URL: https://github.com/apache/flink/pull/23847#discussion_r1411585747 ## docs/content.zh/docs/deployment/filesystems/gcs.md: ## @@ -44,7 +44,10 @@ env.readTextFile("gs:///"); stream.writeAsText("gs:///"); // Use GCS as checkpoint stora

[jira] [Created] (FLINK-33712) FLIP-391: Deprecate RuntimeContext#getExecutionConfig

2023-11-30 Thread Junrui Li (Jira)
Junrui Li created FLINK-33712: - Summary: FLIP-391: Deprecate RuntimeContext#getExecutionConfig Key: FLINK-33712 URL: https://issues.apache.org/jira/browse/FLINK-33712 Project: Flink Issue Type: T

Re: [PR] [FLINK-31896][runtime] Extend web interface to support failure labels [flink]

2023-11-30 Thread via GitHub
pgaref commented on PR #22646: URL: https://github.com/apache/flink/pull/22646#issuecomment-1835461622 Hey @dmvk this is now ready for review -- attached UI screenshots! Please let me know what you think! -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-11-30 Thread via GitHub
JingGe commented on code in PR #23844: URL: https://github.com/apache/flink/pull/23844#discussion_r1411611276 ## flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/HadoopS3AccessHelper.java: ## @@ -84,13 +84,14 @@ public UploadPartResult uploadPart(

Re: [PR] [FLINK-33652]: Fixing hyperlink on first steps page. concepts to concepts/overview, as concepts page is empty. [flink]

2023-11-30 Thread via GitHub
JingGe merged PR #23815: URL: https://github.com/apache/flink/pull/23815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Comment Edited] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2023-11-30 Thread Kevin Tseng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791903#comment-17791903 ] Kevin Tseng edited comment on FLINK-33545 at 12/1/23 5:16 AM:

[jira] [Commented] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2023-11-30 Thread Kevin Tseng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791903#comment-17791903 ] Kevin Tseng commented on FLINK-33545: - Hi Mason, thank you for the comment. In the

[jira] [Created] (FLINK-33713) Deprecate RuntimeContext#getExecutionConfig

2023-11-30 Thread Junrui Li (Jira)
Junrui Li created FLINK-33713: - Summary: Deprecate RuntimeContext#getExecutionConfig Key: FLINK-33713 URL: https://issues.apache.org/jira/browse/FLINK-33713 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-33714) Update documentation about the usage of RuntimeContext#getExecutionConfig

2023-11-30 Thread Junrui Li (Jira)
Junrui Li created FLINK-33714: - Summary: Update documentation about the usage of RuntimeContext#getExecutionConfig Key: FLINK-33714 URL: https://issues.apache.org/jira/browse/FLINK-33714 Project: Flink

Re: [PR] [FLINK-33669][doc] Update the documentation for RestartStrategy, Checkpoint Storage, and State Backend. [flink]

2023-11-30 Thread via GitHub
1996fanrui commented on code in PR #23847: URL: https://github.com/apache/flink/pull/23847#discussion_r1411631989 ## docs/content.zh/docs/ops/state/state_backends.md: ## @@ -538,14 +540,11 @@ state.checkpoint-storage: filesystem {{< tabs "fsstatebackendmigration" >}} {{< tab "

[jira] [Created] (FLINK-33715) Enhance history server to archive multiple histories per jobid

2023-11-30 Thread dongwoo.kim (Jira)
dongwoo.kim created FLINK-33715: --- Summary: Enhance history server to archive multiple histories per jobid Key: FLINK-33715 URL: https://issues.apache.org/jira/browse/FLINK-33715 Project: Flink

[jira] [Updated] (FLINK-33715) Enhance history server to archive multiple histories per jobid

2023-11-30 Thread dongwoo.kim (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dongwoo.kim updated FLINK-33715: Description: Hello Flink team, I'd like to propose an improvement to how the job manager archives

Re: [PR] [FLINK-33669][doc] Update the documentation for RestartStrategy, Checkpoint Storage, and State Backend. [flink]

2023-11-30 Thread via GitHub
JunRuiLee commented on code in PR #23847: URL: https://github.com/apache/flink/pull/23847#discussion_r1411656511 ## docs/content.zh/docs/ops/state/state_backends.md: ## @@ -538,14 +540,11 @@ state.checkpoint-storage: filesystem {{< tabs "fsstatebackendmigration" >}} {{< tab "J

Re: [PR] [FLINK-33433][rest] Introduce async-profiler to support profiling Job… [flink]

2023-11-30 Thread via GitHub
Myasuka commented on code in PR #23820: URL: https://github.com/apache/flink/pull/23820#discussion_r1411573550 ## flink-runtime-web/web-dashboard/src/app/pages/job-manager/profiler/job-manager-profiler.component.html: ## @@ -0,0 +1,108 @@ + + + + + + +Profili

Re: [PR] [FLINK-33669][doc] Update the documentation for RestartStrategy, Checkpoint Storage, and State Backend. [flink]

2023-11-30 Thread via GitHub
JunRuiLee commented on code in PR #23847: URL: https://github.com/apache/flink/pull/23847#discussion_r1411664582 ## docs/content.zh/docs/deployment/filesystems/gcs.md: ## @@ -44,7 +44,10 @@ env.readTextFile("gs:///"); stream.writeAsText("gs:///"); // Use GCS as checkpoint st

[jira] [Updated] (FLINK-32557) API deprecations in Flink 1.18

2023-11-30 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-32557: -- Description: As discussed in [1], we are deprecating multiple APIs in release 1.18, in order to compl

[jira] [Updated] (FLINK-32557) API deprecations in Flink 1.18

2023-11-30 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-32557: -- Description: As discussed in [1], we are deprecating multiple APIs in release 1.18, in order to compl

[jira] [Updated] (FLINK-31596) Cleanup usage of deprecated methods in TableEnvironment

2023-11-30 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-31596: -- Description: This is a preparation to remove the deprecated methods in Table API for Flink v2.0. Curr

[jira] [Created] (FLINK-33716) Cleanup the usage of deprecated StreamTableEnvironment#createTemporaryView(String, DataStream, Expression...)

2023-11-30 Thread Jane Chan (Jira)
Jane Chan created FLINK-33716: - Summary: Cleanup the usage of deprecated StreamTableEnvironment#createTemporaryView(String, DataStream, Expression...) Key: FLINK-33716 URL: https://issues.apache.org/jira/browse/FLINK-

[PR] [FLINK-33713][core] Deprecate RuntimeContext#getExecutionConfig [flink]

2023-11-30 Thread via GitHub
JunRuiLee opened a new pull request, #23848: URL: https://github.com/apache/flink/pull/23848 ## What is the purpose of the change Deprecate RuntimeContext#getExecutionConfig, and introduce the alternative getter methods createSerializer(TypeInformation typeInformation), getGl

[jira] [Updated] (FLINK-33716) Cleanup the usage of deprecated StreamTableEnvironment#createTemporaryView(String, DataStream, Expression...)

2023-11-30 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-33716: -- Description: {code:java} ExpressionTestBase HiveTableSinkITCase {code} > Cleanup the usage of depreca

[jira] [Updated] (FLINK-33713) Deprecate RuntimeContext#getExecutionConfig

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33713: --- Labels: pull-request-available (was: ) > Deprecate RuntimeContext#getExecutionConfig >

[jira] [Created] (FLINK-33717) Cleanup the usage of deprecated StreamTableEnvironment#fromDataStream(DataStream, Expression...)

2023-11-30 Thread Jane Chan (Jira)
Jane Chan created FLINK-33717: - Summary: Cleanup the usage of deprecated StreamTableEnvironment#fromDataStream(DataStream, Expression...) Key: FLINK-33717 URL: https://issues.apache.org/jira/browse/FLINK-33717

[jira] [Updated] (FLINK-33717) Cleanup the usage of deprecated StreamTableEnvironment#fromDataStream(DataStream, Expression...)

2023-11-30 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-33717: -- Description: {code:java} PythonScalarFunctionOperatorTestBase AvroTypesITCase {code} > Cleanup the us

Re: [PR] [FLINK-33713][core] Deprecate RuntimeContext#getExecutionConfig [flink]

2023-11-30 Thread via GitHub
flinkbot commented on PR #23848: URL: https://github.com/apache/flink/pull/23848#issuecomment-1835568401 ## CI report: * 52ea8e42a7be0e6d8679bff1f47a5546617acc6c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-33718) Cleanup the usage of deprecated StreamTableEnvironment#toAppendStream

2023-11-30 Thread Jane Chan (Jira)
Jane Chan created FLINK-33718: - Summary: Cleanup the usage of deprecated StreamTableEnvironment#toAppendStream Key: FLINK-33718 URL: https://issues.apache.org/jira/browse/FLINK-33718 Project: Flink

[jira] [Updated] (FLINK-33717) Cleanup the usage of deprecated StreamTableEnvironment#fromDataStream

2023-11-30 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-33717: -- Summary: Cleanup the usage of deprecated StreamTableEnvironment#fromDataStream (was: Cleanup the usag

[jira] [Updated] (FLINK-33716) Cleanup the usage of deprecated StreamTableEnvironment#createTemporaryView

2023-11-30 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-33716: -- Summary: Cleanup the usage of deprecated StreamTableEnvironment#createTemporaryView (was: Cleanup the

[jira] [Created] (FLINK-33719) Cleanup the usage of deprecated StreamTableEnvironment#toRetractStream

2023-11-30 Thread Jane Chan (Jira)
Jane Chan created FLINK-33719: - Summary: Cleanup the usage of deprecated StreamTableEnvironment#toRetractStream Key: FLINK-33719 URL: https://issues.apache.org/jira/browse/FLINK-33719 Project: Flink

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

2023-11-30 Thread via GitHub
LadyForest commented on code in PR #23678: URL: https://github.com/apache/flink/pull/23678#discussion_r1410315513 ## flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/DataGenTableSourceFactory.java: ## @@ -127,11 +132,53 @@ private Da

[PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-11-30 Thread via GitHub
zoudan opened a new pull request, #23849: URL: https://github.com/apache/flink/pull/23849 ## What is the purpose of the change Support plan cache for DQL in SQL Gateway, so that we could reuse the plan and save time on SQL parsing, validation, and optimization. ## Brief change

<    1   2   3   >