Re: [PR] [FLINK-33691] Support agg push down for 'count(*)/count(1)/count(column not null)' [flink]

2023-11-30 Thread via GitHub
xuyangzhong commented on code in PR #23828: URL: https://github.com/apache/flink/pull/23828#discussion_r1410290690 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/batch/PushLocalSortAggWithCalcIntoScanRule.java: ## @@ -74,9 +74

Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-11-30 Thread via GitHub
MartijnVisser commented on PR #23740: URL: https://github.com/apache/flink/pull/23740#issuecomment-1833304430 > @MartijnVisser do you mind if I continue here or are you still working on this? If you could take it over, that would be great. -- This is an automated message from the

Re: [PR] [FLINK-32714] Add dialect for OceanBase database [flink-connector-jdbc]

2023-11-30 Thread via GitHub
MartijnVisser commented on code in PR #72: URL: https://github.com/apache/flink-connector-jdbc/pull/72#discussion_r1410313686 ## flink-connector-jdbc/pom.xml: ## @@ -110,6 +110,13 @@ under the License. provided + +c

[jira] [Created] (FLINK-33701) restart.time-tracking doc is wrong

2023-11-30 Thread Rui Fan (Jira)
Rui Fan created FLINK-33701: --- Summary: restart.time-tracking doc is wrong Key: FLINK-33701 URL: https://issues.apache.org/jira/browse/FLINK-33701 Project: Flink Issue Type: Technical Debt

[PR] [FLINK-33701][autoscaler] Fix the doc about restart.time-tracking.enabled [flink-kubernetes-operator]

2023-11-30 Thread via GitHub
1996fanrui opened a new pull request, #717: URL: https://github.com/apache/flink-kubernetes-operator/pull/717 The restart.time-tracking.limit as the upper bound instead of restart.time. ![image](https://github.com/apache/flink-kubernetes-operator/assets/38427477/adf0ca66-8adb-411b-b7d

[jira] [Updated] (FLINK-33701) restart.time-tracking doc is wrong

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33701: --- Labels: pull-request-available (was: ) > restart.time-tracking doc is wrong > -

Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-11-30 Thread via GitHub
MartijnVisser commented on PR #23740: URL: https://github.com/apache/flink/pull/23740#issuecomment-1833315378 Feel free to ping me for a review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (FLINK-33684) Improve the retry strategy in CollectResultFetcher

2023-11-30 Thread xiangyu feng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiangyu feng updated FLINK-33684: - Description: Currently  CollectResultFetcher use a fixed retry interval. {code:java} private voi

[jira] [Updated] (FLINK-33702) Add IncrementalDelayRetryStrategy in AsyncRetryStrategies

2023-11-30 Thread xiangyu feng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiangyu feng updated FLINK-33702: - Description: AsyncRetryStrategies now supports NoRetryStrategy, FixedDelayRetryStrategy and Exp

[jira] [Created] (FLINK-33702) Add IncrementalDelayRetryStrategy in AsyncRetryStrategies

2023-11-30 Thread xiangyu feng (Jira)
xiangyu feng created FLINK-33702: Summary: Add IncrementalDelayRetryStrategy in AsyncRetryStrategies Key: FLINK-33702 URL: https://issues.apache.org/jira/browse/FLINK-33702 Project: Flink Is

[jira] [Updated] (FLINK-33702) Add IncrementalDelayRetryStrategy in AsyncRetryStrategies

2023-11-30 Thread xiangyu feng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiangyu feng updated FLINK-33702: - Issue Type: Improvement (was: Bug) > Add IncrementalDelayRetryStrategy in AsyncRetryStrategies

[jira] [Commented] (FLINK-33702) Add IncrementalDelayRetryStrategy in AsyncRetryStrategies

2023-11-30 Thread xiangyu feng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791508#comment-17791508 ] xiangyu feng commented on FLINK-33702: -- Hi [~lincoln.86xy], I'll also work on this

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-11-30 Thread via GitHub
davidradl commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1833362667 @snuyanzin @qingwei91 could you have a look at this please and merge if you are ok with the changes I have made in response you your great feedback. -- This is an automated

[jira] [Updated] (FLINK-33702) Add IncrementalDelayRetryStrategy in AsyncRetryStrategies

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33702: --- Labels: pull-request-available (was: ) > Add IncrementalDelayRetryStrategy in AsyncRetryStr

[PR] [FLINK-33702][datastream] Add IncrementalDelayRetryStrategy in AsyncRetryStrategies [flink]

2023-11-30 Thread via GitHub
xiangyuf opened a new pull request, #23834: URL: https://github.com/apache/flink/pull/23834 ## What is the purpose of the change AsyncRetryStrategies now supports NoRetryStrategy, FixedDelayRetryStrategy and ExponentialBackoffDelayRetryStrategy. In certain scenarios, we also n

Re: [PR] [FLINK-33702][datastream] Add IncrementalDelayRetryStrategy in AsyncRetryStrategies [flink]

2023-11-30 Thread via GitHub
flinkbot commented on PR #23834: URL: https://github.com/apache/flink/pull/23834#issuecomment-1833374659 ## CI report: * b85ed1529098fbb878ff22eada3c37631ce07749 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33675] Serialize ValueLiteralExpressions into SQL [flink]

2023-11-30 Thread via GitHub
twalthr commented on code in PR #23829: URL: https://github.com/apache/flink/pull/23829#discussion_r1410380412 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/expressions/ValueLiteralExpression.java: ## @@ -219,6 +222,83 @@ public String asSummaryString()

[PR] Refactor redistribute [flink]

2023-11-30 Thread via GitHub
jiangxin369 opened a new pull request, #23835: URL: https://github.com/apache/flink/pull/23835 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring the

Re: [PR] [FLINK-33675] Serialize ValueLiteralExpressions into SQL [flink]

2023-11-30 Thread via GitHub
twalthr commented on code in PR #23829: URL: https://github.com/apache/flink/pull/23829#discussion_r1410385087 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/expressions/ValueLiteralExpression.java: ## @@ -219,6 +222,83 @@ public String asSummaryString()

Re: [PR] Refactor redistribute [flink]

2023-11-30 Thread via GitHub
flinkbot commented on PR #23835: URL: https://github.com/apache/flink/pull/23835#issuecomment-1833391016 ## CI report: * 6164e32c9cf2546ae994950fd170201e43e7713d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33694][gs-fs-hadoop] Support overriding GCS root URL [flink]

2023-11-30 Thread via GitHub
patricklucas opened a new pull request, #23836: URL: https://github.com/apache/flink/pull/23836 ## What is the purpose of the change This change configures the the GCS client used by the GSFileSystem's RecoverableWriter codepath to use the same GCS root URL as used by Hadoop. W

Re: [PR] [FLINK-33694][gs-fs-hadoop] Support overriding GCS root URL [flink]

2023-11-30 Thread via GitHub
patricklucas commented on PR #23836: URL: https://github.com/apache/flink/pull/23836#issuecomment-1833404691 Once this is accepted, I am ready with backport branches for 1.18 and 1.17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (FLINK-33694) GCS filesystem does not respect gs.storage.root.url config option

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33694: --- Labels: gcs pull-request-available (was: gcs) > GCS filesystem does not respect gs.storage.

Re: [PR] [FLINK-32714] Add dialect for OceanBase database [flink-connector-jdbc]

2023-11-30 Thread via GitHub
whhe commented on code in PR #72: URL: https://github.com/apache/flink-connector-jdbc/pull/72#discussion_r1410409235 ## flink-connector-jdbc/pom.xml: ## @@ -110,6 +110,13 @@ under the License. provided + +com.oceanb

Re: [PR] [FLINK-33694][gs-fs-hadoop] Support overriding GCS root URL [flink]

2023-11-30 Thread via GitHub
flinkbot commented on PR #23836: URL: https://github.com/apache/flink/pull/23836#issuecomment-1833417452 ## CI report: * da5b66cd0bfca529b8f28869721534b2c375309a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-32444) Enable object reuse for Flink SQL jobs by default

2023-11-30 Thread Stefan Richter (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791536#comment-17791536 ] Stefan Richter commented on FLINK-32444: [~pnowojski] if there really is an issu

[jira] [Created] (FLINK-33703) Use maven 3.8.6 for releasing of flink-shaded

2023-11-30 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33703: --- Summary: Use maven 3.8.6 for releasing of flink-shaded Key: FLINK-33703 URL: https://issues.apache.org/jira/browse/FLINK-33703 Project: Flink Issue Typ

[jira] [Assigned] (FLINK-33584) Update Hadoop Filesystems to 3.3.6

2023-11-30 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-33584: -- Assignee: Sergey Nuyanzin (was: Martijn Visser) > Update Hadoop Filesystems to 3.3.6

[jira] [Created] (FLINK-33704) Update GCS filesystems to latest available versions

2023-11-30 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-33704: -- Summary: Update GCS filesystems to latest available versions Key: FLINK-33704 URL: https://issues.apache.org/jira/browse/FLINK-33704 Project: Flink Issue

[jira] [Updated] (FLINK-33703) Use maven 3.8.6 for releasing of flink-shaded

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33703: --- Labels: pull-request-available (was: ) > Use maven 3.8.6 for releasing of flink-shaded > --

[PR] [FLINK-33704][Filesytems] Update GCS filesystems to latest available versions [flink]

2023-11-30 Thread via GitHub
MartijnVisser opened a new pull request, #23837: URL: https://github.com/apache/flink/pull/23837 ## What is the purpose of the change * Update GCS dependencies for filesystem to the latest versions ## Brief change log * Update POM files * Update NOTICE files * Moved

Re: [PR] FLINK-33600][table] print the query time cost for batch query in cli [flink]

2023-11-30 Thread via GitHub
fsk119 commented on code in PR #23809: URL: https://github.com/apache/flink/pull/23809#discussion_r1410406456 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliTableauResultView.java: ## @@ -122,14 +137,83 @@ private void checkAndCleanUpQuery(boo

[jira] [Updated] (FLINK-33581) FLIP-381: Deprecate configuration getters/setters that return/set complex Java objects

2023-11-30 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33581: Attachment: image-2023-11-30-17-59-42-650.png > FLIP-381: Deprecate configuration getters/setters that ret

[jira] [Created] (FLINK-33705) Upgrade flink-shaded to 18.0

2023-11-30 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33705: --- Summary: Upgrade flink-shaded to 18.0 Key: FLINK-33705 URL: https://issues.apache.org/jira/browse/FLINK-33705 Project: Flink Issue Type: Technical Debt

[jira] [Updated] (FLINK-33704) Update GCS filesystems to latest available versions

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33704: --- Labels: pull-request-available (was: ) > Update GCS filesystems to latest available version

[jira] [Commented] (FLINK-33581) FLIP-381: Deprecate configuration getters/setters that return/set complex Java objects

2023-11-30 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791542#comment-17791542 ] Rui Fan commented on FLINK-33581: - Hey [~JunRuiLi] , after these getters/setters are rem

[PR] [FLINK-33705] Upgrade to flink-shaded 18.0 [flink]

2023-11-30 Thread via GitHub
snuyanzin opened a new pull request, #23838: URL: https://github.com/apache/flink/pull/23838 ## What is the purpose of the change The PR is to bump flink-shaded dependency to 18.0 Also there was a breaking change in jackson-databind https://github.com/FasterXML/jackson-databind

[jira] [Updated] (FLINK-33705) Upgrade flink-shaded to 18.0

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33705: --- Labels: pull-request-available (was: ) > Upgrade flink-shaded to 18.0 > ---

Re: [PR] [FLINK-33704][Filesytems] Update GCS filesystems to latest available versions [flink]

2023-11-30 Thread via GitHub
flinkbot commented on PR #23837: URL: https://github.com/apache/flink/pull/23837#issuecomment-1833454330 ## CI report: * dafafb144572380d8c9a5140a91589bb757f77e6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33704][Filesytems] Update GCS filesystems to latest available versions [flink]

2023-11-30 Thread via GitHub
patricklucas commented on PR #23837: URL: https://github.com/apache/flink/pull/23837#issuecomment-1833459555 @MartijnVisser coincidentally I opened another PR (#23836) on flink-gs-fs-hadoop 20 minutes prior to yours. Maybe it makes sense to include it alongside? -- This is an automated m

Re: [PR] [FLINK-33705] Upgrade to flink-shaded 18.0 [flink]

2023-11-30 Thread via GitHub
flinkbot commented on PR #23838: URL: https://github.com/apache/flink/pull/23838#issuecomment-1833463884 ## CI report: * b97be9f433b01e22a334225399941df8cd9b44b1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33701][autoscaler] Fix the doc about restart.time-tracking.enabled [flink-kubernetes-operator]

2023-11-30 Thread via GitHub
1996fanrui merged PR #717: URL: https://github.com/apache/flink-kubernetes-operator/pull/717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

Re: [PR] [FLINK-33701][autoscaler] Fix the doc about restart.time-tracking.enabled [flink-kubernetes-operator]

2023-11-30 Thread via GitHub
1996fanrui commented on PR #717: URL: https://github.com/apache/flink-kubernetes-operator/pull/717#issuecomment-1833473388 Thanks @mxm for the quick review! Merging~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Resolved] (FLINK-33701) restart.time-tracking doc is wrong

2023-11-30 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-33701. - Resolution: Fixed > restart.time-tracking doc is wrong > -- > >

[jira] [Commented] (FLINK-33701) restart.time-tracking doc is wrong

2023-11-30 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791552#comment-17791552 ] Rui Fan commented on FLINK-33701: - Merged master<1.8.0> via 34b12399467d26b23f761c3db998

Re: [PR] [FLINK-33647] Implement restore tests for LookupJoin node [flink]

2023-11-30 Thread via GitHub
dawidwys commented on code in PR #23814: URL: https://github.com/apache/flink/pull/23814#discussion_r1410461388 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/LookupJoinTestPrograms.java: ## @@ -0,0 +1,287 @@ +/* + * Licens

Re: [PR] [FLINK-33340] Upgrade jackson to 2.15.3 [flink-shaded]

2023-11-30 Thread via GitHub
snuyanzin commented on code in PR #126: URL: https://github.com/apache/flink-shaded/pull/126#discussion_r1410462325 ## flink-shaded-jackson-parent/flink-shaded-jackson-2/pom.xml: ## @@ -78,6 +78,9 @@ under the License. org.apache.maven.plugins

Re: [PR] FLINK-33600][table] print the query time cost for batch query in cli [flink]

2023-11-30 Thread via GitHub
JingGe commented on code in PR #23809: URL: https://github.com/apache/flink/pull/23809#discussion_r1410463737 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliTableauResultView.java: ## @@ -122,14 +137,83 @@ private void checkAndCleanUpQuery(boo

Re: [PR] [FLINK-33470] Implement restore tests for Join node [flink]

2023-11-30 Thread via GitHub
dawidwys commented on code in PR #23680: URL: https://github.com/apache/flink/pull/23680#discussion_r1410463990 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java: ## @@ -0,0 +1,272 @@ +/* + * Licensed

Re: [PR] FLINK-33600][table] print the query time cost for batch query in cli [flink]

2023-11-30 Thread via GitHub
JingGe commented on code in PR #23809: URL: https://github.com/apache/flink/pull/23809#discussion_r1410468089 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliTableauResultView.java: ## @@ -38,31 +38,46 @@ import java.util.concurrent.Executors;

Re: [PR] FLINK-33600][table] print the query time cost for batch query in cli [flink]

2023-11-30 Thread via GitHub
fsk119 commented on code in PR #23809: URL: https://github.com/apache/flink/pull/23809#discussion_r1410477547 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliTableauResultView.java: ## @@ -38,31 +38,46 @@ import java.util.concurrent.Executors;

Re: [PR] FLINK-33600][table] print the query time cost for batch query in cli [flink]

2023-11-30 Thread via GitHub
JingGe commented on code in PR #23809: URL: https://github.com/apache/flink/pull/23809#discussion_r1410463737 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliTableauResultView.java: ## @@ -122,14 +137,83 @@ private void checkAndCleanUpQuery(boo

Re: [PR] FLINK-33600][table] print the query time cost for batch query in cli [flink]

2023-11-30 Thread via GitHub
JingGe commented on code in PR #23809: URL: https://github.com/apache/flink/pull/23809#discussion_r1410463737 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliTableauResultView.java: ## @@ -122,14 +137,83 @@ private void checkAndCleanUpQuery(boo

Re: [PR] FLINK-33600][table] print the query time cost for batch query in cli [flink]

2023-11-30 Thread via GitHub
fsk119 commented on code in PR #23809: URL: https://github.com/apache/flink/pull/23809#discussion_r1410478769 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliTableauResultView.java: ## @@ -122,14 +137,83 @@ private void checkAndCleanUpQuery(boo

Re: [PR] [FLINK-33701][autoscaler] Fix the doc about restart.time-tracking.enabled [flink-kubernetes-operator]

2023-11-30 Thread via GitHub
afedulov commented on PR #717: URL: https://github.com/apache/flink-kubernetes-operator/pull/717#issuecomment-1833511791 Thanks @1996fanrui ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-33470] Implement restore tests for Join node [flink]

2023-11-30 Thread via GitHub
twalthr commented on code in PR #23680: URL: https://github.com/apache/flink/pull/23680#discussion_r1410491319 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java: ## @@ -138,6 +147,16 @@ public Builder consumedAfterRestore(Str

Re: [PR] [FLINK-33470] Implement restore tests for Join node [flink]

2023-11-30 Thread via GitHub
twalthr commented on code in PR #23680: URL: https://github.com/apache/flink/pull/23680#discussion_r1410492024 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java: ## @@ -138,6 +147,16 @@ public Builder consumedAfterRestore(Str

Re: [PR] [FLINK-33470] Implement restore tests for Join node [flink]

2023-11-30 Thread via GitHub
twalthr commented on code in PR #23680: URL: https://github.com/apache/flink/pull/23680#discussion_r1410493959 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java: ## @@ -106,6 +113,8 @@ public static final class Builder extend

Re: [PR] [FLINK-33470] Implement restore tests for Join node [flink]

2023-11-30 Thread via GitHub
dawidwys commented on PR #23680: URL: https://github.com/apache/flink/pull/23680#issuecomment-1833528947 I think it looks mostly good. There is one comment from me left and the comments from Timo. After that I think we're good to go. -- This is an automated message from the Apache Git Ser

[PR] [docs][hotfix] Update AWS connector docs to v4.2 (Flink 1.19) [flink]

2023-11-30 Thread via GitHub
dannycranmer opened a new pull request, #23839: URL: https://github.com/apache/flink/pull/23839 ## What is the purpose of the change - Update docs for AWS connector to point at v4.2 for Flink 1.19 ## Brief change log - Update docs for AWS connector to point at v4.2

[PR] [docs][hotfix] Update AWS connector docs to v4.2 (Flink 1.18) [flink]

2023-11-30 Thread via GitHub
dannycranmer opened a new pull request, #23840: URL: https://github.com/apache/flink/pull/23840 ## What is the purpose of the change - Update docs for AWS connector to point at v4.2 for Flink 1.18 ## Brief change log - Update docs for AWS connector to point at v4.2

[PR] [docs][hotfix] Update AWS connector docs to v4.2 (Flink 1.17) [flink]

2023-11-30 Thread via GitHub
dannycranmer opened a new pull request, #23841: URL: https://github.com/apache/flink/pull/23841 ## What is the purpose of the change - Update docs for AWS connector to point at v4.2 for Flink 1.17 ## Brief change log - Update docs for AWS connector to point at v4.2

Re: [PR] [FLINK-33638][table] Support variable-length data generation for variable-length data types [flink]

2023-11-30 Thread via GitHub
liyubin117 commented on PR #23810: URL: https://github.com/apache/flink/pull/23810#issuecomment-1833537355 @lincoln-lil I have updated based on your comments, now CI succeed :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] [docs][hotfix] Update AWS connector docs to v4.2 (Flink 1.17) [flink]

2023-11-30 Thread via GitHub
flinkbot commented on PR #23841: URL: https://github.com/apache/flink/pull/23841#issuecomment-1833545280 ## CI report: * 6bf6853cc0a096fb26c030b30a96a57166a63e73 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [docs][hotfix] Update AWS connector docs to v4.2 (Flink 1.19) [flink]

2023-11-30 Thread via GitHub
flinkbot commented on PR #23839: URL: https://github.com/apache/flink/pull/23839#issuecomment-1833544870 ## CI report: * 7b92fc55d3887986953db003f22f3130df2161e9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [docs][hotfix] Update AWS connector docs to v4.2 (Flink 1.18) [flink]

2023-11-30 Thread via GitHub
flinkbot commented on PR #23840: URL: https://github.com/apache/flink/pull/23840#issuecomment-1833545079 ## CI report: * 356c967381a9b437e4d4c2f269aac4ccfc99e725 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33340] Upgrade jackson to 2.15.3 [flink-shaded]

2023-11-30 Thread via GitHub
snuyanzin commented on code in PR #126: URL: https://github.com/apache/flink-shaded/pull/126#discussion_r1410515692 ## flink-shaded-jackson-parent/flink-shaded-jackson-2/pom.xml: ## @@ -78,6 +78,9 @@ under the License. org.apache.maven.plugins

[PR] [hotfix][Connectors/AWS] Promoting to 4.3-SNAPSHOT [flink-connector-aws]

2023-11-30 Thread via GitHub
dannycranmer opened a new pull request, #118: URL: https://github.com/apache/flink-connector-aws/pull/118 ## Purpose of the change Promoting to 4.3-SNAPSHOT ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Significan

[PR] [hotfix][Connectors/AWS] Promoting v4.2.0 docs to final and including Flink compatibility matrix [flink-connector-aws]

2023-11-30 Thread via GitHub
dannycranmer opened a new pull request, #119: URL: https://github.com/apache/flink-connector-aws/pull/119 ## Purpose of the change * Promoting v4.2.0 docs to final and including Flink compatibility matrix ## Verifying this change This change is a trivial rework / code cle

Re: [PR] Adding AWS Connectors v4.2.0 [flink-web]

2023-11-30 Thread via GitHub
dannycranmer commented on code in PR #693: URL: https://github.com/apache/flink-web/pull/693#discussion_r1410540839 ## docs/data/release_archive.yml: ## @@ -522,6 +522,11 @@ release_archive: version: 3.0.1 release_date: 2023-10-30 filename: "kafka" +- na

[jira] [Commented] (FLINK-33641) JUnit5 fails to delete a directory on AZP for various table-planner tests

2023-11-30 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791590#comment-17791590 ] Sergey Nuyanzin commented on FLINK-33641: - https://dev.azure.com/apache-flink/ap

[jira] [Commented] (FLINK-33641) JUnit5 fails to delete a directory on AZP for various table-planner tests

2023-11-30 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791591#comment-17791591 ] Sergey Nuyanzin commented on FLINK-33641: - https://dev.azure.com/apache-flink/ap

[jira] [Commented] (FLINK-33699) Verify the snapshot migration on Java21

2023-11-30 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791592#comment-17791592 ] Yun Tang commented on FLINK-33699: -- I think it's better to introduce new tests to cover

[jira] [Commented] (FLINK-32391) YARNSessionFIFOITCase.checkForProhibitedLogContents fails on AZP on Java 17

2023-11-30 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791594#comment-17791594 ] Sergey Nuyanzin commented on FLINK-32391: - There is an occurrence for 1.17 https

[jira] [Commented] (FLINK-26644) python StreamExecutionEnvironmentTests.test_generate_stream_graph_with_dependencies failed on azure

2023-11-30 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791596#comment-17791596 ] Sergey Nuyanzin commented on FLINK-26644: - https://dev.azure.com/apache-flink/ap

[jira] [Created] (FLINK-33706) Build_wheels_on_macos fails on AZP

2023-11-30 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33706: --- Summary: Build_wheels_on_macos fails on AZP Key: FLINK-33706 URL: https://issues.apache.org/jira/browse/FLINK-33706 Project: Flink Issue Type: Bug

Re: [PR] [FLINK-27876][table-planner] Choose the right side as build side when using default shuffle hash strategy if left size is equal with right [flink]

2023-11-30 Thread via GitHub
lsyldliu commented on code in PR #19866: URL: https://github.com/apache/flink/pull/19866#discussion_r1410558281 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/MultipleInputCreationTest.xml: ## @@ -109,39 +109,6 @@ MultipleInpu

[jira] [Commented] (FLINK-27681) Improve the availability of Flink when the RocksDB file is corrupted.

2023-11-30 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791599#comment-17791599 ] Piotr Nowojski commented on FLINK-27681: {quote} However,  the job must fail in

[jira] [Commented] (FLINK-33435) The visualization and download capabilities of profiling history

2023-11-30 Thread Yu Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791600#comment-17791600 ] Yu Chen commented on FLINK-33435: - This subtask will be completed in FLINK-33433 and FLI

[jira] [Closed] (FLINK-33435) The visualization and download capabilities of profiling history

2023-11-30 Thread Yu Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Chen closed FLINK-33435. --- Resolution: Duplicate > The visualization and download capabilities of profiling history >

Re: [PR] Adding AWS Connectors v4.2.0 [flink-web]

2023-11-30 Thread via GitHub
leonardBang commented on code in PR #693: URL: https://github.com/apache/flink-web/pull/693#discussion_r1410574637 ## docs/data/release_archive.yml: ## @@ -522,6 +522,11 @@ release_archive: version: 3.0.1 release_date: 2023-10-30 filename: "kafka" +- nam

[jira] [Created] (FLINK-33707) Verify the snapshot migration on Java17

2023-11-30 Thread Yun Tang (Jira)
Yun Tang created FLINK-33707: Summary: Verify the snapshot migration on Java17 Key: FLINK-33707 URL: https://issues.apache.org/jira/browse/FLINK-33707 Project: Flink Issue Type: Improvement

Re: [PR] Add flink-shaded 18.0 release [flink-web]

2023-11-30 Thread via GitHub
TanYuxin-tyx commented on code in PR #701: URL: https://github.com/apache/flink-web/pull/701#discussion_r1410580484 ## docs/data/additional_components.yml: ## @@ -21,11 +21,11 @@ flink-connector-parent: source_release_asc_url: "https://downloads.apache.org/flink/flink-connec

[jira] [Commented] (FLINK-33581) FLIP-381: Deprecate configuration getters/setters that return/set complex Java objects

2023-11-30 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791609#comment-17791609 ] Junrui Li commented on FLINK-33581: --- Hey [~fanrui] , thank you for the reminder. Indee

[PR] Draft FLINK-32898 ci [flink]

2023-11-30 Thread via GitHub
caodizhou opened a new pull request, #23842: URL: https://github.com/apache/flink/pull/23842 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[jira] [Updated] (FLINK-32898) Improvement of usability for Flink OLAP

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32898: --- Labels: pull-request-available (was: ) > Improvement of usability for Flink OLAP >

Re: [PR] Draft FLINK-32898 ci [flink]

2023-11-30 Thread via GitHub
flinkbot commented on PR #23842: URL: https://github.com/apache/flink/pull/23842#issuecomment-1833695975 ## CI report: * db6ec6436d7e560d13a8b1493b8416aeee1c8107 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33556][CI] Test infrastructure for externalized python code [flink-connector-shared-utils]

2023-11-30 Thread via GitHub
pvary opened a new pull request, #27: URL: https://github.com/apache/flink-connector-shared-utils/pull/27 Adds a new `python_ci.yml` workflow which could be used to execute python tests for connectors. The requirement is that the code should be built with the command below: ```

[jira] [Updated] (FLINK-33556) Test infrastructure for externalized python code

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33556: --- Labels: pull-request-available (was: ) > Test infrastructure for externalized python code >

Re: [PR] Adding AWS Connectors v4.2.0 [flink-web]

2023-11-30 Thread via GitHub
dannycranmer merged PR #693: URL: https://github.com/apache/flink-web/pull/693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [FLINK-33470] Implement restore tests for Join node [flink]

2023-11-30 Thread via GitHub
jnh5y commented on code in PR #23680: URL: https://github.com/apache/flink/pull/23680#discussion_r1410643440 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java: ## @@ -106,6 +113,8 @@ public static final class Builder extends

Re: [PR] [FLINK-33675] Serialize ValueLiteralExpressions into SQL [flink]

2023-11-30 Thread via GitHub
dawidwys merged PR #23829: URL: https://github.com/apache/flink/pull/23829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Closed] (FLINK-33675) Serialize ValueLiteralExpressions into SQL

2023-11-30 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-33675. Resolution: Fixed Implemented in 88509e20df2edd80db9a893da21a9b3cb2777bf9 > Serialize Val

[PR] [FLINK-33556] Test infrastructure for externalized python code [flink]

2023-11-30 Thread via GitHub
pvary opened a new pull request, #23843: URL: https://github.com/apache/flink/pull/23843 ## What is the purpose of the change A few changes are needed in the original python test code, so the externalized connectors could run their tests ## Brief change log Marks the fil

Re: [PR] [FLINK-33556] Test infrastructure for externalized python code [flink]

2023-11-30 Thread via GitHub
flinkbot commented on PR #23843: URL: https://github.com/apache/flink/pull/23843#issuecomment-1833760576 ## CI report: * a212a4e003b06ab493f0f782e365fd90bf6959ff UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [hotfix][Connectors/AWS] Promoting v4.2.0 docs to final and including Flink compatibility matrix [flink-connector-aws]

2023-11-30 Thread via GitHub
dannycranmer merged PR #119: URL: https://github.com/apache/flink-connector-aws/pull/119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [hotfix][Connectors/AWS] Promoting to 4.3-SNAPSHOT [flink-connector-aws]

2023-11-30 Thread via GitHub
dannycranmer merged PR #118: URL: https://github.com/apache/flink-connector-aws/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] Draft FLINK-32898 ci [flink]

2023-11-30 Thread via GitHub
caodizhou commented on PR #23842: URL: https://github.com/apache/flink/pull/23842#issuecomment-1833782667 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [FLINK-33470] Implement restore tests for Join node [flink]

2023-11-30 Thread via GitHub
dawidwys commented on code in PR #23680: URL: https://github.com/apache/flink/pull/23680#discussion_r1410669365 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java: ## @@ -106,6 +113,8 @@ public static final class Builder exten

[PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-11-30 Thread via GitHub
snuyanzin opened a new pull request, #23844: URL: https://github.com/apache/flink/pull/23844 ## What is the purpose of the change This is the PR superceding https://github.com/apache/flink/pull/23740 by adopting hadoop api change usage ## Brief change log * cherry-pick f

  1   2   3   >