Re: [PR] [FLINK-32650][protobuf]Added the ability to split flink-protobuf code… [flink]

2023-11-12 Thread via GitHub
ljw-hit commented on code in PR #23162: URL: https://github.com/apache/flink/pull/23162#discussion_r1390343343 ## flink-formats/flink-protobuf/src/test/java/org/apache/flink/formats/protobuf/BigPbRowToProtoTest.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Fo

[jira] [Created] (FLINK-33526) Improve default autoscaler configs

2023-11-12 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-33526: -- Summary: Improve default autoscaler configs Key: FLINK-33526 URL: https://issues.apache.org/jira/browse/FLINK-33526 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-33527) Clear all physical states after autoscaler is disabled

2023-11-12 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33527: Summary: Clear all physical states after autoscaler is disabled (was: Clear all pysical states after auto

[jira] [Created] (FLINK-33527) Clear all pysical states after autoscaler is disabled

2023-11-12 Thread Rui Fan (Jira)
Rui Fan created FLINK-33527: --- Summary: Clear all pysical states after autoscaler is disabled Key: FLINK-33527 URL: https://issues.apache.org/jira/browse/FLINK-33527 Project: Flink Issue Type: Impro

[jira] [Updated] (FLINK-33527) Clear all physical states after autoscaler is disabled

2023-11-12 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33527: Description: Currently, we just clear ParallelismOverrides  after autoscaler is disabled. We should clear

[PR] [FLINK-33527][autoscaler] Clear all physical states after autoscaler is disabled [flink-kubernetes-operator]

2023-11-12 Thread via GitHub
1996fanrui opened a new pull request, #707: URL: https://github.com/apache/flink-kubernetes-operator/pull/707 ## What is the purpose of the change Currently, we just clear ParallelismOverrides after autoscaler is disabled. We should clear CollectedMetrics and ScalingHistory as

[jira] [Updated] (FLINK-33527) Clear all physical states after autoscaler is disabled

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33527: --- Labels: pull-request-available (was: ) > Clear all physical states after autoscaler is disa

Re: [PR] [FLINK-33331] Update netty to 4.1.100 and arrow to 13.0.0 to make flink-python passing on java 21 [flink]

2023-11-12 Thread via GitHub
snuyanzin commented on PR #23664: URL: https://github.com/apache/flink/pull/23664#issuecomment-1807143508 Thanks for taking a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [FLINK-33331] Update netty to 4.1.100 and arrow to 13.0.0 to make flink-python passing on java 21 [flink]

2023-11-12 Thread via GitHub
snuyanzin merged PR #23664: URL: https://github.com/apache/flink/pull/23664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[jira] [Updated] (FLINK-33526) Improve default autoscaler configs

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33526: --- Labels: pull-request-available (was: ) > Improve default autoscaler configs > -

[PR] [FLINK-33526] Autoscaler config improvement + cleanup [flink-kubernetes-operator]

2023-11-12 Thread via GitHub
gyfora opened a new pull request, #708: URL: https://github.com/apache/flink-kubernetes-operator/pull/708 ## What is the purpose of the change There are a few config defaults that should be improved based on prod usage: - Metric window : 10 -> 15m - Catch up duration: 15 -> 30m

Re: [PR] [FLINK-33526] Autoscaler config improvement + cleanup [flink-kubernetes-operator]

2023-11-12 Thread via GitHub
1996fanrui commented on code in PR #708: URL: https://github.com/apache/flink-kubernetes-operator/pull/708#discussion_r1390425243 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/FlinkOperator.java: ## @@ -190,7 +189,8 @@ void registerSessionJobCo

[jira] [Created] (FLINK-33528) Externalize Python connector code

2023-11-12 Thread Jira
Márton Balassi created FLINK-33528: -- Summary: Externalize Python connector code Key: FLINK-33528 URL: https://issues.apache.org/jira/browse/FLINK-33528 Project: Flink Issue Type: Technical D

Re: [PR] [FLINK-25857] Add committer metrics to track the status of committables [flink]

2023-11-12 Thread via GitHub
mbalassi merged PR #23555: URL: https://github.com/apache/flink/pull/23555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Closed] (FLINK-25857) Add committer metrics to track the status of committables

2023-11-12 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-25857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi closed FLINK-25857. -- Fix Version/s: 1.19.0 Resolution: Implemented [{{c3a07f9}}|https://github.com/apache/fl

Re: [PR] [FLINK-33213][table] Flink SQL calculate SqlMonotonicity for Calc. [flink]

2023-11-12 Thread via GitHub
snuyanzin merged PR #23516: URL: https://github.com/apache/flink/pull/23516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[jira] [Closed] (FLINK-33213) Flink SQL MinMax aggregations without retract messages when `where` condition exist

2023-11-12 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-33213. --- Resolution: Fixed > Flink SQL MinMax aggregations without retract messages when `where` cond

[jira] [Comment Edited] (FLINK-33213) Flink SQL MinMax aggregations without retract messages when `where` condition exist

2023-11-12 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785297#comment-17785297 ] Sergey Nuyanzin edited comment on FLINK-33213 at 11/12/23 5:08 PM: ---

[jira] [Commented] (FLINK-33213) Flink SQL MinMax aggregations without retract messages when `where` condition exist

2023-11-12 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785297#comment-17785297 ] Sergey Nuyanzin commented on FLINK-33213: - Merged as [29e49482a82e8c1cd404e42c3

[jira] [Commented] (FLINK-33331) Upgrade netty to 4.1.93+

2023-11-12 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785298#comment-17785298 ] Sergey Nuyanzin commented on FLINK-1: - Merged to flink main repo as [c488ad

[jira] [Updated] (FLINK-33331) Upgrade netty to 4.1.93+

2023-11-12 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-1: Fix Version/s: 1.19.0 > Upgrade netty to 4.1.93+ > > >

[jira] [Resolved] (FLINK-33331) Upgrade netty to 4.1.93+

2023-11-12 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-1. - Resolution: Fixed > Upgrade netty to 4.1.93+ > > >

Re: [PR] [FLINK-33526] Autoscaler config improvement + cleanup [flink-kubernetes-operator]

2023-11-12 Thread via GitHub
gyfora commented on code in PR #708: URL: https://github.com/apache/flink-kubernetes-operator/pull/708#discussion_r1390449190 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/FlinkOperator.java: ## @@ -190,7 +189,8 @@ void registerSessionJobContro

[jira] [Created] (FLINK-33529) PyFlink fails with "No module named 'cloudpickle"

2023-11-12 Thread Prabhu Joseph (Jira)
Prabhu Joseph created FLINK-33529: - Summary: PyFlink fails with "No module named 'cloudpickle" Key: FLINK-33529 URL: https://issues.apache.org/jira/browse/FLINK-33529 Project: Flink Issue Typ

[jira] [Updated] (FLINK-33529) PyFlink fails with "No module named 'cloudpickle"

2023-11-12 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prabhu Joseph updated FLINK-33529: -- Description: PyFlink fails with "No module named 'cloudpickle" on Flink 1.18. The same progra

[jira] [Updated] (FLINK-33529) PyFlink fails with "No module named 'cloudpickle"

2023-11-12 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prabhu Joseph updated FLINK-33529: -- Attachment: flink1.17-get_site_packages.py flink1.18-get_site_packages.py > Py

[jira] [Updated] (FLINK-33529) PyFlink fails with "No module named 'cloudpickle"

2023-11-12 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prabhu Joseph updated FLINK-33529: -- Attachment: batch_wc.py > PyFlink fails with "No module named 'cloudpickle" >

Re: [PR] [FLINK-33527][autoscaler] Clear all physical states after autoscaler is disabled [flink-kubernetes-operator]

2023-11-12 Thread via GitHub
gyfora commented on code in PR #707: URL: https://github.com/apache/flink-kubernetes-operator/pull/707#discussion_r1390470139 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java: ## @@ -115,10 +123,39 @@ public void cleanup(KEY jobKey) {

[jira] [Commented] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-12 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785321#comment-17785321 ] Sergey Nuyanzin commented on FLINK-33365: - looks like the issue is incomplete im

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-12 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785321#comment-17785321 ] Sergey Nuyanzin edited comment on FLINK-33365 at 11/12/23 9:36 PM: ---

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-12 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785321#comment-17785321 ] Sergey Nuyanzin edited comment on FLINK-33365 at 11/12/23 9:49 PM: ---

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-12 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785321#comment-17785321 ] Sergey Nuyanzin edited comment on FLINK-33365 at 11/12/23 9:57 PM: ---

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-12 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785321#comment-17785321 ] Sergey Nuyanzin edited comment on FLINK-33365 at 11/12/23 10:18 PM: --

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-12 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785321#comment-17785321 ] Sergey Nuyanzin edited comment on FLINK-33365 at 11/12/23 10:20 PM: --

Re: [PR] [FLINK-33361][connectors/kafka] Add Java 17 compatibility to Flink Kafka connector [flink-connector-kafka]

2023-11-12 Thread via GitHub
snuyanzin commented on PR #68: URL: https://github.com/apache/flink-connector-kafka/pull/68#issuecomment-1807265659 @MartijnVisser do you happen to know what should be done to make title validation passing? it seems it satisfies the regexp now, however it didn't with the first commit of

[jira] [Created] (FLINK-33530) Add entropy to Google Cloud Storage path for better scalability

2023-11-12 Thread Talat Uyarer (Jira)
Talat Uyarer created FLINK-33530: Summary: Add entropy to Google Cloud Storage path for better scalability Key: FLINK-33530 URL: https://issues.apache.org/jira/browse/FLINK-33530 Project: Flink

Re: [PR] [FLINK-33069]Mysql and Postgres catalog support url extra parameters [flink-connector-jdbc]

2023-11-12 Thread via GitHub
waywtdcc commented on PR #74: URL: https://github.com/apache/flink-connector-jdbc/pull/74#issuecomment-1807313296 > > Because sometimes you need to use ?characterEncoding=utf8 similar url parameters to connect to jdbc > > But why not just pass these in to the base URL? The rea

Re: [PR] [FLINK-33069]Mysql and Postgres catalog support url extra parameters [flink-connector-jdbc]

2023-11-12 Thread via GitHub
waywtdcc commented on PR #74: URL: https://github.com/apache/flink-connector-jdbc/pull/74#issuecomment-1807313452 > > Because sometimes you need to use ?characterEncoding=utf8 similar url parameters to connect to jdbc > > But why not just pass these in to the base URL? The rea

Re: [PR] [FLINK-33069]Mysql and Postgres catalog support url extra parameters [flink-connector-jdbc]

2023-11-12 Thread via GitHub
waywtdcc closed pull request #74: [FLINK-33069]Mysql and Postgres catalog support url extra parameters URL: https://github.com/apache/flink-connector-jdbc/pull/74 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[PR] [FLINK-33069]Mysql and Postgres catalog support url extra parameters [flink-connector-jdbc]

2023-11-12 Thread via GitHub
waywtdcc opened a new pull request, #74: URL: https://github.com/apache/flink-connector-jdbc/pull/74 Mysql and Postgres catalog support url extra parameters CREATE CATALOG mymysql WITH( 'type' = 'jdbc', 'default-database' = 'test', 'username' = 'root', 'password' = 'xxx',

[jira] [Created] (FLINK-33531) Nightly Python fails with NPE at metadataHandlerProvider on AZP

2023-11-12 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33531: --- Summary: Nightly Python fails with NPE at metadataHandlerProvider on AZP Key: FLINK-33531 URL: https://issues.apache.org/jira/browse/FLINK-33531 Project: Flink

[jira] [Updated] (FLINK-33531) Nightly Python fails with NPE at metadataHandlerProvider on AZP

2023-11-12 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-33531: Description: It seems starting 02.11.2023 every master nightly fails with this (that's why

Re: [PR] [FLINK-33340] Upgrade jackson to 2.15.3 [flink-shaded]

2023-11-12 Thread via GitHub
snuyanzin commented on PR #126: URL: https://github.com/apache/flink-shaded/pull/126#issuecomment-1807326279 resolved conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [FLINK-33340] Upgrade jackson to 2.15.3 [flink-shaded]

2023-11-12 Thread via GitHub
snuyanzin merged PR #126: URL: https://github.com/apache/flink-shaded/pull/126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

[jira] [Updated] (FLINK-33340) Bump Jackson to 2.15.3

2023-11-12 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-33340: Fix Version/s: shaded-18.0 > Bump Jackson to 2.15.3 > -- > >

[jira] [Commented] (FLINK-33340) Bump Jackson to 2.15.3

2023-11-12 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785346#comment-17785346 ] Sergey Nuyanzin commented on FLINK-33340: - Merged to flink-shaded master as [/9

[jira] [Commented] (FLINK-33397) FLIP-373: Support Configuring Different State TTLs using SQL Hint

2023-11-12 Thread CaoZhen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785347#comment-17785347 ] CaoZhen commented on FLINK-33397: - hi [~qingyue], [~xuyangzhong], can I participate in t

Re: [PR] [FLINK-28758] Fix stop-with-savepoint for FlinkKafkaConsumer [flink-connector-kafka]

2023-11-12 Thread via GitHub
ngannt1710 commented on PR #49: URL: https://github.com/apache/flink-connector-kafka/pull/49#issuecomment-1807353419 I use FlinkKafkaConsumer with two consumer(2 nodes) and two partitions. But the two consumers receive the same message regardless of which partitions it is pushed to. --

[jira] [Updated] (FLINK-32380) Support Java records

2023-11-12 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-32380: --- Attachment: image-2023-11-13-10-19-06-035.png > Support Java records > > >

[jira] [Commented] (FLINK-32380) Support Java records

2023-11-12 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785353#comment-17785353 ] xuyang commented on FLINK-32380: Hi, [~gyfora] Sorry for this noise. When I rebased mast

[jira] [Comment Edited] (FLINK-32380) Support Java records

2023-11-12 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785353#comment-17785353 ] xuyang edited comment on FLINK-32380 at 11/13/23 2:21 AM: -- Hi,

[jira] [Created] (FLINK-33532) Move the serialization of ShuffleDescriptorGroup out of the RPC main thread

2023-11-12 Thread Yangze Guo (Jira)
Yangze Guo created FLINK-33532: -- Summary: Move the serialization of ShuffleDescriptorGroup out of the RPC main thread Key: FLINK-33532 URL: https://issues.apache.org/jira/browse/FLINK-33532 Project: Flin

[jira] [Updated] (FLINK-33532) Move the serialization of ShuffleDescriptorGroup out of the RPC main thread

2023-11-12 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo updated FLINK-33532: --- Description: Currently, the serilization of ShuffleDescriptorGroup would happen in the RPC main thre

[jira] [Assigned] (FLINK-33532) Move the serialization of ShuffleDescriptorGroup out of the RPC main thread

2023-11-12 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo reassigned FLINK-33532: -- Assignee: dizhou cao (was: Yangze Guo) > Move the serialization of ShuffleDescriptorGroup ou

[jira] [Updated] (FLINK-33532) Move the serialization of ShuffleDescriptorGroup out of the RPC main thread

2023-11-12 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo updated FLINK-33532: --- Description: Currently, the serilization of ShuffleDescriptorGroup would happen in the RPC main thre

Re: [PR] [FLINK-33395][table-planner] fix the join hint doesn't work when appears in subquery [flink]

2023-11-12 Thread via GitHub
xuyangzhong commented on code in PR #23620: URL: https://github.com/apache/flink/pull/23620#discussion_r1390569239 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/alias/ClearJoinHintsWithInvalidPropagationShuttle.java: ## @@ -48,19 +49,10 @@ * T

Re: [PR] [FLINK-32650][protobuf]Added the ability to split flink-protobuf code… [flink]

2023-11-12 Thread via GitHub
ljw-hit commented on code in PR #23162: URL: https://github.com/apache/flink/pull/23162#discussion_r1390343616 ## flink-formats/flink-protobuf/src/main/java/org/apache/flink/formats/protobuf/PbConstant.java: ## @@ -27,4 +27,10 @@ public class PbConstant { public static fina

[jira] [Commented] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-12 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785355#comment-17785355 ] Benchao Li commented on FLINK-33365: [~Sergey Nuyanzin] Thanks for the digging. It's

Re: [PR] [FLINK-33527][autoscaler] Clear all physical states after autoscaler is disabled [flink-kubernetes-operator]

2023-11-12 Thread via GitHub
1996fanrui commented on code in PR #707: URL: https://github.com/apache/flink-kubernetes-operator/pull/707#discussion_r1390585356 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java: ## @@ -115,10 +123,39 @@ public void cleanup(KEY jobKey) {

Re: [PR] [FLINK-33527][autoscaler] Clear all physical states after autoscaler is disabled [flink-kubernetes-operator]

2023-11-12 Thread via GitHub
1996fanrui commented on code in PR #707: URL: https://github.com/apache/flink-kubernetes-operator/pull/707#discussion_r1390586714 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java: ## @@ -115,10 +123,39 @@ public void cleanup(KEY jobKey) {

Re: [PR] [FLINK-33526] Autoscaler config improvement + cleanup [flink-kubernetes-operator]

2023-11-12 Thread via GitHub
1996fanrui merged PR #708: URL: https://github.com/apache/flink-kubernetes-operator/pull/708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

[jira] [Commented] (FLINK-33526) Improve default autoscaler configs

2023-11-12 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785357#comment-17785357 ] Rui Fan commented on FLINK-33526: - Merged to master<1.7.0> via : cbcc6b67c98ddfad8bd6141

[jira] [Resolved] (FLINK-33526) Improve default autoscaler configs

2023-11-12 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-33526. - Resolution: Fixed > Improve default autoscaler configs > -- > >

[jira] [Updated] (FLINK-33526) Improve default autoscaler configs

2023-11-12 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33526: Fix Version/s: kubernetes-operator-1.7.0 > Improve default autoscaler configs > --

Re: [PR] [FLINK-33445][docs-zh] Translate DataSet migration guideline to Chinese [flink]

2023-11-12 Thread via GitHub
WencongLiu commented on code in PR #23666: URL: https://github.com/apache/flink/pull/23666#discussion_r1390574350 ## docs/content.zh/docs/dev/datastream/dataset_migration.md: ## @@ -134,10 +131,9 @@ DataStreamSource<> source = StreamExecutionEnvironment.createInput(inputFormat)

Re: [PR] [FLINK-32650][protobuf]Added the ability to split flink-protobuf code… [flink]

2023-11-12 Thread via GitHub
ljw-hit commented on PR #23162: URL: https://github.com/apache/flink/pull/23162#issuecomment-1807421613 @libenchao Thank you very much for your code review. I learned a lot from this review and I have solved all the comments. Please review again in your free time. -- This is an automate

Re: [PR] [FLINK-33449][table]Support array_contains_seq function [flink]

2023-11-12 Thread via GitHub
leoyy0316 commented on PR #23656: URL: https://github.com/apache/flink/pull/23656#issuecomment-1807423595 > > I have a question, why we always follow hive and spark? if we thinks is a feature need to support, we can implement it firstly. i think having rich functions is better > > Be

Re: [PR] [FLINK-33527][autoscaler] Clear all physical states after autoscaler is disabled [flink-kubernetes-operator]

2023-11-12 Thread via GitHub
gyfora commented on code in PR #707: URL: https://github.com/apache/flink-kubernetes-operator/pull/707#discussion_r1390598097 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java: ## @@ -115,10 +123,39 @@ public void cleanup(KEY jobKey) {

Re: [PR] [FLINK-33527][autoscaler] Clear all physical states after autoscaler is disabled [flink-kubernetes-operator]

2023-11-12 Thread via GitHub
gyfora merged PR #707: URL: https://github.com/apache/flink-kubernetes-operator/pull/707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Closed] (FLINK-33527) Clear all physical states after autoscaler is disabled

2023-11-12 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-33527. -- Resolution: Fixed merged to main bf5bb94bc87295e5ecb8ace8f579a22dca440e2d > Clear all physical states

Re: [PR] [FLINK-32650][protobuf]Added the ability to split flink-protobuf code… [flink]

2023-11-12 Thread via GitHub
libenchao commented on code in PR #23162: URL: https://github.com/apache/flink/pull/23162#discussion_r1390600656 ## flink-formats/flink-protobuf/src/main/java/org/apache/flink/formats/protobuf/serialize/RowToProtoConverter.java: ## @@ -84,11 +85,18 @@ public RowToProtoConverter(

[jira] [Created] (FLINK-33533) Add documentation about performance for huge ProtoBuf definations

2023-11-12 Thread Benchao Li (Jira)
Benchao Li created FLINK-33533: -- Summary: Add documentation about performance for huge ProtoBuf definations Key: FLINK-33533 URL: https://issues.apache.org/jira/browse/FLINK-33533 Project: Flink

[jira] [Commented] (FLINK-32380) Support Java records

2023-11-12 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785361#comment-17785361 ] Gyula Fora commented on FLINK-32380: Technically speaking we exclude these using the

Re: [PR] [FLINK-32650][protobuf]Added the ability to split flink-protobuf code… [flink]

2023-11-12 Thread via GitHub
ljw-hit commented on PR #23162: URL: https://github.com/apache/flink/pull/23162#issuecomment-1807478539 @libenchao Thank you for your detailed review work. I have solved these comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[jira] [Updated] (FLINK-33533) Add documentation about performance for huge ProtoBuf definations

2023-11-12 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li updated FLINK-33533: --- Description: This is brought up in the discussion of FLINK-32650. For huge ProtoBuf definations, th

[jira] [Commented] (FLINK-32650) Added the ability to split flink-protobuf codegen code

2023-11-12 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785365#comment-17785365 ] Benchao Li commented on FLINK-32650: I've created another ticket to add the document

[jira] [Updated] (FLINK-33533) Add documentation about performance for huge ProtoBuf definations

2023-11-12 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li updated FLINK-33533: --- Issue Type: Improvement (was: Bug) > Add documentation about performance for huge ProtoBuf definati

[jira] [Created] (FLINK-33534) PipelineOptions.PARALLELISM_OVERRIDES is not picked up from jar submission request

2023-11-12 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-33534: -- Summary: PipelineOptions.PARALLELISM_OVERRIDES is not picked up from jar submission request Key: FLINK-33534 URL: https://issues.apache.org/jira/browse/FLINK-33534 Projec

[jira] [Updated] (FLINK-33534) PipelineOptions.PARALLELISM_OVERRIDES is not picked up from jar submission request

2023-11-12 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-33534: --- Issue Type: Bug (was: Improvement) > PipelineOptions.PARALLELISM_OVERRIDES is not picked up from ja

[jira] [Commented] (FLINK-33534) PipelineOptions.PARALLELISM_OVERRIDES is not picked up from jar submission request

2023-11-12 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785367#comment-17785367 ] Gyula Fora commented on FLINK-33534: cc [~mxm] [~fanrui]  > PipelineOptions.PARALLE

Re: [PR] [FLINK-33148] Update Web UI to adopt the new "endpoint" field in REST API [flink]

2023-11-12 Thread via GitHub
X-czh commented on PR #23698: URL: https://github.com/apache/flink/pull/23698#issuecomment-1807522914 @huwh Could you help take a review when you are free? Many thanks~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] [FLINK-33445][docs-zh] Translate DataSet migration guideline to Chinese [flink]

2023-11-12 Thread via GitHub
liyubin117 commented on code in PR #23666: URL: https://github.com/apache/flink/pull/23666#discussion_r1390667818 ## docs/content.zh/docs/dev/datastream/dataset_migration.md: ## @@ -62,44 +58,45 @@ The first step of migrating an application from DataSet API to DataStream API is

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-11-12 Thread via GitHub
KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1390593913 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/SlotSharingGroup.java: ## @@ -76,6 +76,6 @@ public ResourceProfile getResourceProfile() {

[PR] Add release 1.17.2 [flink-web]

2023-11-12 Thread via GitHub
Myasuka opened a new pull request, #696: URL: https://github.com/apache/flink-web/pull/696 Add the content of release 1.17.2 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-33445][docs-zh] Translate DataSet migration guideline to Chinese [flink]

2023-11-12 Thread via GitHub
liyubin117 commented on code in PR #23666: URL: https://github.com/apache/flink/pull/23666#discussion_r1390673821 ## docs/content.zh/docs/dev/datastream/dataset_migration.md: ## @@ -134,10 +131,9 @@ DataStreamSource<> source = StreamExecutionEnvironment.createInput(inputFormat)

Re: [PR] [FLINK-33445][docs-zh] Translate DataSet migration guideline to Chinese [flink]

2023-11-12 Thread via GitHub
liyubin117 commented on code in PR #23666: URL: https://github.com/apache/flink/pull/23666#discussion_r1390674299 ## docs/content.zh/docs/dev/datastream/dataset_migration.md: ## @@ -679,19 +673,19 @@ dataStream3.join(dataStream4) -### Category 4 +### 第四类 -The behavio

[PR] Add flink-shaded 16.2 release [flink-web]

2023-11-12 Thread via GitHub
reswqa opened a new pull request, #697: URL: https://github.com/apache/flink-web/pull/697 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-11-12 Thread via GitHub
1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1390238967 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerConfiguration.java: ## @@ -295,6 +294,19 @@ public static SlotManagerC

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-11-12 Thread via GitHub
1996fanrui commented on PR #23635: URL: https://github.com/apache/flink/pull/23635#issuecomment-1807589290 Hi @KarmaGYZ , thanks for your hard review! > I think this PR contains two components. First would be a supplement of [FLINK-33448](https://issues.apache.org/jira/browse/FLINK-33

[jira] [Commented] (FLINK-26490) Adjust the MaxParallelism or remove the MaxParallelism check when unnecessary.

2023-11-12 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785394#comment-17785394 ] Yuan Mei commented on FLINK-26490: -- Sorry to respond late. Just saw this ticket recentl

[jira] [Commented] (FLINK-32380) Support Java records

2023-11-12 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785396#comment-17785396 ] xuyang commented on FLINK-32380: [~gyfora] Thanks for your quick reply! I'll try it. >