[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #197: [FLINK-30566] Add benchmark for AgglomerativeClustering, HashingTF, IDF, KBinsDiscretizer, LinearRegression, LinearSVC, Logi

2023-01-11 Thread GitBox
zhipeng93 commented on code in PR #197: URL: https://github.com/apache/flink-ml/pull/197#discussion_r1066673845 ## flink-ml-benchmark/src/main/resources/linearregression-benchmark.json: ## @@ -0,0 +1,45 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +/

[jira] [Commented] (FLINK-30552) Pulsar connector shouldn't assert the BatchMessageId size.

2023-01-11 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17665060#comment-17665060 ] Zili Chen commented on FLINK-30552: --- 3.0.1 via https://github.com/apache/flink-connect

[jira] [Assigned] (FLINK-30552) Pulsar connector shouldn't assert the BatchMessageId size.

2023-01-11 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen reassigned FLINK-30552: - Assignee: Yufan Sheng > Pulsar connector shouldn't assert the BatchMessageId size. > --

[jira] [Updated] (FLINK-30552) Pulsar connector shouldn't assert the BatchMessageId size.

2023-01-11 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen updated FLINK-30552: -- Fix Version/s: pulsar-3.0.1 > Pulsar connector shouldn't assert the BatchMessageId size. > ---

[jira] [Updated] (FLINK-30556) Improve the logic for enumerating splits for Hive source to avoid potential OOM

2023-01-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30556: --- Labels: pull-request-available (was: ) > Improve the logic for enumerating splits for Hive

[GitHub] [flink] swuferhong commented on a diff in pull request #21586: [FLINK-30542][table-runtime] Introduce adaptive hash aggregate to adaptively determine whether local hash aggregate is required

2023-01-11 Thread GitBox
swuferhong commented on code in PR #21586: URL: https://github.com/apache/flink/pull/21586#discussion_r1066676100 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/batch/BatchPhysicalHashAggregate.scala: ## @@ -53,7 +53,8 @@ cla

[GitHub] [flink] xintongsong commented on a diff in pull request #21603: [FLINK-30332] HsFileDataIndex supports caching and spilling index entry

2023-01-11 Thread GitBox
xintongsong commented on code in PR #21603: URL: https://github.com/apache/flink/pull/21603#discussion_r1066635610 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsFileDataIndexSpilledRegionManagerImpl.java: ## @@ -0,0 +1,336 @@ +/* + * Licen

[GitHub] [flink-ml] zhipeng93 commented on pull request #197: [FLINK-30566] Add benchmark for AgglomerativeClustering, HashingTF, IDF, KBinsDiscretizer, LinearRegression, LinearSVC, LogisticRegres

2023-01-11 Thread GitBox
zhipeng93 commented on PR #197: URL: https://github.com/apache/flink-ml/pull/197#issuecomment-1378366076 Thanks for the review @lindong28 . I have updated the PR in the latest PR. Please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [flink] flinkbot commented on pull request #21645: [FLINK-30556] Improve the logic for enumerating splits for Hive source to avoid potential OOM

2023-01-11 Thread GitBox
flinkbot commented on PR #21645: URL: https://github.com/apache/flink/pull/21645#issuecomment-1378371092 ## CI report: * 7162b2dbc3219a744e6be798d5b11215dda5cf74 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21626: [FLINK-30604][runtime] Remove the limitation that parallelism decided by adaptive batch scheduler is always a power of two

2023-01-11 Thread GitBox
zhuzhurk commented on code in PR #21626: URL: https://github.com/apache/flink/pull/21626#discussion_r1066677286 ## flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java: ## @@ -582,14 +578,9 @@ public enum SchedulerType { .withDescri

[GitHub] [flink-table-store] JingsongLi merged pull request #478: [FLINK-30615] Refactor ReadWriteTableITCase to get rid of Managed Table and introduce new AbstractTestBase

2023-01-11 Thread GitBox
JingsongLi merged PR #478: URL: https://github.com/apache/flink-table-store/pull/478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[jira] [Closed] (FLINK-30615) Refactor ReadWriteTableITCase to get rid of Managed Table

2023-01-11 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-30615. Fix Version/s: table-store-0.4.0 Assignee: yuzelin Resolution: Fixed master: 7417d

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #475: [FLINK-30620] Table Store Hive catalog supports specifying custom Hive metastore client

2023-01-11 Thread GitBox
JingsongLi commented on code in PR #475: URL: https://github.com/apache/flink-table-store/pull/475#discussion_r1066684828 ## flink-table-store-hive/flink-table-store-hive-catalog/src/main/java/org/apache/flink/table/store/hive/HiveCatalogOptions.java: ## @@ -0,0 +1,34 @@ +/* + *

[GitHub] [flink-ml] lindong28 commented on pull request #197: [FLINK-30566] Add benchmark for AgglomerativeClustering, HashingTF, IDF, KBinsDiscretizer, LinearRegression, LinearSVC, LogisticRegres

2023-01-11 Thread GitBox
lindong28 commented on PR #197: URL: https://github.com/apache/flink-ml/pull/197#issuecomment-1378376796 Thanks for the update! LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-ml] lindong28 closed pull request #197: [FLINK-30566] Add benchmark for AgglomerativeClustering, HashingTF, IDF, KBinsDiscretizer, LinearRegression, LinearSVC, LogisticRegression,

2023-01-11 Thread GitBox
lindong28 closed pull request #197: [FLINK-30566] Add benchmark for AgglomerativeClustering, HashingTF, IDF, KBinsDiscretizer, LinearRegression, LinearSVC, LogisticRegression, NGram, RegexTokenizer, Tokenizer and Vectorindexer URL: https://github.com/apache/flink-ml/pull/197 -- This is

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #198: [FLINK-30568] Add benchmark for PolyNomialExpansion, Normalizer, Binarizer, Interaction, MaxAbsScaler, VectorSlicer, ElementWise

2023-01-11 Thread GitBox
zhipeng93 commented on code in PR #198: URL: https://github.com/apache/flink-ml/pull/198#discussion_r1066688256 ## flink-ml-benchmark/src/main/resources/elementwiseproduct-benchmark.json: ## @@ -0,0 +1,41 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Commented] (FLINK-25916) Using upsert-kafka with a flush buffer results in Null Pointer Exception

2023-01-11 Thread Yao Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17668604#comment-17668604 ] Yao Zhang commented on FLINK-25916: --- Hi all, Could someone help review the code pleas

[jira] [Created] (FLINK-30629) ClientHeartbeatTest.testJobRunningIfClientReportHeartbeat is unstable

2023-01-11 Thread Xintong Song (Jira)
Xintong Song created FLINK-30629: Summary: ClientHeartbeatTest.testJobRunningIfClientReportHeartbeat is unstable Key: FLINK-30629 URL: https://issues.apache.org/jira/browse/FLINK-30629 Project: Flink

[jira] [Commented] (FLINK-30629) ClientHeartbeatTest.testJobRunningIfClientReportHeartbeat is unstable

2023-01-11 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17670876#comment-17670876 ] Xintong Song commented on FLINK-30629: -- [~Jiangang], could you please take a look a

[jira] [Commented] (FLINK-29427) LookupJoinITCase failed with classloader problem

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17671517#comment-17671517 ] Matthias Pohl commented on FLINK-29427: --- https://dev.azure.com/apache-flink/apache

[jira] [Created] (FLINK-30630) Python: BatchModeDataStreamTests.test_keyed_map failed

2023-01-11 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-30630: - Summary: Python: BatchModeDataStreamTests.test_keyed_map failed Key: FLINK-30630 URL: https://issues.apache.org/jira/browse/FLINK-30630 Project: Flink Issu

[jira] [Updated] (FLINK-30630) Python: BatchModeDataStreamTests.test_keyed_map failed

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30630: -- Description: {{BatchModeDataStreamTests.test_keyed_map}} failed in 1.15: https://dev.azure.com

[jira] [Comment Edited] (FLINK-30630) Python: BatchModeDataStreamTests.test_keyed_map failed

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672188#comment-17672188 ] Matthias Pohl edited comment on FLINK-30630 at 1/11/23 8:45 AM: --

[jira] [Updated] (FLINK-30630) Python: BatchModeDataStreamTests.test_keyed_map failed

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30630: -- Priority: Critical (was: Major) > Python: BatchModeDataStreamTests.test_keyed_map failed > --

[jira] [Commented] (FLINK-30630) Python: BatchModeDataStreamTests.test_keyed_map failed

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672188#comment-17672188 ] Matthias Pohl commented on FLINK-30630: --- [~dianfu][~hxbks2ks] > Python: BatchMode

[GitHub] [flink] yuzelin commented on a diff in pull request #21502: [FLINK-29950] Refactor ResultSet to an interface

2023-01-11 Thread GitBox
yuzelin commented on code in PR #21502: URL: https://github.com/apache/flink/pull/21502#discussion_r1066716687 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/result/ResultFetcher.java: ## @@ -220,4 +283,26 @@ public synchronized ResultSet f

[jira] [Created] (FLINK-30631) Limit the max number of subpartitons consumed by each downstream task

2023-01-11 Thread Lijie Wang (Jira)
Lijie Wang created FLINK-30631: -- Summary: Limit the max number of subpartitons consumed by each downstream task Key: FLINK-30631 URL: https://issues.apache.org/jira/browse/FLINK-30631 Project: Flink

[jira] [Assigned] (FLINK-30631) Limit the max number of subpartitons consumed by each downstream task

2023-01-11 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang reassigned FLINK-30631: -- Assignee: Lijie Wang > Limit the max number of subpartitons consumed by each downstream task

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #21546: [FLINK-30477][datastream] Fix AsyncWaitOperator that not properly blocking retries when timeout occurs

2023-01-11 Thread GitBox
gaoyunhaii commented on code in PR #21546: URL: https://github.com/apache/flink/pull/21546#discussion_r1066547072 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperator.java: ## @@ -443,33 +445,53 @@ public RetryableResultHandlerDe

[jira] [Commented] (FLINK-30559) May get wrong result for `if` expression if it's string data type

2023-01-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672243#comment-17672243 ] luoyuxia commented on FLINK-30559: -- Thanks [~miamiaoxyz]  Please feel free to take it.

[jira] [Commented] (FLINK-30023) ChangelogStorageMetricsTest#testTotalAttemptsPerUpload failed

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672244#comment-17672244 ] Matthias Pohl commented on FLINK-30023: --- We see a similar test failure in 1.15. h

[GitHub] [flink] wanglijie95 opened a new pull request, #21646: [FLINK-30631][runtime] Limit the max number of subpartitons consumed by each downstream task

2023-01-11 Thread GitBox
wanglijie95 opened a new pull request, #21646: URL: https://github.com/apache/flink/pull/21646 ## What is the purpose of the change In the current implementation([FLINK-25035](https://issues.apache.org/jira/browse/FLINK-25035)), when the upstream vertex parallelism is much greater than t

[jira] [Updated] (FLINK-30631) Limit the max number of subpartitons consumed by each downstream task

2023-01-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30631: --- Labels: pull-request-available (was: ) > Limit the max number of subpartitons consumed by e

[jira] [Created] (FLINK-30632) Introduce DataType for table store

2023-01-11 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-30632: Summary: Introduce DataType for table store Key: FLINK-30632 URL: https://issues.apache.org/jira/browse/FLINK-30632 Project: Flink Issue Type: Sub-task

[GitHub] [flink-table-store] JingsongLi opened a new pull request, #479: [FLINK-30632] Introduce DataType for table store

2023-01-11 Thread GitBox
JingsongLi opened a new pull request, #479: URL: https://github.com/apache/flink-table-store/pull/479 Introduce table store own DataType to decouple Flink SQL LogicalType. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Updated] (FLINK-30632) Introduce DataType for table store

2023-01-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30632: --- Labels: pull-request-available (was: ) > Introduce DataType for table store > -

[GitHub] [flink] luoyuxia commented on a diff in pull request #21609: [FLINK-30586][table-runtime] Fix calcCodeGen failed if calc with 'like' condition contains double quotation mark

2023-01-11 Thread GitBox
luoyuxia commented on code in PR #21609: URL: https://github.com/apache/flink/pull/21609#discussion_r1066727574 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala: ## @@ -304,9 +304,10 @@ object GenerateUtils { //

[jira] [Updated] (FLINK-30023) ChangelogStorageMetricsTest#testTotalAttemptsPerUpload failed

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30023: -- Affects Version/s: 1.15.3 > ChangelogStorageMetricsTest#testTotalAttemptsPerUpload failed > --

[jira] [Updated] (FLINK-30023) ChangelogStorageMetricsTest#testTotalAttemptsPerUpload failed

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30023: -- Component/s: Runtime / State Backends > ChangelogStorageMetricsTest#testTotalAttemptsPerUpload

[jira] [Updated] (FLINK-30023) ChangelogStorageMetricsTest#testTotalAttemptsPerUpload failed

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30023: -- Affects Version/s: 1.16.0 1.17.0 > ChangelogStorageMetricsTest#testTota

[GitHub] [flink] flinkbot commented on pull request #21646: [FLINK-30631][runtime] Limit the max number of subpartitons consumed by each downstream task

2023-01-11 Thread GitBox
flinkbot commented on PR #21646: URL: https://github.com/apache/flink/pull/21646#issuecomment-1378428604 ## CI report: * 50715d0b007f8393d2a730e48a83426475535569 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-30023) ChangelogStorageMetricsTest#testTotalAttemptsPerUpload failed

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672251#comment-17672251 ] Matthias Pohl commented on FLINK-30023: --- I updated the affected Version to also in

[jira] [Created] (FLINK-30633) Update AWS SDKv2 to v2.19.14

2023-01-11 Thread Danny Cranmer (Jira)
Danny Cranmer created FLINK-30633: - Summary: Update AWS SDKv2 to v2.19.14 Key: FLINK-30633 URL: https://issues.apache.org/jira/browse/FLINK-30633 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-30304) Possible Deadlock in Kinesis/Firehose/DynamoDB Connector

2023-01-11 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672255#comment-17672255 ] Danny Cranmer commented on FLINK-30304: --- This has been fixed in SDK v2.19.14, upgr

[jira] [Assigned] (FLINK-30633) Update AWS SDKv2 to v2.19.14

2023-01-11 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-30633: - Assignee: Danny Cranmer > Update AWS SDKv2 to v2.19.14 > >

[jira] [Updated] (FLINK-30304) Possible Deadlock in Kinesis/Firehose/DynamoDB Connector

2023-01-11 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-30304: -- Affects Version/s: aws-connector-4.0.0 > Possible Deadlock in Kinesis/Firehose/DynamoDB Connec

[jira] [Updated] (FLINK-30304) Possible Deadlock in Kinesis/Firehose/DynamoDB Connector

2023-01-11 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-30304: -- Fix Version/s: aws-connector-4.1.0 > Possible Deadlock in Kinesis/Firehose/DynamoDB Connector

[GitHub] [flink] link3280 commented on pull request #21582: [FLINK-28655][SQL gateway] Support show jobs operation in SqlGateway

2023-01-11 Thread GitBox
link3280 commented on PR #21582: URL: https://github.com/apache/flink/pull/21582#issuecomment-1378444635 @fsk119 Thanks a lot for your review! The PR is updated as suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (FLINK-30533) SourceOperator#emitNext() should push records to DataOutput in a while loop

2023-01-11 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672260#comment-17672260 ] Yanfei Lei commented on FLINK-30533: Hi [~lindong] , could you please help take a lo

[GitHub] [flink] link3280 commented on a diff in pull request #21581: [FLINK-30538][SQL gateway/client] Improve error handling of stop job operation

2023-01-11 Thread GitBox
link3280 commented on code in PR #21581: URL: https://github.com/apache/flink/pull/21581#discussion_r1066752130 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java: ## @@ -487,23 +487,22 @@ public ResultFetcher c

[GitHub] [flink] luoyuxia commented on a diff in pull request #21629: [FLINK-30579][hive] Introducing cofigurable option to enable hive native function

2023-01-11 Thread GitBox
luoyuxia commented on code in PR #21629: URL: https://github.com/apache/flink/pull/21629#discussion_r1066748204 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveSumAggFunction.java: ## @@ -125,10 +126,16 @@ private DataType initRes

[jira] [Reopened] (FLINK-30413) Drop Shared and Key_Shared subscription support in Pulsar connector

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reopened FLINK-30413: --- Can you please provide backports to 1.16 and 1.15? We've seen test instabilities (the once coll

[jira] [Comment Edited] (FLINK-30413) Drop Shared and Key_Shared subscription support in Pulsar connector

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672264#comment-17672264 ] Matthias Pohl edited comment on FLINK-30413 at 1/11/23 9:25 AM: --

[GitHub] [flink] tsianglei closed pull request #19124: [FLINK-26694] LookupFunction doesn't support multilevel inheritance.

2023-01-11 Thread GitBox
tsianglei closed pull request #19124: [FLINK-26694] LookupFunction doesn't support multilevel inheritance. URL: https://github.com/apache/flink/pull/19124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Updated] (FLINK-30413) Drop Shared and Key_Shared subscription support in Pulsar connector

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30413: -- Affects Version/s: 1.15.3 1.16.0 > Drop Shared and Key_Shared subscript

[jira] [Comment Edited] (FLINK-30413) Drop Shared and Key_Shared subscription support in Pulsar connector

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672264#comment-17672264 ] Matthias Pohl edited comment on FLINK-30413 at 1/11/23 9:27 AM: --

[jira] [Commented] (FLINK-30629) ClientHeartbeatTest.testJobRunningIfClientReportHeartbeat is unstable

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672265#comment-17672265 ] Matthias Pohl commented on FLINK-30629: --- https://dev.azure.com/apache-flink/apache

[jira] [Updated] (FLINK-30629) ClientHeartbeatTest.testJobRunningIfClientReportHeartbeat is unstable

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30629: -- Labels: test-stability (was: ) > ClientHeartbeatTest.testJobRunningIfClientReportHeartbeat is

[jira] [Updated] (FLINK-30629) ClientHeartbeatTest.testJobRunningIfClientReportHeartbeat is unstable

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30629: -- Priority: Critical (was: Major) > ClientHeartbeatTest.testJobRunningIfClientReportHeartbeat i

[GitHub] [flink] swuferhong commented on a diff in pull request #21586: [FLINK-30542][table-runtime] Introduce adaptive hash aggregate to adaptively determine whether local hash aggregate is required

2023-01-11 Thread GitBox
swuferhong commented on code in PR #21586: URL: https://github.com/apache/flink/pull/21586#discussion_r1066761596 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/agg/batch/HashAggCodeGenerator.scala: ## @@ -202,11 +299,43 @@ class HashAgg

[jira] [Commented] (FLINK-29427) LookupJoinITCase failed with classloader problem

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672266#comment-17672266 ] Matthias Pohl commented on FLINK-29427: --- https://dev.azure.com/apache-flink/apache

[jira] [Commented] (FLINK-30141) MinioTestContainerTest failed due to IllegalStateException in container startup

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672267#comment-17672267 ] Matthias Pohl commented on FLINK-30141: --- https://dev.azure.com/apache-flink/apache

[jira] [Comment Edited] (FLINK-30629) ClientHeartbeatTest.testJobRunningIfClientReportHeartbeat is unstable

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672265#comment-17672265 ] Matthias Pohl edited comment on FLINK-30629 at 1/11/23 9:30 AM: --

[jira] [Created] (FLINK-30634) HiveTableSourceITCase.setupSourceDatabaseAndData fails with InvalidObjectException

2023-01-11 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-30634: - Summary: HiveTableSourceITCase.setupSourceDatabaseAndData fails with InvalidObjectException Key: FLINK-30634 URL: https://issues.apache.org/jira/browse/FLINK-30634

[jira] [Created] (FLINK-30635) Fail to recover for row-format when writing to OSS using FileSystemTable connector

2023-01-11 Thread luoyuxia (Jira)
luoyuxia created FLINK-30635: Summary: Fail to recover for row-format when writing to OSS using FileSystemTable connector Key: FLINK-30635 URL: https://issues.apache.org/jira/browse/FLINK-30635 Project: F

[jira] [Commented] (FLINK-30623) Performance regression in checkpointSingleInput.UNALIGNED on 04.01.2023

2023-01-11 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672271#comment-17672271 ] Yanfei Lei commented on FLINK-30623: For checkpointSingleInput.UNALIGNED and checkpo

[GitHub] [flink] swuferhong commented on a diff in pull request #21586: [FLINK-30542][table-runtime] Introduce adaptive hash aggregate to adaptively determine whether local hash aggregate is required

2023-01-11 Thread GitBox
swuferhong commented on code in PR #21586: URL: https://github.com/apache/flink/pull/21586#discussion_r1066775534 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala: ## @@ -610,6 +610,58 @@ object GenerateUtils { g

[jira] [Updated] (FLINK-30635) Fail to recover for row-format when writing to OSS using FileSystemTable connector

2023-01-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-30635: - Attachment: image-2023-01-11-17-42-15-964.png > Fail to recover for row-format when writing to OSS using

[jira] [Updated] (FLINK-30635) Fail to recover for row-format when writing to OSS using FileSystemTable connector

2023-01-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-30635: - Description: When recover for row-format file such as csv/json, it will try to copy oss to local which

[jira] [Assigned] (FLINK-30629) ClientHeartbeatTest.testJobRunningIfClientReportHeartbeat is unstable

2023-01-11 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song reassigned FLINK-30629: Assignee: Liu > ClientHeartbeatTest.testJobRunningIfClientReportHeartbeat is unstable > -

[jira] [Commented] (FLINK-30629) ClientHeartbeatTest.testJobRunningIfClientReportHeartbeat is unstable

2023-01-11 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672277#comment-17672277 ] Xintong Song commented on FLINK-30629: -- Offline reached out to [~Jiangang] and he s

[jira] [Commented] (FLINK-30621) Violation of main thread constraint detected

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672278#comment-17672278 ] Matthias Pohl commented on FLINK-30621: --- I true, that's what I should have checked

[jira] [Comment Edited] (FLINK-30621) Violation of main thread constraint detected

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672278#comment-17672278 ] Matthias Pohl edited comment on FLINK-30621 at 1/11/23 9:48 AM: --

[jira] [Commented] (FLINK-30623) Performance regression in checkpointSingleInput.UNALIGNED on 04.01.2023

2023-01-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672279#comment-17672279 ] Martijn Visser commented on FLINK-30623: [~Yanfei Lei]  Thanks for helping out o

[GitHub] [flink] link3280 commented on a diff in pull request #21581: [FLINK-30538][SQL gateway/client] Improve error handling of stop job operation

2023-01-11 Thread GitBox
link3280 commented on code in PR #21581: URL: https://github.com/apache/flink/pull/21581#discussion_r1066752130 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java: ## @@ -487,23 +487,22 @@ public ResultFetcher c

[jira] [Assigned] (FLINK-29231) PyFlink udtaf produces different results in the same sliding window

2023-01-11 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu reassigned FLINK-29231: --- Assignee: Dian Fu (was: Xingbo Huang) > PyFlink udtaf produces different results in the same slidi

[jira] [Commented] (FLINK-30618) flink-connector-pulsar not retrievable from Apache's Snapshot Maven repository

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672280#comment-17672280 ] Matthias Pohl commented on FLINK-30618: --- good catch, @yufan! We, indeed, had issue

[GitHub] [flink] Samrat002 commented on pull request #21512: [FLINK-30375][hotfix]sql-client leaks flink-table-planner jar in /tmp

2023-01-11 Thread GitBox
Samrat002 commented on PR #21512: URL: https://github.com/apache/flink/pull/21512#issuecomment-1378495537 Test failure . Associated known ticket https://issues.apache.org/jira/browse/FLINK-30629 -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (FLINK-30375) SqlClient leaks flink-table-planner jar under /tmp

2023-01-11 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672284#comment-17672284 ] Samrat Deb commented on FLINK-30375: Please help review the pr.  > SqlClient leaks

[GitHub] [flink] LadyForest opened a new pull request, #21647: [FLINK-22320][docs][table] Add documentation for new introduced ALTER TABLE statements

2023-01-11 Thread GitBox
LadyForest opened a new pull request, #21647: URL: https://github.com/apache/flink/pull/21647 ## What is the purpose of the change This PR is a subtask of FLINK-21634 to add documentation. ## Brief change log Add documentation for `ALTER TALBE [IF EXISTS] ` statement

[jira] [Commented] (FLINK-30231) Update to Fabric8 Kubernetes Client to a version that has automatic renewal of service account tokens

2023-01-11 Thread liad shachoach (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672287#comment-17672287 ] liad shachoach commented on FLINK-30231: [~martijnvisser]  I tried building fli

[jira] [Updated] (FLINK-22320) Add documentation for new introduced ALTER TABLE statements

2023-01-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-22320: --- Labels: pull-request-available (was: ) > Add documentation for new introduced ALTER TABLE s

[GitHub] [flink] flinkbot commented on pull request #21647: [FLINK-22320][docs][table] Add documentation for new introduced ALTER TABLE statements

2023-01-11 Thread GitBox
flinkbot commented on PR #21647: URL: https://github.com/apache/flink/pull/21647#issuecomment-1378512863 ## CI report: * 1dbed20696b4185c1950d841e34958d8b7830c5e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] tsreaper commented on a diff in pull request #21393: [FLINK-27246][TableSQL/Runtime][master] - Include WHILE blocks in split generated java methods

2023-01-11 Thread GitBox
tsreaper commented on code in PR #21393: URL: https://github.com/apache/flink/pull/21393#discussion_r1066708360 ## flink-table/flink-table-code-splitter/src/main/java/org/apache/flink/table/codesplit/BlockStatementGrouper.java: ## @@ -0,0 +1,432 @@ +/* + * Licensed to the Apache

[GitHub] [flink] tsreaper commented on a diff in pull request #21393: [FLINK-27246][TableSQL/Runtime][master] - Include WHILE blocks in split generated java methods

2023-01-11 Thread GitBox
tsreaper commented on code in PR #21393: URL: https://github.com/apache/flink/pull/21393#discussion_r1066817943 ## flink-table/flink-table-code-splitter/src/main/java/org/apache/flink/table/codesplit/BlockStatementGrouper.java: ## @@ -0,0 +1,432 @@ +/* + * Licensed to the Apache

[jira] [Created] (FLINK-30636) Typo fix: "to to" -> "to"

2023-01-11 Thread Gunnar Morling (Jira)
Gunnar Morling created FLINK-30636: -- Summary: Typo fix: "to to" -> "to" Key: FLINK-30636 URL: https://issues.apache.org/jira/browse/FLINK-30636 Project: Flink Issue Type: Technical Debt

[jira] [Commented] (FLINK-30636) Typo fix: "to to" -> "to"

2023-01-11 Thread Gunnar Morling (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672294#comment-17672294 ] Gunnar Morling commented on FLINK-30636: Will send a PR for this shortly. > Typ

[GitHub] [flink] gunnarmorling opened a new pull request, #21648: [FLINK-30636] [docs]: Typo fix; 'to to' -> 'to'

2023-01-11 Thread GitBox
gunnarmorling opened a new pull request, #21648: URL: https://github.com/apache/flink/pull/21648 Just a fix of a surprisingly common typo in JavaDoc etc. https://issues.apache.org/jira/browse/FLINK-30636 -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (FLINK-30636) Typo fix: "to to" -> "to"

2023-01-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30636: --- Labels: pull-request-available (was: ) > Typo fix: "to to" -> "to" > --

[GitHub] [flink] gunnarmorling commented on pull request #21648: [FLINK-30636] [docs]: Typo fix; 'to to' -> 'to'

2023-01-11 Thread GitBox
gunnarmorling commented on PR #21648: URL: https://github.com/apache/flink/pull/21648#issuecomment-1378532036 // CC @rmetzger -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Assigned] (FLINK-30636) Typo fix: "to to" -> "to"

2023-01-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-30636: -- Assignee: Gunnar Morling > Typo fix: "to to" -> "to" > - > >

[jira] [Commented] (FLINK-30231) Update to Fabric8 Kubernetes Client to a version that has automatic renewal of service account tokens

2023-01-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672297#comment-17672297 ] Martijn Visser commented on FLINK-30231: [~liadsh] In the future, it's better to

[jira] [Resolved] (FLINK-28898) ChangelogRecoverySwitchStateBackendITCase.testSwitchFromEnablingToDisablingWithRescalingOut failed

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-28898. --- Fix Version/s: 1.16.0 Resolution: Fixed I took a look at the stacktraces: Only the is

[jira] [Comment Edited] (FLINK-28898) ChangelogRecoverySwitchStateBackendITCase.testSwitchFromEnablingToDisablingWithRescalingOut failed

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672299#comment-17672299 ] Matthias Pohl edited comment on FLINK-28898 at 1/11/23 10:27 AM: -

[jira] [Reopened] (FLINK-28440) EventTimeWindowCheckpointingITCase.testSlidingTimeWindow failed with restore

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reopened FLINK-28440: --- I'm reopneing this issue since closing it as a duplicate of FLINK-28440 was a mistake. FLINK-28

[GitHub] [flink] flinkbot commented on pull request #21648: [FLINK-30636] [docs]: Typo fix; 'to to' -> 'to'

2023-01-11 Thread GitBox
flinkbot commented on PR #21648: URL: https://github.com/apache/flink/pull/21648#issuecomment-1378543117 ## CI report: * 1b6d9da1b1667437af361b2614470c8dfe830754 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-28440) EventTimeWindowCheckpointingITCase.testSlidingTimeWindow failed with restore

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-28440: -- Description: {code:java} Caused by: java.lang.Exception: Exception while creating StreamOpera

[jira] [Updated] (FLINK-28440) EventTimeWindowCheckpointingITCase.testSlidingTimeWindow failed with restore

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-28440: -- Priority: Critical (was: Major) > EventTimeWindowCheckpointingITCase.testSlidingTimeWindow fa

[jira] [Closed] (FLINK-30102) Unstable test EventTimeWindowCheckpointingITCase.testPreAggregatedSlidingTimeWindow failed runs on azure

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl closed FLINK-30102. - Resolution: Duplicate Closing this issue as a duplicate of FLINK-28440 as all the reported build

[jira] [Closed] (FLINK-30107) Unstable test ChangelogRecoveryITCase#testMaterialization failed on azure

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl closed FLINK-30107. - Resolution: Duplicate Closing this issue in favor of FLINK-28440 after verifying that all test

  1   2   3   >