[GitHub] [flink] wuchong commented on pull request #17038: [FLINK-24024][table-planner] Fix syntax mistake in session Window TVF

2021-08-30 Thread GitBox
wuchong commented on pull request #17038: URL: https://github.com/apache/flink/pull/17038#issuecomment-908084677 Looks good to me. cc @godfreyhe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [flink] gyfora commented on pull request #17022: [FLINK-24020][web] Aggregate HTTP requests before custom netty handers are getting the data

2021-08-30 Thread GitBox
gyfora commented on pull request #17022: URL: https://github.com/apache/flink/pull/17022#issuecomment-908087499 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [flink] wuchong commented on pull request #16723: [FLINK-22885][table] Supports 'SHOW COLUMNS' syntax.

2021-08-30 Thread GitBox
wuchong commented on pull request #16723: URL: https://github.com/apache/flink/pull/16723#issuecomment-908087936 @RocMarshal Please do not use "git merge" to rebase branches, otherwise the changes is hard to track. Please use "git rebase" instead. IntelliJ IDEA provide an easy tool to do

[GitHub] [flink] flinkbot edited a comment on pull request #16963: [FLINK-23582][docs][table] Add documentation for session window tvf.

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #16963: URL: https://github.com/apache/flink/pull/16963#issuecomment-904569734 ## CI report: * 3f642deaa05216d448a83522964416044891297b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17022: [FLINK-24020][web] Aggregate HTTP requests before custom netty handers are getting the data

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17022: URL: https://github.com/apache/flink/pull/17022#issuecomment-907158087 ## CI report: * f954017eb4d81acc1283bae464d7247bda38d904 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17019: URL: https://github.com/apache/flink/pull/17019#issuecomment-907120059 ## CI report: * fa25b27d642ab7e6af356ca1e9738a006d48 UNKNOWN * 6120b584b4b4ee9286f4998065f122c9a7de Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #17044: [FLINK-24010][connector/common] HybridSourceReader/Enumerator delegate checkpoint notifications

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17044: URL: https://github.com/apache/flink/pull/17044#issuecomment-907990627 ## CI report: * d0e16223f3b69b417b90c1320117168b8dc5e59e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17045: [FLINK-23924][python][examples] Add PyFlink examples

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17045: URL: https://github.com/apache/flink/pull/17045#issuecomment-908007478 ## CI report: * 77e0e48a0f9c3f2f62e6e19ca5f4253060c13b07 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Assigned] (FLINK-23686) KafkaSource metric "commitsSucceeded" should count per-commit instead of per-partition

2021-08-30 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-23686: Assignee: Qingsheng Ren > KafkaSource metric "commitsSucceeded" should count per-

[GitHub] [flink] flinkbot commented on pull request #17046: [FLINK-24049][python] Handle properly for field types need conversion in TupleTypeInfo

2021-08-30 Thread GitBox
flinkbot commented on pull request #17046: URL: https://github.com/apache/flink/pull/17046#issuecomment-908096451 ## CI report: * 0ce3f1e021ffd0a8278412dda43198f8c1eb0b8c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot commented on pull request #17047: [FLINK-24027][filesystems] Remove excessive dependencies from NOTICE files

2021-08-30 Thread GitBox
flinkbot commented on pull request #17047: URL: https://github.com/apache/flink/pull/17047#issuecomment-908096579 ## CI report: * cba327f4c75a11dcb018505333abf42e50f0b7f7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] zentol commented on a change in pull request #17027: [FLINK-23954][tests] Fix e2e test test_queryable_state_restart_tm.sh

2021-08-30 Thread GitBox
zentol commented on a change in pull request #17027: URL: https://github.com/apache/flink/pull/17027#discussion_r698253003 ## File path: flink-end-to-end-tests/flink-queryable-state-test/src/main/java/org/apache/flink/streaming/tests/queryablestate/QsStateProducer.java ## @@ -

[GitHub] [flink] zentol commented on pull request #17034: [BP-1.13][FLINK-23947] Improve logging of granting/revoking leadership in DefaultDispatcherRunner

2021-08-30 Thread GitBox
zentol commented on pull request #17034: URL: https://github.com/apache/flink/pull/17034#issuecomment-908106689 Could you rebase the PR again? šŸ˜¢ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (FLINK-24044) Errors are output when compiling flink-runtime-web

2021-08-30 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-24044: - Component/s: Build System > Errors are output when compiling flink-runtime-web > ---

[jira] [Updated] (FLINK-23555) Improve common subexpression elimination by using local references

2021-08-30 Thread weibowen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] weibowen updated FLINK-23555: - Description: When we write a sql likeĀ  {code:java} select udf2(udf1(field), udf3(udf1(field) ...{code} u

[GitHub] [flink] zhuzhurk commented on pull request #16856: [FLINK-23833][coordination] Individually clean up the cache for ShuffleDescriptors

2021-08-30 Thread GitBox
zhuzhurk commented on pull request #16856: URL: https://github.com/apache/flink/pull/16856#issuecomment-908108473 Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-23555) Improve common subexpression elimination by using local references

2021-08-30 Thread weibowen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] weibowen updated FLINK-23555: - Issue Type: Bug (was: Improvement) > Improve common subexpression elimination by using local references

[jira] [Updated] (FLINK-23555) Improve common subexpression elimination by using local references

2021-08-30 Thread weibowen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] weibowen updated FLINK-23555: - Description: When we write a sql likeĀ  {code:java} select udf2(udf1(field), udf3(udf1(field) ...{code} u

[jira] [Updated] (FLINK-23555) Improve common subexpression elimination by using local references

2021-08-30 Thread weibowen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] weibowen updated FLINK-23555: - Description: When we write a sql likeĀ  {code:java} select udf2(udf1(field), udf3(udf1(field) ...{code} u

[jira] [Updated] (FLINK-23555) Improve common subexpression elimination by using local references

2021-08-30 Thread weibowen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] weibowen updated FLINK-23555: - Description: When we write a sql likeĀ  {code:java} select udf2(udf1(field), udf3(udf1(field) ...{code} u

[GitHub] [flink] flinkbot edited a comment on pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17019: URL: https://github.com/apache/flink/pull/17019#issuecomment-907120059 ## CI report: * fa25b27d642ab7e6af356ca1e9738a006d48 UNKNOWN * 6120b584b4b4ee9286f4998065f122c9a7de Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #17011: [FLINK-23663][table-planner] Reduce state size of ChangelogNormalize

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17011: URL: https://github.com/apache/flink/pull/17011#issuecomment-907015222 ## CI report: * e13ee18ff9f927cb23c670236f83956873cfcc1e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17022: [FLINK-24020][web] Aggregate HTTP requests before custom netty handers are getting the data

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17022: URL: https://github.com/apache/flink/pull/17022#issuecomment-907158087 ## CI report: * f954017eb4d81acc1283bae464d7247bda38d904 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17038: [FLINK-24024][table-planner] Fix syntax mistake in session Window TVF

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17038: URL: https://github.com/apache/flink/pull/17038#issuecomment-907732897 ## CI report: * c6982f9e3518e2908a4c206d0aad363d22fab2d7 UNKNOWN * 209ebeb33f4cb30e50d87728af0db0c9088e0303 Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #17047: [FLINK-24027][filesystems] Remove excessive dependencies from NOTICE files

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17047: URL: https://github.com/apache/flink/pull/17047#issuecomment-908096579 ## CI report: * cba327f4c75a11dcb018505333abf42e50f0b7f7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Updated] (FLINK-23555) Improve common subexpression elimination by using local references

2021-08-30 Thread weibowen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] weibowen updated FLINK-23555: - Description: When we write a sql likeĀ  {code:java} select udf2(udf1(field), udf3(udf1(field) ...{code} u

[GitHub] [flink] flinkbot edited a comment on pull request #17046: [FLINK-24049][python] Handle properly for field types need conversion in TupleTypeInfo

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17046: URL: https://github.com/apache/flink/pull/17046#issuecomment-908096451 ## CI report: * 0ce3f1e021ffd0a8278412dda43198f8c1eb0b8c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Updated] (FLINK-23555) Improve common subexpression elimination by using local references

2021-08-30 Thread weibowen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] weibowen updated FLINK-23555: - Description: When we write a sql likeĀ  {code:java} select udf2(udf1(field), udf3(udf1(field) ...{code} u

[GitHub] [flink] zhuzhurk closed pull request #16856: [FLINK-23833][coordination] Individually clean up the cache for ShuffleDescriptors

2021-08-30 Thread GitBox
zhuzhurk closed pull request #16856: URL: https://github.com/apache/flink/pull/16856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[jira] [Updated] (FLINK-23833) Cache of ShuffleDescriptors should be individually cleaned up

2021-08-30 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-23833: Fix Version/s: 1.15.0 > Cache of ShuffleDescriptors should be individually cleaned up > --

[GitHub] [flink] zentol commented on pull request #17022: [FLINK-24020][web] Aggregate HTTP requests before custom netty handers are getting the data

2021-08-30 Thread GitBox
zentol commented on pull request #17022: URL: https://github.com/apache/flink/pull/17022#issuecomment-908116741 The HistoryServerTest is getting stuck on CI which is likely caused by this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [flink] beyond1920 commented on pull request #16997: [FLINK-23287][docs][table] Create user document for Window Join in SQL

2021-08-30 Thread GitBox
beyond1920 commented on pull request #16997: URL: https://github.com/apache/flink/pull/16997#issuecomment-908118313 @wuchong Jark, I've updated the input schema to use a lower-case and non-reserved-keyword as the field names. -- This is an automated message from the Apache Git Se

[jira] [Commented] (FLINK-23971) PulsarSourceITCase.testIdleReader failed on azure

2021-08-30 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406602#comment-17406602 ] Hang Ruan commented on FLINK-23971: --- Fine, I will provide a PR to fix it. > PulsarSou

[jira] [Closed] (FLINK-23833) Cache of ShuffleDescriptors should be individually cleaned up

2021-08-30 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-23833. --- Resolution: Fixed Fixed via: master: 8d3ec4a2fb1c9e07ee386dced15e1f64f359c6a2 ef6ef809b17b4547194c247975fb45

[jira] [Commented] (FLINK-24043) Reuse the code of 'check savepoint preconditions'.

2021-08-30 Thread Roc Marshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406605#comment-17406605 ] Roc Marshal commented on FLINK-24043: - Thanks [~jark] for the reply. Hi, [~gaoyunh

[jira] [Commented] (FLINK-23555) Improve common subexpression elimination by using local references

2021-08-30 Thread Enze Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406607#comment-17406607 ] Enze Liu commented on FLINK-23555: -- The description has updated. Please help check agai

[GitHub] [flink] pnowojski commented on a change in pull request #17037: [FLINK-24035][network] Guarantee that the LocalBufferPool is initialized with one buffer

2021-08-30 Thread GitBox
pnowojski commented on a change in pull request #17037: URL: https://github.com/apache/flink/pull/17037#discussion_r698277969 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java ## @@ -216,9 +220,10 @@ // Lock is o

[GitHub] [flink] fapaul commented on a change in pull request #16966: [FLINK-23875][connectors/kafka] Snapshot reduceBuffer of ReducingUpseā€¦

2021-08-30 Thread GitBox
fapaul commented on a change in pull request #16966: URL: https://github.com/apache/flink/pull/16966#discussion_r698282237 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/CompoundReducingUpsertWriterStateSerializer.j

[jira] [Commented] (FLINK-23971) PulsarSourceITCase.testIdleReader failed on azure

2021-08-30 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406615#comment-17406615 ] Xintong Song commented on FLINK-23971: -- Thanks [~ruanhang1993], you're assigned. Pl

[jira] [Assigned] (FLINK-23971) PulsarSourceITCase.testIdleReader failed on azure

2021-08-30 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song reassigned FLINK-23971: Assignee: Hang Ruan > PulsarSourceITCase.testIdleReader failed on azure > ---

[jira] [Commented] (FLINK-23190) Make task-slot allocation much more evenly

2021-08-30 Thread loyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406616#comment-17406616 ] loyi commented on FLINK-23190: -- I have submitted a [PR|https://github.com/apache/flink/pull

[GitHub] [flink] fapaul commented on a change in pull request #16966: [FLINK-23875][connectors/kafka] Snapshot reduceBuffer of ReducingUpseā€¦

2021-08-30 Thread GitBox
fapaul commented on a change in pull request #16966: URL: https://github.com/apache/flink/pull/16966#discussion_r698286541 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/CompoundReducingUpsertWriterState.java ##

[jira] [Commented] (FLINK-18807) FlinkKafkaProducerITCase.testScaleUpAfterScalingDown failed with "Timeout expired after 60000milliseconds while awaiting EndTxn(COMMIT)"

2021-08-30 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406617#comment-17406617 ] Xintong Song commented on FLINK-18807: -- https://dev.azure.com/apache-flink/apache-f

[GitHub] [flink-statefun] igalshilman closed pull request #245: [FLINK-23520][datastream] improve statefun <-> datastream interop

2021-08-30 Thread GitBox
igalshilman closed pull request #245: URL: https://github.com/apache/flink-statefun/pull/245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

[GitHub] [flink-statefun] igalshilman commented on pull request #245: [FLINK-23520][datastream] improve statefun <-> datastream interop

2021-08-30 Thread GitBox
igalshilman commented on pull request #245: URL: https://github.com/apache/flink-statefun/pull/245#issuecomment-908144474 @sjwiesman I'm closing this for now, because we will try to solve it without copying the sources, by properly shedding protobuf. -- This is an automated message from

[GitHub] [flink] flinkbot edited a comment on pull request #16723: [FLINK-22885][table] Supports 'SHOW COLUMNS' syntax.

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #16723: URL: https://github.com/apache/flink/pull/16723#issuecomment-893364145 ## CI report: * 542b00a0777a8b6483a0e61eaf47787ee43f98b8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-23971) PulsarSourceITCase.testIdleReader failed on azure

2021-08-30 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406618#comment-17406618 ] Qingsheng Ren commented on FLINK-23971: --- Thanks [~ruanhang1993]Ā for the investigat

[GitHub] [flink] flinkbot edited a comment on pull request #17011: [FLINK-23663][table-planner] Reduce state size of ChangelogNormalize

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17011: URL: https://github.com/apache/flink/pull/17011#issuecomment-907015222 ## CI report: * e13ee18ff9f927cb23c670236f83956873cfcc1e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #16997: [FLINK-23287][docs][table] Create user document for Window Join in SQL

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #16997: URL: https://github.com/apache/flink/pull/16997#issuecomment-906324142 ## CI report: * 717cc232df32c0a19b2026b7246af7b307c14dc7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-23544) Window TVF Supports session window

2021-08-30 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406619#comment-17406619 ] Timo Walther commented on FLINK-23544: -- [~godfreyhe][~qingru zhang] Sorry, for jump

[jira] [Updated] (FLINK-23791) Enable RocksDB log again

2021-08-30 Thread Yu Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li updated FLINK-23791: -- Fix Version/s: 1.15.0 > Enable RocksDB log again > > > Key: FLINK-237

[GitHub] [flink] AHeise commented on a change in pull request #16966: [FLINK-23875][connectors/kafka] Snapshot reduceBuffer of ReducingUpseā€¦

2021-08-30 Thread GitBox
AHeise commented on a change in pull request #16966: URL: https://github.com/apache/flink/pull/16966#discussion_r698299396 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/CompoundReducingUpsertWriterState.java ##

[jira] [Commented] (FLINK-23814) Test FLIP-143 KafkaSink

2021-08-30 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406624#comment-17406624 ] Fabian Paul commented on FLINK-23814: - [~ruanhang1993]Ā we consolidated all our found

[GitHub] [flink] AHeise commented on a change in pull request #16966: [FLINK-23875][connectors/kafka] Snapshot reduceBuffer of ReducingUpseā€¦

2021-08-30 Thread GitBox
AHeise commented on a change in pull request #16966: URL: https://github.com/apache/flink/pull/16966#discussion_r698299782 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/CompoundReducingUpsertWriterStateSerializer.j

[GitHub] [flink-statefun-docker] igalshilman merged pull request #15: Flink StateFun Release 3.1.0

2021-08-30 Thread GitBox
igalshilman merged pull request #15: URL: https://github.com/apache/flink-statefun-docker/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] twalthr opened a new pull request #17048: [FLINK-24033][table-planner] Propagate unique keys for fromChangelogStream

2021-08-30 Thread GitBox
twalthr opened a new pull request #17048: URL: https://github.com/apache/flink/pull/17048 ## What is the purpose of the change This fixes a serious issue which also justified that `from/toChangelogStream` were marked as `@Experimental` in 1.13. Unique keys were not set correctly. Fi

[GitHub] [flink] fapaul commented on a change in pull request #16966: [FLINK-23875][connectors/kafka] Snapshot reduceBuffer of ReducingUpseā€¦

2021-08-30 Thread GitBox
fapaul commented on a change in pull request #16966: URL: https://github.com/apache/flink/pull/16966#discussion_r698300654 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/CompoundReducingUpsertWriterStateSerializer.j

[GitHub] [flink] gaborgsomogyi commented on pull request #17022: [FLINK-24020][web] Aggregate HTTP requests before custom netty handers are getting the data

2021-08-30 Thread GitBox
gaborgsomogyi commented on pull request #17022: URL: https://github.com/apache/flink/pull/17022#issuecomment-908155425 @zentol having a look... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Updated] (FLINK-24033) Propagate unique keys for fromChangelogStream

2021-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24033: --- Labels: pull-request-available (was: ) > Propagate unique keys for fromChangelogStream > --

[GitHub] [flink] flinkbot commented on pull request #17048: [FLINK-24033][table-planner] Propagate unique keys for fromChangelogStream

2021-08-30 Thread GitBox
flinkbot commented on pull request #17048: URL: https://github.com/apache/flink/pull/17048#issuecomment-908156791 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] wsry closed pull request #17030: [FLINK-24035][network] Notify the buffer listeners when the local buffer pool receives available notification from the global pool

2021-08-30 Thread GitBox
wsry closed pull request #17030: URL: https://github.com/apache/flink/pull/17030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [flink] wsry commented on pull request #17030: [FLINK-24035][network] Notify the buffer listeners when the local buffer pool receives available notification from the global pool

2021-08-30 Thread GitBox
wsry commented on pull request #17030: URL: https://github.com/apache/flink/pull/17030#issuecomment-908159549 Abandoned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Created] (FLINK-24050) Support primary keys on metadata columns

2021-08-30 Thread Jira
Ingo BĆ¼rk created FLINK-24050: - Summary: Support primary keys on metadata columns Key: FLINK-24050 URL: https://issues.apache.org/jira/browse/FLINK-24050 Project: Flink Issue Type: Improvement

[GitHub] [flink] flinkbot edited a comment on pull request #16723: [FLINK-22885][table] Supports 'SHOW COLUMNS' syntax.

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #16723: URL: https://github.com/apache/flink/pull/16723#issuecomment-893364145 ## CI report: * 542b00a0777a8b6483a0e61eaf47787ee43f98b8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #16966: [FLINK-23875][connectors/kafka] Snapshot reduceBuffer of ReducingUpseā€¦

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #16966: URL: https://github.com/apache/flink/pull/16966#issuecomment-904741081 ## CI report: * ed07cb76926d2747ac25953e5f5e74c48e64ef25 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #16997: [FLINK-23287][docs][table] Create user document for Window Join in SQL

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #16997: URL: https://github.com/apache/flink/pull/16997#issuecomment-906324142 ## CI report: * 717cc232df32c0a19b2026b7246af7b307c14dc7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17045: [FLINK-23924][python][examples] Add PyFlink examples

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17045: URL: https://github.com/apache/flink/pull/17045#issuecomment-908007478 ## CI report: * 77e0e48a0f9c3f2f62e6e19ca5f4253060c13b07 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] tillrohrmann commented on pull request #16915: [FLINK-9925][tests] Harden ClientTest by making handler shareable

2021-08-30 Thread GitBox
tillrohrmann commented on pull request #16915: URL: https://github.com/apache/flink/pull/16915#issuecomment-908164719 Thanks for the review @zentol. The failing test case is https://issues.apache.org/jira/browse/FLINK-23097 and should be unrelated. -- This is an automated message from th

[jira] [Created] (FLINK-24051) Make consumer.group-id optional for KafkaSource

2021-08-30 Thread Fabian Paul (Jira)
Fabian Paul created FLINK-24051: --- Summary: Make consumer.group-id optional for KafkaSource Key: FLINK-24051 URL: https://issues.apache.org/jira/browse/FLINK-24051 Project: Flink Issue Type: Imp

[jira] [Assigned] (FLINK-24051) Make consumer.group-id optional for KafkaSource

2021-08-30 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Paul reassigned FLINK-24051: --- Assignee: Fabian Paul > Make consumer.group-id optional for KafkaSource > -

[GitHub] [flink-training] NicoK merged pull request #35: [FLINK-24022] Change how to enable Scala and use in CI

2021-08-30 Thread GitBox
NicoK merged pull request #35: URL: https://github.com/apache/flink-training/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[jira] [Commented] (FLINK-24050) Support primary keys on metadata columns

2021-08-30 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406632#comment-17406632 ] Jark Wu commented on FLINK-24050: - Sounds good to me. From my perspective, metadata colu

[jira] [Closed] (FLINK-24022) Scala checks not running in flink-training CI

2021-08-30 Thread Nico Kruber (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber closed FLINK-24022. --- Resolution: Fixed Fixed on master via 65cde7910e5bff6283eef7ea536fde3ea5d4c9d4 > Scala checks not r

[jira] [Commented] (FLINK-23764) add RuntimeContext to SourceReaderContext

2021-08-30 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406633#comment-17406633 ] Fabian Paul commented on FLINK-23764: - [~ruanhang1993]Ā you made a good point. I will

[jira] [Updated] (FLINK-24050) Support primary keys on metadata columns

2021-08-30 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-24050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo BĆ¼rk updated FLINK-24050: -- Description: Currently, primary keys are required to consist solely of physical columns. However, the

[GitHub] [flink] Airblader commented on a change in pull request #17048: [FLINK-24033][table-planner] Propagate unique keys for fromChangelogStream

2021-08-30 Thread GitBox
Airblader commented on a change in pull request #17048: URL: https://github.com/apache/flink/pull/17048#discussion_r698307830 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/connectors/DynamicSourceUtils.java ## @@ -90,13 +90,18 @@ pu

[GitHub] [flink] tillrohrmann closed pull request #16915: [FLINK-9925][tests] Harden ClientTest by making handler shareable

2021-08-30 Thread GitBox
tillrohrmann closed pull request #16915: URL: https://github.com/apache/flink/pull/16915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [flink] pnowojski merged pull request #17009: [FLINK-23466][network] Fix the bug that buffer listeners may not be notified when recycling buffers

2021-08-30 Thread GitBox
pnowojski merged pull request #17009: URL: https://github.com/apache/flink/pull/17009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[jira] [Updated] (FLINK-23466) UnalignedCheckpointITCase hangs on Azure

2021-08-30 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-23466: --- Description: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=20813&vi

[jira] [Closed] (FLINK-23466) UnalignedCheckpointITCase hangs on Azure

2021-08-30 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-23466. -- Resolution: Fixed Merged to master as 48a384dffc7 Merged to release-1.14 as 0067d35cc0f > Una

[jira] [Closed] (FLINK-24030) PulsarSourceITCase>SourceTestSuiteBase.testMultipleSplits failed

2021-08-30 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-24030. -- Resolution: Duplicate > PulsarSourceITCase>SourceTestSuiteBase.testMultipleSplits failed > ---

[jira] [Closed] (FLINK-9925) ClientTest.testSimpleRequests fails on Travis

2021-08-30 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-9925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-9925. Resolution: Fixed Fixed via 1.15.0: bad537d6b4517341e33253354d6273153e571747 d505e6ed9bd596d1b6efc

[GitHub] [flink] flinkbot edited a comment on pull request #16966: [FLINK-23875][connectors/kafka] Snapshot reduceBuffer of ReducingUpseā€¦

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #16966: URL: https://github.com/apache/flink/pull/16966#issuecomment-904741081 ## CI report: * ed07cb76926d2747ac25953e5f5e74c48e64ef25 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-22483) Recover checkpoints when JobMaster gains leadership

2021-08-30 Thread ming li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406647#comment-17406647 ] ming li commented on FLINK-22483: - Hi, [~dmvk], [~edu05]. Could you please help answer o

[GitHub] [flink] flinkbot edited a comment on pull request #17045: [FLINK-23924][python][examples] Add PyFlink examples

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17045: URL: https://github.com/apache/flink/pull/17045#issuecomment-908007478 ## CI report: * 77e0e48a0f9c3f2f62e6e19ca5f4253060c13b07 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #17048: [FLINK-24033][table-planner] Propagate unique keys for fromChangelogStream

2021-08-30 Thread GitBox
flinkbot commented on pull request #17048: URL: https://github.com/apache/flink/pull/17048#issuecomment-908188488 ## CI report: * 44a4c5b89d03c403df73fae28d464a557444323a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[jira] [Comment Edited] (FLINK-22483) Recover checkpoints when JobMaster gains leadership

2021-08-30 Thread ming li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406647#comment-17406647 ] ming li edited comment on FLINK-22483 at 8/30/21, 9:25 AM: --- Hi

[GitHub] [flink] wsry commented on a change in pull request #17037: [FLINK-24035][network] Guarantee that the LocalBufferPool is initialized with one buffer

2021-08-30 Thread GitBox
wsry commented on a change in pull request #17037: URL: https://github.com/apache/flink/pull/17037#discussion_r698335837 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java ## @@ -216,9 +220,10 @@ // Lock is only t

[GitHub] [flink] wsry commented on a change in pull request #17037: [FLINK-24035][network] Guarantee that the LocalBufferPool is initialized with one buffer

2021-08-30 Thread GitBox
wsry commented on a change in pull request #17037: URL: https://github.com/apache/flink/pull/17037#discussion_r698335837 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java ## @@ -216,9 +220,10 @@ // Lock is only t

[GitHub] [flink-training] NicoK commented on a change in pull request #31: [FLINK-23653] exercise and test rework

2021-08-30 Thread GitBox
NicoK commented on a change in pull request #31: URL: https://github.com/apache/flink-training/pull/31#discussion_r698320553 ## File path: common/src/test/java/org/apache/flink/training/exercises/testing/ComposedRichCoFlatMapFunction.java ## @@ -0,0 +1,70 @@ +package org.apach

[GitHub] [flink] twalthr commented on a change in pull request #17011: [FLINK-23663][table-planner] Reduce state size of ChangelogNormalize

2021-08-30 Thread GitBox
twalthr commented on a change in pull request #17011: URL: https://github.com/apache/flink/pull/17011#discussion_r698306556 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TableFactoryHarness.java ## @@ -0,0 +1,361 @@ +/* +

[jira] [Assigned] (FLINK-23850) Test Kafka table connector with new runtime provider

2021-08-30 Thread Matthias (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias reassigned FLINK-23850: Assignee: Matthias > Test Kafka table connector with new runtime provider > -

[GitHub] [flink] flinkbot edited a comment on pull request #17037: [FLINK-24035][network] Guarantee that the LocalBufferPool is initialized with one buffer

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17037: URL: https://github.com/apache/flink/pull/17037#issuecomment-907731112 ## CI report: * 71ddbbb89bf81896a5acca9466e50d0a6e544758 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Created] (FLINK-24052) Flink SQL reads S3 bucket data.

2021-08-30 Thread Moses (Jira)
Moses created FLINK-24052: - Summary: Flink SQL reads S3 bucket data. Key: FLINK-24052 URL: https://issues.apache.org/jira/browse/FLINK-24052 Project: Flink Issue Type: Improvement Component

[jira] [Updated] (FLINK-24036) SSL cannot be installed on CI

2021-08-30 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-24036: - Fix Version/s: (was: 1.15.0) > SSL cannot be installed on CI > -

[GitHub] [flink] zentol merged pull request #17047: [FLINK-24027][filesystems] Remove excessive dependencies from NOTICE files

2021-08-30 Thread GitBox
zentol merged pull request #17047: URL: https://github.com/apache/flink/pull/17047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Closed] (FLINK-24027) FileSystems list excessive dependencies in NOTICE

2021-08-30 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-24027. Resolution: Fixed master: 401d7241c7e1eb432d988af3ef097dc5a633c9b4 1.14: 4c23df38555e364df

[GitHub] [flink] flinkbot edited a comment on pull request #17048: [FLINK-24033][table-planner] Propagate unique keys for fromChangelogStream

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17048: URL: https://github.com/apache/flink/pull/17048#issuecomment-908188488 ## CI report: * 44a4c5b89d03c403df73fae28d464a557444323a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] tillrohrmann commented on a change in pull request #17027: [FLINK-23954][tests] Fix e2e test test_queryable_state_restart_tm.sh

2021-08-30 Thread GitBox
tillrohrmann commented on a change in pull request #17027: URL: https://github.com/apache/flink/pull/17027#discussion_r698366255 ## File path: flink-end-to-end-tests/flink-queryable-state-test/src/main/java/org/apache/flink/streaming/tests/queryablestate/QsStateProducer.java #

[GitHub] [flink] tillrohrmann commented on pull request #17027: [FLINK-23954][tests] Fix e2e test test_queryable_state_restart_tm.sh

2021-08-30 Thread GitBox
tillrohrmann commented on pull request #17027: URL: https://github.com/apache/flink/pull/17027#issuecomment-908221973 Thanks for the review @zentol. Merging this PR now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

  1   2   3   4   5   6   >