Github user W4anD0eR96 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5957#discussion_r186635353
--- Diff: docs/quickstart/setup_quickstart.md ---
@@ -233,29 +239,17 @@ window of processing time, as long as words are
floating in.
* First of
[
https://issues.apache.org/jira/browse/FLINK-9282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16466978#comment-16466978
]
ASF GitHub Bot commented on FLINK-9282:
---
Github user W4anD0eR96 commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-9302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467013#comment-16467013
]
Stefan Richter commented on FLINK-9302:
---
Thanks for the update, I appreciate it. Thi
Github user shuai-xu commented on the issue:
https://github.com/apache/flink/pull/5931
@StephanEwen, Good idea, I prefer the first one. As for the second one, the
pending request may have been fulfilled when task executor is killed. so job
master can not cancel the pending request. An
[
https://issues.apache.org/jira/browse/FLINK-9190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467046#comment-16467046
]
ASF GitHub Bot commented on FLINK-9190:
---
Github user shuai-xu commented on the issue
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5955
Could you review it @aljoscha ?
---
[
https://issues.apache.org/jira/browse/FLINK-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467048#comment-16467048
]
ASF GitHub Bot commented on FLINK-8659:
---
Github user kl0u commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467053#comment-16467053
]
Dmitrii Kober commented on FLINK-2435:
--
Hi [~fhueske]. Sure, thank you!
> Add suppor
[
https://issues.apache.org/jira/browse/FLINK-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467134#comment-16467134
]
ASF GitHub Bot commented on FLINK-8655:
---
Github user ctamisier commented on the issu
Github user ctamisier commented on the issue:
https://github.com/apache/flink/pull/5964
@zentol, @StephanEwen, @Bekreth
> We would have to pass the keyspace via the constructor as the
Configuration approach doesn't work for streaming.
I'm not sure to understand, the new un
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/5953
---
[
https://issues.apache.org/jira/browse/FLINK-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467177#comment-16467177
]
ASF GitHub Bot commented on FLINK-9235:
---
Github user aljoscha closed the pull reques
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5879
Hi @zentol , will this PR go into 1.5? I think the log seems to be a bit
noise currently when we diagnosing the job.
---
[
https://issues.apache.org/jira/browse/FLINK-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467181#comment-16467181
]
ASF GitHub Bot commented on FLINK-9215:
---
Github user sihuazhou commented on the issu
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5964#discussion_r186673889
--- Diff:
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java
---
@@ -429,
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5964#discussion_r186674717
--- Diff:
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java
---
@@ -429,
[
https://issues.apache.org/jira/browse/FLINK-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467191#comment-16467191
]
ASF GitHub Bot commented on FLINK-8655:
---
Github user zentol commented on a diff in t
[
https://issues.apache.org/jira/browse/FLINK-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467192#comment-16467192
]
ASF GitHub Bot commented on FLINK-8655:
---
Github user zentol commented on a diff in t
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5964#discussion_r186673807
--- Diff:
flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraPojoSink.java
---
@@ -50,18 +51,3
[
https://issues.apache.org/jira/browse/FLINK-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467193#comment-16467193
]
ASF GitHub Bot commented on FLINK-8655:
---
Github user zentol commented on a diff in t
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5931
I also `+1` for the first approach, but I would like to wait for
@tillrohrmann 's opinion.
And I also curious about one thing, that is currently when ResourceManager
allocate a slot for t
[
https://issues.apache.org/jira/browse/FLINK-9190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467198#comment-16467198
]
ASF GitHub Bot commented on FLINK-9190:
---
Github user sihuazhou commented on the issu
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5957#discussion_r186679634
--- Diff: docs/quickstart/setup_quickstart.md ---
@@ -233,29 +239,17 @@ window of processing time, as long as words are
floating in.
* First of all
[
https://issues.apache.org/jira/browse/FLINK-9282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467201#comment-16467201
]
ASF GitHub Bot commented on FLINK-9282:
---
Github user zentol commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5957
merging.
---
[
https://issues.apache.org/jira/browse/FLINK-9282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467200#comment-16467200
]
ASF GitHub Bot commented on FLINK-9282:
---
Github user zentol commented on a diff in t
Github user W4anD0eR96 commented on the issue:
https://github.com/apache/flink/pull/5957
Thanks!
---
[
https://issues.apache.org/jira/browse/FLINK-9305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467203#comment-16467203
]
Nico Kruber commented on FLINK-9305:
I would actually follow your argumentation that i
[
https://issues.apache.org/jira/browse/FLINK-9282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467204#comment-16467204
]
ASF GitHub Bot commented on FLINK-9282:
---
Github user W4anD0eR96 commented on the iss
Github user ctamisier commented on the issue:
https://github.com/apache/flink/pull/5964
> The keyspace field in the sink isn't used anywhere
It is used in CassandraPojoSinkBuilder.createSink(), the keyspace is an
argument of `new CassandraPojoSink<>(...);`
```
@Overrid
[
https://issues.apache.org/jira/browse/FLINK-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467252#comment-16467252
]
ASF GitHub Bot commented on FLINK-8655:
---
Github user ctamisier commented on the issu
[
https://issues.apache.org/jira/browse/FLINK-9306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek closed FLINK-9306.
---
Resolution: Fixed
release-1.5:
3049744588f7b902f550f790a4fbdb80f358b525
master:
5249981dc5140
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5901
@suez1224 I resolve https://issues.apache.org/jira/browse/FLINK-9306 via
#5953. This supersedes this PR, could you please close it?
Thanks a lot for looking into this, by the way, and discov
[
https://issues.apache.org/jira/browse/FLINK-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467275#comment-16467275
]
ASF GitHub Bot commented on FLINK-9235:
---
Github user aljoscha commented on the issue
[
https://issues.apache.org/jira/browse/FLINK-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467282#comment-16467282
]
ASF GitHub Bot commented on FLINK-9235:
---
Github user aljoscha commented on the issue
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5901
By the way, the test still doesn't catch the bug that you're fixing
(https://issues.apache.org/jira/browse/FLINK-8286). I think we need proper
end-to-end tests that really test Flink-Kerberos integr
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5964
h so that where it is used...
---
[
https://issues.apache.org/jira/browse/FLINK-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467284#comment-16467284
]
ASF GitHub Bot commented on FLINK-8655:
---
Github user zentol commented on the issue:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5964#discussion_r186700920
--- Diff:
flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBase.java
---
@@ -85,7 +85,7
[
https://issues.apache.org/jira/browse/FLINK-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467287#comment-16467287
]
ASF GitHub Bot commented on FLINK-8655:
---
Github user zentol commented on a diff in t
[
https://issues.apache.org/jira/browse/FLINK-9277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467309#comment-16467309
]
Sihua Zhou commented on FLINK-9277:
---
Hmm...{{+1}} that this is looks like a duplicate of
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5847
Hi, @aljoscha will this PR go into 1.5?
---
[
https://issues.apache.org/jira/browse/FLINK-9174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467312#comment-16467312
]
ASF GitHub Bot commented on FLINK-9174:
---
Github user sihuazhou commented on the issu
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5749
Hey guys, what going on with this now? I think this is a pretty good
ideal...
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5896
@suez1224 I'll now merge the actual fix, but I'm not 100 % sure the
refactoring is correct.
After the fix, we have roughly this path through the code:
```
if (keytabPath != null && r
[
https://issues.apache.org/jira/browse/FLINK-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467318#comment-16467318
]
ASF GitHub Bot commented on FLINK-9058:
---
Github user sihuazhou commented on the issu
[
https://issues.apache.org/jira/browse/FLINK-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467319#comment-16467319
]
ASF GitHub Bot commented on FLINK-8286:
---
Github user aljoscha commented on the issue
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5749
What exactly is the benefit of this change? Or why `Iterable` and not
`Collection` so that we can benefit from methods like `addAll(...)` which can
optimize insertion because the size is known
[
https://issues.apache.org/jira/browse/FLINK-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467323#comment-16467323
]
ASF GitHub Bot commented on FLINK-9058:
---
Github user StefanRRichter commented on the
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5749
Hi, @StefanRRichter That's a good question, I think the `Collection` looks
better then `Iterable`... the benefit is that the api looks more consistency
with the java api, and maybe convenient to us
[
https://issues.apache.org/jira/browse/FLINK-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467345#comment-16467345
]
ASF GitHub Bot commented on FLINK-9058:
---
Github user sihuazhou commented on the issu
[
https://issues.apache.org/jira/browse/FLINK-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467371#comment-16467371
]
ASF GitHub Bot commented on FLINK-8134:
---
GitHub user maxbelov opened a pull request:
GitHub user maxbelov opened a pull request:
https://github.com/apache/flink/pull/5967
[FLINK-8134] add method getDescription() to MessageHeaders
## What is the purpose of the change
* Add method getDescription() to MessageHeaders interface to provide
meaningful REST endpoint des
Github user ctamisier commented on the issue:
https://github.com/apache/flink/pull/5964
I pushed the changes and refactored to use `sanityCheck` method to check
the `keyspace` depending the builder in use. (like it is already done with
`query`)
---
[
https://issues.apache.org/jira/browse/FLINK-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467372#comment-16467372
]
ASF GitHub Bot commented on FLINK-8655:
---
Github user ctamisier commented on the issu
Github user ctamisier commented on a diff in the pull request:
https://github.com/apache/flink/pull/5964#discussion_r186714037
--- Diff:
flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBase.java
---
@@ -85,7 +85
[
https://issues.apache.org/jira/browse/FLINK-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467375#comment-16467375
]
ASF GitHub Bot commented on FLINK-8655:
---
Github user ctamisier commented on a diff i
[
https://issues.apache.org/jira/browse/FLINK-9308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467398#comment-16467398
]
Seweryn Habdank-Wojewodzki commented on FLINK-9308:
---
Hmm...
I suppose,
[
https://issues.apache.org/jira/browse/FLINK-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek closed FLINK-8286.
---
Resolution: Fixed
release-1.5:
93d1c47a14ab500b07331b2c415c86973fbeca29
master:
ba3e2711a2091
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5896
Merged, could you please close the PR after discussion of the refactoring?
---
[
https://issues.apache.org/jira/browse/FLINK-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467447#comment-16467447
]
ASF GitHub Bot commented on FLINK-8286:
---
Github user aljoscha commented on the issue
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5966#discussion_r186769177
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyServer.java
---
@@ -170,8 +171,8 @@ public void initChannel(SocketCha
[
https://issues.apache.org/jira/browse/FLINK-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467571#comment-16467571
]
ASF GitHub Bot commented on FLINK-9312:
---
Github user sihuazhou commented on a diff i
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5962#discussion_r186775375
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
---
@@ -706,6 +689,38 @@ public void notifyCheckpoin
[
https://issues.apache.org/jira/browse/FLINK-9316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Piotr Nowojski updated FLINK-9316:
--
Affects Version/s: 1.4.2
> Expose operator unique ID to the DataStream operators.
>
Piotr Nowojski created FLINK-9316:
-
Summary: Expose operator unique ID to the DataStream operators.
Key: FLINK-9316
URL: https://issues.apache.org/jira/browse/FLINK-9316
Project: Flink
Issue
[
https://issues.apache.org/jira/browse/FLINK-9304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467587#comment-16467587
]
ASF GitHub Bot commented on FLINK-9304:
---
Github user sihuazhou commented on a diff i
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/5966#discussion_r186800971
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyServer.java
---
@@ -170,8 +171,8 @@ public void initChannel(SocketC
[
https://issues.apache.org/jira/browse/FLINK-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467702#comment-16467702
]
ASF GitHub Bot commented on FLINK-9312:
---
Github user StephanEwen commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-9316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467713#comment-16467713
]
Chesnay Schepler commented on FLINK-9316:
-
Operators can already access the operat
[
https://issues.apache.org/jira/browse/FLINK-9185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468214#comment-16468214
]
Ted Yu commented on FLINK-9185:
---
lgtm
> Potential null dereference in
> PrioritizedOperato
[
https://issues.apache.org/jira/browse/FLINK-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468219#comment-16468219
]
yuemeng commented on FLINK-9201:
[~aljoscha]
thanks for your suggest
i will move the tes
[
https://issues.apache.org/jira/browse/FLINK-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468219#comment-16468219
]
yuemeng edited comment on FLINK-9201 at 5/9/18 2:12 AM:
[~aljoscha
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/5941
@StefanRRichter the PR is ready for another review, thanks!
---
[
https://issues.apache.org/jira/browse/FLINK-8971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468269#comment-16468269
]
ASF GitHub Bot commented on FLINK-8971:
---
Github user tzulitai commented on the issue
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5926
---
[
https://issues.apache.org/jira/browse/FLINK-9073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468315#comment-16468315
]
ASF GitHub Bot commented on FLINK-9073:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-9073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tzu-Li (Gordon) Tai closed FLINK-9073.
--
> Resume from savepoint end-to-end tests should be extended for different state
> backends
[
https://issues.apache.org/jira/browse/FLINK-9073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468317#comment-16468317
]
Tzu-Li (Gordon) Tai commented on FLINK-9073:
Merged.
1.6.0: d6d2c36c6f89fa402
[
https://issues.apache.org/jira/browse/FLINK-9073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tzu-Li (Gordon) Tai resolved FLINK-9073.
Resolution: Fixed
Fix Version/s: (was: 1.6.0)
1.5.0
>
Yazdan Shirvany created FLINK-9317:
--
Summary: Async I/O API Example For Scala has Variable Name error
Key: FLINK-9317
URL: https://issues.apache.org/jira/browse/FLINK-9317
Project: Flink
Iss
[
https://issues.apache.org/jira/browse/FLINK-9317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yazdan Shirvany updated FLINK-9317:
---
Description:
h2. Async I/O API Scala Example has duplicated {{resultFuture variable with
diff
GitHub user medcv opened a pull request:
https://github.com/apache/flink/pull/5968
[FLINK-9317] Async I/O API Example For Scala has Variable Name error
## What is the purpose of the change
Updating AsyncIO Scala Example with proper variable names
## Does this pull r
[
https://issues.apache.org/jira/browse/FLINK-9317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468411#comment-16468411
]
ASF GitHub Bot commented on FLINK-9317:
---
GitHub user medcv opened a pull request:
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/5969
[FLINK-9074] [e2e] Add e2e for resuming from externalized checkpoints
## What is the purpose of the change
This PR adds an end-to-end test for resuming from externalized, retained
checkpoi
[
https://issues.apache.org/jira/browse/FLINK-9074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468472#comment-16468472
]
ASF GitHub Bot commented on FLINK-9074:
---
GitHub user tzulitai opened a pull request:
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5936
cc @StephanEwen , here is the dependency tree :
```
[INFO] org.apache.flink:flink-metrics-prometheus:jar:1.6-SNAPSHOT
[INFO] +- io.prometheus:simpleclient:jar:0.3.0:compile
[INFO]
[
https://issues.apache.org/jira/browse/FLINK-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468479#comment-16468479
]
ASF GitHub Bot commented on FLINK-9265:
---
Github user yanghua commented on the issue:
88 matches
Mail list logo
