[jira] [Commented] (FLINK-5946) Kinesis Producer uses KPL that orphans threads that consume 100% CPU

2017-05-16 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011874#comment-16011874 ] Tzu-Li (Gordon) Tai commented on FLINK-5946: Great news! Thanks for the info S

[jira] [Created] (FLINK-6596) Disable javadoc generation in all travis builds

2017-05-16 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-6596: --- Summary: Disable javadoc generation in all travis builds Key: FLINK-6596 URL: https://issues.apache.org/jira/browse/FLINK-6596 Project: Flink Issue Typ

[GitHub] flink pull request #3914: [FLINK-6596][travis] Disable javadoc generation fo...

2017-05-16 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/3914 [FLINK-6596][travis] Disable javadoc generation for jdk 7 You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 6596_travis_javadoc Alter

[jira] [Commented] (FLINK-6596) Disable javadoc generation in all travis builds

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011879#comment-16011879 ] ASF GitHub Bot commented on FLINK-6596: --- GitHub user zentol opened a pull request:

[jira] [Commented] (FLINK-6593) Fix Bug in ProctimeAttribute or RowtimeAttribute with join UDTF

2017-05-16 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011893#comment-16011893 ] Timo Walther commented on FLINK-6593: - [~RuidongLi] have you started with this issue?

[GitHub] flink pull request #3495: [FLINK-5781][config] Generation HTML from ConfigOp...

2017-05-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3495 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #3655: [FLINK-6175] Harden HistoryServerTest#testFullArch...

2017-05-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3655 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Closed] (FLINK-5781) Generation HTML from ConfigOption

2017-05-16 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-5781. --- Resolution: Fixed Fix Version/s: 1.4.0 1.4: b54a72e4507b0d968c8209f2c447729b51d5d3bd >

[jira] [Commented] (FLINK-6175) HistoryServerTest.testFullArchiveLifecycle fails

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011906#comment-16011906 ] ASF GitHub Bot commented on FLINK-6175: --- Github user asfgit closed the pull request

[jira] [Closed] (FLINK-5780) Extend ConfigOption with descriptions

2017-05-16 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-5780. --- Resolution: Fixed Fix Version/s: 1.4.0 1.4: b54a72e4507b0d968c8209f2c447729b51d5d3bd >

[jira] [Commented] (FLINK-5781) Generation HTML from ConfigOption

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011907#comment-16011907 ] ASF GitHub Bot commented on FLINK-5781: --- Github user asfgit closed the pull request

[jira] [Closed] (FLINK-6175) HistoryServerTest.testFullArchiveLifecycle fails

2017-05-16 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-6175. --- Resolution: Fixed Fix Version/s: 1.4.0 1.3.0 1.3: 4e7598d9c21821db8f

[jira] [Commented] (FLINK-6593) Fix Bug in ProctimeAttribute or RowtimeAttribute with join UDTF

2017-05-16 Thread Ruidong Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011917#comment-16011917 ] Ruidong Li commented on FLINK-6593: --- Hi, I have fixed it, you can review later today >

[GitHub] flink pull request #3915: [FLINK-6352] Support to use timestamp to set the i...

2017-05-16 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/3915 [FLINK-6352] Support to use timestamp to set the initial offset of kafka Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into conside

[GitHub] flink issue #3861: [Flink-6352] Support to use timestamp to set the initial ...

2017-05-16 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3861 Use [https://github.com/apache/flink/pull/3915](url) instead --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] flink pull request #3861: [Flink-6352] Support to use timestamp to set the i...

2017-05-16 Thread fanyon
Github user fanyon closed the pull request at: https://github.com/apache/flink/pull/3861 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-6352) FlinkKafkaConsumer should support to use timestamp to set up start offset

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011918#comment-16011918 ] ASF GitHub Bot commented on FLINK-6352: --- GitHub user zjureel opened a pull request:

[jira] [Commented] (FLINK-6352) FlinkKafkaConsumer should support to use timestamp to set up start offset

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011919#comment-16011919 ] ASF GitHub Bot commented on FLINK-6352: --- Github user zjureel commented on the issue:

[GitHub] flink issue #3915: [FLINK-6352] Support to use timestamp to set the initial ...

2017-05-16 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3915 @tzulitai Could you please review code here when you are free, thanks :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] flink issue #3904: [FLINK-6439] Fix close OutputStream && InputStream in Ope...

2017-05-16 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3904 @zentol Thank you for your reply, I have update the code and add space after `try` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-6439) Unclosed InputStream in OperatorSnapshotUtil#readStateHandle()

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011922#comment-16011922 ] ASF GitHub Bot commented on FLINK-6439: --- Github user zjureel commented on the issue:

[GitHub] flink issue #3890: [FLINK-6569] flink-table KafkaJsonTableSource example doe...

2017-05-16 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3890 The Java version of the API also depends on the Scala classes of `flink-table`. Everything in `org.apache.flink.table.api` is used in both languages. `org.apache.flink.table.api.scala/java` contain l

[jira] [Commented] (FLINK-6569) flink-table KafkaJsonTableSource example doesn't work

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011928#comment-16011928 ] ASF GitHub Bot commented on FLINK-6569: --- Github user twalthr commented on the issue:

[GitHub] flink pull request #3916: [FLINK-6590] Integrate automatic docs generation

2017-05-16 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/3916 [FLINK-6590] Integrate automatic docs generation This PR partially integrates the docs generation introduced in FLINK-5781/#3495 into the actual documentation. The following sections now us

[jira] [Commented] (FLINK-6590) Integrate generated tables into documentation

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011937#comment-16011937 ] ASF GitHub Bot commented on FLINK-6590: --- GitHub user zentol opened a pull request:

[GitHub] flink pull request #3915: [FLINK-6352] Support to use timestamp to set the i...

2017-05-16 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3915#discussion_r116674541 --- Diff: flink-connectors/flink-connector-kafka-0.10/pom.xml --- @@ -37,7 +37,7 @@ under the License. - 0.10.0.1 +

[GitHub] flink pull request #3915: [FLINK-6352] Support to use timestamp to set the i...

2017-05-16 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3915#discussion_r116675083 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -290,10

[GitHub] flink pull request #3915: [FLINK-6352] Support to use timestamp to set the i...

2017-05-16 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3915#discussion_r116675211 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -290,10

[jira] [Commented] (FLINK-6352) FlinkKafkaConsumer should support to use timestamp to set up start offset

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011944#comment-16011944 ] ASF GitHub Bot commented on FLINK-6352: --- Github user tzulitai commented on a diff in

[jira] [Commented] (FLINK-6352) FlinkKafkaConsumer should support to use timestamp to set up start offset

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011943#comment-16011943 ] ASF GitHub Bot commented on FLINK-6352: --- Github user tzulitai commented on a diff in

[jira] [Commented] (FLINK-6352) FlinkKafkaConsumer should support to use timestamp to set up start offset

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011941#comment-16011941 ] ASF GitHub Bot commented on FLINK-6352: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #3915: [FLINK-6352] Support to use timestamp to set the i...

2017-05-16 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3915#discussion_r116675159 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -290,10

[GitHub] flink pull request #3915: [FLINK-6352] Support to use timestamp to set the i...

2017-05-16 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3915#discussion_r116674925 --- Diff: flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer09.java --- @@ -181,12 +18

[jira] [Commented] (FLINK-6352) FlinkKafkaConsumer should support to use timestamp to set up start offset

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011945#comment-16011945 ] ASF GitHub Bot commented on FLINK-6352: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #3915: [FLINK-6352] Support to use timestamp to set the i...

2017-05-16 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3915#discussion_r116674594 --- Diff: flink-connectors/flink-connector-kafka-0.10/pom.xml --- @@ -53,6 +53,10 @@ under the License. org.apache.ka

[GitHub] flink pull request #3915: [FLINK-6352] Support to use timestamp to set the i...

2017-05-16 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3915#discussion_r116676798 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -290,10

[jira] [Commented] (FLINK-6352) FlinkKafkaConsumer should support to use timestamp to set up start offset

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011942#comment-16011942 ] ASF GitHub Bot commented on FLINK-6352: --- Github user tzulitai commented on a diff in

[jira] [Commented] (FLINK-6352) FlinkKafkaConsumer should support to use timestamp to set up start offset

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011946#comment-16011946 ] ASF GitHub Bot commented on FLINK-6352: --- Github user tzulitai commented on a diff in

[jira] [Commented] (FLINK-6352) FlinkKafkaConsumer should support to use timestamp to set up start offset

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011947#comment-16011947 ] ASF GitHub Bot commented on FLINK-6352: --- Github user tzulitai commented on a diff in

[jira] [Commented] (FLINK-6537) Umbrella issue for fixes to incremental snapshots

2017-05-16 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011952#comment-16011952 ] Stefan Richter commented on FLINK-6537: --- Hi, thanks a lot for the testing effort an

[jira] [Commented] (FLINK-6352) FlinkKafkaConsumer should support to use timestamp to set up start offset

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011953#comment-16011953 ] ASF GitHub Bot commented on FLINK-6352: --- Github user tzulitai commented on the issue

[GitHub] flink issue #3915: [FLINK-6352] Support to use timestamp to set the initial ...

2017-05-16 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3915 Also, it seems like 0.8 does support a timestamp-based offset retrieval. See the "finding start offsets for reads" in https://cwiki.apache.org/confluence/display/KAFKA/0.8.0+SimpleConsumer+Example.

[jira] [Assigned] (FLINK-6440) Noisy logs from metric fetcher

2017-05-16 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-6440: --- Assignee: Chesnay Schepler > Noisy logs from metric fetcher > ---

[jira] [Commented] (FLINK-6440) Noisy logs from metric fetcher

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011967#comment-16011967 ] ASF GitHub Bot commented on FLINK-6440: --- GitHub user zentol opened a pull request:

[GitHub] flink pull request #3917: [FLINK-6440][metrics] Downgrade fetching failure l...

2017-05-16 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/3917 [FLINK-6440][metrics] Downgrade fetching failure logging to DEBUG You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 6440_fetcher_log

[GitHub] flink issue #3633: [FLINK-5982] [runtime] Refactor AbstractInvokable and Sta...

2017-05-16 Thread tony810430
Github user tony810430 commented on the issue: https://github.com/apache/flink/pull/3633 Hi @StephanEwen Have you been reviewing this PR? If not, I would like to rebase it and fix those conflicts. What do you think? --- If your project is set up for it, you can reply to thi

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011984#comment-16011984 ] ASF GitHub Bot commented on FLINK-5982: --- Github user tony810430 commented on the iss

[jira] [Commented] (FLINK-6062) Re-read a Kafka topic at the reception of an event

2017-05-16 Thread Julien Preisner (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011988#comment-16011988 ] Julien Preisner commented on FLINK-6062: Yes, it is the solution that I designed t

[jira] [Closed] (FLINK-6062) Re-read a Kafka topic at the reception of an event

2017-05-16 Thread Julien Preisner (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien Preisner closed FLINK-6062. -- Resolution: Done I wrote a shell script that restart the job. So my use case is done. > Re-read

[jira] [Updated] (FLINK-6593) Fix Bug in ProctimeAttribute or RowtimeAttribute with join UDTF

2017-05-16 Thread Ruidong Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruidong Li updated FLINK-6593: -- Description: the ProctimeAttribute or RowtimeAttribute should not be take into codegenerator was: wh

[jira] [Updated] (FLINK-6593) Fix Bug in ProctimeAttribute or RowtimeAttribute with CodeGenerator

2017-05-16 Thread Ruidong Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruidong Li updated FLINK-6593: -- Summary: Fix Bug in ProctimeAttribute or RowtimeAttribute with CodeGenerator (was: Fix Bug in ProctimeA

[GitHub] flink pull request #3918: [FLINK-6593] Fix Bug in ProctimeAttribute or Rowti...

2017-05-16 Thread Xpray
GitHub user Xpray opened a pull request: https://github.com/apache/flink/pull/3918 [FLINK-6593] Fix Bug in ProctimeAttribute or RowtimeAttribute with Co… …deGenerator Thanks for contributing to Apache Flink. Before you open your pull request, please take the following c

[jira] [Commented] (FLINK-6593) Fix Bug in ProctimeAttribute or RowtimeAttribute with CodeGenerator

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012034#comment-16012034 ] ASF GitHub Bot commented on FLINK-6593: --- GitHub user Xpray opened a pull request:

[GitHub] flink issue #2332: [FLINK-2055] Implement Streaming HBaseSink

2017-05-16 Thread nragon
Github user nragon commented on the issue: https://github.com/apache/flink/pull/2332 Any updates on this sink? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink pull request #3919: [FLINK-6583][talbe]Enable QueryConfig in count bas...

2017-05-16 Thread sunjincheng121
GitHub user sunjincheng121 opened a pull request: https://github.com/apache/flink/pull/3919 [FLINK-6583][talbe]Enable QueryConfig in count base GroupWindow In this PR. Enabled the `QueryConfig` for count base `GroupWindow`. - [x] General - The pull request references t

[jira] [Commented] (FLINK-2055) Implement Streaming HBaseSink

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012042#comment-16012042 ] ASF GitHub Bot commented on FLINK-2055: --- Github user nragon commented on the issue:

[jira] [Commented] (FLINK-6583) Enable QueryConfig in count base GroupWindow

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012043#comment-16012043 ] ASF GitHub Bot commented on FLINK-6583: --- GitHub user sunjincheng121 opened a pull re

[GitHub] flink issue #3820: [FLINK-6381] [connector] Unnecessary synchronizing object...

2017-05-16 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3820 Thanks for your work @zhangminglei . Changes look good! Merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (FLINK-6381) Unnecessary synchronizing object in BucketingSink

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012049#comment-16012049 ] ASF GitHub Bot commented on FLINK-6381: --- Github user kl0u commented on the issue:

[jira] [Created] (FLINK-6597) Cleanup WindowOperatorTest useless imports

2017-05-16 Thread sunjincheng (JIRA)
sunjincheng created FLINK-6597: -- Summary: Cleanup WindowOperatorTest useless imports Key: FLINK-6597 URL: https://issues.apache.org/jira/browse/FLINK-6597 Project: Flink Issue Type: Test

[jira] [Updated] (FLINK-6597) Cleanup WindowOperatorTest useless imports

2017-05-16 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-6597: --- Component/s: Streaming > Cleanup WindowOperatorTest useless imports >

[GitHub] flink issue #3903: [FLINK-6581] [cli] Correct dynamic property parsing for Y...

2017-05-16 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3903 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (FLINK-6581) Dynamic property parsing broken for YARN

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012061#comment-16012061 ] ASF GitHub Bot commented on FLINK-6581: --- Github user rmetzger commented on the issue

[GitHub] flink pull request #3920: [FLINK-6597][streaming] Cleanup WindowOperatorTest...

2017-05-16 Thread sunjincheng121
GitHub user sunjincheng121 opened a pull request: https://github.com/apache/flink/pull/3920 [FLINK-6597][streaming] Cleanup WindowOperatorTest useless imports Don't miss doing any good thing no matter how insignificant it looks. - [x] General - The pull request referen

[jira] [Commented] (FLINK-6597) Cleanup WindowOperatorTest useless imports

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012067#comment-16012067 ] ASF GitHub Bot commented on FLINK-6597: --- GitHub user sunjincheng121 opened a pull re

[GitHub] flink issue #3901: [FLINK-6288] fix FlinkKafkaProducer's custom Partitioner ...

2017-05-16 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3901 @tzulitai I agree with you and `ExecutorService` is really unnecessary. I will update the code and remove `ExecutorService` --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (FLINK-6288) FlinkKafkaProducer's custom Partitioner is always invoked with number of partitions of default topic

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012079#comment-16012079 ] ASF GitHub Bot commented on FLINK-6288: --- Github user zjureel commented on the issue:

[jira] [Closed] (FLINK-6592) RawLocalFileSystem created even if fs.hdfs.hadoopconf specified

2017-05-16 Thread Andrey (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey closed FLINK-6592. - Resolution: Invalid Looks like by default new org.apache.hadoop.conf.Configuration loads defaultFS. When Bucketin

[GitHub] flink pull request #3909: [FLINK-6578] Fix self-loop handling in SharedBuffe...

2017-05-16 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3909#discussion_r116699827 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -593,15 +596,24 @@ private boolean checkFilterCondition(Computat

[GitHub] flink pull request #3909: [FLINK-6578] Fix self-loop handling in SharedBuffe...

2017-05-16 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3909#discussion_r116700334 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java --- @@ -271,8 +286,8 @@ public void lock(final K key, final V

[GitHub] flink pull request #3909: [FLINK-6578] Fix self-loop handling in SharedBuffe...

2017-05-16 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3909#discussion_r11678 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java --- @@ -83,26 +84,29 @@ public SharedBuffer(final TypeSerializ

[GitHub] flink pull request #3909: [FLINK-6578] Fix self-loop handling in SharedBuffe...

2017-05-16 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3909#discussion_r116700094 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java --- @@ -114,16 +118,16 @@ public void put( * @param t

[GitHub] flink pull request #3909: [FLINK-6578] Fix self-loop handling in SharedBuffe...

2017-05-16 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3909#discussion_r116700283 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java --- @@ -256,8 +271,8 @@ public void prune(long pruningTimestam

[jira] [Commented] (FLINK-6578) SharedBuffer creates self-loops when having elements with same value/timestamp.

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012087#comment-16012087 ] ASF GitHub Bot commented on FLINK-6578: --- Github user dawidwys commented on a diff in

[jira] [Commented] (FLINK-6578) SharedBuffer creates self-loops when having elements with same value/timestamp.

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012089#comment-16012089 ] ASF GitHub Bot commented on FLINK-6578: --- Github user dawidwys commented on a diff in

[jira] [Commented] (FLINK-6578) SharedBuffer creates self-loops when having elements with same value/timestamp.

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012088#comment-16012088 ] ASF GitHub Bot commented on FLINK-6578: --- Github user dawidwys commented on a diff in

[jira] [Commented] (FLINK-6578) SharedBuffer creates self-loops when having elements with same value/timestamp.

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012086#comment-16012086 ] ASF GitHub Bot commented on FLINK-6578: --- Github user dawidwys commented on a diff in

[jira] [Commented] (FLINK-6578) SharedBuffer creates self-loops when having elements with same value/timestamp.

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012085#comment-16012085 ] ASF GitHub Bot commented on FLINK-6578: --- Github user dawidwys commented on a diff in

[jira] [Commented] (FLINK-6381) Unnecessary synchronizing object in BucketingSink

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012094#comment-16012094 ] ASF GitHub Bot commented on FLINK-6381: --- Github user zhangminglei commented on the i

[GitHub] flink issue #3820: [FLINK-6381] [connector] Unnecessary synchronizing object...

2017-05-16 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3820 Thanks for review @kl0u and the travis had gave us the green light. Very appreciate it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-6058) Don't read DEFAULT_PARALLELISM from GlobalConfiguration

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012126#comment-16012126 ] ASF GitHub Bot commented on FLINK-6058: --- GitHub user zjureel opened a pull request:

[GitHub] flink pull request #3921: [FLINK-6058] fix read DEFAULT_PARALLELISM from Con...

2017-05-16 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/3921 [FLINK-6058] fix read DEFAULT_PARALLELISM from ContextEnvironment Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.

[jira] [Created] (FLINK-6598) Fix `DataStreamGroupAggregateRule` matches error.

2017-05-16 Thread sunjincheng (JIRA)
sunjincheng created FLINK-6598: -- Summary: Fix `DataStreamGroupAggregateRule` matches error. Key: FLINK-6598 URL: https://issues.apache.org/jira/browse/FLINK-6598 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-6598) Fix `DataStreamGroupAggregateRule` matches error.

2017-05-16 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-6598: --- Description: Change retrun from {{!distinctAggs && !groupSets && !agg.indicator}} to {{!distinctAggs

[jira] [Assigned] (FLINK-5422) Check for name collisions in the Rolling/BucketingSink

2017-05-16 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas reassigned FLINK-5422: - Assignee: (was: Kostas Kloudas) > Check for name collisions in the Rolling/BucketingS

[jira] [Commented] (FLINK-6581) Dynamic property parsing broken for YARN

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012151#comment-16012151 ] ASF GitHub Bot commented on FLINK-6581: --- Github user johnboy14 commented on the issu

[GitHub] flink issue #3920: [FLINK-6597][streaming] Cleanup WindowOperatorTest useles...

2017-05-16 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3920 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink issue #3903: [FLINK-6581] [cli] Correct dynamic property parsing for Y...

2017-05-16 Thread johnboy14
Github user johnboy14 commented on the issue: https://github.com/apache/flink/pull/3903 Thanks for turning this around quickly @tillrohrmann We are experiencing this issue with AWS EMR. Is it possible to patch the current 1.2.0 version available via EMR? --- If your project is set

[jira] [Commented] (FLINK-6597) Cleanup WindowOperatorTest useless imports

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012152#comment-16012152 ] ASF GitHub Bot commented on FLINK-6597: --- Github user fhueske commented on the issue:

[jira] [Updated] (FLINK-6598) Fix `DataStreamGroupAggregateRule` matches error.

2017-05-16 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-6598: --- Description: Change {{DataStreamGroupWindowAggregateRule}} and {{DataStreamGroupAggregateRule}} retrun

[jira] [Commented] (FLINK-6598) Fix `DataStreamGroupAggregateRule` matches error.

2017-05-16 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012159#comment-16012159 ] Fabian Hueske commented on FLINK-6598: -- Why should {{agg.getAggCallList.isEmpty}} not

[GitHub] flink pull request #3922: [FLINK-6598][table] Fix `DataStreamGroupAggregateR...

2017-05-16 Thread sunjincheng121
GitHub user sunjincheng121 opened a pull request: https://github.com/apache/flink/pull/3922 [FLINK-6598][table] Fix `DataStreamGroupAggregateRule` and `DataStrea… The changes of this PR. is modify the `matches` method of `DataStreamGroupAggregateRule` and `DataStreamGroupWindowAgg

[jira] [Commented] (FLINK-6598) Fix `DataStreamGroupAggregateRule` matches error.

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012162#comment-16012162 ] ASF GitHub Bot commented on FLINK-6598: --- GitHub user sunjincheng121 opened a pull re

[jira] [Updated] (FLINK-6598) Fix `DataStreamGroupAggregateRule`and `DataStreamGroupWindowAggregateRule` matches error.

2017-05-16 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-6598: --- Summary: Fix `DataStreamGroupAggregateRule`and `DataStreamGroupWindowAggregateRule` matches error. (w

[jira] [Updated] (FLINK-6598) Fix `DataStreamGroupAggregateRule`and `DataStreamGroupWindowAggregateRule` matches error.

2017-05-16 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-6598: --- Description: Changes as follows: 1. Add {{!agg.getAggCallList.isEmpty}} condition for {{DataStreamGro

[jira] [Commented] (FLINK-6598) Fix `DataStreamGroupAggregateRule`and `DataStreamGroupWindowAggregateRule` matches error.

2017-05-16 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012206#comment-16012206 ] sunjincheng commented on FLINK-6598: Hi, [~fhueske], I think: 1. for `DataStreamGroupA

[GitHub] flink issue #3885: [FLINK-6552] Allow differing types for side outputs

2017-05-16 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3885 Thanks @tedyu and @zentol! I pushed another commit with these minor fixes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[jira] [Commented] (FLINK-6552) Side outputs don't allow differing output types

2017-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012208#comment-16012208 ] ASF GitHub Bot commented on FLINK-6552: --- Github user aljoscha commented on the issue

[jira] [Commented] (FLINK-6598) Fix `DataStreamGroupAggregateRule`and `DataStreamGroupWindowAggregateRule` matches error.

2017-05-16 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012216#comment-16012216 ] Fabian Hueske commented on FLINK-6598: -- I think this is valid SQL syntax that can be

[GitHub] flink pull request #3913: [FLINK-6574] Support nested catalogs in ExternalCa...

2017-05-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3913#discussion_r116721535 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CrudExternalCatalog.scala --- @@ -79,7 +76,7 @@ trait CrudExternalCatalo

  1   2   3   >