[GitHub] flink pull request #2815: [FLINK-5073] Use Executor to run ZooKeeper callbac...

GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/2815 [FLINK-5073] Use Executor to run ZooKeeper callbacks in ZooKeeperStateHandleStore Use dedicated Executor to run ZooKeeper callbacks in ZooKeeperStateHandleStore instead of running it in th

[GitHub] flink pull request #2816: [backport] [FLINK-5073] Use Executor to run ZooKee...

GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/2816 [backport] [FLINK-5073] Use Executor to run ZooKeeper callbacks in ZooKeeperStateHandleStore Backport of #2815 for the release-1.1 branch. Use dedicated Executor to run ZooKeeper callb

[jira] [Commented] (FLINK-5073) ZooKeeperCompleteCheckpointStore executes blocking delete operation in ZooKeeper client thread

[ https://issues.apache.org/jira/browse/FLINK-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15669775#comment-15669775 ] ASF GitHub Bot commented on FLINK-5073: --- GitHub user tillrohrmann opened a pull requ

[jira] [Commented] (FLINK-5073) ZooKeeperCompleteCheckpointStore executes blocking delete operation in ZooKeeper client thread

[ https://issues.apache.org/jira/browse/FLINK-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15669777#comment-15669777 ] ASF GitHub Bot commented on FLINK-5073: --- GitHub user tillrohrmann opened a pull requ

[jira] [Updated] (FLINK-5013) Flink Kinesis connector doesn't work on old EMR versions

[ https://issues.apache.org/jira/browse/FLINK-5013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-5013: --- Fix Version/s: 1.1.4 > Flink Kinesis connector doesn't work on old EMR versions >

[jira] [Updated] (FLINK-5075) Kinesis consumer incorrectly determines shards as newly discovered when tested against Kinesalite

[ https://issues.apache.org/jira/browse/FLINK-5075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-5075: --- Assignee: (was: Tzu-Li (Gordon) Tai) > Kinesis consumer incorrectly determines sha

[jira] [Assigned] (FLINK-5075) Kinesis consumer incorrectly determines shards as newly discovered when tested against Kinesalite

[ https://issues.apache.org/jira/browse/FLINK-5075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai reassigned FLINK-5075: -- Assignee: Tzu-Li (Gordon) Tai > Kinesis consumer incorrectly determines shards

[jira] [Commented] (FLINK-5073) ZooKeeperCompleteCheckpointStore executes blocking delete operation in ZooKeeper client thread

[ https://issues.apache.org/jira/browse/FLINK-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670029#comment-15670029 ] ASF GitHub Bot commented on FLINK-5073: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #2816: [backport] [FLINK-5073] Use Executor to run ZooKee...

Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2816#discussion_r88204552 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java --- @@ -237,11 +242,12 @@ public static CompletedCheckpointStore crea

[GitHub] flink issue #2797: [FLINK-5056] Makes the BucketingSink rescalable.

Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2797 Hi @zentol . I integrated your last comments. Now for the your last question, the answer is that the only way to distinguish between the two types of files is by their filename (prefix and suf

[jira] [Commented] (FLINK-5056) BucketingSink deletes valid data when checkpoint notification is slow.

[ https://issues.apache.org/jira/browse/FLINK-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670043#comment-15670043 ] ASF GitHub Bot commented on FLINK-5056: --- Github user kl0u commented on the issue:

[GitHub] flink pull request #2817: [FLINK-5076] Shutting down TM when shutting down m...

GitHub user ifndef-SleePy opened a pull request: https://github.com/apache/flink/pull/2817 [FLINK-5076] Shutting down TM when shutting down mini cluster. This PR [#5076](https://issues.apache.org/jira/browse/FLINK-5076) adds shutting down task manager when shutting down new mini clu

[jira] [Commented] (FLINK-5076) Shutting down TM when shutting down new mini cluster

[ https://issues.apache.org/jira/browse/FLINK-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670062#comment-15670062 ] ASF GitHub Bot commented on FLINK-5076: --- GitHub user ifndef-SleePy opened a pull req

[jira] [Commented] (FLINK-2646) Rich functions should provide a method "closeAfterFailure()"

[ https://issues.apache.org/jira/browse/FLINK-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670070#comment-15670070 ] Kostas Kloudas commented on FLINK-2646: --- Big +1 for the feature as well. To revive

[GitHub] flink pull request #2797: [FLINK-5056] Makes the BucketingSink rescalable.

Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2797#discussion_r88208586 --- Diff: flink-streaming-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java --- @@ -57

[GitHub] flink pull request #2797: [FLINK-5056] Makes the BucketingSink rescalable.

Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2797#discussion_r88208047 --- Diff: flink-streaming-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java --- @@ -97

[jira] [Commented] (FLINK-5056) BucketingSink deletes valid data when checkpoint notification is slow.

[ https://issues.apache.org/jira/browse/FLINK-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670084#comment-15670084 ] ASF GitHub Bot commented on FLINK-5056: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-5056) BucketingSink deletes valid data when checkpoint notification is slow.

[ https://issues.apache.org/jira/browse/FLINK-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670083#comment-15670083 ] ASF GitHub Bot commented on FLINK-5056: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #2797: [FLINK-5056] Makes the BucketingSink rescalable.

Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2797#discussion_r88206960 --- Diff: flink-streaming-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSinkFaultToleranceITCase.

[GitHub] flink pull request #2797: [FLINK-5056] Makes the BucketingSink rescalable.

Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2797#discussion_r88207666 --- Diff: flink-streaming-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java --- @@ -57

[jira] [Commented] (FLINK-5056) BucketingSink deletes valid data when checkpoint notification is slow.

[ https://issues.apache.org/jira/browse/FLINK-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670081#comment-15670081 ] ASF GitHub Bot commented on FLINK-5056: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-5056) BucketingSink deletes valid data when checkpoint notification is slow.

[ https://issues.apache.org/jira/browse/FLINK-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670082#comment-15670082 ] ASF GitHub Bot commented on FLINK-5056: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #2797: [FLINK-5056] Makes the BucketingSink rescalable.

Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2797#discussion_r88209971 --- Diff: flink-streaming-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSinkFaultToleranceITCase.ja

[jira] [Commented] (FLINK-5056) BucketingSink deletes valid data when checkpoint notification is slow.

[ https://issues.apache.org/jira/browse/FLINK-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670106#comment-15670106 ] ASF GitHub Bot commented on FLINK-5056: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #2797: [FLINK-5056] Makes the BucketingSink rescalable.

Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2797#discussion_r88211157 --- Diff: flink-streaming-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java --- @@ -972,

[jira] [Commented] (FLINK-5056) BucketingSink deletes valid data when checkpoint notification is slow.

[ https://issues.apache.org/jira/browse/FLINK-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670124#comment-15670124 ] ASF GitHub Bot commented on FLINK-5056: --- Github user kl0u commented on a diff in the

[GitHub] flink issue #2797: [FLINK-5056] Makes the BucketingSink rescalable.

Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2797 Done @zentol --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-5056) BucketingSink deletes valid data when checkpoint notification is slow.

[ https://issues.apache.org/jira/browse/FLINK-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670129#comment-15670129 ] ASF GitHub Bot commented on FLINK-5056: --- Github user kl0u commented on the issue:

[jira] [Created] (FLINK-5078) Introduce annotations for classes copied from Calcite

Timo Walther created FLINK-5078: --- Summary: Introduce annotations for classes copied from Calcite Key: FLINK-5078 URL: https://issues.apache.org/jira/browse/FLINK-5078 Project: Flink Issue Type:

[GitHub] flink pull request #2797: [FLINK-5056] Makes the BucketingSink rescalable.

Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2797#discussion_r88215090 --- Diff: flink-streaming-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java --- @@ -97

[jira] [Commented] (FLINK-5056) BucketingSink deletes valid data when checkpoint notification is slow.

[ https://issues.apache.org/jira/browse/FLINK-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670169#comment-15670169 ] ASF GitHub Bot commented on FLINK-5056: --- Github user zentol commented on a diff in t

[jira] [Created] (FLINK-5079) Failed to submit job to YARN cluster

Ufuk Celebi created FLINK-5079: -- Summary: Failed to submit job to YARN cluster Key: FLINK-5079 URL: https://issues.apache.org/jira/browse/FLINK-5079 Project: Flink Issue Type: Bug Affects Ve

[jira] [Commented] (FLINK-5078) Introduce annotations for classes copied from Calcite

[ https://issues.apache.org/jira/browse/FLINK-5078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670189#comment-15670189 ] Fabian Hueske commented on FLINK-5078: -- +1 That's a good idea! > Introduce annotatio

[jira] [Commented] (FLINK-2646) Rich functions should provide a method "closeAfterFailure()"

[ https://issues.apache.org/jira/browse/FLINK-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670219#comment-15670219 ] Stephan Ewen commented on FLINK-2646: - One thing we can do is mirror the way it is don

[jira] [Comment Edited] (FLINK-2646) Rich functions should provide a method "closeAfterFailure()"

[ https://issues.apache.org/jira/browse/FLINK-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670219#comment-15670219 ] Stephan Ewen edited comment on FLINK-2646 at 11/16/16 11:34 AM:

[jira] [Commented] (FLINK-4872) Type erasure problem exclusively on cluster execution

[ https://issues.apache.org/jira/browse/FLINK-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670241#comment-15670241 ] Martin Junghanns commented on FLINK-4872: - [~twalthr] Thanks for looking into it.

[jira] [Comment Edited] (FLINK-4872) Type erasure problem exclusively on cluster execution

[ https://issues.apache.org/jira/browse/FLINK-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670241#comment-15670241 ] Martin Junghanns edited comment on FLINK-4872 at 11/16/16 11:44 AM:

[GitHub] flink pull request #2816: [backport] [FLINK-5073] Use Executor to run ZooKee...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2816#discussion_r88231145 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java --- @@ -237,11 +242,12 @@ public static CompletedCheckpointStore

[jira] [Commented] (FLINK-5073) ZooKeeperCompleteCheckpointStore executes blocking delete operation in ZooKeeper client thread

[ https://issues.apache.org/jira/browse/FLINK-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670380#comment-15670380 ] ASF GitHub Bot commented on FLINK-5073: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #:

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/commit/57208e650f94edece537ccdeb1a2c19b4f7ccca8#commitcomment-19844923 In flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java: In flink-runtime/src/main/java/org/ap

[GitHub] flink pull request #:

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/commit/57208e650f94edece537ccdeb1a2c19b4f7ccca8#commitcomment-19844939 In flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java: In flink-runtime/src/main/java/org/ap

[GitHub] flink pull request #:

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/commit/57208e650f94edece537ccdeb1a2c19b4f7ccca8#commitcomment-19844935 In flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java: In flink-runtime/src/main/java/org/ap

[GitHub] flink issue #2786: [FLINK-5016] [ci] Increase no output timeout to 10 mins

Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2786 I think we should split up the tests that take so long into multiple files. That should do the trick as well. For example, the `EventTimeWindowCheckpointingITCase` can simply have an abs

[GitHub] flink issue #2814: Corrected log4j files.

Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2814 +1 @greghogan feel free to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[jira] [Commented] (FLINK-5016) EventTimeWindowCheckpointingITCase testTumblingTimeWindowWithKVStateMaxMaxParallelism with RocksDB hangs

[ https://issues.apache.org/jira/browse/FLINK-5016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670419#comment-15670419 ] ASF GitHub Bot commented on FLINK-5016: --- Github user StephanEwen commented on the is

[jira] [Created] (FLINK-5080) Cassandra connector ignores saveAsync result onSuccess

Jakub Nowacki created FLINK-5080: Summary: Cassandra connector ignores saveAsync result onSuccess Key: FLINK-5080 URL: https://issues.apache.org/jira/browse/FLINK-5080 Project: Flink Issue Ty

[GitHub] flink pull request #:

Github user zentol commented on the pull request: https://github.com/apache/flink/commit/57208e650f94edece537ccdeb1a2c19b4f7ccca8#commitcomment-19845480 In flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java: In flink-runtime/src/main/java/org/apache/

[GitHub] flink pull request #:

Github user zentol commented on the pull request: https://github.com/apache/flink/commit/57208e650f94edece537ccdeb1a2c19b4f7ccca8#commitcomment-19845484 In flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java: In flink-runtime/src/main/java/org/apache/

[GitHub] flink pull request #:

Github user zentol commented on the pull request: https://github.com/apache/flink/commit/57208e650f94edece537ccdeb1a2c19b4f7ccca8#commitcomment-19845479 In flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java: In flink-runtime/src/main/java/org/apache/

[GitHub] flink pull request #:

Github user zentol commented on the pull request: https://github.com/apache/flink/commit/57208e650f94edece537ccdeb1a2c19b4f7ccca8#commitcomment-19845489 In flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java: In flink-runtime/src/main/java/org/apache/

[jira] [Commented] (FLINK-5067) Make Flink compile with 1.8 Java compiler

[ https://issues.apache.org/jira/browse/FLINK-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670492#comment-15670492 ] ASF GitHub Bot commented on FLINK-5067: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request #2804: [FLINK-5067] Make Flink compile with 1.8 Java comp...

Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2804#discussion_r88242410 --- Diff: pom.xml --- @@ -96,7 +96,7 @@ under the License. 1.7.7 18.0 2.3.7 - 1.7 +

[jira] [Commented] (FLINK-5067) Make Flink compile with 1.8 Java compiler

[ https://issues.apache.org/jira/browse/FLINK-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670491#comment-15670491 ] ASF GitHub Bot commented on FLINK-5067: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request #2804: [FLINK-5067] Make Flink compile with 1.8 Java comp...

Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2804#discussion_r88242077 --- Diff: flink-java/src/test/java/org/apache/flink/api/common/operators/CollectionExecutionAccumulatorsTest.java --- @@ -35,7 +35,7 @@ @Test

[GitHub] flink pull request #2804: [FLINK-5067] Make Flink compile with 1.8 Java comp...

Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2804#discussion_r88241945 --- Diff: flink-tests/src/test/java/org/apache/flink/test/windowing/sessionwindows/SessionWindowITCase.java --- @@ -122,11 +122,11 @@ private void runTes

[jira] [Commented] (FLINK-5067) Make Flink compile with 1.8 Java compiler

[ https://issues.apache.org/jira/browse/FLINK-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670490#comment-15670490 ] ASF GitHub Bot commented on FLINK-5067: --- Github user StephanEwen commented on a diff

[GitHub] flink issue #2789: [FLINK-5048] [Kafka Consumer] Change thread model of Flin...

Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2789 Thanks for the review, @tzulitai I would go ahead and merge this, addressing the comments. --- If your project is set up for it, you can reply to this email and have your reply appear o

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670496#comment-15670496 ] ASF GitHub Bot commented on FLINK-5048: --- Github user StephanEwen commented on the is

[GitHub] flink issue #2761: [FLINK-3551] [examples] Sync Scala Streaiming Examples

Github user thvasilo commented on the issue: https://github.com/apache/flink/pull/2761 Hello Lim, thank you for your contribution! I've taken a quick look and most of these look fine, plus I see you've included the required tests. I'll do a review this week and hopefully a

[jira] [Commented] (FLINK-3551) Sync Scala and Java Streaming Examples

[ https://issues.apache.org/jira/browse/FLINK-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670501#comment-15670501 ] ASF GitHub Bot commented on FLINK-3551: --- Github user thvasilo commented on the issue

[GitHub] flink issue #2807: [FLINK-4631] Prevent some possible NPEs.

Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2807 I think we need to go through these changes one by one. In many situations, field being null indicates an error. These situations now silently do nothing, rather than at least reporting a

[GitHub] flink pull request #2818: [FLINK-4263] [table] SQL's VALUES does not work pr...

GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/2818 [FLINK-4263] [table] SQL's VALUES does not work properly Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If y

[jira] [Commented] (FLINK-4631) NullPointerException during stream task cleanup

[ https://issues.apache.org/jira/browse/FLINK-4631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670507#comment-15670507 ] ASF GitHub Bot commented on FLINK-4631: --- Github user StephanEwen commented on the is

[jira] [Commented] (FLINK-4263) SQL's VALUES does not work properly

[ https://issues.apache.org/jira/browse/FLINK-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670509#comment-15670509 ] ASF GitHub Bot commented on FLINK-4263: --- GitHub user twalthr opened a pull request:

[jira] [Commented] (FLINK-5063) State handles are not properly cleaned up for declined or expired checkpoints

[ https://issues.apache.org/jira/browse/FLINK-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670516#comment-15670516 ] ASF GitHub Bot commented on FLINK-5063: --- Github user StephanEwen commented on the is

[GitHub] flink issue #2813: [backport] [FLINK-5063] Discard state handles of declined...

Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2813 Similar to #2812 - good fix! +1 from my side! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] flink issue #2812: [FLINK-5063] Discard state handles of declined or expired...

Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2812 Good catch and patch! +1 from my side to merge this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[jira] [Commented] (FLINK-5063) State handles are not properly cleaned up for declined or expired checkpoints

[ https://issues.apache.org/jira/browse/FLINK-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670518#comment-15670518 ] ASF GitHub Bot commented on FLINK-5063: --- Github user StephanEwen commented on the is

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670534#comment-15670534 ] ASF GitHub Bot commented on FLINK-5048: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request #2789: [FLINK-5048] [Kafka Consumer] Change thread model ...

Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2789#discussion_r88245373 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java --

[jira] [Commented] (FLINK-4961) SGD for Matrix Factorization

[ https://issues.apache.org/jira/browse/FLINK-4961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670629#comment-15670629 ] ASF GitHub Bot commented on FLINK-4961: --- GitHub user gaborhermann opened a pull requ

[GitHub] flink pull request #2819: [FLINK-4961] [ml] SGD for Matrix Factorization (WI...

GitHub user gaborhermann opened a pull request: https://github.com/apache/flink/pull/2819 [FLINK-4961] [ml] SGD for Matrix Factorization (WIP) Please note, that this is a work-in-progress PR, to discuss some design questions. There are minor things to be done including the documenta

[jira] [Commented] (FLINK-4961) SGD for Matrix Factorization

[ https://issues.apache.org/jira/browse/FLINK-4961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670658#comment-15670658 ] ASF GitHub Bot commented on FLINK-4961: --- Github user gaborhermann commented on the i

[GitHub] flink issue #2819: [FLINK-4961] [ml] SGD for Matrix Factorization (WIP)

Github user gaborhermann commented on the issue: https://github.com/apache/flink/pull/2819 There are some open questions: 1. Should we optimize 3 way join? For now the join order is burnt into the code, also we might be able to give hints for join strategies. 2. How should

[GitHub] flink pull request #2789: [FLINK-5048] [Kafka Consumer] Change thread model ...

Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2789#discussion_r88257338 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerCallBridge010.

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670707#comment-15670707 ] ASF GitHub Bot commented on FLINK-5048: --- Github user StephanEwen commented on a diff

[jira] [Commented] (FLINK-4872) Type erasure problem exclusively on cluster execution

[ https://issues.apache.org/jira/browse/FLINK-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670710#comment-15670710 ] Timo Walther commented on FLINK-4872: - I still can't reproduce your problem. What I no

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670717#comment-15670717 ] ASF GitHub Bot commented on FLINK-5048: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request #2789: [FLINK-5048] [Kafka Consumer] Change thread model ...

Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2789#discussion_r88258273 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaShortRetentionTestBase.java --

[jira] [Created] (FLINK-5081) unable to set yarn.maximum-failed-containers with flink one-time YARN setup

Nico Kruber created FLINK-5081: -- Summary: unable to set yarn.maximum-failed-containers with flink one-time YARN setup Key: FLINK-5081 URL: https://issues.apache.org/jira/browse/FLINK-5081 Project: Flink

[GitHub] flink pull request #2789: [FLINK-5048] [Kafka Consumer] Change thread model ...

Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2789#discussion_r88260220 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java --

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670743#comment-15670743 ] ASF GitHub Bot commented on FLINK-5048: --- Github user StephanEwen commented on a diff

[GitHub] flink issue #2789: [FLINK-5048] [Kafka Consumer] Change thread model of Flin...

Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2789 I would actually like to not change how/when `handover.close()` is called. It is called more often that necessary (probably), but since it is an idempotent operation, it does not matter.

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670757#comment-15670757 ] ASF GitHub Bot commented on FLINK-5048: --- Github user StephanEwen commented on the is

[GitHub] flink pull request #2789: [FLINK-5048] [Kafka Consumer] Change thread model ...

Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2789#discussion_r88264489 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java --

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670798#comment-15670798 ] ASF GitHub Bot commented on FLINK-5048: --- Github user StephanEwen commented on a diff

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670803#comment-15670803 ] ASF GitHub Bot commented on FLINK-5048: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request #2789: [FLINK-5048] [Kafka Consumer] Change thread model ...

Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2789#discussion_r88264932 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka09Fetcher.java ---

[GitHub] flink issue #2789: [FLINK-5048] [Kafka Consumer] Change thread model of Flin...

Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2789 > Also, both the fetcher and the KafkaConsumerThread are written to encapsulate all necessary logic self contained. That means they do not rely on each other to call handover.close() in any situatio

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670854#comment-15670854 ] ASF GitHub Bot commented on FLINK-5048: --- Github user tzulitai commented on the issue

[GitHub] flink pull request #2789: [FLINK-5048] [Kafka Consumer] Change thread model ...

Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2789#discussion_r88273352 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka09Fetcher.java --- @@

[jira] [Commented] (FLINK-3551) Sync Scala and Java Streaming Examples

[ https://issues.apache.org/jira/browse/FLINK-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670912#comment-15670912 ] ASF GitHub Bot commented on FLINK-3551: --- Github user ch33hau commented on the issue:

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670911#comment-15670911 ] ASF GitHub Bot commented on FLINK-5048: --- Github user tzulitai commented on a diff in

[GitHub] flink issue #2761: [FLINK-3551] [examples] Sync Scala Streaiming Examples

Github user ch33hau commented on the issue: https://github.com/apache/flink/pull/2761 @thvasilo thanks! I will do that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[jira] [Created] (FLINK-5082) Pull ExecutionService lifecycle management out of the JobManager

Till Rohrmann created FLINK-5082: Summary: Pull ExecutionService lifecycle management out of the JobManager Key: FLINK-5082 URL: https://issues.apache.org/jira/browse/FLINK-5082 Project: Flink

[GitHub] flink issue #1033: Add Scala version of GraphAlgorithm

Github user greghogan commented on the issue: https://github.com/apache/flink/pull/1033 Is this PR's functionality still requested or can it be closed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #2066: Updated ssh configuration in base Dockerfile

Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2066 The `Dockerfile` has been fully rewritten since this PR. @techmaniack is there additional functionality still needed or can this PR be closed? --- If your project is set up for it, you can reply t

[GitHub] flink pull request #2820: [FLINK-5082] Pull ExecutorService lifecycle manage...

GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/2820 [FLINK-5082] Pull ExecutorService lifecycle management out of the JobManager The provided ExecutorService will no longer be closed by the JobManager. Instead the lifecycle is managed outsid

[jira] [Commented] (FLINK-5082) Pull ExecutionService lifecycle management out of the JobManager

[ https://issues.apache.org/jira/browse/FLINK-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671130#comment-15671130 ] ASF GitHub Bot commented on FLINK-5082: --- GitHub user tillrohrmann opened a pull requ

[jira] [Commented] (FLINK-4872) Type erasure problem exclusively on cluster execution

[ https://issues.apache.org/jira/browse/FLINK-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671192#comment-15671192 ] Martin Junghanns commented on FLINK-4872: - I just reproduced it using the followin

  1   2   3   >