Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2244
@mushketyk I will review it this week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
[
https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411454#comment-15411454
]
ASF GitHub Bot commented on FLINK-3874:
---
Github user twalthr commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411460#comment-15411460
]
Ufuk Celebi commented on FLINK-4323:
Should we still remove the shut down hook? The sh
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2327
Thanks for reviewing. Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
[
https://issues.apache.org/jira/browse/FLINK-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411463#comment-15411463
]
ASF GitHub Bot commented on FLINK-4304:
---
Github user twalthr commented on the issue:
Ufuk Celebi created FLINK-4328:
--
Summary: Harden JobManagerHA*ITCase
Key: FLINK-4328
URL: https://issues.apache.org/jira/browse/FLINK-4328
Project: Flink
Issue Type: Improvement
Compon
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2327
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411470#comment-15411470
]
ASF GitHub Bot commented on FLINK-4304:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timo Walther resolved FLINK-4304.
-
Resolution: Fixed
Fix Version/s: 1.1.0
Fixed in 8d25c64146ef0a2d0e9ee4c3e8ac3229e72a1416.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2329
Thanks Stephan. Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
[
https://issues.apache.org/jira/browse/FLINK-3138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411549#comment-15411549
]
ASF GitHub Bot commented on FLINK-3138:
---
Github user twalthr commented on the issue:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2329
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-3138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411561#comment-15411561
]
ASF GitHub Bot commented on FLINK-3138:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timo Walther updated FLINK-4304:
Fix Version/s: (was: 1.1.0)
1.2.0
> Jar names that contain whitespace cause p
[
https://issues.apache.org/jira/browse/FLINK-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timo Walther updated FLINK-4304:
Fix Version/s: (was: 1.2.0)
1.2
> Jar names that contain whitespace cause pro
[
https://issues.apache.org/jira/browse/FLINK-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timo Walther updated FLINK-4304:
Fix Version/s: (was: 1.2)
1.2.0
> Jar names that contain whitespace cause pro
[
https://issues.apache.org/jira/browse/FLINK-3138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timo Walther resolved FLINK-3138.
-
Resolution: Fixed
Fix Version/s: 1.2.0
Fixed in ff777084ba2e1f1070ce5ecbc5afc122756ba851.
[
https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411582#comment-15411582
]
Aljoscha Krettek commented on FLINK-4282:
-
Hi,
the offset just hast to be taken in
[
https://issues.apache.org/jira/browse/FLINK-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411588#comment-15411588
]
Aljoscha Krettek commented on FLINK-4326:
-
[~iemejia] I think you would also be in
[
https://issues.apache.org/jira/browse/FLINK-3899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411590#comment-15411590
]
Aljoscha Krettek commented on FLINK-3899:
-
Yes, I thing that would be enough.
> D
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2337
There are tests failing. I will update the PR later today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
[
https://issues.apache.org/jira/browse/FLINK-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411592#comment-15411592
]
ASF GitHub Bot commented on FLINK-3042:
---
Github user twalthr commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411602#comment-15411602
]
ASF GitHub Bot commented on FLINK-4081:
---
Github user twalthr commented on the issue:
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2297
The length is not sufficient to differentiate between empty column and
empty string.
E.g. if you have quoted strings: `,,` and `,"",`
With the changes in this PR we don't modify the return val
[
https://issues.apache.org/jira/browse/FLINK-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411605#comment-15411605
]
Ismaël Mejía commented on FLINK-4326:
-
For ref this is the commit of my proposed solut
[
https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411608#comment-15411608
]
Aditi Viswanathan commented on FLINK-4282:
--
Hi Aljoscha,
I've written down an ex
[
https://issues.apache.org/jira/browse/FLINK-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411622#comment-15411622
]
Till Rohrmann commented on FLINK-3703:
--
Hi [~ivan.mushketyk],
Yes you're right with
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2244
@twalthr Great! Thank your help.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
[
https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411623#comment-15411623
]
ASF GitHub Bot commented on FLINK-3874:
---
Github user mushketyk commented on the issu
Aljoscha Krettek created FLINK-4329:
---
Summary: Streaming File Source Must Correctly Handle
Timestamps/Watermarks
Key: FLINK-4329
URL: https://issues.apache.org/jira/browse/FLINK-4329
Project: Flink
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2297
Okay, I think the main source of confusion here is that `EMPTY_STRING` does
actually not refer to an empty string (as specific to the string parser) but to
something like "null", "empty column",
[
https://issues.apache.org/jira/browse/FLINK-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411745#comment-15411745
]
ASF GitHub Bot commented on FLINK-4081:
---
Github user StephanEwen commented on the is
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2261
merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
[
https://issues.apache.org/jira/browse/FLINK-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411759#comment-15411759
]
ASF GitHub Bot commented on FLINK-4226:
---
Github user rmetzger commented on the issue
[
https://issues.apache.org/jira/browse/FLINK-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger closed FLINK-4226.
-
Resolution: Fixed
Fix Version/s: 1.2.0
Resolved in http://git-wip-us.apache.org/repos/asf/f
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2261
@ASRagab: Could you close the pull request? I can not close the PR from the
Github interface and I forgot to include the magic string to close it from the
commit message.
---
If your project is se
[
https://issues.apache.org/jira/browse/FLINK-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411767#comment-15411767
]
ASF GitHub Bot commented on FLINK-4226:
---
Github user rmetzger commented on the issue
[
https://issues.apache.org/jira/browse/FLINK-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411771#comment-15411771
]
ASF GitHub Bot commented on FLINK-4226:
---
Github user ASRagab commented on the issue:
Github user ASRagab commented on the issue:
https://github.com/apache/flink/pull/2261
Closing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
[
https://issues.apache.org/jira/browse/FLINK-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411772#comment-15411772
]
ASF GitHub Bot commented on FLINK-4226:
---
Github user ASRagab closed the pull request
Github user ASRagab closed the pull request at:
https://github.com/apache/flink/pull/2261
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2318
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2312
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
[
https://issues.apache.org/jira/browse/FLINK-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411777#comment-15411777
]
ASF GitHub Bot commented on FLINK-4291:
---
Github user zentol commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411776#comment-15411776
]
ASF GitHub Bot commented on FLINK-4276:
---
Github user zentol commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-4276.
---
Resolution: Fixed
Fix Version/s: 1.2.0
Fixed in a2219b0b6258077fedc355d71d1846e3142d3e1
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2312
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2318
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411783#comment-15411783
]
ASF GitHub Bot commented on FLINK-4291:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-4276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411782#comment-15411782
]
ASF GitHub Bot commented on FLINK-4276:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-4291.
---
Resolution: Fixed
Assignee: Chesnay Schepler
Fix Version/s: 1.2.0
Fixed in f1e
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2261
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
[
https://issues.apache.org/jira/browse/FLINK-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411786#comment-15411786
]
ASF GitHub Bot commented on FLINK-4226:
---
Github user rmetzger commented on the issue
Robert Metzger created FLINK-4330:
-
Summary: Consider removing min()/minBy()/max()/maxBy()/sum()
utility methods from the DataStream API
Key: FLINK-4330
URL: https://issues.apache.org/jira/browse/FLINK-4330
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2323
@mushketyk Are you going to update this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
[
https://issues.apache.org/jira/browse/FLINK-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411840#comment-15411840
]
ASF GitHub Bot commented on FLINK-2090:
---
Github user StephanEwen commented on the is
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2337
@twalthr and me had an offline review of this.
The general approach is "+1"
We decided to see if the "generic input variable mapping" can be part of
the `TypeInformation`, rather than
[
https://issues.apache.org/jira/browse/FLINK-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411858#comment-15411858
]
ASF GitHub Bot commented on FLINK-3042:
---
Github user StephanEwen commented on the is
[
https://issues.apache.org/jira/browse/FLINK-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411852#comment-15411852
]
ASF GitHub Bot commented on FLINK-4271:
---
Github user StephanEwen commented on the is
Pushpendra Jaiswal created FLINK-4331:
-
Summary: Flink is not able to serialize scala classes / Task Not
Serializable
Key: FLINK-4331
URL: https://issues.apache.org/jira/browse/FLINK-4331
Project:
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2305
I am at the point where I would suggest to actually break the API and apply
a proper fix. Tough step, but the alternatives seem even worse.
I wrote a [discuss] mail to the dev list, let's
[
https://issues.apache.org/jira/browse/FLINK-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411965#comment-15411965
]
ASF GitHub Bot commented on FLINK-2090:
---
Github user mushketyk commented on the issu
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2323
@StephanEwen Sorry, somehow I missed your comment. I'll update the PR today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/FLINK-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412032#comment-15412032
]
Stephan Ewen commented on FLINK-4331:
-
There are two different issues here:
- The g
[
https://issues.apache.org/jira/browse/FLINK-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412040#comment-15412040
]
Milosz Tanski commented on FLINK-4326:
--
This would also be valuable for people trying
[
https://issues.apache.org/jira/browse/FLINK-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen updated FLINK-4333:
Fix Version/s: 1.2.0
> Name mixup in Savepoint versions
>
>
>
Stephan Ewen created FLINK-4332:
---
Summary: Savepoint Serializer mixed read()/readFully()
Key: FLINK-4332
URL: https://issues.apache.org/jira/browse/FLINK-4332
Project: Flink
Issue Type: Bug
[
https://issues.apache.org/jira/browse/FLINK-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen updated FLINK-4333:
Affects Version/s: (was: 1.2.0)
> Name mixup in Savepoint versions
> ---
Stephan Ewen created FLINK-4333:
---
Summary: Name mixup in Savepoint versions
Key: FLINK-4333
URL: https://issues.apache.org/jira/browse/FLINK-4333
Project: Flink
Issue Type: Bug
Compon
[
https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412194#comment-15412194
]
Vasia Kalavri commented on FLINK-1707:
--
Thank you for the example [~joseprupi]. I'll
[
https://issues.apache.org/jira/browse/FLINK-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412244#comment-15412244
]
Stephan Ewen commented on FLINK-4330:
-
I the {{DataSet}} API, these methods made sense
Github user delding commented on a diff in the pull request:
https://github.com/apache/flink/pull/2332#discussion_r73939778
--- Diff:
flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseSink.java
---
@@ -0,0 +1,100 @@
[
https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412334#comment-15412334
]
ASF GitHub Bot commented on FLINK-2055:
---
Github user delding commented on a diff in
Shannon Carey created FLINK-4334:
Summary: Shaded Hadoop1 jar not fully excluded in Quickstart
Key: FLINK-4334
URL: https://issues.apache.org/jira/browse/FLINK-4334
Project: Flink
Issue Type:
GitHub user rehevkor5 opened a pull request:
https://github.com/apache/flink/pull/2341
[FLINK-4334] [quickstarts] Correctly exclude hadoop1 in quickstart POMs
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consid
[
https://issues.apache.org/jira/browse/FLINK-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412412#comment-15412412
]
ASF GitHub Bot commented on FLINK-4334:
---
GitHub user rehevkor5 opened a pull request
[
https://issues.apache.org/jira/browse/FLINK-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412490#comment-15412490
]
Elias Levy commented on FLINK-4326:
---
Not just systemd, but also upstart (my particular c
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2323
@StephanEwen I've updated the PR according to your review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
[
https://issues.apache.org/jira/browse/FLINK-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412528#comment-15412528
]
ASF GitHub Bot commented on FLINK-2090:
---
Github user mushketyk commented on the issu
Zhenzhong Xu created FLINK-4335:
---
Summary: Add jar id, and job parameters information to job status
rest call
Key: FLINK-4335
URL: https://issues.apache.org/jira/browse/FLINK-4335
Project: Flink
Zhenzhong Xu created FLINK-4336:
---
Summary: Expose ability to take a savepoint from job manager rest
api
Key: FLINK-4336
URL: https://issues.apache.org/jira/browse/FLINK-4336
Project: Flink
Iss
[
https://issues.apache.org/jira/browse/FLINK-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhenzhong Xu updated FLINK-4335:
Description:
>From declarative, reconcilation based job management perspective, there is a
>need to
82 matches
Mail list logo