[
https://issues.apache.org/jira/browse/FLINK-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405483#comment-15405483
]
Ivan Mushketyk commented on FLINK-3950:
---
If no one is working on it, I would like to
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2282#discussion_r73290760
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetSort.scala
---
@@ -71,11 +78,57 @@ class DataSetSor
[
https://issues.apache.org/jira/browse/FLINK-4256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405484#comment-15405484
]
Zhijiang Wang commented on FLINK-4256:
--
In further improvement, if task c failed, the
[
https://issues.apache.org/jira/browse/FLINK-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405482#comment-15405482
]
ASF GitHub Bot commented on FLINK-3940:
---
Github user twalthr commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405488#comment-15405488
]
ASF GitHub Bot commented on FLINK-3940:
---
Github user twalthr commented on a diff in
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2282#discussion_r73291620
--- Diff: docs/apis/table.md ---
@@ -606,6 +606,28 @@ Table result = in.orderBy("a.asc");
+
+ Offset
+
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2282#discussion_r73292974
--- Diff: docs/apis/table.md ---
@@ -606,6 +606,28 @@ Table result = in.orderBy("a.asc");
+
+ Offset
+
[
https://issues.apache.org/jira/browse/FLINK-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405511#comment-15405511
]
ASF GitHub Bot commented on FLINK-3940:
---
Github user wuchong commented on a diff in
GitHub user chermenin opened a pull request:
https://github.com/apache/flink/pull/2328
[hotfix] Fix TypeExtractor.
When function is a method reference to an instance method of an arbitrary
object of a particular type it hasn't any parameters and getting of input type
throws excepti
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2328
Thanks for your PR. I will review it shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2298
@StephanEwen A user can also call `CsvInputFormat.nextRecord()` because it
is public, but this was never a problem. If we want to restrict visibility of
`TableSource` interface methods, we have to co
[
https://issues.apache.org/jira/browse/FLINK-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405553#comment-15405553
]
ASF GitHub Bot commented on FLINK-4247:
---
Github user twalthr commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405572#comment-15405572
]
Timo Walther commented on FLINK-4262:
-
I think this issue is bit tricky as the positio
[
https://issues.apache.org/jira/browse/FLINK-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405623#comment-15405623
]
ASF GitHub Bot commented on FLINK-4271:
---
Github user StephanEwen commented on the is
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2305
We should not change the checker sensitivity. It is very important that it
checks for binary compatibility - that was the promise of Flink 1.0.
If we want to break compatibility, we can d
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2305
I think, specify parallelism between `window(...)` and `apply(...)` is not
nice. We not just need `setParallelism` function but also `name`, `uid`,
`slotSharingGroup` and many other functions in `Sin
[
https://issues.apache.org/jira/browse/FLINK-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405657#comment-15405657
]
ASF GitHub Bot commented on FLINK-4271:
---
Github user wuchong commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405660#comment-15405660
]
Till Rohrmann commented on FLINK-3703:
--
Hi [~ivan.mushketyk],
I think this feature s
[
https://issues.apache.org/jira/browse/FLINK-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405664#comment-15405664
]
Till Rohrmann commented on FLINK-3318:
--
Hi [~ivan.mushketyk],
yes I think we need so
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2328
Your fix skips basically the input validation, I think we should still add
some additional checks and some additional tests. I will open a PR for it. You
can close this PR.
---
If your project is s
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2305
True, this may warrant a case of breaking APIs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
[
https://issues.apache.org/jira/browse/FLINK-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405827#comment-15405827
]
ASF GitHub Bot commented on FLINK-4271:
---
Github user StephanEwen commented on the is
Stephan Ewen created FLINK-4310:
---
Summary: Move BinaryCompatibility Check plugin to relevant projects
Key: FLINK-4310
URL: https://issues.apache.org/jira/browse/FLINK-4310
Project: Flink
Issue
[
https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405836#comment-15405836
]
Stephan Ewen commented on FLINK-4094:
-
If a task requests more memory than the system
Niels Basjes created FLINK-4311:
---
Summary: TableInputFormat fails when reused on next split
Key: FLINK-4311
URL: https://issues.apache.org/jira/browse/FLINK-4311
Project: Flink
Issue Type: Bug
Github user chermenin closed the pull request at:
https://github.com/apache/flink/pull/2328
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
[
https://issues.apache.org/jira/browse/FLINK-3138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405865#comment-15405865
]
ASF GitHub Bot commented on FLINK-3138:
---
GitHub user twalthr opened a pull request:
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2329
[FLINK-3138] [types] Method References are not supported as lambda
expressions
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
[
https://issues.apache.org/jira/browse/FLINK-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timo Walther reassigned FLINK-3042:
---
Assignee: Timo Walther
> Define a way to let types create their own TypeInformation
> ---
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2320#discussion_r7859
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -260,8 +263,15 @@ public AbstractYarnClusterDescriptor
creat
[
https://issues.apache.org/jira/browse/FLINK-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405886#comment-15405886
]
ASF GitHub Bot commented on FLINK-4297:
---
Github user StephanEwen commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405888#comment-15405888
]
ASF GitHub Bot commented on FLINK-4297:
---
Github user StephanEwen commented on the is
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2320
One comment inline, otherwise looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2327
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
[
https://issues.apache.org/jira/browse/FLINK-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405889#comment-15405889
]
ASF GitHub Bot commented on FLINK-4304:
---
Github user StephanEwen commented on the is
[
https://issues.apache.org/jira/browse/FLINK-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405893#comment-15405893
]
ASF GitHub Bot commented on FLINK-4311:
---
GitHub user nielsbasjes opened a pull reque
GitHub user nielsbasjes opened a pull request:
https://github.com/apache/flink/pull/2330
FLINK-4311 Fixed several problems in TableInputFormat
Question: Do you guys want a unit test for this?
In HBase itself I have done this in the past yet this required a large
chunk of additio
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2324
I actually need to bump my version, so will merge this and adjust the
references in docs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user nielsbasjes commented on the issue:
https://github.com/apache/flink/pull/2330
Oh damn,
I just noticed a major issue in this: In order to create the input splits
the table needs to be available "before" the call to the 'open' method.
---
If your project is set u
[
https://issues.apache.org/jira/browse/FLINK-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405896#comment-15405896
]
ASF GitHub Bot commented on FLINK-4311:
---
Github user nielsbasjes commented on the is
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2309
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, o
[
https://issues.apache.org/jira/browse/FLINK-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405908#comment-15405908
]
ASF GitHub Bot commented on FLINK-4161:
---
Github user StephanEwen commented on the is
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2297
I am confused here, the return value is not the parsed value, but the
length that got parsed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
[
https://issues.apache.org/jira/browse/FLINK-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405909#comment-15405909
]
ASF GitHub Bot commented on FLINK-4081:
---
Github user StephanEwen commented on the is
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2290
@twalthr @fhueske Can you take a look at this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
[
https://issues.apache.org/jira/browse/FLINK-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405910#comment-15405910
]
ASF GitHub Bot commented on FLINK-4242:
---
Github user StephanEwen commented on the is
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2330
maybe you can move the table initialization into `openInputFormat()`
(called once before all splits) and close it in `closeInputFormat()` (called
once after all splits).
---
If your project is set u
[
https://issues.apache.org/jira/browse/FLINK-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405912#comment-15405912
]
ASF GitHub Bot commented on FLINK-4311:
---
Github user zentol commented on the issue:
Github user nielsbasjes commented on the issue:
https://github.com/apache/flink/pull/2330
Yes, that is indeed the right place to do this.
Bummer this method does not allow throwing exceptions.
---
If your project is set up for it, you can reply to this email and have your
reply a
[
https://issues.apache.org/jira/browse/FLINK-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405918#comment-15405918
]
ASF GitHub Bot commented on FLINK-4311:
---
Github user nielsbasjes commented on the is
[
https://issues.apache.org/jira/browse/FLINK-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405928#comment-15405928
]
ASF GitHub Bot commented on FLINK-4311:
---
Github user nielsbasjes commented on the is
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2330
I would say yes, since `open()` and `close()` can also throw an
`IOException`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/FLINK-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405932#comment-15405932
]
ASF GitHub Bot commented on FLINK-4311:
---
Github user zentol commented on the issue:
Github user nielsbasjes commented on the issue:
https://github.com/apache/flink/pull/2330
Now I see why I missed these two; They are newer than the 1.0.3 I was
working with.
Is it a good idea to add ' throws IOException' to these two in
RichInputFormat ?
---
If your project is s
[
https://issues.apache.org/jira/browse/FLINK-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405945#comment-15405945
]
Ivan Mushketyk commented on FLINK-3318:
---
Hi [~till.rohrmann],
Thank you for your co
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2282#discussion_r73349912
--- Diff: docs/apis/table.md ---
@@ -606,6 +606,28 @@ Table result = in.orderBy("a.asc");
+
+ Offset
+
[
https://issues.apache.org/jira/browse/FLINK-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406004#comment-15406004
]
ASF GitHub Bot commented on FLINK-3940:
---
Github user aljoscha commented on a diff in
Github user nielsbasjes commented on the issue:
https://github.com/apache/flink/pull/2330
Note that this version still assumes that the single instance will only see
multiple splits for the same table. Is that a safe assumption?
---
If your project is set up for it, you can reply to
[
https://issues.apache.org/jira/browse/FLINK-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406043#comment-15406043
]
ASF GitHub Bot commented on FLINK-4311:
---
Github user nielsbasjes commented on the is
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2324
We also need to bump the version in the metrics imls.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
GitHub user aditivin opened a pull request:
https://github.com/apache/flink/pull/2331
[FLINK-4282] [streaming] Added an offset parameter for processing time
window assâ¦
Added offset parameter for the processing time window assigners:
- ProcessingTimeSessionWindows
- Slidin
[
https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406108#comment-15406108
]
ASF GitHub Bot commented on FLINK-4282:
---
GitHub user aditivin opened a pull request:
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2331
Your commit contains a lot of unrelated changes. This is probably caused by
the fact that your changes are not rebased on top of the current master branch.
Could you please do that.
---
If your p
[
https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406146#comment-15406146
]
ASF GitHub Bot commented on FLINK-4282:
---
Github user aljoscha commented on the issue
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r73381826
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
---
@@ -328,7 +328,11 @@ public
[
https://issues.apache.org/jira/browse/FLINK-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406281#comment-15406281
]
ASF GitHub Bot commented on FLINK-4311:
---
Github user zentol commented on a diff in t
[
https://issues.apache.org/jira/browse/FLINK-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406284#comment-15406284
]
ASF GitHub Bot commented on FLINK-4311:
---
Github user zentol commented on a diff in t
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r73382033
--- Diff:
flink-batch-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
@@ -237,7 +244,7 @@ private void logSplitIn
[
https://issues.apache.org/jira/browse/FLINK-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406293#comment-15406293
]
ASF GitHub Bot commented on FLINK-4311:
---
Github user zentol commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2330
I don't know, and it seems the InputFormat itself doesn't know either. If
we go by the previous implementation then yes, there will only be one table.
However, based on the comments on Line 64: `// ab
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2324
What do you mean by "the metrics imls"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
[
https://issues.apache.org/jira/browse/FLINK-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406318#comment-15406318
]
Stephan Ewen commented on FLINK-4308:
-
I think this sounds good, would be happy to get
[
https://issues.apache.org/jira/browse/FLINK-3899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406319#comment-15406319
]
Daniel Blazevski commented on FLINK-3899:
-
[~fhueske]
I'm happy to take this one
[
https://issues.apache.org/jira/browse/FLINK-3899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406319#comment-15406319
]
Daniel Blazevski edited comment on FLINK-3899 at 8/3/16 6:04 PM:
---
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2324
~~~
mbalassi$ grep 1.1-SNAPSHOT -R .
./docs/_config.yml:version: "1.1-SNAPSHOT"
./flink-metric-reporters/flink-metrics-dropwizard/flink-metrics-dropwizard.iml:
./flink-metric-rep
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2324
If it can wait until tomorrow morning CEST I will add these to the change
version scripts in tools. If it is urgent go ahead.
---
If your project is set up for it, you can reply to this email and h
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2324
Oh, my bad - those are just IntelliJ files left over on my machine. Adding
the doc update to the tools script and quickly rebasing this commit. Sorry for
the fuss.
---
If your project is set up fo
[
https://issues.apache.org/jira/browse/FLINK-3899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406319#comment-15406319
]
Daniel Blazevski edited comment on FLINK-3899 at 8/3/16 6:50 PM:
---
[
https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josep Rubió updated FLINK-1707:
---
Description:
This issue proposes adding the an implementation of the Affinity Propagation
algorithm a
[
https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406651#comment-15406651
]
Josep Rubió commented on FLINK-1707:
Hi all,
Sorry for my late response but I did not
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2324
Did the update, please use this version of the commit. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
[
https://issues.apache.org/jira/browse/FLINK-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406736#comment-15406736
]
ASF GitHub Bot commented on FLINK-3677:
---
Github user mushketyk commented on the issu
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2109
@mxm I've updated the PR according to your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
[
https://issues.apache.org/jira/browse/FLINK-3899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406889#comment-15406889
]
Aljoscha Krettek commented on FLINK-3899:
-
[~danielblazevski] this is meant to add
Github user gallenvara commented on a diff in the pull request:
https://github.com/apache/flink/pull/2282#discussion_r73452976
--- Diff: docs/apis/table.md ---
@@ -606,6 +606,28 @@ Table result = in.orderBy("a.asc");
+
+ Offset
+
[
https://issues.apache.org/jira/browse/FLINK-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406992#comment-15406992
]
ASF GitHub Bot commented on FLINK-3940:
---
Github user gallenvara commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407083#comment-15407083
]
Jark Wu commented on FLINK-4288:
Because {{SchemaPlus}} has no {{remove}} function, we can
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2305
Hi @aljoscha @tillrohrmann , what do you think about this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
[
https://issues.apache.org/jira/browse/FLINK-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407086#comment-15407086
]
ASF GitHub Bot commented on FLINK-4271:
---
Github user wuchong commented on the issue:
89 matches
Mail list logo
