[GitHub] flink pull request #2292: [FLINK-3891] [table] Add a class containing all su...

2016-07-25 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/2292 [FLINK-3891] [table] Add a class containing all supported Table API types Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consid

[jira] [Commented] (FLINK-3891) Add a class containing all supported Table API types

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391560#comment-15391560 ] ASF GitHub Bot commented on FLINK-3891: --- GitHub user twalthr opened a pull request:

[GitHub] flink issue #2278: [FLINK-4239] Set Default Allowed Lateness to Zero and Mak...

2016-07-25 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2278 @kl0u can you review this today? This should be part of the 1.1 release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] flink issue #2277: [FLINK-4207] WindowOperator becomes very slow with allowe...

2016-07-25 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2277 @aljoscha Can you review this today? This is a blocker for the 1.1 release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-4207) WindowOperator becomes very slow with allowed lateness

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391614#comment-15391614 ] ASF GitHub Bot commented on FLINK-4207: --- Github user uce commented on the issue:

[jira] [Commented] (FLINK-4239) Set Default Allowed Lateness to Zero and Make Triggers Non-Purging

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391612#comment-15391612 ] ASF GitHub Bot commented on FLINK-4239: --- Github user uce commented on the issue:

[GitHub] flink issue #2278: [FLINK-4239] Set Default Allowed Lateness to Zero and Mak...

2016-07-25 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2278 @uce I will do it today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[jira] [Commented] (FLINK-4239) Set Default Allowed Lateness to Zero and Make Triggers Non-Purging

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391615#comment-15391615 ] ASF GitHub Bot commented on FLINK-4239: --- Github user kl0u commented on the issue:

[GitHub] flink issue #2257: [FLINK-4152] Allow re-registration of TMs at resource man...

2016-07-25 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2257 Thanks for investigating! Let me see if I can further debug the problem and find out why Maven doesn't use the installed `flink-runtime` artifact instead of the snapshot artifact. --- If your project i

[jira] [Commented] (FLINK-4152) TaskManager registration exponential backoff doesn't work

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391616#comment-15391616 ] ASF GitHub Bot commented on FLINK-4152: --- Github user mxm commented on the issue:

[GitHub] flink issue #2269: [FLINK-4190] Generalise RollingSink to work with arbitrar...

2016-07-25 Thread joshfg
Github user joshfg commented on the issue: https://github.com/apache/flink/pull/2269 Thanks! Oh nice, this looks like a better solution for checking for bucket inactivity... For the tests, is there any reason not to fold all of those tests into the new `BucketingSinkTest`? Current

[jira] [Issue Comment Deleted] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

2016-07-25 Thread Josh Forman-Gornall (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Forman-Gornall updated FLINK-4190: --- Comment: was deleted (was: Thanks! Oh nice, this looks like a better solution for chec

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391621#comment-15391621 ] ASF GitHub Bot commented on FLINK-4190: --- Github user joshfg commented on the issue:

[jira] [Commented] (FLINK-4047) Fix documentation about determinism of KeySelectors

2016-07-25 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391631#comment-15391631 ] Aljoscha Krettek commented on FLINK-4047: - Hi, yes this issue is still valid. > F

[GitHub] flink issue #2269: [FLINK-4190] Generalise RollingSink to work with arbitrar...

2016-07-25 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2269 Not really, the reason for having an ITCase is just that they really exercise the sink embedded in a proper Flink job, which might bring up interactions that where overlooked when writing a test cas

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391647#comment-15391647 ] ASF GitHub Bot commented on FLINK-4190: --- Github user aljoscha commented on the issue

[jira] [Commented] (FLINK-3891) Add a class containing all supported Table API types

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391746#comment-15391746 ] ASF GitHub Bot commented on FLINK-3891: --- Github user zentol commented on a diff in t

[GitHub] flink issue #2287: [hotfix] Prevent CheckpointCommitter from failing job

2016-07-25 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2287 I'm checking now but I'm assuming it will fix it from looking at the code. Could we also a a test for this? --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] flink pull request #2292: [FLINK-3891] [table] Add a class containing all su...

2016-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2292#discussion_r72048591 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/batch/table/CastingITCase.java --- @@ -138,50 +138,5 @@ public void testCastFrom

[GitHub] flink issue #2051: [FLINK-3779] Add support for queryable state

2016-07-25 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2051 @soniclavier I think this is not configurable in Flink at the moment. The client uses the `LeaderRetrievalService` to retrieve the job manager path. @soumyasd I hope to merge this after the 1.1

[jira] [Commented] (FLINK-3779) Add support for queryable state

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391756#comment-15391756 ] ASF GitHub Bot commented on FLINK-3779: --- Github user uce commented on the issue:

[GitHub] flink issue #2269: [FLINK-4190] Generalise RollingSink to work with arbitrar...

2016-07-25 Thread joshfg
Github user joshfg commented on the issue: https://github.com/apache/flink/pull/2269 Ah I see, that makes sense. I've began refactoring the tests here: https://github.com/joshfg/flink/blob/flink-4190/flink-streaming-connectors/flink-connector-filesystem/src/test/java/org/apache/fli

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391760#comment-15391760 ] ASF GitHub Bot commented on FLINK-4190: --- Github user joshfg commented on the issue:

[GitHub] flink issue #2269: [FLINK-4190] Generalise RollingSink to work with arbitrar...

2016-07-25 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2269 This is caused by `setInputType()` not being called on `SequenceFileWriter`. In the test, you can call `setInputType` on the `BucketingSink` once with the input `TypeInformation` and a `new Executi

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391765#comment-15391765 ] ASF GitHub Bot commented on FLINK-4190: --- Github user aljoscha commented on the issue

[GitHub] flink issue #2287: [hotfix] Prevent CheckpointCommitter from failing job

2016-07-25 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2287 This does in fact fix the problem. Running smoothly now. 😃 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[jira] [Created] (FLINK-4260) Allow SQL's LIKE ESCAPE

2016-07-25 Thread Timo Walther (JIRA)
Timo Walther created FLINK-4260: --- Summary: Allow SQL's LIKE ESCAPE Key: FLINK-4260 URL: https://issues.apache.org/jira/browse/FLINK-4260 Project: Flink Issue Type: Improvement Compone

[jira] [Updated] (FLINK-4260) Allow SQL's LIKE ESCAPE

2016-07-25 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-4260: Affects Version/s: 1.1.0 > Allow SQL's LIKE ESCAPE > --- > > Key

[jira] [Updated] (FLINK-4174) Enhance Window Evictor

2016-07-25 Thread vishnu viswanath (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vishnu viswanath updated FLINK-4174: Description: Enhance the current functionality of Evictor as per this [design document|http

[jira] [Updated] (FLINK-4260) Allow SQL's LIKE ESCAPE

2016-07-25 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-4260: Description: Currently, the SQL API does not support specifying an ESCAPE character in a LIKE expres

[GitHub] flink issue #2287: [hotfix] Prevent CheckpointCommitter from failing job

2016-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2287 That's great to hear, working on a test right now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] flink issue #2287: [hotfix] Prevent CheckpointCommitter from failing job

2016-07-25 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2287 Thanks! 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink pull request #2292: [FLINK-3891] [table] Add a class containing all su...

2016-07-25 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2292#discussion_r72052751 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/batch/table/CastingITCase.java --- @@ -138,50 +138,5 @@ public void testCastFro

[jira] [Commented] (FLINK-3891) Add a class containing all supported Table API types

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391789#comment-15391789 ] ASF GitHub Bot commented on FLINK-3891: --- Github user twalthr commented on a diff in

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2226 I've update the PR accordingly. The PR is now separated into 4 commits: 1. move all user-facing API into flink-metrics-core 2. move remaining metric classes out of flink-core (mos

[jira] [Commented] (FLINK-4192) Move Metrics API to separate module

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391796#comment-15391796 ] ASF GitHub Bot commented on FLINK-4192: --- Github user zentol commented on the issue:

[GitHub] flink issue #2287: [hotfix] Prevent CheckpointCommitter from failing job

2016-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2287 - added test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink issue #2287: [hotfix] Prevent CheckpointCommitter from failing job

2016-07-25 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2287 Test looks good! Please go ahead and merge if you're ready. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-4260) Allow SQL's LIKE ESCAPE

2016-07-25 Thread miaoever (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391839#comment-15391839 ] miaoever commented on FLINK-4260: - I am glad to work on this issue. > Allow SQL's LIKE ES

[GitHub] flink issue #2287: [hotfix] Prevent CheckpointCommitter from failing job

2016-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2287 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] flink pull request #2287: [hotfix] Prevent CheckpointCommitter from failing ...

2016-07-25 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/2287 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-4047) Fix documentation about determinism of KeySelectors

2016-07-25 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391840#comment-15391840 ] Greg Hogan commented on FLINK-4047: --- We should similarly document Field Expressions. >

[GitHub] flink issue #2269: [FLINK-4190] Generalise RollingSink to work with arbitrar...

2016-07-25 Thread joshfg
Github user joshfg commented on the issue: https://github.com/apache/flink/pull/2269 That works, thanks! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391842#comment-15391842 ] ASF GitHub Bot commented on FLINK-4190: --- Github user joshfg commented on the issue:

[jira] [Commented] (FLINK-4256) Fine-grained recovery

2016-07-25 Thread Wenlong Lyu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391849#comment-15391849 ] Wenlong Lyu commented on FLINK-4256: hi, Stephan, we have implemented similar solution

[jira] [Commented] (FLINK-4260) Allow SQL's LIKE ESCAPE

2016-07-25 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391851#comment-15391851 ] Timo Walther commented on FLINK-4260: - [~miaoever] that's great! I will assign the iss

[jira] [Assigned] (FLINK-4260) Allow SQL's LIKE ESCAPE

2016-07-25 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-4260: --- Assignee: Timo Walther > Allow SQL's LIKE ESCAPE > --- > >

[jira] [Updated] (FLINK-4260) Allow SQL's LIKE ESCAPE

2016-07-25 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-4260: Assignee: (was: Timo Walther) > Allow SQL's LIKE ESCAPE > --- > >

[jira] [Updated] (FLINK-4257) Handle delegating algorithm change of class

2016-07-25 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-4257: -- Description: A class created by {{ProxyFactory}} can intercept and reinterpret method calls using its {

[jira] [Updated] (FLINK-4260) Allow SQL's LIKE ESCAPE

2016-07-25 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-4260: Assignee: miaoever > Allow SQL's LIKE ESCAPE > --- > > Key: FLIN

[jira] [Commented] (FLINK-3901) Create a RowCsvInputFormat to use as default CSV IF in Table API

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391861#comment-15391861 ] ASF GitHub Bot commented on FLINK-3901: --- Github user twalthr commented on the issue:

[GitHub] flink issue #2283: [FLINK-3901] [table] Create a RowCsvInputFormat for Table...

2016-07-25 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2283 Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[jira] [Comment Edited] (FLINK-4256) Fine-grained recovery

2016-07-25 Thread Wenlong Lyu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391849#comment-15391849 ] Wenlong Lyu edited comment on FLINK-4256 at 7/25/16 1:14 PM: -

[GitHub] flink pull request #2256: [FLINK-4150] [runtime] Don't clean up BlobStore on...

2016-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2256 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-4150) Problem with Blobstore in Yarn HA setting on recovery after cluster shutdown

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391874#comment-15391874 ] ASF GitHub Bot commented on FLINK-4150: --- Github user asfgit closed the pull request

[jira] [Closed] (FLINK-4150) Problem with Blobstore in Yarn HA setting on recovery after cluster shutdown

2016-07-25 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi closed FLINK-4150. -- Resolution: Fixed Fixed in 3213016 (master). > Problem with Blobstore in Yarn HA setting on recovery af

[GitHub] flink pull request #2283: [FLINK-3901] [table] Create a RowCsvInputFormat fo...

2016-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2283 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-3901) Create a RowCsvInputFormat to use as default CSV IF in Table API

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391878#comment-15391878 ] ASF GitHub Bot commented on FLINK-3901: --- Github user asfgit closed the pull request

[jira] [Resolved] (FLINK-3901) Create a RowCsvInputFormat to use as default CSV IF in Table API

2016-07-25 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-3901. - Resolution: Fixed Fix Version/s: 1.1.0 Fixed in 2f9a28ae113f0e941b8bf3676ab84e1492fbf26f.

[GitHub] flink issue #2292: [FLINK-3891] [table] Add a class containing all supported...

2016-07-25 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2292 Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[jira] [Commented] (FLINK-3891) Add a class containing all supported Table API types

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391884#comment-15391884 ] ASF GitHub Bot commented on FLINK-3891: --- Github user twalthr commented on the issue:

[GitHub] flink pull request #2292: [FLINK-3891] [table] Add a class containing all su...

2016-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2292 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-3891) Add a class containing all supported Table API types

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391889#comment-15391889 ] ASF GitHub Bot commented on FLINK-3891: --- Github user asfgit closed the pull request

[jira] [Resolved] (FLINK-3891) Add a class containing all supported Table API types

2016-07-25 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-3891. - Resolution: Fixed Fix Version/s: 1.1.0 Fixed in b6f9308c9841db1e775358da50a8498409cde298.

[jira] [Commented] (FLINK-4244) Field names for union operator do not have to be equal

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391904#comment-15391904 ] ASF GitHub Bot commented on FLINK-4244: --- Github user twalthr commented on the issue:

[jira] [Commented] (FLINK-4239) Set Default Allowed Lateness to Zero and Make Triggers Non-Purging

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391911#comment-15391911 ] ASF GitHub Bot commented on FLINK-4239: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #2278: [FLINK-4239] Set Default Allowed Lateness to Zero ...

2016-07-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2278#discussion_r72065711 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/PurgingTrigger.java --- @@ -44,39 +44,36 @@ private PurgingTrigg

[GitHub] flink pull request #2278: [FLINK-4239] Set Default Allowed Lateness to Zero ...

2016-07-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2278#discussion_r72065755 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/PurgingTrigger.java --- @@ -44,39 +44,36 @@ private PurgingTrigg

[jira] [Commented] (FLINK-4239) Set Default Allowed Lateness to Zero and Make Triggers Non-Purging

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391912#comment-15391912 ] ASF GitHub Bot commented on FLINK-4239: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #2278: [FLINK-4239] Set Default Allowed Lateness to Zero ...

2016-07-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2278#discussion_r72065910 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/PurgingTrigger.java --- @@ -93,13 +90,12 @@ public boolean canMer

[jira] [Commented] (FLINK-4239) Set Default Allowed Lateness to Zero and Make Triggers Non-Purging

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391914#comment-15391914 ] ASF GitHub Bot commented on FLINK-4239: --- Github user kl0u commented on a diff in the

[jira] [Commented] (FLINK-4239) Set Default Allowed Lateness to Zero and Make Triggers Non-Purging

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391915#comment-15391915 ] ASF GitHub Bot commented on FLINK-4239: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #2278: [FLINK-4239] Set Default Allowed Lateness to Zero ...

2016-07-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2278#discussion_r72065896 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/PurgingTrigger.java --- @@ -44,39 +44,36 @@ private PurgingTrigg

[GitHub] flink pull request #2280: [FLINK-4244] [docs] Field names for union operator...

2016-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2280 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Resolved] (FLINK-4244) Field names for union operator do not have to be equal

2016-07-25 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-4244. - Resolution: Fixed Fix Version/s: 1.1.0 Fixed in 5888309470bf36a0c9011fe07d1a9c48368f.

[GitHub] flink issue #2277: [FLINK-4207] WindowOperator becomes very slow with allowe...

2016-07-25 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2277 This doesn't work for some cases. Consider, when you change `testCleanupTimerWithEmptyListStateForTumblingWindows()` to this: ``` @Test public void testCleanupTimerWithEmptyL

[GitHub] flink pull request #2277: [FLINK-4207] WindowOperator becomes very slow with...

2016-07-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2277#discussion_r72067210 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java --- @@ -408,11 +410,22 @@ public voi

[jira] [Commented] (FLINK-4207) WindowOperator becomes very slow with allowed lateness

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391927#comment-15391927 ] ASF GitHub Bot commented on FLINK-4207: --- Github user aljoscha commented on a diff in

[GitHub] flink issue #2278: [FLINK-4239] Set Default Allowed Lateness to Zero and Mak...

2016-07-25 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2278 Thanks for the review! The change you proposed really makes the code a lot nicer. 😃 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[jira] [Commented] (FLINK-4239) Set Default Allowed Lateness to Zero and Make Triggers Non-Purging

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391931#comment-15391931 ] ASF GitHub Bot commented on FLINK-4239: --- Github user aljoscha commented on the issue

[jira] [Commented] (FLINK-4244) Field names for union operator do not have to be equal

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391916#comment-15391916 ] ASF GitHub Bot commented on FLINK-4244: --- Github user asfgit closed the pull request

[GitHub] flink issue #2280: [FLINK-4244] [docs] Field names for union operator do not...

2016-07-25 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2280 Thanks @wuchong. Will merge... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] flink issue #2269: [FLINK-4190] Generalise RollingSink to work with arbitrar...

2016-07-25 Thread joshfg
Github user joshfg commented on the issue: https://github.com/apache/flink/pull/2269 Ok I've migrated `BucketingSinkITCase` and `BucketingSinkMultipleActiveBucketsCase` over to `BucketingSinkTest` using the test harness with `TimeServiceProvider`. I've left the two fault tolerance IT

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391934#comment-15391934 ] ASF GitHub Bot commented on FLINK-4190: --- Github user joshfg commented on the issue:

[GitHub] flink issue #2269: [FLINK-4190] Generalise RollingSink to work with arbitrar...

2016-07-25 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2269 Thanks for moving the tests! It should be ok to leave these other two ITCases. I'll merge the commits into one once I can find some time to look at the tests and merge it. --- If your pro

[jira] [Commented] (FLINK-4207) WindowOperator becomes very slow with allowed lateness

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391923#comment-15391923 ] ASF GitHub Bot commented on FLINK-4207: --- Github user aljoscha commented on the issue

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391952#comment-15391952 ] ASF GitHub Bot commented on FLINK-4190: --- Github user aljoscha commented on the issue

[jira] [Updated] (FLINK-4261) Setup atomic deployment of snapshots

2016-07-25 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-4261: -- External issue ID: (was: INFRA-12320) > Setup atomic deployment of snapshots > ---

[jira] [Commented] (FLINK-2980) Add CUBE/ROLLUP/GROUPING SETS operator in Table API.

2016-07-25 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391957#comment-15391957 ] Timo Walther commented on FLINK-2980: - [~chengxiang li] are you still wanna work on th

[jira] [Created] (FLINK-4261) Setup atomic deployment of snapshots

2016-07-25 Thread Maximilian Michels (JIRA)
Maximilian Michels created FLINK-4261: - Summary: Setup atomic deployment of snapshots Key: FLINK-4261 URL: https://issues.apache.org/jira/browse/FLINK-4261 Project: Flink Issue Type: Bug

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2226 I took this change from @StephanEwen branch; I don't _know_ why, but I'm assuming for the purpose of making `flink-metrics-core` truly independent. --- If your project is set up for it, you can reply

[jira] [Commented] (FLINK-4192) Move Metrics API to separate module

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391960#comment-15391960 ] ASF GitHub Bot commented on FLINK-4192: --- Github user zentol commented on the issue:

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-25 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2226 Why did you remove the `@PublicEvolving` annotations? I think technically they are not required since the code is not in the core or runtime package anymore but it's still a good hint for users that

[jira] [Commented] (FLINK-3904) GlobalConfiguration doesn't ensure config has been loaded

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391975#comment-15391975 ] ASF GitHub Bot commented on FLINK-3904: --- Github user uce commented on a diff in the

[jira] [Created] (FLINK-4262) Consider null handling during sorting

2016-07-25 Thread Timo Walther (JIRA)
Timo Walther created FLINK-4262: --- Summary: Consider null handling during sorting Key: FLINK-4262 URL: https://issues.apache.org/jira/browse/FLINK-4262 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-4192) Move Metrics API to separate module

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391946#comment-15391946 ] ASF GitHub Bot commented on FLINK-4192: --- Github user aljoscha commented on the issue

[jira] [Commented] (FLINK-3904) GlobalConfiguration doesn't ensure config has been loaded

2016-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391986#comment-15391986 ] ASF GitHub Bot commented on FLINK-3904: --- Github user uce commented on a diff in the

[GitHub] flink pull request #2123: [FLINK-3904] GlobalConfiguration doesn't ensure co...

2016-07-25 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2123#discussion_r72072774 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/GlobalConfiguration.java --- @@ -44,159 +35,62 @@ @Internal public final class Global

[GitHub] flink pull request #2123: [FLINK-3904] GlobalConfiguration doesn't ensure co...

2016-07-25 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2123#discussion_r72071650 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java --- @@ -84,12 +84,11 @@ */ private static int MAX_SA

[GitHub] flink pull request #2278: [FLINK-4239] Set Default Allowed Lateness to Zero ...

2016-07-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2278#discussion_r72073857 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java --- @@ -1409,7 +1409,7 @@ public voi

  1   2   >