[jira] [Resolved] (FLINK-4230) Session Windowing IT Case

2016-07-21 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek resolved FLINK-4230. - Resolution: Fixed Fix Version/s: 1.1.0 Added in https://github.com/apache/flink/co

[GitHub] flink issue #2263: [FLINK-4230] [DataStreamAPI] Add Session Windowing ITCase

2016-07-21 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2263 Thanks for your work! I merged it. Could you please close this PR if it isn't closed automatically. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[jira] [Commented] (FLINK-4230) Session Windowing IT Case

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387348#comment-15387348 ] ASF GitHub Bot commented on FLINK-4230: --- Github user aljoscha commented on the issue

[jira] [Commented] (FLINK-4230) Session Windowing IT Case

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387350#comment-15387350 ] ASF GitHub Bot commented on FLINK-4230: --- Github user StefanRRichter commented on the

[GitHub] flink issue #2263: [FLINK-4230] [DataStreamAPI] Add Session Windowing ITCase

2016-07-21 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/2263 Thanks Aljoscha, I will close it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[jira] [Commented] (FLINK-4230) Session Windowing IT Case

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387349#comment-15387349 ] ASF GitHub Bot commented on FLINK-4230: --- Github user StefanRRichter closed the pull

[GitHub] flink pull request #2263: [FLINK-4230] [DataStreamAPI] Add Session Windowing...

2016-07-21 Thread StefanRRichter
Github user StefanRRichter closed the pull request at: https://github.com/apache/flink/pull/2263 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (FLINK-4152) TaskManager registration exponential backoff doesn't work

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387353#comment-15387353 ] ASF GitHub Bot commented on FLINK-4152: --- Github user mxm commented on a diff in the

[GitHub] flink pull request #2257: [FLINK-4152] Allow re-registration of TMs at resou...

2016-07-21 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2257#discussion_r71664748 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/FlinkResourceManager.java --- @@ -113,7 +111,8 @@ /** The service to find

[jira] [Created] (FLINK-4239) Set Default Allowed Lateness to Zero and Make Triggers Non-Purging

2016-07-21 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-4239: --- Summary: Set Default Allowed Lateness to Zero and Make Triggers Non-Purging Key: FLINK-4239 URL: https://issues.apache.org/jira/browse/FLINK-4239 Project: Flink

[jira] [Commented] (FLINK-4152) TaskManager registration exponential backoff doesn't work

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387352#comment-15387352 ] ASF GitHub Bot commented on FLINK-4152: --- Github user mxm commented on a diff in the

[GitHub] flink pull request #2257: [FLINK-4152] Allow re-registration of TMs at resou...

2016-07-21 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2257#discussion_r71664833 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -405,36 +405,23 @@ class JobManager( currentR

[GitHub] flink pull request #2257: [FLINK-4152] Allow re-registration of TMs at resou...

2016-07-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2257#discussion_r71665307 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/FlinkResourceManager.java --- @@ -113,7 +111,8 @@ /** The servic

[jira] [Commented] (FLINK-4152) TaskManager registration exponential backoff doesn't work

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387357#comment-15387357 ] ASF GitHub Bot commented on FLINK-4152: --- Github user tillrohrmann commented on a dif

[jira] [Assigned] (FLINK-4203) Improve Table API documentation

2016-07-21 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-4203: --- Assignee: Timo Walther > Improve Table API documentation > --- >

[jira] [Commented] (FLINK-4236) Flink Dashboard stops showing list of uploaded jars if main method cannot be looked up

2016-07-21 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387371#comment-15387371 ] Gary Yao commented on FLINK-4236: - See http://mail-archives.apache.org/mod_mbox/flink-user

[jira] [Updated] (FLINK-4236) Flink Dashboard stops showing list of uploaded jars if main method cannot be looked up

2016-07-21 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-4236: -- Fix Version/s: 1.1.0 > Flink Dashboard stops showing list of uploaded jars if main metho

[jira] [Commented] (FLINK-4236) Flink Dashboard stops showing list of uploaded jars if main method cannot be looked up

2016-07-21 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387376#comment-15387376 ] Aljoscha Krettek commented on FLINK-4236: - This is a direct link to the discussion

[GitHub] flink issue #2273: [FLINK-4238] Only allow/require query for Tuple Stream in...

2016-07-21 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2273 Thanks for review! I moved the checks to the specific builders. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[jira] [Commented] (FLINK-4238) Only allow/require query for Tuple Stream in CassandraSink

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387422#comment-15387422 ] ASF GitHub Bot commented on FLINK-4238: --- Github user aljoscha commented on the issue

[jira] [Closed] (FLINK-4235) ClassLoaderITCase.testDisposeSavepointWithCustomKvState timed out on Travis

2016-07-21 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi closed FLINK-4235. -- Resolution: Fixed Fix Version/s: 1.1.0 Fixed in f81cda3 (master)... issue tag points to the dupli

[jira] [Commented] (FLINK-4201) Checkpoints for jobs in non-terminal state (e.g. suspended) get deleted

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387564#comment-15387564 ] ASF GitHub Bot commented on FLINK-4201: --- GitHub user uce opened a pull request:

[GitHub] flink pull request #2276: [FLINK-4201] [runtime] Forward suspend to checkpoi...

2016-07-21 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/2276 [FLINK-4201] [runtime] Forward suspend to checkpoint coordinator Suspended jobs were leading to shutdown of the checkpoint coordinator and hence removal of checkpoint state. For standalone recovery mode

[jira] [Commented] (FLINK-4239) Set Default Allowed Lateness to Zero and Make Triggers Non-Purging

2016-07-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387609#comment-15387609 ] Stephan Ewen commented on FLINK-4239: - +1, this sounds like a good default behavior >

[jira] [Commented] (FLINK-4236) Flink Dashboard stops showing list of uploaded jars if main method cannot be looked up

2016-07-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387610#comment-15387610 ] Stephan Ewen commented on FLINK-4236: - The handlers for those actions should catch tha

[jira] [Commented] (FLINK-4228) RocksDB semi-async snapshot to S3AFileSystem fails

2016-07-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387613#comment-15387613 ] Stephan Ewen commented on FLINK-4228: - +1 to make the fully asynchronous snapshots the

[GitHub] flink issue #2257: [FLINK-4152] Allow re-registration of TMs at resource man...

2016-07-21 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2257 Hi @mxm, I've added the changes to rename `registeredWorkers` into `startedWorkers` and in the same wake I renamed the `RegisterResource` message into a `NotifyResourceStarted` message which ref

[GitHub] flink issue #2275: FLINK-3929 Support for Kerberos Authentication with Keyta...

2016-07-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2275 Thanks for that big contribution. Could you explain the changes you made in more detail? What new parameters were introduced, how is the Keytab forwarded. How do components interact with

[jira] [Commented] (FLINK-4152) TaskManager registration exponential backoff doesn't work

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387616#comment-15387616 ] ASF GitHub Bot commented on FLINK-4152: --- Github user tillrohrmann commented on the i

[jira] [Commented] (FLINK-3929) Support for Kerberos Authentication with Keytab Credential

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387617#comment-15387617 ] ASF GitHub Bot commented on FLINK-3929: --- Github user StephanEwen commented on the is

[GitHub] flink issue #2275: FLINK-3929 Support for Kerberos Authentication with Keyta...

2016-07-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2275 One quick comment (without understanding the functionality of the code): We are trying to minimize external dependencies, especially to Guava (which has a lot of version conflicts). If you nee

[jira] [Commented] (FLINK-3929) Support for Kerberos Authentication with Keytab Credential

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387625#comment-15387625 ] ASF GitHub Bot commented on FLINK-3929: --- Github user StephanEwen commented on the is

[GitHub] flink pull request #2245: [hotfix] Fix Redis Sink to fail at opening if Redi...

2016-07-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2245#discussion_r71698908 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java --- @@ -103,15 +

[GitHub] flink pull request #2277: [FLINK-4207] WindowOperator becomes very slow with...

2016-07-21 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2277 [FLINK-4207] WindowOperator becomes very slow with allowed lateness Fixes the slowdown due to the allowedLateness. The problem was the deleteCleanupTimer that was called on cleanup() for each windo

[GitHub] flink pull request #2278: [FLINK-4239] Set Default Allowed Lateness to Zero ...

2016-07-21 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/2278 [FLINK-4239] Set Default Allowed Lateness to Zero and Make Triggers N… R: @kl0u for review You can merge this pull request into a Git repository by running: $ git pull https://github.com/alj

[jira] [Commented] (FLINK-4239) Set Default Allowed Lateness to Zero and Make Triggers Non-Purging

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387651#comment-15387651 ] ASF GitHub Bot commented on FLINK-4239: --- GitHub user aljoscha opened a pull request:

[jira] [Commented] (FLINK-4207) WindowOperator becomes very slow with allowed lateness

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387644#comment-15387644 ] ASF GitHub Bot commented on FLINK-4207: --- GitHub user kl0u opened a pull request:

[GitHub] flink pull request #2273: [FLINK-4238] Only allow/require query for Tuple St...

2016-07-21 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/2273 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2226 Having `MetricsConfig` extend `Properties` mitigates the issue to some extend. I know I am very adamant on not having an extra config object. It's because I heard it a bunch of times tha

[jira] [Commented] (FLINK-4238) Only allow/require query for Tuple Stream in CassandraSink

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387665#comment-15387665 ] ASF GitHub Bot commented on FLINK-4238: --- Github user aljoscha closed the pull reques

[jira] [Commented] (FLINK-4192) Move Metrics API to separate module

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387666#comment-15387666 ] ASF GitHub Bot commented on FLINK-4192: --- Github user StephanEwen commented on the is

[jira] [Resolved] (FLINK-4238) Only allow/require query for Tuple Stream in CassandraSink

2016-07-21 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek resolved FLINK-4238. - Resolution: Fixed Fix Version/s: 1.1.0 Fixed in https://github.com/apache/flink/co

[jira] [Created] (FLINK-4240) Cannot use expressions in Scala Table API's groupBy method

2016-07-21 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-4240: Summary: Cannot use expressions in Scala Table API's groupBy method Key: FLINK-4240 URL: https://issues.apache.org/jira/browse/FLINK-4240 Project: Flink Issu

[jira] [Created] (FLINK-4241) Cryptic expression parser exceptions

2016-07-21 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-4241: Summary: Cryptic expression parser exceptions Key: FLINK-4241 URL: https://issues.apache.org/jira/browse/FLINK-4241 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-4241) Cryptic expression parser exceptions

2016-07-21 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-4241: - Description: The exceptions thrown when giving wrong SQL syntax to Flink's SQL parser is very cry

[jira] [Commented] (FLINK-2392) Instable test in flink-yarn-tests

2016-07-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387677#comment-15387677 ] Stephan Ewen commented on FLINK-2392: - This issue has been resolved in 7f9580061177e81

[jira] [Resolved] (FLINK-2392) Instable test in flink-yarn-tests

2016-07-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-2392. - Resolution: Fixed Fix Version/s: (was: 1.0.0) 1.1.0 Fixed as part of

[jira] [Closed] (FLINK-2392) Instable test in flink-yarn-tests

2016-07-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-2392. --- > Instable test in flink-yarn-tests > - > > Key: FLINK-239

[GitHub] flink pull request #:

2016-07-21 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/commit/19dae21b00cfbf68ee64af80672d25974a3cd346#commitcomment-18339131 Quick question in this: Why don't we make the default behavior of the JMX reporter to not start an extra server, and only start

[jira] [Commented] (FLINK-4202) Add JM metric which shows the restart duration

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387697#comment-15387697 ] ASF GitHub Bot commented on FLINK-4202: --- Github user uce commented on a diff in the

[GitHub] flink pull request #2271: [FLINK-4202] Add restarting time JM metric

2016-07-21 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2271#discussion_r71705985 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphMetricsTest.java --- @@ -0,0 +1,321 @@ +/* + * Licensed to th

[jira] [Created] (FLINK-4242) Improve validation exception messages

2016-07-21 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-4242: Summary: Improve validation exception messages Key: FLINK-4242 URL: https://issues.apache.org/jira/browse/FLINK-4242 Project: Flink Issue Type: Improvement

[GitHub] flink pull request #:

2016-07-21 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/commit/19dae21b00cfbf68ee64af80672d25974a3cd346#commitcomment-18339338 That seems like a good idea, yes. Still not have the JMXReporter active by default or now have it active by default again? --- I

[GitHub] flink issue #2271: [FLINK-4202] Add restarting time JM metric

2016-07-21 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2271 +1 to merge. Tests and and comments are very good. I've tested this locally with a job with restarts and everything works as expected: ![screen shot 2016-07-21 at 15 47 34](https://cloud.githubu

[GitHub] flink issue #2276: [FLINK-4201] [runtime] Forward suspend to checkpoint coor...

2016-07-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2276 I think that change is good in "our" philosophy, just wondering about the following implication: Some people want to run HA setups without ZooKeeper, simply using an external service to

[jira] [Commented] (FLINK-4202) Add JM metric which shows the restart duration

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387718#comment-15387718 ] ASF GitHub Bot commented on FLINK-4202: --- Github user uce commented on the issue:

[jira] [Commented] (FLINK-3962) JMXReporter doesn't properly register/deregister metrics

2016-07-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387726#comment-15387726 ] Stephan Ewen commented on FLINK-3962: - This issue has been resolved by not throwing ex

[jira] [Closed] (FLINK-3962) JMXReporter doesn't properly register/deregister metrics

2016-07-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-3962. --- > JMXReporter doesn't properly register/deregister metrics > -

[jira] [Commented] (FLINK-4201) Checkpoints for jobs in non-terminal state (e.g. suspended) get deleted

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387721#comment-15387721 ] ASF GitHub Bot commented on FLINK-4201: --- Github user StephanEwen commented on the is

[jira] [Created] (FLINK-4243) Change "Scope" to "Namespace" for Metrics

2016-07-21 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-4243: --- Summary: Change "Scope" to "Namespace" for Metrics Key: FLINK-4243 URL: https://issues.apache.org/jira/browse/FLINK-4243 Project: Flink Issue Type: Improvement

[jira] [Resolved] (FLINK-3962) JMXReporter doesn't properly register/deregister metrics

2016-07-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-3962. - Resolution: Fixed > JMXReporter doesn't properly register/deregister metrics > ---

[jira] [Created] (FLINK-4244) Field names for union operator do not have to be equal

2016-07-21 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-4244: Summary: Field names for union operator do not have to be equal Key: FLINK-4244 URL: https://issues.apache.org/jira/browse/FLINK-4244 Project: Flink Issue Ty

[GitHub] flink pull request #2256: [FLINK-4150] [runtime] Don't clean up BlobStore on...

2016-07-21 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2256#discussion_r71711908 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerHARecoveryTest.java --- @@ -243,6 +256,268 @@ public void testJobRecoveryWhen

[jira] [Commented] (FLINK-4150) Problem with Blobstore in Yarn HA setting on recovery after cluster shutdown

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387744#comment-15387744 ] ASF GitHub Bot commented on FLINK-4150: --- Github user uce commented on a diff in the

[jira] [Commented] (FLINK-4150) Problem with Blobstore in Yarn HA setting on recovery after cluster shutdown

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387753#comment-15387753 ] ASF GitHub Bot commented on FLINK-4150: --- Github user uce commented on the issue:

[GitHub] flink pull request #:

2016-07-21 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/commit/19dae21b00cfbf68ee64af80672d25974a3cd346#commitcomment-18339788 Let's leave the remainder as it is for now, at least as long as we do not have the name collisions fully resolved. I am filing

[GitHub] flink issue #2271: [FLINK-4202] Add restarting time JM metric

2016-07-21 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2271 Thanks for the review @uce. Will merge this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink issue #2269: [FLINK-4190] Generalise RollingSink to work with arbitrar...

2016-07-21 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2269 Very good work! I know we discussed before whether to check for inactivity in a different thread or in `invoke()`. There's actually a third option that I'm showcasing in the PR I did agains

[GitHub] flink issue #2256: [FLINK-4150] [runtime] Don't clean up BlobStore on BlobSe...

2016-07-21 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2256 Thank you for your review. I've addressed your comment and now parent directories are deleted if empty, resulting in an empty storage folder after regular cleanup. If there are no objections, I would lik

[jira] [Commented] (FLINK-4202) Add JM metric which shows the restart duration

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387754#comment-15387754 ] ASF GitHub Bot commented on FLINK-4202: --- Github user tillrohrmann commented on the i

[GitHub] flink pull request #2271: [FLINK-4202] Add restarting time JM metric

2016-07-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2271 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Closed] (FLINK-4202) Add JM metric which shows the restart duration

2016-07-21 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-4202. Resolution: Done Added via 5dd85e2867a639e10891209dd59be0136a19ecfa > Add JM metric which shows the

[jira] [Commented] (FLINK-4202) Add JM metric which shows the restart duration

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387768#comment-15387768 ] ASF GitHub Bot commented on FLINK-4202: --- Github user asfgit closed the pull request

[jira] [Created] (FLINK-4245) Metric naming improvements

2016-07-21 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-4245: --- Summary: Metric naming improvements Key: FLINK-4245 URL: https://issues.apache.org/jira/browse/FLINK-4245 Project: Flink Issue Type: Improvement Re

[jira] [Commented] (FLINK-4245) Metric naming improvements

2016-07-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387772#comment-15387772 ] Stephan Ewen commented on FLINK-4245: - An added benefit of that would be that, regardl

[jira] [Comment Edited] (FLINK-4245) Metric naming improvements

2016-07-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387772#comment-15387772 ] Stephan Ewen edited comment on FLINK-4245 at 7/21/16 2:26 PM: --

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387767#comment-15387767 ] ASF GitHub Bot commented on FLINK-4190: --- Github user aljoscha commented on the issue

[GitHub] flink issue #2276: [FLINK-4201] [runtime] Forward suspend to checkpoint coor...

2016-07-21 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2276 Thanks for taking a look, Stephan. Regarding your question: *Would we interfere with such a setup when removing checkpoints on "suspend" in "standalone" mode?*: Yes, we would interfere,

[jira] [Commented] (FLINK-4201) Checkpoints for jobs in non-terminal state (e.g. suspended) get deleted

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387789#comment-15387789 ] ASF GitHub Bot commented on FLINK-4201: --- Github user uce commented on the issue:

[jira] [Commented] (FLINK-4201) Checkpoints for jobs in non-terminal state (e.g. suspended) get deleted

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387800#comment-15387800 ] ASF GitHub Bot commented on FLINK-4201: --- Github user StephanEwen commented on the is

[GitHub] flink pull request #2279: [FLINK-4229] Only start JMX server when port is sp...

2016-07-21 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/2279 [FLINK-4229] Only start JMX server when port is specified The JMX reporter now only starts an extra server if a port (or port range) was specified. Otherwise, it will just have the default local JM

[jira] [Commented] (FLINK-4229) Do not start Metrics Reporter by default

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387809#comment-15387809 ] ASF GitHub Bot commented on FLINK-4229: --- GitHub user aljoscha opened a pull request:

[GitHub] flink pull request #2279: [FLINK-4229] Only start JMX server when port is sp...

2016-07-21 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2279#discussion_r71720105 --- Diff: flink-core/src/test/java/org/apache/flink/metrics/reporter/JMXReporterTest.java --- @@ -88,7 +88,7 @@ public void testPortConflictHandling() th

[jira] [Commented] (FLINK-4229) Do not start Metrics Reporter by default

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387820#comment-15387820 ] ASF GitHub Bot commented on FLINK-4229: --- Github user StephanEwen commented on a diff

[jira] [Commented] (FLINK-4240) Cannot use expressions in Scala Table API's groupBy method

2016-07-21 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387824#comment-15387824 ] Jark Wu commented on FLINK-4240: It's not a bug I think as we cannot select a column not i

[GitHub] flink issue #2276: [FLINK-4201] [runtime] Forward suspend to checkpoint coor...

2016-07-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2276 I think as it is, it is fine. Let's extend the option for HA in a separate issue. We could have: - high-availability: *none* (what is currently *standalone recovery*) - high-av

[GitHub] flink pull request #2279: [FLINK-4229] Only start JMX server when port is sp...

2016-07-21 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2279#discussion_r71722866 --- Diff: flink-core/src/test/java/org/apache/flink/metrics/reporter/JMXReporterTest.java --- @@ -88,7 +88,7 @@ public void testPortConflictHandling() th

[GitHub] flink issue #2279: [FLINK-4229] Only start JMX server when port is specified

2016-07-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2279 Looks good, will merge this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[jira] [Commented] (FLINK-4229) Do not start Metrics Reporter by default

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387848#comment-15387848 ] ASF GitHub Bot commented on FLINK-4229: --- Github user StephanEwen commented on a diff

[jira] [Commented] (FLINK-4244) Field names for union operator do not have to be equal

2016-07-21 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387851#comment-15387851 ] Jark Wu commented on FLINK-4244: Yes, we just merged [FLINK-2985] , but not update the doc

[jira] [Commented] (FLINK-4229) Do not start Metrics Reporter by default

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387849#comment-15387849 ] ASF GitHub Bot commented on FLINK-4229: --- Github user StephanEwen commented on the is

[jira] [Created] (FLINK-4246) Allow Specifying Multiple Metrics Reporters

2016-07-21 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-4246: --- Summary: Allow Specifying Multiple Metrics Reporters Key: FLINK-4246 URL: https://issues.apache.org/jira/browse/FLINK-4246 Project: Flink Issue Type: I

[jira] [Commented] (FLINK-4152) TaskManager registration exponential backoff doesn't work

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387859#comment-15387859 ] ASF GitHub Bot commented on FLINK-4152: --- Github user mxm commented on the issue:

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2226 Will merge this, leaving the config as is. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[jira] [Commented] (FLINK-4192) Move Metrics API to separate module

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387865#comment-15387865 ] ASF GitHub Bot commented on FLINK-4192: --- Github user StephanEwen commented on the is

[jira] [Commented] (FLINK-4246) Allow Specifying Multiple Metrics Reporters

2016-07-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387867#comment-15387867 ] Stephan Ewen commented on FLINK-4246: - +1, I like this idea > Allow Specifying Multip

[GitHub] flink issue #2257: [FLINK-4152] Allow re-registration of TMs at resource man...

2016-07-21 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2257 Hi @tillrohrmann! Your changes look good. I would say this is good to merge once we have fixed the issue with the `YarnFlinkResourceManagerTest` on Travis. --- If your project is set up for it, you can

[GitHub] flink issue #1989: FLINK-3901 - Added CsvRowInputFormat

2016-07-21 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/1989 @fpompermaier I started working on this, but I can not guarantee that it will be part of the release. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-3901) Create a RowCsvInputFormat to use as default CSV IF in Table API

2016-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387892#comment-15387892 ] ASF GitHub Bot commented on FLINK-3901: --- Github user twalthr commented on the issue:

[jira] [Assigned] (FLINK-4244) Field names for union operator do not have to be equal

2016-07-21 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-4244: -- Assignee: Jark Wu > Field names for union operator do not have to be equal > --

  1   2   >