[
https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360501#comment-15360501
]
ramkrishna.s.vasudevan commented on FLINK-3674:
---
[~aljoscha]
I read thro the
Ufuk Celebi created FLINK-4145:
--
Summary: JmxReporterTest fails due to port conflicts
Key: FLINK-4145
URL: https://issues.apache.org/jira/browse/FLINK-4145
Project: Flink
Issue Type: Bug
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/2193
[FLINK-4145] [core] Configure port range for JMXReporterTest
I saw multiple failures of the JmxReporterTest most likely due to a port
conflicts. The test relies on the default JMX reporter port range, w
[
https://issues.apache.org/jira/browse/FLINK-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360554#comment-15360554
]
ASF GitHub Bot commented on FLINK-4145:
---
GitHub user uce opened a pull request:
Ufuk Celebi created FLINK-4146:
--
Summary: CliFrontendYarnAddressConfigurationTest picks wrong IP
address on Travis
Key: FLINK-4146
URL: https://issues.apache.org/jira/browse/FLINK-4146
Project: Flink
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/2194
[FLINK-4067] [runtime] Add savepoint headers
Savepoints were previously persisted without any meta data using default
Java serialization of a `CompletedCheckpoint`. This PR introduces a savepoint
class
[
https://issues.apache.org/jira/browse/FLINK-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360615#comment-15360615
]
ASF GitHub Bot commented on FLINK-4067:
---
GitHub user uce opened a pull request:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2193
the default port range is 9010-9025, that's 15 not 5 ports.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
[
https://issues.apache.org/jira/browse/FLINK-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360678#comment-15360678
]
ASF GitHub Bot commented on FLINK-4145:
---
Github user zentol commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360682#comment-15360682
]
ASF GitHub Bot commented on FLINK-4145:
---
Github user zentol commented on a diff in t
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2193#discussion_r69397170
--- Diff:
flink-core/src/test/java/org/apache/flink/metrics/reporter/JMXReporterTest.java
---
@@ -285,4 +289,23 @@ public long getMin() {
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2193
I would suggest using a random port range.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
[
https://issues.apache.org/jira/browse/FLINK-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360685#comment-15360685
]
ASF GitHub Bot commented on FLINK-4145:
---
Github user zentol commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360686#comment-15360686
]
Vladislav Pernin commented on FLINK-4145:
-
Wy not using something like :
{code}
[
https://issues.apache.org/jira/browse/FLINK-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360691#comment-15360691
]
Chesnay Schepler commented on FLINK-4145:
-
because it is prone to race conditions.
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2078#discussion_r69402729
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/typeutils/RowTypeInfo.scala
---
@@ -25,38 +25,25 @@ import
org.apache.flink.
[
https://issues.apache.org/jira/browse/FLINK-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360749#comment-15360749
]
ASF GitHub Bot commented on FLINK-2985:
---
Github user wuchong commented on a diff in
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r69407871
--- Diff: docs/apis/streaming/connectors/redis.md ---
@@ -0,0 +1,177 @@
+---
+title: "Redis Connector"
+
+# Sub-level navigation
+sub-nav-
[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360821#comment-15360821
]
ASF GitHub Bot commented on FLINK-3034:
---
Github user tzulitai commented on a diff in
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2078
Hi @gallenvara , I debug the `IndexOutOfBoundsException` exception of
`testJoinWithDisjunctivePred`, and find this line [L526 in
CodeGenerator](https://github.com/apache/flink/blob/master/flink-lib
[
https://issues.apache.org/jira/browse/FLINK-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360828#comment-15360828
]
ASF GitHub Bot commented on FLINK-2985:
---
Github user wuchong commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360835#comment-15360835
]
ASF GitHub Bot commented on FLINK-3034:
---
Github user tzulitai commented on a diff in
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r69408867
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,193 @@
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r69408897
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,193 @@
[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360838#comment-15360838
]
ASF GitHub Bot commented on FLINK-3034:
---
Github user tzulitai commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360842#comment-15360842
]
ASF GitHub Bot commented on FLINK-3034:
---
Github user tzulitai commented on a diff in
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r69409088
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisCommandsContainerBuild
[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360846#comment-15360846
]
ASF GitHub Bot commented on FLINK-3034:
---
Github user tzulitai commented on a diff in
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r69409336
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/config/FlinkJedisClusterConfig.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r69409744
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,193 @@
[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360854#comment-15360854
]
ASF GitHub Bot commented on FLINK-3034:
---
Github user tzulitai commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360861#comment-15360861
]
ASF GitHub Bot commented on FLINK-3034:
---
Github user tzulitai commented on a diff in
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r69410042
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/config/FlinkJedisConfigBase.java
---
[
https://issues.apache.org/jira/browse/FLINK-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360863#comment-15360863
]
Vladislav Pernin commented on FLINK-4145:
-
Without an os lock, yes, but more flexi
[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360868#comment-15360868
]
ASF GitHub Bot commented on FLINK-3034:
---
Github user tzulitai commented on a diff in
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r69410536
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/config/FlinkJedisConfigBase.java
---
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/1813
Hi @subhankarb,
Thank you for addressing our comments. I have some last nit-pick comments
to make the code just a little better, otherwise the changes LGTM :)
Perhaps we should also wait for
[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360878#comment-15360878
]
ASF GitHub Bot commented on FLINK-3034:
---
Github user tzulitai commented on the issue
Github user gallenvara commented on the issue:
https://github.com/apache/flink/pull/2078
Hi @wuchong , thanks a lot for your advice. With default fieldnames may
cause same content of `input1` and `input2` in `CodeGenerator`. Comparing the
`inputTerm` is a easy and effective way to avo
[
https://issues.apache.org/jira/browse/FLINK-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360898#comment-15360898
]
ASF GitHub Bot commented on FLINK-2985:
---
Github user gallenvara commented on the iss
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2078
Yes, you are right. Now this PR look good to me. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
[
https://issues.apache.org/jira/browse/FLINK-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360922#comment-15360922
]
ASF GitHub Bot commented on FLINK-2985:
---
Github user wuchong commented on the issue:
42 matches
Mail list logo
