[GitHub] flink issue #2152: [FLINK-3920] Distributed Linear Algebra: block-based matr...

2016-06-24 Thread chiwanpark
Github user chiwanpark commented on the issue: https://github.com/apache/flink/pull/2152 Thanks for opening pull request @chobeat! I would like to shepherd this PR. I'll review in weekend. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-3920) Distributed Linear Algebra: block-based matrix

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15347894#comment-15347894 ] ASF GitHub Bot commented on FLINK-3920: --- Github user chiwanpark commented on the iss

[jira] [Commented] (FLINK-3962) JMXReporter doesn't properly register/deregister metrics

2016-06-24 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348022#comment-15348022 ] Chesnay Schepler commented on FLINK-3962: - this can easily happen for streaming jo

[GitHub] flink issue #2105: [FLINK-4074] Make metric reporters less blocking

2016-06-24 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2105 @tillrohrmann Addressed all your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[jira] [Commented] (FLINK-4074) Reporter can block TaskManager shutdown

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348040#comment-15348040 ] ASF GitHub Bot commented on FLINK-4074: --- Github user zentol commented on the issue:

[jira] [Created] (FLINK-4116) Document metrics

2016-06-24 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-4116: --- Summary: Document metrics Key: FLINK-4116 URL: https://issues.apache.org/jira/browse/FLINK-4116 Project: Flink Issue Type: Improvement Compon

[GitHub] flink pull request #2158: [FLINK-4116] Metrics documentation

2016-06-24 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/2158 [FLINK-4116] Metrics documentation You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink metrics_docs Alternatively you can review and ap

[jira] [Commented] (FLINK-4116) Document metrics

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348094#comment-15348094 ] ASF GitHub Bot commented on FLINK-4116: --- GitHub user zentol opened a pull request:

[jira] [Updated] (FLINK-3834) flink-statebackend-rocksdb

2016-06-24 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-3834: Assignee: (was: Chesnay Schepler) > flink-statebackend-rocksdb > ---

[GitHub] flink issue #2131: [FLINK-3231][streaming-connectors] FlinkKinesisConsumer r...

2016-06-24 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2131 I'll review your change now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348158#comment-15348158 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on the issue

[GitHub] flink pull request #2071: [FLINK-4018][streaming-connectors] Configurable id...

2016-06-24 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2071#discussion_r68386857 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumerThread.java ---

[jira] [Commented] (FLINK-4018) Configurable idle time between getRecords requests to Kinesis shards

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348168#comment-15348168 ] ASF GitHub Bot commented on FLINK-4018: --- Github user rmetzger commented on a diff in

[GitHub] flink issue #2109: [FLINK-3677] FileInputFormat: Allow to specify include/ex...

2016-06-24 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2109 Hello @mushketyk and sorry for the late response. Great that you are working on that also for the Batch API! Recently we introduced in the Streaming API (not batch) the notion of continuou

[jira] [Commented] (FLINK-3677) FileInputFormat: Allow to specify include/exclude file name patterns

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348193#comment-15348193 ] ASF GitHub Bot commented on FLINK-3677: --- Github user kl0u commented on the issue:

[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-24 Thread wuchong
GitHub user wuchong opened a pull request: https://github.com/apache/flink/pull/2159 [FLINK-3942] [tableAPI] Add support for INTERSECT Internally, I translate INTERSECT into a Join on all fields and then a distinct for removing duplicate records. As Calcite SQL Parser does

[jira] [Commented] (FLINK-3942) Add support for INTERSECT

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348210#comment-15348210 ] ASF GitHub Bot commented on FLINK-3942: --- GitHub user wuchong opened a pull request:

[jira] [Commented] (FLINK-3942) Add support for INTERSECT

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348231#comment-15348231 ] ASF GitHub Bot commented on FLINK-3942: --- Github user mushketyk commented on the issu

[GitHub] flink issue #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-24 Thread mushketyk
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2159 I think you need to update documentation for this page: https://ci.apache.org/projects/flink/flink-docs-master/apis/table.html regarding newly added operations. --- If your project is set up for

[GitHub] flink pull request #2145: [FLINK-4087] [metrics] Improved JMX port handling

2016-06-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2145#discussion_r68396189 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java --- @@ -265,4 +329,72 @@ public Object getValue() {

[jira] [Commented] (FLINK-4087) JMXReporter can't handle port conflicts

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348243#comment-15348243 ] ASF GitHub Bot commented on FLINK-4087: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348255#comment-15348255 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-24 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68397478 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java ---

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-24 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68399389 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/IKinesisProxy.java --- @@ -0,

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-24 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68399467 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@ -122

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-24 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68399431 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@ -86,

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348274#comment-15348274 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on a diff in

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348279#comment-15348279 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-24 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68399454 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@ -122

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348281#comment-15348281 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on a diff in

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348280#comment-15348280 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on a diff in

[jira] [Commented] (FLINK-3397) Failed streaming jobs should fall back to the most recent checkpoint/savepoint

2016-06-24 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348283#comment-15348283 ] ramkrishna.s.vasudevan commented on FLINK-3397: --- I checked this JIRA and the

[jira] [Reopened] (FLINK-4075) ContinuousFileProcessingCheckpointITCase failed on Travis

2016-06-24 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas reopened FLINK-4075: --- It reappeared here: https://s3.amazonaws.com/archive.travis-ci.org/jobs/139523725/log.txt > Cont

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-24 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68400596 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/IKinesisProxy.java --- @@ -0,

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348293#comment-15348293 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-24 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68400657 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@ -122

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348295#comment-15348295 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-24 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68402254 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@ -159

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348310#comment-15348310 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-24 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68403594 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@ -86,

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348318#comment-15348318 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-24 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68403918 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@ -206

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348323#comment-15348323 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on a diff in

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348327#comment-15348327 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-24 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68404148 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@ -159

[GitHub] flink issue #2145: [FLINK-4087] [metrics] Improved JMX port handling

2016-06-24 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2145 @tillrohrmann I've addressed your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[jira] [Commented] (FLINK-4087) JMXReporter can't handle port conflicts

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348335#comment-15348335 ] ASF GitHub Bot commented on FLINK-4087: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-4113) Always copy first value in ChainedAllReduceDriver

2016-06-24 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348342#comment-15348342 ] Chesnay Schepler commented on FLINK-4113: - under which circumstances can this occu

[GitHub] flink pull request #2128: [FLINK-4053] Return value from Connection should b...

2016-06-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2128#discussion_r68406562 --- Diff: flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/common/Utils.java --- @@ -0,0 +1,47

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-24 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68406625 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java --- @

[jira] [Commented] (FLINK-4053) Return value from Connection should be checked against null

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348349#comment-15348349 ] ASF GitHub Bot commented on FLINK-4053: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348350#comment-15348350 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on a diff in

[jira] [Commented] (FLINK-4053) Return value from Connection should be checked against null

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348353#comment-15348353 ] ASF GitHub Bot commented on FLINK-4053: --- Github user mushketyk commented on the issu

[GitHub] flink pull request #2128: [FLINK-4053] Return value from Connection should b...

2016-06-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2128#discussion_r68406896 --- Diff: flink-streaming-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQSinkTest.java --- @@ -0,0

[GitHub] flink issue #2128: [FLINK-4053] Return value from Connection should be check...

2016-06-24 Thread mushketyk
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2128 I wanted to avoid this bit of duplication, but I have no strong preferences for that. Will remove this static method. --- If your project is set up for it, you can reply to this email and have you

[jira] [Commented] (FLINK-4053) Return value from Connection should be checked against null

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348354#comment-15348354 ] ASF GitHub Bot commented on FLINK-4053: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-4113) Always copy first value in ChainedAllReduceDriver

2016-06-24 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348356#comment-15348356 ] Greg Hogan commented on FLINK-4113: --- I experienced the problem when verifying the [HITS

[GitHub] flink pull request #2128: [FLINK-4053] Return value from Connection should b...

2016-06-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2128#discussion_r68408173 --- Diff: flink-streaming-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQSinkTest.java --- @@ -0,0

[jira] [Commented] (FLINK-4053) Return value from Connection should be checked against null

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348364#comment-15348364 ] ASF GitHub Bot commented on FLINK-4053: --- Github user zentol commented on a diff in t

[jira] [Created] (FLINK-4117) Wait for CuratorFramework connection to be established

2016-06-24 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-4117: - Summary: Wait for CuratorFramework connection to be established Key: FLINK-4117 URL: https://issues.apache.org/jira/browse/FLINK-4117 Project: Flink Issue Type: Bu

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-24 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68408986 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java ---

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348376#comment-15348376 ] ASF GitHub Bot commented on FLINK-3231: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-24 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68409331 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@ -159

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348383#comment-15348383 ] ASF GitHub Bot commented on FLINK-3231: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-24 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68409807 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java --- @

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-24 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68409932 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java --- @

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348387#comment-15348387 ] ASF GitHub Bot commented on FLINK-3231: --- Github user tzulitai commented on a diff in

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348386#comment-15348386 ] ASF GitHub Bot commented on FLINK-3231: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-24 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68410216 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java --- @

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348389#comment-15348389 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-24 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68411242 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java --- @

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348395#comment-15348395 ] ASF GitHub Bot commented on FLINK-3231: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-24 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68412025 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@ -206

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348404#comment-15348404 ] ASF GitHub Bot commented on FLINK-3231: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

2016-06-24 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r68412669 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java --

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348407#comment-15348407 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in th

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348412#comment-15348412 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-24 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68413466 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@ -206

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348419#comment-15348419 ] ASF GitHub Bot commented on FLINK-3231: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-24 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68414043 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@ -86,

[GitHub] flink issue #1813: [FLINK-3034] Redis Sink Connector

2016-06-24 Thread mjsax
Github user mjsax commented on the issue: https://github.com/apache/flink/pull/1813 Please address last comment. Otherwise, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348422#comment-15348422 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on the issue:

[jira] [Comment Edited] (FLINK-4098) Iteration support in Python API

2016-06-24 Thread Geoffrey Mon (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15347577#comment-15347577 ] Geoffrey Mon edited comment on FLINK-4098 at 6/24/16 3:34 PM: --

[GitHub] flink pull request #2071: [FLINK-4018][streaming-connectors] Configurable id...

2016-06-24 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2071#discussion_r68420387 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumerThread.java ---

[jira] [Commented] (FLINK-4018) Configurable idle time between getRecords requests to Kinesis shards

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348477#comment-15348477 ] ASF GitHub Bot commented on FLINK-4018: --- Github user tzulitai commented on a diff in

[GitHub] flink issue #2071: [FLINK-4018][streaming-connectors] Configurable idle time...

2016-06-24 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2071 Thank you for reviewing this @rmetzger. Should I address your comment after the rework in https://github.com/apache/flink/pull/2131 is merged, and rebase this PR on that? --- If your project is se

[jira] [Commented] (FLINK-4018) Configurable idle time between getRecords requests to Kinesis shards

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348482#comment-15348482 ] ASF GitHub Bot commented on FLINK-4018: --- Github user tzulitai commented on the issue

[GitHub] flink issue #2071: [FLINK-4018][streaming-connectors] Configurable idle time...

2016-06-24 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2071 Yes, I would suggest to do this PR after the big one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] flink issue #2131: [FLINK-3231][streaming-connectors] FlinkKinesisConsumer r...

2016-06-24 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2131 I'm not done with the review yet. I hope I find some time over the weekend to continue with it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[jira] [Commented] (FLINK-4018) Configurable idle time between getRecords requests to Kinesis shards

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348502#comment-15348502 ] ASF GitHub Bot commented on FLINK-4018: --- Github user rmetzger commented on the issue

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348503#comment-15348503 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on the issue

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348516#comment-15348516 ] ASF GitHub Bot commented on FLINK-3231: --- Github user tzulitai commented on the issue

[GitHub] flink issue #2131: [FLINK-3231][streaming-connectors] FlinkKinesisConsumer r...

2016-06-24 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2131 @rmetzger Thank you! No problem, I can wait and address the current comments meanwhile. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] flink issue #2131: [FLINK-3231][streaming-connectors] FlinkKinesisConsumer r...

2016-06-24 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2131 Okay, sounds good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348522#comment-15348522 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on the issue

[jira] [Commented] (FLINK-4098) Iteration support in Python API

2016-06-24 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348529#comment-15348529 ] Chesnay Schepler commented on FLINK-4098: - huh. As far as i can tell, every call t

[GitHub] flink pull request #2147: [FLINK-1946] reduce verbosity of Yarn cluster setu...

2016-06-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2147 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #2139: [FLINK-3838] Upgrade commons-cli to fix parsing of...

2016-06-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2139 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #2138: [FLINK-3757] clarify JavaDoc for addAccumulator me...

2016-06-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2138 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #2125: [FLINK-3864] Yarn tests don't check for prohibited...

2016-06-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2125 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

  1   2   >