[GitHub] flink pull request: [Discuss] Simplify SplittableIterator interfac...

2015-01-26 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/338#issuecomment-71595710 I think in the current state, this makes sense. I wrote the interface like it was, because it would enable implementations that does not compute/provide all sp

[GitHub] flink pull request: [FLINK-1352] [runtime] Fix buggy registration ...

2015-01-26 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/328#issuecomment-71596308 Looks good to me +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[jira] [Commented] (FLINK-1352) Buggy registration from TaskManager to JobManager

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293041#comment-14293041 ] ASF GitHub Bot commented on FLINK-1352: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-1328] Reworked semantic annotations

2015-01-26 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/311#issuecomment-71598228 +1 from my side --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[jira] [Commented] (FLINK-1328) Rework Constant Field Annotations

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293067#comment-14293067 ] ASF GitHub Bot commented on FLINK-1328: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-1330] [build] Build creates a link in t...

2015-01-26 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71598417 Okay, let's add an exclude for the linked target directory and update `basedir` to `project.basedir`. Will that do? --- If your project is set up for it, you can repl

[jira] [Commented] (FLINK-1330) Restructure directory layout

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293071#comment-14293071 ] ASF GitHub Bot commented on FLINK-1330: --- Github user StephanEwen commented on the pu

<    1   2   3