Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-06-10 Thread via GitHub
dannycranmer merged PR #24839: URL: https://github.com/apache/flink/pull/24839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-06-06 Thread via GitHub
jeyhunkarimov commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1629840434 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterTimeoutTest.java: ## @@ -0,0 +1,200 @@ +/* + * L

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-06-06 Thread via GitHub
vahmed-hamdy commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1629436707 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java: ## @@ -533,4 +607,77 @@ private int getNex

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-06-06 Thread via GitHub
vahmed-hamdy commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1629436707 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java: ## @@ -533,4 +607,77 @@ private int getNex

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-06-05 Thread via GitHub
liuml07 commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1628815201 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java: ## @@ -533,4 +607,77 @@ private int getNextBatc

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-06-04 Thread via GitHub
vahmed-hamdy commented on PR #24839: URL: https://github.com/apache/flink/pull/24839#issuecomment-2147156792 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-26 Thread via GitHub
vahmed-hamdy commented on PR #24839: URL: https://github.com/apache/flink/pull/24839#issuecomment-2132249502 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-26 Thread via GitHub
vahmed-hamdy commented on PR #24839: URL: https://github.com/apache/flink/pull/24839#issuecomment-2132141416 @dannycranmer thanks for the review, Could you have another pass? The CI is failing due to a bug in Architecture tests FLINK-35454, Could you take a look at this [PR](htt

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-25 Thread via GitHub
vahmed-hamdy commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1614911177 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterTimeoutTest.java: ## @@ -0,0 +1,200 @@ +/* + * Li

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-25 Thread via GitHub
vahmed-hamdy commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1614911032 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterTimeoutTest.java: ## @@ -0,0 +1,200 @@ +/* + * Li

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-25 Thread via GitHub
vahmed-hamdy commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1614910580 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterTimeoutTest.java: ## @@ -0,0 +1,200 @@ +/* + * Li

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-25 Thread via GitHub
vahmed-hamdy commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1614908849 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterTimeoutTest.java: ## @@ -0,0 +1,200 @@ +/* + * Li

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-25 Thread via GitHub
vahmed-hamdy commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1614909440 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterTimeoutTest.java: ## @@ -0,0 +1,200 @@ +/* + * Li

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-25 Thread via GitHub
vahmed-hamdy commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1614907240 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBase.java: ## @@ -54,6 +54,8 @@ public abstract class AsyncSin

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-25 Thread via GitHub
vahmed-hamdy commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1614905336 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java: ## @@ -533,4 +607,77 @@ private int getNex

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-25 Thread via GitHub
vahmed-hamdy commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1614904850 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java: ## @@ -533,4 +607,77 @@ private int getNex

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-25 Thread via GitHub
vahmed-hamdy commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1614903605 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBase.java: ## @@ -73,6 +97,8 @@ protected AsyncSinkBase(

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-25 Thread via GitHub
jeyhunkarimov commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1614421157 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java: ## @@ -181,15 +187,88 @@ public abstract

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-24 Thread via GitHub
dannycranmer commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1613883830 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBase.java: ## @@ -54,6 +54,8 @@ public abstract class AsyncSin

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-24 Thread via GitHub
flinkbot commented on PR #24839: URL: https://github.com/apache/flink/pull/24839#issuecomment-2129354320 ## CI report: * 2b91a9c92af7d97d492a9c83d43d7c544f85d355 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`