Re: [PR] [FLINK-35019] support convert show create model sql to operation [flink]

2025-05-13 Thread via GitHub
fsk119 merged PR #26528: URL: https://github.com/apache/flink/pull/26528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-35019] support convert show create model sql to operation [flink]

2025-05-12 Thread via GitHub
lihaosky commented on code in PR #26528: URL: https://github.com/apache/flink/pull/26528#discussion_r2085179230 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ShowCreateUtil.java: ## @@ -177,6 +206,17 @@ static String extractFormattedColum

Re: [PR] [FLINK-35019] support convert show create model sql to operation [flink]

2025-05-11 Thread via GitHub
fsk119 commented on code in PR #26528: URL: https://github.com/apache/flink/pull/26528#discussion_r2083722961 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ShowCreateUtil.java: ## @@ -177,6 +206,17 @@ static String extractFormattedColumns

Re: [PR] [FLINK-35019] support convert show create model sql to operation [flink]

2025-05-11 Thread via GitHub
fsk119 commented on code in PR #26528: URL: https://github.com/apache/flink/pull/26528#discussion_r2083710337 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ShowCreateUtil.java: ## @@ -130,6 +150,15 @@ static String buildCreateFormattedPref

Re: [PR] [FLINK-35019] support convert show create model sql to operation [flink]

2025-05-07 Thread via GitHub
lihaosky commented on code in PR #26528: URL: https://github.com/apache/flink/pull/26528#discussion_r2078311124 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala: ## @@ -2957,6 +2957,177 @@ class TableEnvironmentTest { c

Re: [PR] [FLINK-35019] support convert show create model sql to operation [flink]

2025-05-07 Thread via GitHub
davidradl commented on code in PR #26528: URL: https://github.com/apache/flink/pull/26528#discussion_r2077909232 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlNodeConverters.java: ## @@ -53,6 +53,7 @@ public class SqlNod

Re: [PR] [FLINK-35019] support convert show create model sql to operation [flink]

2025-05-07 Thread via GitHub
davidradl commented on code in PR #26528: URL: https://github.com/apache/flink/pull/26528#discussion_r2077909232 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlNodeConverters.java: ## @@ -53,6 +53,7 @@ public class SqlNod

Re: [PR] [FLINK-35019] support convert show create model sql to operation [flink]

2025-05-07 Thread via GitHub
lihaosky commented on code in PR #26528: URL: https://github.com/apache/flink/pull/26528#discussion_r2077932178 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlNodeConverters.java: ## @@ -53,6 +53,7 @@ public class SqlNode

Re: [PR] [FLINK-35019] support convert show create model sql to operation [flink]

2025-05-07 Thread via GitHub
davidradl commented on code in PR #26528: URL: https://github.com/apache/flink/pull/26528#discussion_r2077928618 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala: ## @@ -2957,6 +2957,136 @@ class TableEnvironmentTest {

Re: [PR] [FLINK-35019] support convert show create model sql to operation [flink]

2025-05-05 Thread via GitHub
flinkbot commented on PR #26528: URL: https://github.com/apache/flink/pull/26528#issuecomment-2852726466 ## CI report: * 5f2ba2d3bb1be6a85d09a4bb39bfb208837cc4d4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`