Samrat002 commented on code in PR #206:
URL:
https://github.com/apache/flink-connector-aws/pull/206#discussion_r2253099353
##
flink-catalog-aws/flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/GlueCatalog.java:
##
@@ -0,0 +1,935 @@
+/*
+ * Licensed to th
Samrat002 commented on PR #206:
URL:
https://github.com/apache/flink-connector-aws/pull/206#issuecomment-2948650989
Thanks for incorporating the changes. I will review the pr in next couple of
days .
--
This is an automated message from the Apache Git Service.
To respond to the message,
FranMorilloAWS commented on PR #206:
URL:
https://github.com/apache/flink-connector-aws/pull/206#issuecomment-2935805209
> Thanks for the contribution. A few points to note:
>
> It looks like most of the code has already been reviewed across multiple
PRs.
>
> Concerns:
>
nicusX commented on PR #206:
URL:
https://github.com/apache/flink-connector-aws/pull/206#issuecomment-2915317163
@Samrat002 @FranMorilloAWS about case sensitivity, these are the logical
rules I suggest:
1. the actual case should preserved for **all supported objects** and used
consi
nicusX commented on code in PR #206:
URL:
https://github.com/apache/flink-connector-aws/pull/206#discussion_r2109663034
##
flink-catalog-aws/flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/GlueCatalog.java:
##
@@ -0,0 +1,935 @@
+/*
+ * Licensed to the A
leekeiabstraction commented on code in PR #206:
URL:
https://github.com/apache/flink-connector-aws/pull/206#discussion_r2095889230
##
flink-catalog-aws/flink-catalog-aws-glue/README.md:
##
@@ -0,0 +1,358 @@
+# Flink AWS Glue Catalog Connector
+
+The Flink AWS Glue Catalog conne
Samrat002 commented on PR #206:
URL:
https://github.com/apache/flink-connector-aws/pull/206#issuecomment-2886038191
> Hey Samrat. How could we encapsulate this specific issues? From user
perspective we are already limiting them creating tables and databases with
uppercase. In regards of th
Samrat002 commented on code in PR #206:
URL:
https://github.com/apache/flink-connector-aws/pull/206#discussion_r2086618120
##
flink-catalog-aws/flink-catalog-aws-glue/.idea/.gitignore:
##
@@ -0,0 +1,10 @@
+# Default ignored files
Review Comment:
Is this file required ?
#
FranMorilloAWS closed pull request #191: [FLINK-29549]- Flink Glue Catalog
integration
URL: https://github.com/apache/flink-connector-aws/pull/191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
FranMorilloAWS commented on PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#issuecomment-2831287953
@Samrat002 Considering that glue will lower case all databases, we shouldnt
allow users to create databases with uppercase, therefore if they try to do
show Create datab
Samrat002 commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2055238321
##
flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/operations/GlueDatabaseOperations.java:
##
@@ -0,0 +1,240 @@
+/*
+ * Licensed t
FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2052347317
##
flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/GlueCatalog.java:
##
@@ -0,0 +1,925 @@
+/*
+ * Licensed to the Apache Soft
FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2052295570
##
flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/operations/GlueTableOperations.java:
##
@@ -0,0 +1,255 @@
+/*
+ * Licensed
FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2052228672
##
flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/GlueCatalog.java:
##
@@ -0,0 +1,925 @@
+/*
+ * Licensed to the Apache Soft
FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2052176250
##
flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/operations/GlueDatabaseOperations.java:
##
@@ -0,0 +1,240 @@
+/*
+ * Licen
FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2052171687
##
flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/util/GlueTypeConverter.java:
##
@@ -0,0 +1,311 @@
+/*
+ * Licensed to the
FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2049064887
##
flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/operations/GlueDatabaseOperations.java:
##
@@ -0,0 +1,192 @@
+/*
+ * Licen
FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2048683923
##
flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/GlueCatalogFactory.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apach
FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2048936077
##
flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/StreamingJob.java:
##
@@ -0,0 +1,306 @@
+/*
+ * Licensed to the Apache Sof
FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2049063624
##
flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/operations/GlueTableOperations.java:
##
@@ -0,0 +1,208 @@
+/*
+ * Licensed
FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2048929683
##
flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/GlueCatalogFactory.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apach
FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2048935634
##
flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/GlueCatalogFactory.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apach
FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2048952219
##
flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/GlueCatalogFactory.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apach
FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2048924692
##
flink-catalog-aws-glue/README.md:
##
@@ -0,0 +1,377 @@
+# Flink AWS Glue Catalog Connector
+
+The Flink AWS Glue Catalog connector provides integra
FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2048940798
##
flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/operations/GlueDatabaseOperations.java:
##
@@ -0,0 +1,192 @@
+/*
+ * Licen
FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2048952907
##
flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/operations/GlueDatabaseOperations.java:
##
@@ -0,0 +1,192 @@
+/*
+ * Licen
FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2048925573
##
flink-catalog-aws-glue/README.md:
##
@@ -0,0 +1,377 @@
+# Flink AWS Glue Catalog Connector
+
+The Flink AWS Glue Catalog connector provides integra
FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2048945859
##
flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/operations/GlueFunctionsOperations.java:
##
@@ -0,0 +1,277 @@
+/*
+ * Lice
FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2048974130
##
flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/util/GlueTypeConverter.java:
##
@@ -0,0 +1,298 @@
+/*
+ * Licensed to the
FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2048927505
##
flink-catalog-aws-glue/README.md:
##
@@ -0,0 +1,377 @@
+# Flink AWS Glue Catalog Connector
+
+The Flink AWS Glue Catalog connector provides integra
FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2048928553
##
flink-catalog-aws-glue/pom.xml:
##
@@ -0,0 +1,200 @@
+
+
+http://www.w3.org/2001/XMLSchema-instance";
+ xmlns="http://maven.apache.org/POM/
FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2048928245
##
flink-catalog-aws-glue/pom.xml:
##
@@ -0,0 +1,200 @@
+
+
+http://www.w3.org/2001/XMLSchema-instance";
+ xmlns="http://maven.apache.org/POM/
Samrat002 commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2045157187
##
flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/GlueCatalogFactory.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Sof
hlteoh37 commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2044486912
##
flink-catalog-aws-glue/README.md:
##
@@ -0,0 +1,377 @@
+# Flink AWS Glue Catalog Connector
+
+The Flink AWS Glue Catalog connector provides integration b
FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2034866646
##
flink-catalog-aws-glue/src/main/java/com/amazonaws/services/msf/GlueCatalogFactory.java:
##
@@ -0,0 +1,66 @@
+package com.amazonaws.services.msf;
+
FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2034972205
##
flink-catalog-aws-glue/src/main/java/com/amazonaws/services/msf/util/ConnectorRegistry.java:
##
@@ -0,0 +1,53 @@
+package com.amazonaws.services.ms
leekeiabstraction commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2033639231
##
flink-catalog-aws-glue/README.md:
##
@@ -0,0 +1,389 @@
+# Flink AWS Glue Catalog Connector
+
+The Flink AWS Glue Catalog connector provides inte
boring-cyborg[bot] commented on PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#issuecomment-2693884736
Thanks for opening this pull request! Please check out our contributing
guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is a
38 matches
Mail list logo
