Re: [PR] [FLINK-17224][table] Support precision for TIME [flink]

2025-04-05 Thread via GitHub
github-actions[bot] closed pull request #22775: [FLINK-17224][table] Support precision for TIME URL: https://github.com/apache/flink/pull/22775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [FLINK-17224][table] Support precision for TIME [flink]

2025-04-03 Thread via GitHub
github-actions[bot] commented on PR #22775: URL: https://github.com/apache/flink/pull/22775#issuecomment-2774618880 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

Re: [PR] [FLINK-17224][table] Support precision for TIME [flink]

2025-01-16 Thread via GitHub
github-actions[bot] commented on PR #22775: URL: https://github.com/apache/flink/pull/22775#issuecomment-2595359595 This PR is being marked as stale since it has not had any activity in the last 180 days. If you would like to keep this PR alive, please leave a comment asking for a revie

Re: [PR] [FLINK-17224][table] Support precision for TIME [flink]

2024-06-17 Thread via GitHub
snuyanzin commented on PR #22775: URL: https://github.com/apache/flink/pull/22775#issuecomment-2172858716 Thanks for your feedback >Could we change sth so that we don't lose data when a precision >3 is used? Could we throw an exception somewhere explicitly? This seems a questionabl

Re: [PR] [FLINK-17224][table] Support precision for TIME [flink]

2024-06-17 Thread via GitHub
snuyanzin commented on code in PR #22775: URL: https://github.com/apache/flink/pull/22775#discussion_r1642482796 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java: ## @@ -1038,9 +1112,9 @@ private static List toStri

Re: [PR] [FLINK-17224][table] Support precision for TIME [flink]

2024-06-17 Thread via GitHub
snuyanzin commented on PR #22775: URL: https://github.com/apache/flink/pull/22775#issuecomment-2172834841 Rebased to solve the conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [FLINK-17224][table] Support precision for TIME [flink]

2024-06-05 Thread via GitHub
dawidwys commented on code in PR #22775: URL: https://github.com/apache/flink/pull/22775#discussion_r1627434353 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java: ## @@ -763,6 +763,68 @@ private static List allTypes