[jira] [Commented] (FLINK-7398) Table API operators/UDFs must not store Logger

2017-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146024#comment-16146024 ] ASF GitHub Bot commented on FLINK-7398: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-7398) Table API operators/UDFs must not store Logger

2017-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145393#comment-16145393 ] ASF GitHub Bot commented on FLINK-7398: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-7398) Table API operators/UDFs must not store Logger

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139145#comment-16139145 ] ASF GitHub Bot commented on FLINK-7398: --- GitHub user haohui opened a pull request:

[jira] [Commented] (FLINK-7398) Table API operators/UDFs must not store Logger

2017-08-22 Thread Jacob Park (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137250#comment-16137250 ] Jacob Park commented on FLINK-7398: --- +1 for the checkstyle rule. > Table API operators/

[jira] [Commented] (FLINK-7398) Table API operators/UDFs must not store Logger

2017-08-21 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136280#comment-16136280 ] Haohui Mai commented on FLINK-7398: --- +1 on logging trait. I'll submit a PR. Adding a ch

[jira] [Commented] (FLINK-7398) Table API operators/UDFs must not store Logger

2017-08-21 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136140#comment-16136140 ] Jark Wu commented on FLINK-7398: +1 Logging trait. BTW, I think to avoid the misusage of

[jira] [Commented] (FLINK-7398) Table API operators/UDFs must not store Logger

2017-08-10 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121753#comment-16121753 ] Fabian Hueske commented on FLINK-7398: -- +1 [~jark], if we decide to port the runtime

[jira] [Commented] (FLINK-7398) Table API operators/UDFs must not store Logger

2017-08-10 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121545#comment-16121545 ] Jark Wu commented on FLINK-7398: Porting to Java is not related to this issue. I have the

[jira] [Commented] (FLINK-7398) Table API operators/UDFs must not store Logger

2017-08-10 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121265#comment-16121265 ] Haohui Mai commented on FLINK-7398: --- Putting in a companion object is an viable option.

[jira] [Commented] (FLINK-7398) Table API operators/UDFs must not store Logger

2017-08-10 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121259#comment-16121259 ] Aljoscha Krettek commented on FLINK-7398: - I agree with both [~fhueske] and [~jark

[jira] [Commented] (FLINK-7398) Table API operators/UDFs must not store Logger

2017-08-10 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121234#comment-16121234 ] Fabian Hueske commented on FLINK-7398: -- In Scala you can make the field {{transient}}

[jira] [Commented] (FLINK-7398) Table API operators/UDFs must not store Logger

2017-08-10 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121219#comment-16121219 ] Jark Wu commented on FLINK-7398: [~fhueske] in Java, we will set the Logger as static fina

[jira] [Commented] (FLINK-7398) Table API operators/UDFs must not store Logger

2017-08-10 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121204#comment-16121204 ] Fabian Hueske commented on FLINK-7398: -- This issue would happen with Java as well. It

[jira] [Commented] (FLINK-7398) Table API operators/UDFs must not store Logger

2017-08-09 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120928#comment-16120928 ] Jark Wu commented on FLINK-7398: [~wheat9] how do you want to fix it? > Table API operat

[jira] [Commented] (FLINK-7398) Table API operators/UDFs must not store Logger

2017-08-09 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120536#comment-16120536 ] Haohui Mai commented on FLINK-7398: --- Good catch! I think we can fix it for once but I'm