[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319532#comment-16319532 ] ASF GitHub Bot commented on FLINK-5982: --- Github user tony810430 commented on the iss

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318879#comment-16318879 ] ASF GitHub Bot commented on FLINK-5982: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318396#comment-16318396 ] ASF GitHub Bot commented on FLINK-5982: --- Github user StephanEwen commented on the is

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196607#comment-16196607 ] ASF GitHub Bot commented on FLINK-5982: --- Github user tony810430 commented on the iss

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087333#comment-16087333 ] ASF GitHub Bot commented on FLINK-5982: --- Github user StephanEwen commented on the is

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077956#comment-16077956 ] ASF GitHub Bot commented on FLINK-5982: --- Github user tony810430 commented on the iss

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16013259#comment-16013259 ] ASF GitHub Bot commented on FLINK-5982: --- Github user tony810430 commented on the iss

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012419#comment-16012419 ] ASF GitHub Bot commented on FLINK-5982: --- Github user StephanEwen commented on the is

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011984#comment-16011984 ] ASF GitHub Bot commented on FLINK-5982: --- Github user tony810430 commented on the iss

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15947032#comment-15947032 ] ASF GitHub Bot commented on FLINK-5982: --- Github user StephanEwen commented on the is

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946503#comment-15946503 ] ASF GitHub Bot commented on FLINK-5982: --- Github user tony810430 commented on the iss

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945578#comment-15945578 ] ASF GitHub Bot commented on FLINK-5982: --- Github user StephanEwen commented on the is

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945161#comment-15945161 ] ASF GitHub Bot commented on FLINK-5982: --- GitHub user tony810430 opened a pull reques

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945074#comment-15945074 ] Till Rohrmann commented on FLINK-5982: -- Alright, this sounds good to me :-) > Refact

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943360#comment-15943360 ] Wei-Che Wei commented on FLINK-5982: Hi [~till.rohrmann], I prefer not to pass only {

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943286#comment-15943286 ] Stephan Ewen commented on FLINK-5982: - I think that is actually simpler to shoot yours

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943273#comment-15943273 ] Till Rohrmann commented on FLINK-5982: -- True, we can also throw an {{IllegalStateExce

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943028#comment-15943028 ] Stephan Ewen commented on FLINK-5982: - [~till.rohrmann] Why not throw an illegal state

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942972#comment-15942972 ] Wei-Che Wei commented on FLINK-5982: Hi [~till.rohrmann] Ok, I see. Thanks for your s

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942957#comment-15942957 ] Till Rohrmann commented on FLINK-5982: -- Hi [~tonywei], one of the ideas for the refa

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15939521#comment-15939521 ] Wei-Che Wei commented on FLINK-5982: Hi [~till.rohrmann] Thanks for your replying. Fo

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938422#comment-15938422 ] Till Rohrmann commented on FLINK-5982: -- Hi [~tonywei], I think you should check in t

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906135#comment-15906135 ] Wei-Che Wei commented on FLINK-5982: I see. I will just focus on refactoring {{setEnvi

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902789#comment-15902789 ] Stephan Ewen commented on FLINK-5982: - The description is good, please go ahead with t

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901331#comment-15901331 ] Wei-Che Wei commented on FLINK-5982: [~StephanEwen], [~till.rohrmann] Have updated the

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901309#comment-15901309 ] Wei-Che Wei commented on FLINK-5982: If handling recovery state on {{BatchTask}} is ne

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901289#comment-15901289 ] Stephan Ewen commented on FLINK-5982: - I am personally for dropping the distinction be

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15899574#comment-15899574 ] Till Rohrmann commented on FLINK-5982: -- +1 for the proposed changes :-) > Refactor A

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15899368#comment-15899368 ] Wei-Che Wei commented on FLINK-5982: FYI [~StephanEwen], [~till.rohrmann] Please let