[jira] [Commented] (FLINK-21738) reduce unnecessary method calls in ModuleManager

2021-03-12 Thread zoucao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300239#comment-17300239 ] zoucao commented on FLINK-21738: Hi [~qingyue], thanks for your advice(y), I found this

[jira] [Commented] (FLINK-21738) reduce unnecessary method calls in ModuleManager

2021-03-11 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300099#comment-17300099 ] Jark Wu commented on FLINK-21738: - yes. It is called 6 times, because the planner doesn'

[jira] [Commented] (FLINK-21738) reduce unnecessary method calls in ModuleManager

2021-03-11 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300097#comment-17300097 ] Jane Chan commented on FLINK-21738: --- Hi [~zoucao], I guess using the `json_tuple` late

[jira] [Commented] (FLINK-21738) reduce unnecessary method calls in ModuleManager

2021-03-11 Thread zoucao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300058#comment-17300058 ] zoucao commented on FLINK-21738: hi [~qingyue] and [~jark], thanks for your quick reply,

[jira] [Commented] (FLINK-21738) reduce unnecessary method calls in ModuleManager

2021-03-11 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300033#comment-17300033 ] Jark Wu commented on FLINK-21738: - I think it's a good idea to support caching. But the

[jira] [Commented] (FLINK-21738) reduce unnecessary method calls in ModuleManager

2021-03-11 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299988#comment-17299988 ] Jane Chan commented on FLINK-21738: --- Hi [~zoucao], thanks for bringing out this issue.