Re: [PR] Support config yaml [flink-kubernetes-operator]

2025-04-28 Thread via GitHub
gyfora merged PR #848: URL: https://github.com/apache/flink-kubernetes-operator/pull/848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] Support config yaml [flink-kubernetes-operator]

2025-04-08 Thread via GitHub
ctrlaltdilj commented on code in PR #848: URL: https://github.com/apache/flink-kubernetes-operator/pull/848#discussion_r2033998975 ## helm/flink-kubernetes-operator/values.yaml: ## @@ -154,6 +154,9 @@ defaultConfiguration: # If set to false, loads just the overrides as in (2

Re: [PR] Support config yaml [flink-kubernetes-operator]

2025-04-06 Thread via GitHub
ctrlaltdilj commented on code in PR #848: URL: https://github.com/apache/flink-kubernetes-operator/pull/848#discussion_r2030254823 ## e2e-tests/test_dynamic_flink_conf.sh: ## @@ -0,0 +1,40 @@ +#!/usr/bin/env bash +

Re: [PR] Support config yaml [flink-kubernetes-operator]

2025-04-06 Thread via GitHub
ctrlaltdilj commented on code in PR #848: URL: https://github.com/apache/flink-kubernetes-operator/pull/848#discussion_r2030254823 ## e2e-tests/test_dynamic_flink_conf.sh: ## @@ -0,0 +1,40 @@ +#!/usr/bin/env bash +

Re: [PR] Support config yaml [flink-kubernetes-operator]

2025-04-06 Thread via GitHub
ctrlaltdilj commented on PR #848: URL: https://github.com/apache/flink-kubernetes-operator/pull/848#issuecomment-2781628728 @gyfora added, let me know what you think, or if you have any feedback -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Support config yaml [flink-kubernetes-operator]

2025-03-19 Thread via GitHub
ctrlaltdilj commented on PR #848: URL: https://github.com/apache/flink-kubernetes-operator/pull/848#issuecomment-2737284875 @gyfora that should be possible, let me take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] Support config yaml [flink-kubernetes-operator]

2025-03-19 Thread via GitHub
gyfora commented on PR #848: URL: https://github.com/apache/flink-kubernetes-operator/pull/848#issuecomment-2736779092 I think this will require some more testing and some e2es to make sure that this type of configuration on the operator side still works with Flink versions. Can we e

Re: [PR] Support config yaml [flink-kubernetes-operator]

2025-03-14 Thread via GitHub
ctrlaltdilj commented on PR #848: URL: https://github.com/apache/flink-kubernetes-operator/pull/848#issuecomment-2725622465 @gyfora @ljankows whenever you get a chance to take a look, if the approach makes sense, I can proceed with some documentation changes and adding some tests? -- Th

Re: [PR] Support config yaml [flink-kubernetes-operator]

2025-03-09 Thread via GitHub
ctrlaltdilj commented on PR #848: URL: https://github.com/apache/flink-kubernetes-operator/pull/848#issuecomment-2709352804 @gyfora does this approach look better? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Support config yaml [flink-kubernetes-operator]

2025-03-08 Thread via GitHub
ctrlaltdilj commented on PR #848: URL: https://github.com/apache/flink-kubernetes-operator/pull/848#issuecomment-2708366566 @hugovideira-ppb , I have updated the helm chart, if this approach looks good, can I proceed with some documentation changes and adding some tests? -- This is an au

Re: [PR] Support config yaml [flink-kubernetes-operator]

2024-11-18 Thread via GitHub
ctrlaltdilj commented on PR #848: URL: https://github.com/apache/flink-kubernetes-operator/pull/848#issuecomment-2483051059 Hi @hugovideira-ppb , yes, apologize got busy, I'll try to knock this out -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Support config yaml [flink-kubernetes-operator]

2024-11-13 Thread via GitHub
hugovideira-ppb commented on PR #848: URL: https://github.com/apache/flink-kubernetes-operator/pull/848#issuecomment-2475020840 Hi @ctrlaltdilj any updates on this? Is there a chance of this moving forward? It would be a great addition! -- This is an automated message from the Apache Gi

Re: [PR] Support config yaml [flink-kubernetes-operator]

2024-10-25 Thread via GitHub
myskaludek commented on PR #848: URL: https://github.com/apache/flink-kubernetes-operator/pull/848#issuecomment-2437590183 Hi I made changes to helm template file, but operator pod will not start with error ``` Exception in thread "main" org.apache.flink.configuration.IllegalC

Re: [PR] Support config yaml [flink-kubernetes-operator]

2024-10-25 Thread via GitHub
myskaludek commented on PR #848: URL: https://github.com/apache/flink-kubernetes-operator/pull/848#issuecomment-2437587335 Hi , i made changes to helm template and in values set ```yaml defaultConfiguration: standardYaml: true ``` The operator dont start pod with errror

Re: [PR] Support config yaml [flink-kubernetes-operator]

2024-10-08 Thread via GitHub
ctrlaltdilj commented on code in PR #848: URL: https://github.com/apache/flink-kubernetes-operator/pull/848#discussion_r1786292910 ## helm/flink-kubernetes-operator/values.yaml: ## @@ -154,6 +154,9 @@ defaultConfiguration: # If set to false, loads just the overrides as in (2

Re: [PR] Support config yaml [flink-kubernetes-operator]

2024-08-22 Thread via GitHub
ljankows commented on code in PR #848: URL: https://github.com/apache/flink-kubernetes-operator/pull/848#discussion_r1726681341 ## pom.xml: ## @@ -83,7 +83,7 @@ under the License. 1.18.30 3.12.0 2.11.0 -1.18.1 +1.19.0 Review Comment:

Re: [PR] Support config yaml [flink-kubernetes-operator]

2024-08-06 Thread via GitHub
gyfora commented on code in PR #848: URL: https://github.com/apache/flink-kubernetes-operator/pull/848#discussion_r1705872227 ## helm/flink-kubernetes-operator/values.yaml: ## @@ -154,6 +154,9 @@ defaultConfiguration: # If set to false, loads just the overrides as in (2).

Re: [PR] Support config yaml [flink-kubernetes-operator]

2024-07-02 Thread via GitHub
ctrlaltdilj commented on PR #848: URL: https://github.com/apache/flink-kubernetes-operator/pull/848#issuecomment-2203244208 Thanks @mateczagany for all the info! I have requested a JIRA account, and will file a ticket -- This is an automated message from the Apache Git Service. To respon