Re: [PR] FLINK-36479 remove deprecated method Table getSchema as [flink]

2025-01-09 Thread via GitHub
xuyangzhong commented on PR #25540: URL: https://github.com/apache/flink/pull/25540#issuecomment-2581566400 No worries, I'll continue handling it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] FLINK-36479 remove deprecated method Table getSchema as [flink]

2025-01-09 Thread via GitHub
jbalchan commented on PR #25540: URL: https://github.com/apache/flink/pull/25540#issuecomment-2580142260 I'm struggling to fix the scala test cases for this. I'm stuck on it and might need more time. Since code freeze is approaching, please take over this. I'm sooo sorry I couldn't fig

Re: [PR] FLINK-36479 remove deprecated method Table getSchema as [flink]

2025-01-08 Thread via GitHub
xuyangzhong commented on PR #25540: URL: https://github.com/apache/flink/pull/25540#issuecomment-2577228132 Hi, @jbalchan any update? If you're busy, I'll take charge of this task and add you as co-author since the code freeze date for flink 2.0.0 is approaching... -- This is an automate

Re: [PR] FLINK-36479 remove deprecated method Table getSchema as [flink]

2025-01-02 Thread via GitHub
jbalchan commented on PR #25540: URL: https://github.com/apache/flink/pull/25540#issuecomment-2568124379 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] FLINK-36479 remove deprecated method Table getSchema as [flink]

2025-01-02 Thread via GitHub
jbalchan commented on PR #25540: URL: https://github.com/apache/flink/pull/25540#issuecomment-2568032684 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] FLINK-36479 remove deprecated method Table getSchema as [flink]

2025-01-01 Thread via GitHub
xuyangzhong commented on PR #25540: URL: https://github.com/apache/flink/pull/25540#issuecomment-2567259193 Hi, @jbalchan can you take a look at the ci failure? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] FLINK-36479 remove deprecated method Table getSchema as [flink]

2024-10-17 Thread via GitHub
davidradl commented on code in PR #25540: URL: https://github.com/apache/flink/pull/25540#discussion_r1804348228 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Table.java: ## @@ -161,27 +147,6 @@ TemporalTableFunction createTemporalTableFunction(

Re: [PR] FLINK-36479 remove deprecated method Table getSchema as [flink]

2024-10-16 Thread via GitHub
flinkbot commented on PR #25540: URL: https://github.com/apache/flink/pull/25540#issuecomment-2416887514 ## CI report: * 2301bb6bfe7e0f5596690386ac7a56170c771077 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] FLINK-36479 remove deprecated method Table getSchema as [flink]

2024-10-16 Thread via GitHub
jbalchan opened a new pull request, #25540: URL: https://github.com/apache/flink/pull/25540 ## What is the purpose of the change [FLINK-36479] (https://issues.apache.org/jira/browse/FLINK-36479) Component: [Table SQL / API](https://issues.apache.org/jira/issues/?jql=projec

Re: [PR] FLINK-36479 Remove deprecated method Table getSchema as [flink]

2024-10-16 Thread via GitHub
jbalchan commented on PR #25519: URL: https://github.com/apache/flink/pull/25519#issuecomment-2416861263 i'm sorry. I was trying to remove my commit which failed the jenkins check. But PR itself got closed. -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] FLINK-36479 Remove deprecated method Table getSchema as [flink]

2024-10-16 Thread via GitHub
jbalchan closed pull request #25519: FLINK-36479 Remove deprecated method Table getSchema as URL: https://github.com/apache/flink/pull/25519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] FLINK-36479 Remove deprecated method Table getSchema as [flink]

2024-10-15 Thread via GitHub
flinkbot commented on PR #25519: URL: https://github.com/apache/flink/pull/25519#issuecomment-2413677431 ## CI report: * 1a0e5c8ea9b28b3c2113bee30f1d4fe6896c1de3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] FLINK-36479 Remove deprecated method Table getSchema as [flink]

2024-10-15 Thread via GitHub
jbalchan opened a new pull request, #25519: URL: https://github.com/apache/flink/pull/25519 ## What is the purpose of the change https://issues.apache.org/jira/browse/FLINK-36479 Remove deprecated methods `Table#getSchema` and `Table#as` ## Brief change log