Re: [PR] [hotfix] fix ci failure due to code style [flink-cdc]

2025-04-10 Thread via GitHub
loserwang1024 commented on code in PR #3980: URL: https://github.com/apache/flink-cdc/pull/3980#discussion_r2034743082 ## docs/content/docs/connectors/pipeline-connectors/kafka.md: ## @@ -149,7 +149,7 @@ Pipeline Connector Options Custom table mappings for each table from

Re: [PR] [hotfix] fix ci failure due to code style [flink-cdc]

2025-04-10 Thread via GitHub
MOBIN-F commented on PR #3980: URL: https://github.com/apache/flink-cdc/pull/3980#issuecomment-2785098828 @leonardBang PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [hotfix] fix ci failure due to code style [flink-cdc]

2025-04-09 Thread via GitHub
MOBIN-F commented on code in PR #3980: URL: https://github.com/apache/flink-cdc/pull/3980#discussion_r2034862990 ## docs/content/docs/connectors/pipeline-connectors/kafka.md: ## @@ -149,7 +149,7 @@ Pipeline Connector Options Custom table mappings for each table from upstr

Re: [PR] [hotfix] fix ci failure due to code style [flink-cdc]

2025-04-08 Thread via GitHub
MOBIN-F commented on PR #3980: URL: https://github.com/apache/flink-cdc/pull/3980#issuecomment-2788169558 It seems to be an occasional error, the 1.20 test passes ![image](https://github.com/user-attachments/assets/f977c9a0-541e-42ad-8e3a-505b9875163a) -- This is an automated messa

Re: [PR] [hotfix] fix ci failure due to code style [flink-cdc]

2025-04-08 Thread via GitHub
MOBIN-F commented on PR #3980: URL: https://github.com/apache/flink-cdc/pull/3980#issuecomment-2786373629 #3834 #3954 has code style conflict, I will rebase and resolve it together -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] [hotfix] fix ci failure due to code style [flink-cdc]

2025-04-08 Thread via GitHub
MOBIN-F commented on PR #3980: URL: https://github.com/apache/flink-cdc/pull/3980#issuecomment-2785888140 In [my CI action](https://github.com/MOBIN-F/flink-cdc/actions/runs/14328920446), CI passed ![image](https://github.com/user-attachments/assets/2dfcb5c3-8680-4549-8f66-da5569c1ff26)

Re: [PR] [hotfix] fix ci failure due to code style [flink-cdc]

2025-04-08 Thread via GitHub
MOBIN-F commented on PR #3980: URL: https://github.com/apache/flink-cdc/pull/3980#issuecomment-2785499677 Rename sink.debezium-json.include-schema.enabled to debezium-json.include-schema.enabled Reason: 1. With the introduction of #3926, the createSerializationSchema constructor recei

Re: [PR] [hotfix] fix ci failure due to code style [flink-cdc]

2025-04-08 Thread via GitHub
leonardBang commented on PR #3980: URL: https://github.com/apache/flink-cdc/pull/3980#issuecomment-2785526486 > Rename sink.debezium-json.include-schema.enabled to debezium-json.include-schema.enabled Reason: > > 1. With the introduction of [[FLINK-37358][kafka] Support to pass format

Re: [PR] [hotfix] fix ci failure due to code style [flink-cdc]

2025-04-07 Thread via GitHub
MOBIN-F commented on PR #3980: URL: https://github.com/apache/flink-cdc/pull/3980#issuecomment-2785142817 ci failed. I'll check again later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] [hotfix] fix ci failure due to code style [flink-cdc]

2025-04-07 Thread via GitHub
leonardBang commented on PR #3980: URL: https://github.com/apache/flink-cdc/pull/3980#issuecomment-2785104152 Thanks @MOBIN-F for the quickfix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [hotfix] fix ci failure due to code style [flink-cdc]

2025-04-07 Thread via GitHub
MOBIN-F opened a new pull request, #3980: URL: https://github.com/apache/flink-cdc/pull/3980 Code style verifier has been updated to JUnit 5 ![image](https://github.com/user-attachments/assets/316c7713-b6af-41a7-9efd-5850c9ac5f19) -- This is an automated message from the Apache Git