davidradl commented on PR #25850:
URL: https://github.com/apache/flink/pull/25850#issuecomment-2583080401
Reviewed by Chi on 09/01/2025 Go back to the submitter with review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
davidradl commented on code in PR #25850:
URL: https://github.com/apache/flink/pull/25850#discussion_r1908998363
##
docs/content.zh/docs/connectors/datastream/formats/parquet.md:
##
@@ -198,14 +198,14 @@ ds = env.from_source(source,
WatermarkStrategy.no_watermarks(), "file-sour
flinkbot commented on PR #25850:
URL: https://github.com/apache/flink/pull/25850#issuecomment-2561049411
## CI report:
* 17682e00f7f9c9288eb9cb2e68306d34ba5c042c UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
donPain commented on PR #25769:
URL: https://github.com/apache/flink/pull/25769#issuecomment-2561027021
> rmetzger
Sure, here it is: https://github.com/apache/flink/pull/25850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
donPain opened a new pull request, #25850:
URL: https://github.com/apache/flink/pull/25850
Just correcting the url reference to access the Avro specification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
donPain closed pull request #25849: [hotfix][docs] Fix Apache Avro
Specification Link
URL: https://github.com/apache/flink/pull/25849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
donPain opened a new pull request, #25849:
URL: https://github.com/apache/flink/pull/25849
Just correcting the url reference to access the Avro specification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
rmetzger commented on PR #25769:
URL: https://github.com/apache/flink/pull/25769#issuecomment-2556729833
@donPain could you raise a PR forward-porting the commit to the `master`
branch as well? Thx
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
rmetzger merged PR #25769:
URL: https://github.com/apache/flink/pull/25769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apac
davidradl commented on PR #25769:
URL: https://github.com/apache/flink/pull/25769#issuecomment-2556549160
@rmetzger as discussed at the Chi meeting are you ok to merge this? @donPain
can you raise a separate issue to track the variable replacement improvement
idea please.
--
This is an
davidradl commented on PR #25769:
URL: https://github.com/apache/flink/pull/25769#issuecomment-2548134819
@rmetzger @donPain I had a quick look at the docs, it seems that Hugo does
allow templating which supports variables. I can see the Flink code referencing
the predefined variables with
donPain commented on PR #25769:
URL: https://github.com/apache/flink/pull/25769#issuecomment-2545623883
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
donPain commented on PR #25769:
URL: https://github.com/apache/flink/pull/25769#issuecomment-2542209289
> Flink is using Avro 1.11.4. Wouldn't it make more sense to link to the
docs of that version, then add a note to the pom file where the avro version is
defined to make sure folks update
rmetzger commented on PR #25769:
URL: https://github.com/apache/flink/pull/25769#issuecomment-2542149109
Flink is using Avro 1.11.4. Wouldn't it make more sense to link to the docs
of that version, then add a note to the pom file where the avro version is
defined to make sure folks update t
rmetzger commented on code in PR #25769:
URL: https://github.com/apache/flink/pull/25769#discussion_r1884416619
##
docs/content.zh/docs/connectors/datastream/formats/parquet.md:
##
@@ -198,14 +198,14 @@ ds = env.from_source(source,
WatermarkStrategy.no_watermarks(), "file-sourc
davidradl commented on PR #25769:
URL: https://github.com/apache/flink/pull/25769#issuecomment-2541660979
Reviewed by Chi on 12/12/24 Approve - looking for committer to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
donPain commented on PR #25769:
URL: https://github.com/apache/flink/pull/25769#issuecomment-2541206816
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
snuyanzin commented on PR #25769:
URL: https://github.com/apache/flink/pull/25769#issuecomment-2540741299
run `./mvnw spotless:apply`
before
```
git add . && git commit
```
as mentioned at
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=64325&view=logs&j
donPain commented on PR #25769:
URL: https://github.com/apache/flink/pull/25769#issuecomment-2539702897
> can you also change it at
>
>
https://github.com/apache/flink/blob/72b32fcd53f2d0d81329298a6c0a7d08e084f769/flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/ty
snuyanzin commented on PR #25769:
URL: https://github.com/apache/flink/pull/25769#issuecomment-2539537588
can you also change it at
https://github.com/apache/flink/blob/72b32fcd53f2d0d81329298a6c0a7d08e084f769/flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/Avr
donPain commented on code in PR #25769:
URL: https://github.com/apache/flink/pull/25769#discussion_r1882539224
##
docs/content/docs/connectors/table/formats/avro.md:
##
@@ -218,4 +218,4 @@ So the following table lists the type mapping from Flink
type to Avro type.
In additio
davidradl commented on code in PR #25769:
URL: https://github.com/apache/flink/pull/25769#discussion_r1882098243
##
docs/content/docs/connectors/table/formats/avro.md:
##
@@ -218,4 +218,4 @@ So the following table lists the type mapping from Flink
type to Avro type.
In addit
donPain commented on PR #25769:
URL: https://github.com/apache/flink/pull/25769#issuecomment-2531652588
@davidradl I made the changes, could you review it again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
23 matches
Mail list logo
