Re: [PR] [FLINK-37638] Avoid duplicate call on getEffectiveConfiguration [flink]

2025-04-14 Thread via GitHub
beliefer commented on PR #26428: URL: https://github.com/apache/flink/pull/26428#issuecomment-2803922439 @ferenc-csaky @davidradl Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] [FLINK-37638] Avoid duplicate call on getEffectiveConfiguration [flink]

2025-04-14 Thread via GitHub
ferenc-csaky merged PR #26428: URL: https://github.com/apache/flink/pull/26428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [FLINK-37638] Avoid duplicate call on getEffectiveConfiguration [flink]

2025-04-13 Thread via GitHub
beliefer commented on code in PR #26428: URL: https://github.com/apache/flink/pull/26428#discussion_r2041306536 ## flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java: ## @@ -301,14 +296,9 @@ private Configuration getEffectiveConfiguration( } pri

Re: [PR] [FLINK-37638] Avoid duplicate call on getEffectiveConfiguration [flink]

2025-04-11 Thread via GitHub
ferenc-csaky commented on code in PR #26428: URL: https://github.com/apache/flink/pull/26428#discussion_r2040031414 ## flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java: ## @@ -301,14 +296,9 @@ private Configuration getEffectiveConfiguration( }

Re: [PR] [FLINK-37638] Avoid duplicate call on getEffectiveConfiguration [flink]

2025-04-10 Thread via GitHub
beliefer commented on PR #26428: URL: https://github.com/apache/flink/pull/26428#issuecomment-2795928329 ping @ferenc-csaky @kl0u @wangyang0918 cc @1996fanrui @davidradl @GOODBOY008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [FLINK-37638] Avoid duplicate call on getEffectiveConfiguration [flink]

2025-04-09 Thread via GitHub
beliefer commented on PR #26428: URL: https://github.com/apache/flink/pull/26428#issuecomment-2791500611 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-37638] Avoid duplicate call on getEffectiveConfiguration [flink]

2025-04-09 Thread via GitHub
beliefer commented on PR #26428: URL: https://github.com/apache/flink/pull/26428#issuecomment-2789623058 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-37638] Avoid duplicate call on getEffectiveConfiguration [flink]

2025-04-09 Thread via GitHub
flinkbot commented on PR #26428: URL: https://github.com/apache/flink/pull/26428#issuecomment-2788829143 ## CI report: * 55ec34348cd901aae8e782fb11e8698c0b92fe43 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-37638] Avoid duplicate call on getEffectiveConfiguration [flink]

2025-04-09 Thread via GitHub
beliefer opened a new pull request, #26428: URL: https://github.com/apache/flink/pull/26428 ## What is the purpose of the change This PR aims to avoid duplicate call on `getEffectiveConfiguration`. The code of `getEffectiveConfiguration` show below, I think it has a lot of overhead