Re: [PR] [FLINK-37385][table] Add support for smile format [flink]

2025-02-27 Thread via GitHub
snuyanzin merged PR #26217: URL: https://github.com/apache/flink/pull/26217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-37385][table] Add support for smile format [flink]

2025-02-27 Thread via GitHub
twalthr commented on code in PR #26217: URL: https://github.com/apache/flink/pull/26217#discussion_r1973403212 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/PlanReference.java: ## @@ -160,6 +167,43 @@ public String toString() { } }

Re: [PR] [FLINK-37385][table] Add support for smile format [flink]

2025-02-27 Thread via GitHub
snuyanzin commented on code in PR #26217: URL: https://github.com/apache/flink/pull/26217#discussion_r1973343687 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/JsonSmileSerdeUtil.java: ## @@ -71,51 +73,71 @@ import java.io.

Re: [PR] [FLINK-37385][table] Add support for smile format [flink]

2025-02-27 Thread via GitHub
snuyanzin commented on code in PR #26217: URL: https://github.com/apache/flink/pull/26217#discussion_r1973336049 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/JsonSmileSerdeUtil.java: ## @@ -71,51 +73,71 @@ import java.io.

Re: [PR] [FLINK-37385][table] Add support for smile format [flink]

2025-02-27 Thread via GitHub
dawidwys commented on code in PR #26217: URL: https://github.com/apache/flink/pull/26217#discussion_r1973158894 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/JsonSmileSerdeUtil.java: ## @@ -71,51 +73,71 @@ import java.io.I

Re: [PR] [FLINK-37385][table] Add support for smile format [flink]

2025-02-26 Thread via GitHub
flinkbot commented on PR #26217: URL: https://github.com/apache/flink/pull/26217#issuecomment-2684807091 ## CI report: * 6ccd9ee03dbe6bb13f43490a37a04edf74a17287 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-37385][table] Add support for smile format [flink]

2025-02-26 Thread via GitHub
snuyanzin opened a new pull request, #26217: URL: https://github.com/apache/flink/pull/26217 ## What is the purpose of the change Implementation of FLIP-508: add support for Smile format ## Verifying this change During restore tests we extract compiled plans as Smile, loa