Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly merged PR #25996: URL: https://github.com/apache/flink/pull/25996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1921497698 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/transformations/OneInputTransformation.java: ## @@ -192,4 +192,9 @@ public boolean isOutputOnlyAfterEndOfS

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on PR #25996: URL: https://github.com/apache/flink/pull/25996#issuecomment-2599580729 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on PR #25996: URL: https://github.com/apache/flink/pull/25996#issuecomment-2599534361 > LGTM. It's better to parameterize the test also. @Zakelly Thanks for reviewing. I have refactor the UT of window. After refactoring, existing window UT (i.e., `WindowOperatorTest`

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1920957468 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/AsyncContinuousEventTimeTrigger.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to t

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1920956871 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/windowing/assigners/WindowAssigner.java: ## @@ -64,6 +66,13 @@ public abstract Collection assignWindows(

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1920956433 ## flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/WindowWordCount.java: ## @@ -88,6 +93,12 @@ public static void ma

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1920955938 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/triggers/AsyncTrigger.java: ## @@ -0,0 +1,195 @@ +/* + * Licensed to the Apa

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1920952684 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/AsyncContinuousEventTimeTrigger.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to t

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1920951003 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/windowing/assigners/WindowAssigner.java: ## @@ -64,6 +66,13 @@ public abstract Collection assignWindows(

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1920950253 ## flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/WindowWordCount.java: ## @@ -88,6 +93,12 @@ public static void ma

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1920944894 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/triggers/AsyncTrigger.java: ## @@ -0,0 +1,195 @@ +/* + * Licensed to the Apa

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1920149771 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/AsyncWindowOperator.java: ## @@ -0,0 +1,810 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1920137914 ## flink-core/src/main/java/org/apache/flink/core/state/StateFutureUtils.java: ## @@ -34,6 +35,14 @@ */ @Experimental public class StateFutureUtils { +/** +

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1920137353 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/AsyncWindowOperator.java: ## @@ -0,0 +1,810 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1920130658 ## flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/WindowWordCount.java: ## @@ -118,15 +129,33 @@ public static void

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1919497856 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/AsyncWindowOperator.java: ## @@ -0,0 +1,810 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1919497038 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/AsyncWindowOperator.java: ## @@ -0,0 +1,810 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1919492658 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/AsyncWindowOperator.java: ## @@ -0,0 +1,810 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1919492658 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/AsyncWindowOperator.java: ## @@ -0,0 +1,810 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1919492172 ## flink-core/src/main/java/org/apache/flink/core/state/StateFutureUtils.java: ## @@ -34,6 +35,14 @@ */ @Experimental public class StateFutureUtils { +/** +

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1919476870 ## flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/WindowWordCount.java: ## @@ -118,15 +129,33 @@ public static void

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on PR #25996: URL: https://github.com/apache/flink/pull/25996#issuecomment-2595672230 @Zakelly Thanks for reviewing. I have fixed the comments. Moreover, I have added another two commits to run an end-to-end example (i.e., WindowWordCount) for window datastream with

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1918443143 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/functions/InternalAggregateProcessAsyncWindowFunction.java: ## @@ -0,0 +1,11

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1918440423 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/AsyncWindowOperator.java: ## @@ -0,0 +1,902 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1918436120 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/windowing/assigners/WindowAssigner.java: ## @@ -64,6 +65,12 @@ public abstract Collection assignWindows(

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1918355186 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/AsyncWindowOperator.java: ## @@ -0,0 +1,902 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1918341973 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/functions/InternalAggregateProcessAsyncWindowFunction.java: ## @@ -0,0 +1,11

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1918338304 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/AsyncWindowOperator.java: ## @@ -0,0 +1,902 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1918334489 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/AsyncWindowOperator.java: ## @@ -0,0 +1,902 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1918332729 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/AsyncWindowOperator.java: ## @@ -0,0 +1,902 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1918320158 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/declare/state/StateWithDeclaredNamespace.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1918319804 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/declare/state/StateWithDeclaredNamespace.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1918318689 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/declare/state/StateWithDeclaredNamespace.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1918312532 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/declare/state/StateWithDeclaredNamespace.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1918306337 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/declare/state/ValueStateWithDeclaredNamespace.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to the

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1918291061 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/declare/state/AggregatingStateWithDeclaredNamespace.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

flinkbot commented on PR #25996: URL: https://github.com/apache/flink/pull/25996#issuecomment-2595002635 ## CI report: * d442af5859312a03adf2491bdbfbb98f52e9ce8a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1918104714 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/windowing/assigners/WindowAssigner.java: ## @@ -64,6 +65,12 @@ public abstract Collection assignWindows(

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1918101684 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/windowing/assigners/WindowAssigner.java: ## @@ -64,6 +65,12 @@ public abstract Collection assignWindows(

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1918060154 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/AsyncWindowOperator.java: ## @@ -0,0 +1,902 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1918060154 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/AsyncWindowOperator.java: ## @@ -0,0 +1,902 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1918042057 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/AsyncWindowOperator.java: ## @@ -0,0 +1,902 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1918029036 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/AsyncWindowOperator.java: ## @@ -0,0 +1,902 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1918017015 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/AsyncWindowOperator.java: ## @@ -0,0 +1,902 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1918001457 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/AsyncWindowOperator.java: ## @@ -0,0 +1,902 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1917988381 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/AsyncWindowOperator.java: ## @@ -0,0 +1,902 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1917973049 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/declare/state/StateWithDeclaredNamespace.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1917941066 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/functions/InternalAggregateProcessAsyncWindowFunction.java: ## @@ -0,0 +1,11

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1917936589 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/windowing/functions/InternalAggregateProcessAsyncWindowFunction.java: ## @@ -0,0 +1,11

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1917933066 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/declare/state/ValueStateWithDeclaredNamespace.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to the

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1917926823 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/declare/state/StateWithDeclaredNamespace.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1917925184 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/declare/state/StateWithDeclaredNamespace.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

Zakelly commented on code in PR #25996: URL: https://github.com/apache/flink/pull/25996#discussion_r1917914164 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/declare/state/StateWithDeclaredNamespace.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apach

[PR] [FLINK-37028] Datastream Window operator with async state processing [flink]

jiexray opened a new pull request, #25996: URL: https://github.com/apache/flink/pull/25996 ## What is the purpose of the change Implement DataStream WindowOperator to support async state access. ## Brief change log TODO ## Verifying this change