chenyuzhi459 commented on PR #25788:
URL: https://github.com/apache/flink/pull/25788#issuecomment-2606156814
> Reviewed by Chi on 12/12/24. Asked submitter questions
The code has been updated and the question has been answered. Please review
again.
@davidradl
--
This is an
chenyuzhi459 commented on code in PR #25788:
URL: https://github.com/apache/flink/pull/25788#discussion_r1887841888
##
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java:
##
@@ -264,15 +278,21 @@ protected void initChannel(SocketChannel socketChannel) {
chenyuzhi459 commented on code in PR #25788:
URL: https://github.com/apache/flink/pull/25788#discussion_r1886236906
##
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java:
##
@@ -264,15 +278,21 @@ protected void initChannel(SocketChannel socketChannel) {
chenyuzhi459 commented on code in PR #25788:
URL: https://github.com/apache/flink/pull/25788#discussion_r1886236906
##
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java:
##
@@ -264,15 +278,21 @@ protected void initChannel(SocketChannel socketChannel) {
davidradl commented on PR #25788:
URL: https://github.com/apache/flink/pull/25788#issuecomment-2541684156
Reviewed by Chi on 12/12/24. Asked submitter questions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
davidradl commented on code in PR #25788:
URL: https://github.com/apache/flink/pull/25788#discussion_r1882264279
##
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java:
##
@@ -264,15 +278,21 @@ protected void initChannel(SocketChannel socketChannel) {
davidradl commented on code in PR #25788:
URL: https://github.com/apache/flink/pull/25788#discussion_r1882256774
##
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java:
##
@@ -264,15 +278,21 @@ protected void initChannel(SocketChannel socketChannel) {
davidradl commented on code in PR #25788:
URL: https://github.com/apache/flink/pull/25788#discussion_r1882245040
##
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java:
##
@@ -317,7 +337,7 @@ private CompletableFuture shutdownInternally(Duration
timeout) {
davidradl commented on code in PR #25788:
URL: https://github.com/apache/flink/pull/25788#discussion_r1882245040
##
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java:
##
@@ -317,7 +337,7 @@ private CompletableFuture shutdownInternally(Duration
timeout) {
davidradl commented on code in PR #25788:
URL: https://github.com/apache/flink/pull/25788#discussion_r1882238434
##
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java:
##
@@ -230,15 +240,17 @@ public RestClusterClient(
restCl
davidradl commented on code in PR #25788:
URL: https://github.com/apache/flink/pull/25788#discussion_r1879912333
##
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java:
##
@@ -143,30 +144,42 @@ public class RestClient implements AutoCloseableAsync {
flinkbot commented on PR #25788:
URL: https://github.com/apache/flink/pull/25788#issuecomment-2535247824
## CI report:
* 041b1d2957f0e8bbafb7cbd91aff2309a81121e3 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
chenyuzhi459 opened a new pull request, #25788:
URL: https://github.com/apache/flink/pull/25788
## What is the purpose of the change
Support external eventLoopGroup for RestClient
## Brief change log
*(for example:)*
- *Support pass an external eventLoopG
13 matches
Mail list logo
