fhueske merged PR #25605:
URL: https://github.com/apache/flink/pull/25605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apach
fhueske opened a new pull request, #25605:
URL: https://github.com/apache/flink/pull/25605
## What is the purpose of the change
Backport of PR #25601 to `release-1.20`
## Brief change log
* fix sqlNames of built-in functions
* add test cases to ExpressionSerializationT
flinkbot commented on PR #25605:
URL: https://github.com/apache/flink/pull/25605#issuecomment-2454484739
## CI report:
* 1c51e884ff5824c2bb41bff3bdbc038a296f6022 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
fhueske merged PR #25601:
URL: https://github.com/apache/flink/pull/25601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apach
snuyanzin commented on PR #25601:
URL: https://github.com/apache/flink/pull/25601#issuecomment-2454184086
ok, I see, thanks for clarification here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
fhueske commented on PR #25601:
URL: https://github.com/apache/flink/pull/25601#issuecomment-2454168608
Thanks for the review @snuyanzin!
I didn't add a test case for `CURRENT_ROW_TIMESTAMP` because there is no
Table API expression for it yet.
I fixed the SQL name to have it prepared o
snuyanzin commented on PR #25601:
URL: https://github.com/apache/flink/pull/25601#issuecomment-2452295562
+1
LGTM
one minor thing: I noticed there is absent test for CURRENT_ROW_TIMESTAMP
does it make sense to add it as well?
--
This is an automated message from the Apache Gi
fhueske commented on code in PR #25601:
URL: https://github.com/apache/flink/pull/25601#discussion_r1825949609
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##
@@ -2157,6 +2172,7 @@ ANY, and(logical(LogicalTypeR
snuyanzin commented on code in PR #25601:
URL: https://github.com/apache/flink/pull/25601#discussion_r1825795742
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##
@@ -2157,6 +2172,7 @@ ANY, and(logical(LogicalTyp
flinkbot commented on PR #25601:
URL: https://github.com/apache/flink/pull/25601#issuecomment-2451673231
## CI report:
* e49564a2e36a43ac5a3cb4bd64c0470f3ec9c9df UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
fhueske opened a new pull request, #25601:
URL: https://github.com/apache/flink/pull/25601
## What is the purpose of the change
Fix the SQL names of several built-in functions.
The names are used to serialize Table API expressions to SQL. Using wrong
function names results in SQL
11 matches
Mail list logo
