Re: [PR] [FLINK-36455] Sinks retry synchronously [flink]

2024-11-06 Thread via GitHub
AHeise merged PR #25547: URL: https://github.com/apache/flink/pull/25547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-36455] Sinks retry synchronously [flink]

2024-11-04 Thread via GitHub
fapaul commented on code in PR #25547: URL: https://github.com/apache/flink/pull/25547#discussion_r1827385788 ## flink-core/src/main/java/org/apache/flink/configuration/SinkOptions.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] [FLINK-36455] Sinks retry synchronously [flink]

2024-11-04 Thread via GitHub
AHeise commented on code in PR #25547: URL: https://github.com/apache/flink/pull/25547#discussion_r1827370992 ## flink-core/src/main/java/org/apache/flink/configuration/SinkOptions.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] [FLINK-36455] Sinks retry synchronously [flink]

2024-10-30 Thread via GitHub
fapaul commented on code in PR #25547: URL: https://github.com/apache/flink/pull/25547#discussion_r1822429861 ## flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitterOperator.java: ## @@ -164,41 +165,37 @@ public void notifyCheckpointComplete(lo

Re: [PR] [FLINK-36455] Sinks retry synchronously [flink]

2024-10-30 Thread via GitHub
fapaul commented on code in PR #25547: URL: https://github.com/apache/flink/pull/25547#discussion_r1822432325 ## flink-core/src/main/java/org/apache/flink/configuration/SinkOptions.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] [FLINK-36455] Sinks retry synchronously [flink]

2024-10-29 Thread via GitHub
AHeise commented on code in PR #25547: URL: https://github.com/apache/flink/pull/25547#discussion_r1820836505 ## flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitterOperator.java: ## @@ -164,41 +165,37 @@ public void notifyCheckpointComplete(lo

Re: [PR] [FLINK-36455] Sinks retry synchronously [flink]

2024-10-29 Thread via GitHub
AHeise commented on PR #25547: URL: https://github.com/apache/flink/pull/25547#issuecomment-2444290856 Reverted the deprecation of numFailed and added a config option for the retries. PTAL @fapaul -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] [FLINK-36455] Sinks retry synchronously [flink]

2024-10-28 Thread via GitHub
AHeise commented on code in PR #25547: URL: https://github.com/apache/flink/pull/25547#discussion_r1819084931 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/connector/sink2/CommittableSummary.java: ## @@ -39,11 +39,21 @@ public class CommittableSummary implements

Re: [PR] [FLINK-36455] Sinks retry synchronously [flink]

2024-10-28 Thread via GitHub
fapaul commented on code in PR #25547: URL: https://github.com/apache/flink/pull/25547#discussion_r1818576013 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/connector/sink2/CommittableSummary.java: ## @@ -39,11 +39,21 @@ public class CommittableSummary implements

Re: [PR] [FLINK-36455] Sinks retry synchronously [flink]

2024-10-18 Thread via GitHub
flinkbot commented on PR #25547: URL: https://github.com/apache/flink/pull/25547#issuecomment-2422494183 ## CI report: * c4672fc5f56fc099f46520017755ebafaadcbd25 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-36455] Sinks retry synchronously [flink]

2024-10-18 Thread via GitHub
AHeise opened a new pull request, #25547: URL: https://github.com/apache/flink/pull/25547 ## What is the purpose of the change Sinks so far retried asynchronously to increase commit throughput in case of temporary issues. However, the contract of notifyCheckpointCompleted stat