boring-cyborg[bot] commented on PR #115:
URL:
https://github.com/apache/flink-connector-kafka/pull/115#issuecomment-2320740732
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
AHeise merged PR #115:
URL: https://github.com/apache/flink-connector-kafka/pull/115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
AHeise commented on PR #115:
URL:
https://github.com/apache/flink-connector-kafka/pull/115#issuecomment-2320739887
> LGTM although I am slightly confused if users could have used the classes
removed by this PR
It was originally used by the universal producer (FlinkKafkaProducer) and
fapaul commented on code in PR #115:
URL:
https://github.com/apache/flink-connector-kafka/pull/115#discussion_r1738067276
##
flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBase.java:
##
@@ -1,442 +0,0 @@
-/*
- * Licensed to the
boring-cyborg[bot] commented on PR #115:
URL:
https://github.com/apache/flink-connector-kafka/pull/115#issuecomment-2317623921
Thanks for opening this pull request! Please check out our contributing
guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is
AHeise opened a new pull request, #115:
URL: https://github.com/apache/flink-connector-kafka/pull/115
Warp up FLINK-19152 by also removing all related producer code.
Move FlinkKafkaProducerBase.getPropertiesFromBrokerList to a new test
utility class as this method is used by some test
