Re: [PR] [FLINK-36172][metrics][rest] Optimize transient metric cleanup [flink]

2025-03-04 Thread via GitHub
fdc-ntflx commented on PR #26204: URL: https://github.com/apache/flink/pull/26204#issuecomment-2697766555 Thanks for the review, everyone! I got caught up with work and wasn't able to address the comments before the PR was merged. I agree that more unit tests could have been added, but I fe

Re: [PR] [FLINK-36172][metrics][rest] Optimize transient metric cleanup [flink]

2025-02-28 Thread via GitHub
JunRuiLee merged PR #26204: URL: https://github.com/apache/flink/pull/26204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-36172][metrics][rest] Optimize transient metric cleanup [flink]

2025-02-27 Thread via GitHub
JunRuiLee commented on PR #26204: URL: https://github.com/apache/flink/pull/26204#issuecomment-2689852623 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-36172][metrics][rest] Optimize transient metric cleanup [flink]

2025-02-26 Thread via GitHub
davidradl commented on code in PR #26204: URL: https://github.com/apache/flink/pull/26204#discussion_r1971819836 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStore.java: ## @@ -439,42 +440,37 @@ private boolean isRepresentativeAttempt

Re: [PR] [FLINK-36172][metrics][rest] Optimize transient metric cleanup [flink]

2025-02-24 Thread via GitHub
flinkbot commented on PR #26204: URL: https://github.com/apache/flink/pull/26204#issuecomment-2679134515 ## CI report: * 52a381328a90f28bc705cbfb98c703f8e03413a8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`