Re: [PR] [FLINK-35931][table] Add REGEXP_EXTRACT_ALL function [flink]

2024-08-14 Thread via GitHub
dylanhz commented on code in PR #25137: URL: https://github.com/apache/flink/pull/25137#discussion_r1716641558 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/RegexpExtractAllFunction.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to

Re: [PR] [FLINK-35931][table] Add REGEXP_EXTRACT_ALL function [flink]

2024-08-02 Thread via GitHub
dylanhz commented on PR #25137: URL: https://github.com/apache/flink/pull/25137#issuecomment-2264916761 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-35931][table] Add REGEXP_EXTRACT_ALL function [flink]

2024-08-02 Thread via GitHub
dylanhz commented on code in PR #25137: URL: https://github.com/apache/flink/pull/25137#discussion_r1701484163 ## docs/data/sql_functions.yml: ## @@ -304,7 +304,13 @@ string: not exceed the number of the defined groups. E.g. REGEXP_EXTRACT('foothebar', 'foo(.*?)(

Re: [PR] [FLINK-35931][table] Add REGEXP_EXTRACT_ALL function [flink]

2024-08-02 Thread via GitHub
superdiaodiao commented on code in PR #25137: URL: https://github.com/apache/flink/pull/25137#discussion_r1701430328 ## docs/data/sql_functions.yml: ## @@ -304,7 +304,13 @@ string: not exceed the number of the defined groups. E.g. REGEXP_EXTRACT('foothebar', 'foo

Re: [PR] [FLINK-35931][table] Add REGEXP_EXTRACT_ALL function [flink]

2024-08-02 Thread via GitHub
superdiaodiao commented on code in PR #25137: URL: https://github.com/apache/flink/pull/25137#discussion_r1701430328 ## docs/data/sql_functions.yml: ## @@ -304,7 +304,13 @@ string: not exceed the number of the defined groups. E.g. REGEXP_EXTRACT('foothebar', 'foo

Re: [PR] [FLINK-35931][table] Add REGEXP_EXTRACT_ALL function [flink]

2024-08-01 Thread via GitHub
superdiaodiao commented on code in PR #25137: URL: https://github.com/apache/flink/pull/25137#discussion_r1701353427 ## flink-python/pyflink/table/expression.py: ## @@ -1205,6 +1205,18 @@ def regexp_extract(self, else: return _ternary_op("regexpExtract")(se