Re: [PR] [FLINK-35832][Table SQL / Planner] Fix IFNULL outputTypeStrategy [flink]

2024-07-19 Thread via GitHub
lsyldliu merged PR #25105: URL: https://github.com/apache/flink/pull/25105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-35832][Table SQL / Planner] Fix IFNULL outputTypeStrategy [flink]

2024-07-19 Thread via GitHub
lsyldliu merged PR #25106: URL: https://github.com/apache/flink/pull/25106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-35832][Table SQL / Planner] Fix IFNULL outputTypeStrategy [flink]

2024-07-19 Thread via GitHub
flinkbot commented on PR #25106: URL: https://github.com/apache/flink/pull/25106#issuecomment-2238612503 ## CI report: * f826267f58ff5dcaed2837e1989110290d47ada4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35832][Table SQL / Planner] Fix IFNULL outputTypeStrategy [flink]

2024-07-19 Thread via GitHub
dylanhz opened a new pull request, #25106: URL: https://github.com/apache/flink/pull/25106 ## What is the purpose of the change Fix the incorrect output datatype of `IFNULL`. ## Brief change log The `IfNullTypeStrategy` previously takes the datatype of nullReplacement

Re: [PR] [FLINK-35832][Table SQL / Planner] Fix IFNULL outputTypeStrategy [flink]

2024-07-18 Thread via GitHub
lsyldliu merged PR #25099: URL: https://github.com/apache/flink/pull/25099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-35832][Table SQL / Planner] Fix IFNULL outputTypeStrategy [flink]

2024-07-17 Thread via GitHub
lsyldliu commented on code in PR #25099: URL: https://github.com/apache/flink/pull/25099#discussion_r1680934801 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/IfNullTypeStrategy.java: ## @@ -35,10 +43,20 @@ public Optional infer

Re: [PR] [FLINK-35832][Table SQL / Planner] Fix IFNULL outputTypeStrategy [flink]

2024-07-17 Thread via GitHub
lsyldliu commented on code in PR #25099: URL: https://github.com/apache/flink/pull/25099#discussion_r1680726049 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/MiscFunctionsITCase.java: ## @@ -55,8 +55,11 @@ Stream getTestSetSpecs() {

Re: [PR] [FLINK-35832][Table SQL / Planner] Fix IFNULL outputTypeStrategy [flink]

2024-07-16 Thread via GitHub
flinkbot commented on PR #25099: URL: https://github.com/apache/flink/pull/25099#issuecomment-2232561121 ## CI report: * 44145686170d159ef0a7742d49d41da7651ae7e0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35832][Table SQL / Planner] Fix IFNULL outputTypeStrategy [flink]

2024-07-16 Thread via GitHub
dylanhz opened a new pull request, #25099: URL: https://github.com/apache/flink/pull/25099 ## What is the purpose of the change Fix the incorrect output datatype of `IFNULL`. ## Brief change log The `IfNullTypeStrategy` previously takes the datatype of nullRep