Re: [PR] [FLINK-35739][FLIP-444] Native file copy support [flink]

2024-07-10 Thread via GitHub
pnowojski commented on code in PR #25028: URL: https://github.com/apache/flink/pull/25028#discussion_r1672556173 ## flink-core/src/main/java/org/apache/flink/util/FileUtils.java: ## @@ -138,17 +140,27 @@ public static String readFile(File file, String charsetName) throws IOExce

Re: [PR] [FLINK-35739][FLIP-444] Native file copy support [flink]

2024-07-10 Thread via GitHub
pnowojski commented on code in PR #25028: URL: https://github.com/apache/flink/pull/25028#discussion_r1672494318 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/StreamStateHandle.java: ## @@ -38,6 +38,14 @@ public interface StreamStateHandle extends StateObject {

Re: [PR] [FLINK-35739][FLIP-444] Native file copy support [flink]

2024-07-10 Thread via GitHub
rkhachatryan commented on code in PR #25028: URL: https://github.com/apache/flink/pull/25028#discussion_r1671890364 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/StreamStateHandle.java: ## @@ -38,6 +38,14 @@ public interface StreamStateHandle extends StateObject

Re: [PR] [FLINK-35739][FLIP-444] Native file copy support [flink]

2024-07-10 Thread via GitHub
rkhachatryan commented on code in PR #25028: URL: https://github.com/apache/flink/pull/25028#discussion_r1671875906 ## flink-core/src/main/java/org/apache/flink/util/FileUtils.java: ## @@ -138,17 +140,27 @@ public static String readFile(File file, String charsetName) throws IOE

Re: [PR] [FLINK-35739][FLIP-444] Native file copy support [flink]

2024-07-09 Thread via GitHub
pnowojski commented on code in PR #25028: URL: https://github.com/apache/flink/pull/25028#discussion_r1668797419 ## flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/AbstractS3FileSystemFactory.java: ## @@ -41,6 +42,41 @@ /** Base class for file sys

Re: [PR] [FLINK-35739][FLIP-444] Native file copy support [flink]

2024-07-08 Thread via GitHub
rkhachatryan commented on code in PR #25028: URL: https://github.com/apache/flink/pull/25028#discussion_r1668622658 ## flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/AbstractS3FileSystemFactory.java: ## @@ -41,6 +42,41 @@ /** Base class for file

Re: [PR] [FLINK-35739][FLIP-444] Native file copy support [flink]

2024-07-05 Thread via GitHub
flinkbot commented on PR #25028: URL: https://github.com/apache/flink/pull/25028#issuecomment-2211147576 ## CI report: * 596da908dc3670d2f70c2740d2636e35d60a06bd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35739][FLIP-444] Native file copy support [flink]

2024-07-05 Thread via GitHub
pnowojski opened a new pull request, #25028: URL: https://github.com/apache/flink/pull/25028 ## What is the purpose of the change State downloading in Flink can be a time and CPU consuming operation, which is especially visible if CPU resources per task slot are strictly restricted to